Re: [usb-storage] PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-22 Thread Guillaume Bedot
Hello, Le dimanche 20 janvier 2008 à 11:27 +0100, Hans de Goede a écrit : Hi all, This patch sets the last_sector_bug flag to 1 for all USB disks. This is needed to makes the cardreader on various HP multifunction printers work. Since the performance impact is negible we set this flag for

Re: Performance of SCST versus STGT

2008-01-22 Thread Bart Van Assche
On Jan 17, 2008 6:45 PM, Pete Wyckoff [EMAIL PROTECTED] wrote: There's nothing particularly stunning here. Suspect Bart has configuration issues if not even IPoIB will do 100 MB/s. By this time I found out that the BIOS of the test systems (Intel Server Board S5000PAL) set the PCI-e parameter

[PATCH] IB/iSER: add logical unit reset support

2008-01-22 Thread Erez Zilber
eh_device_reset_handler was already added to scsi_host_template in iscsi_tcp, and is now added also for iscsi_iser. Signed-off-by: Erez Zilber [EMAIL PROTECTED] Signed-off-by: Mike Christie [EMAIL PROTECTED] --- drivers/infiniband/ulp/iser/iscsi_iser.c |1 + 1 files changed, 1 insertions(+),

Re: [RFC] A SCSI fault injection framework using SystemTap.

2008-01-22 Thread K.Tanaka
The new framework is tested on Fedora8(i386) running with kernel 2.6.23.12. So far, I'm cleaning up the tool set for release, and plan to post it in the near future. Now it's ready. The scsi fault injection tool is available from the following site.

Re: Performance of SCST versus STGT

2008-01-22 Thread Vladislav Bolkhovitin
FUJITA Tomonori wrote: The big problem of stgt iSER is disk I/Os (move data between disk and page cache). We need a proper asynchronous I/O mechanism, however, Linux doesn't provide such and we use a workaround, which incurs large latency. I guess, we cannot solve this until syslets is merged

Re: Performance of SCST versus STGT

2008-01-22 Thread Vladislav Bolkhovitin
Bart Van Assche wrote: On Jan 17, 2008 6:45 PM, Pete Wyckoff [EMAIL PROTECTED] wrote: There's nothing particularly stunning here. Suspect Bart has configuration issues if not even IPoIB will do 100 MB/s. By this time I found out that the BIOS of the test systems (Intel Server Board

Re: Performance of SCST versus STGT

2008-01-22 Thread FUJITA Tomonori
On Tue, 22 Jan 2008 14:33:13 +0300 Vladislav Bolkhovitin [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: The big problem of stgt iSER is disk I/Os (move data between disk and page cache). We need a proper asynchronous I/O mechanism, however, Linux doesn't provide such and we use a

Re: Performance of SCST versus STGT

2008-01-22 Thread Vladislav Bolkhovitin
FUJITA Tomonori wrote: On Tue, 22 Jan 2008 14:33:13 +0300 Vladislav Bolkhovitin [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: The big problem of stgt iSER is disk I/Os (move data between disk and page cache). We need a proper asynchronous I/O mechanism, however, Linux doesn't provide such

Re: Performance of SCST versus STGT

2008-01-22 Thread Bart Van Assche
On Jan 22, 2008 12:33 PM, Vladislav Bolkhovitin [EMAIL PROTECTED] wrote: What are the new SRPT/iSER numbers? You can find the new performance numbers below. These are all numbers for reading from the remote buffer cache, no actual disk reads were performed. The read tests have been performed

Re: Performance of SCST versus STGT

2008-01-22 Thread Vladislav Bolkhovitin
Bart Van Assche wrote: On Jan 22, 2008 12:33 PM, Vladislav Bolkhovitin [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: What are the new SRPT/iSER numbers? You can find the new performance numbers below. These are all numbers for reading from the remote buffer cache, no actual disk reads

Re: Performance of SCST versus STGT

2008-01-22 Thread Bart Van Assche
On Jan 22, 2008 4:26 AM, FUJITA Tomonori [EMAIL PROTECTED] wrote: First, I recommend you to examine iSER stuff more since it has some parameters unlike SRP, which effects the performance, IIRC. At least, you could get the iSER performances similar to Pete's. Apparently open-iscsi uses the

[PATCH 1/3] scsi_debug: add get_data_transfer_info helper function

2008-01-22 Thread FUJITA Tomonori
This adds get_data_transfer_info helper function that get lha and sectors for READ_* and WRITE_* commands (and XDWRITEREAD_10 later). Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] --- drivers/scsi/scsi_debug.c | 83 1 files changed, 38

Re: [PATCH 0/3] update bidirectional series to sit on top of sg_table

2008-01-22 Thread FUJITA Tomonori
From: James Bottomley [EMAIL PROTECTED] Subject: [PATCH 0/3] update bidirectional series to sit on top of sg_table Date: Fri, 11 Jan 2008 21:09:00 -0600 OK, I suppose in the scheme of things, it's my turn to bear some of the pain. the SCSI bidirectional series rejects pretty badly with

[PATCH 2/3] scsi_debug: add bidi data transfer support

2008-01-22 Thread FUJITA Tomonori
This enables fill_from_dev_buffer and fetch_to_dev_buffer to handle bidi commands. Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] --- drivers/scsi/scsi_debug.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/scsi_debug.c

[PATCH 3/3] scsi_debug: add XDWRITEREAD_10 support

2008-01-22 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] --- drivers/scsi/scsi_debug.c | 70 + include/scsi/scsi.h |1 + 2 files changed, 71 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread James Bottomley
Added linux-scsi to the cc. On Tue, 2008-01-22 at 17:11 +, Hugh Dickins wrote: 2.6.24-rc8-mm1 is corrupting. smartd does some sg_ioctl into its stack, and depending on how its stack randomization worked out, this is liable to end up writing into the adjacent physical page too. If you're

Re: INITIO scsi driver fails to work properly

2008-01-22 Thread Filippos Papadopoulos
I get the following: SAH SSH SCB Q SCB EXEC SCB EXEC DONE After ~3 secs the system freezes. On Jan 22, 2008 12:20 AM, Alan Cox [EMAIL PROTECTED] wrote: Ok my attempt to get the card failed so we are going to have to do this the hard way. See where this patch crashes and what it prints (On

[trivial patch] scsi/ultrastor: clean up inline asm warnings (fwd)

2008-01-22 Thread Adrian Bunk
James, can you review and apply this patch? TIA Adrian - Forwarded message from Frederik Deweerdt [EMAIL PROTECTED] - Date: Wed, 16 Jan 2008 17:19:08 +0100 From: Frederik Deweerdt [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: [trivial patch] scsi/ultrastor:

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread Hugh Dickins
On Tue, 22 Jan 2008, James Bottomley wrote: --- 2.6.24-rc8-mm1/drivers/ata/libata-scsi.c2008-01-17 16:49:47.0 + +++ linux/drivers/ata/libata-scsi.c 2008-01-22 15:45:40.0 + @@ -826,7 +826,7 @@ static void ata_scsi_sdev_config(struct

Warning: sym53c8xx calls dma_free_coherent() with irqs disabled

2008-01-22 Thread Tony Battersby
When unloading, sym53c8xx calls dma_free_coherent() while holding a spinlock (sym53c8xx_lock) with irqs disabled, which produces the following warning with 2.6.24: modprobe sym53c8xx modprobe -r sym53c8xx sym0: detaching ... sym0: resetting chip WARNING: at arch/x86/kernel/pci-dma_32.c:66

Re: Warning: sym53c8xx calls dma_free_coherent() with irqs disabled

2008-01-22 Thread Matthew Wilcox
On Tue, Jan 22, 2008 at 01:19:09PM -0500, Tony Battersby wrote: When unloading, sym53c8xx calls dma_free_coherent() while holding a spinlock (sym53c8xx_lock) with irqs disabled, which produces the following warning with 2.6.24: Ugh. I'm slightly torn. On the one hand, it's probably possible

[PATCH] [SCSI]: constify function pointer tables

2008-01-22 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- drivers/scsi/lpfc/lpfc_debugfs.c | 10 +- drivers/scsi/sg.c|8 diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index d6a98bc..002f541 100644 ---

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread James Bottomley
On Tue, 2008-01-22 at 18:36 +, Hugh Dickins wrote: On Tue, 22 Jan 2008, James Bottomley wrote: --- 2.6.24-rc8-mm1/drivers/ata/libata-scsi.c 2008-01-17 16:49:47.0 + +++ linux/drivers/ata/libata-scsi.c 2008-01-22 15:45:40.0 + @@ -826,7 +826,7

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread Hugh Dickins
On Tue, 22 Jan 2008, James Bottomley wrote: Actually, I don't think it's a smaller I/O issue. The SMART protocol specifically mandates that the transfers for SMART READ DATA and SMART READ LOG shall be 512 bytes). However, the pio transfer routine does seem to be assuming sector alignment

[PATCH] fix /proc/scsi/sg/devices when no SCSI devices

2008-01-22 Thread Tony Battersby
The patch [SCSI] sg: use idr to replace static arrays in 2.6.24-rc1 causes a bogus line to appear in /proc/scsi/sg/devices containing -1 -1 -1 -1 -1 -1 -1 -1 -1 when there are no SCSI devices in the system. In 2.6.23, /proc/scsi/sg/devices is empty when there are no SCSI devices in the system. A

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread Jeff Garzik
James Bottomley wrote: Actually, I don't think it's a smaller I/O issue. The SMART protocol specifically mandates that the transfers for SMART READ DATA and SMART READ LOG shall be 512 bytes). However, the pio transfer routine does seem to be assuming sector alignment as well, which will be

Re: [PATCH] [SCSI]: constify function pointer tables

2008-01-22 Thread James Smart
Jan Engelhardt wrote: Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- drivers/scsi/lpfc/lpfc_debugfs.c | 10 +- drivers/scsi/sg.c|8 ACK -- james s - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to

RE: Megaraid: Use of outb_p

2008-01-22 Thread Yang, Bo
Alan/Matthew, I found inb_p/outb_p are defined as inb/outb in kernel src. So it should not have problems to change inb_p/outb_p to inb/outb. Thanks. Bo Yang -Original Message- From: Matthew Wilcox [mailto:[EMAIL PROTECTED] Sent: Friday, January 18, 2008 3:41 PM To: Yang, Bo Cc:

Re: Megaraid: Use of outb_p

2008-01-22 Thread Matthew Wilcox
On Tue, Jan 22, 2008 at 02:30:12PM -0700, Yang, Bo wrote: Alan/Matthew, I found inb_p/outb_p are defined as inb/outb in kernel src. So it should not have problems to change inb_p/outb_p to inb/outb. That's not true for x86-32. Please, can you look up the documentation for this chip and

RE: Megaraid: Use of outb_p

2008-01-22 Thread Yang, Bo
Alan/Matthew, I will double check and give you back soon. Regards. Bo Yang -Original Message- From: Matthew Wilcox [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 22, 2008 4:38 PM To: Yang, Bo Cc: Alan Cox; linux-scsi@vger.kernel.org; DL-MegaRAID Linux Subject: Re: Megaraid: Use of

Re: [PATCH] fix /proc/scsi/sg/devices when no SCSI devices

2008-01-22 Thread Douglas Gilbert
Tony Battersby wrote: The patch [SCSI] sg: use idr to replace static arrays in 2.6.24-rc1 causes a bogus line to appear in /proc/scsi/sg/devices containing -1 -1 -1 -1 -1 -1 -1 -1 -1 when there are no SCSI devices in the system. In 2.6.23, /proc/scsi/sg/devices is empty when there are no SCSI

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread James Bottomley
On Tue, 2008-01-22 at 20:20 +, Hugh Dickins wrote: On Tue, 22 Jan 2008, James Bottomley wrote: Actually, I don't think it's a smaller I/O issue. The SMART protocol specifically mandates that the transfers for SMART READ DATA and SMART READ LOG shall be 512 bytes). However, the pio

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread Alan Cox
However, I'd like to see if we can track the problem through the SG_IO direct path ... how many adjacent page bytes are corrupt? Just a few or a large number (I'm wondering if it's an off by one or off by alignment type bug)? Which ATA controller is involved - in theory ATA DMA is byte

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread Hugh Dickins
On Tue, 22 Jan 2008, Alan Cox wrote: However, I'd like to see if we can track the problem through the SG_IO direct path ... how many adjacent page bytes are corrupt? Just a few or a large number (I'm wondering if it's an off by one or off by alignment type bug)? We moved away from that

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread Hugh Dickins
On Tue, 22 Jan 2008, James Bottomley wrote: libsas looks to be OK because it specifically kmallocs a 512 byte buffer which should (for off slab data) be 512 byte aligned. I don't remember the various SLAB and SLOB and SLUB rules offhand: I'm not sure it's safe to rely on such alignment on all

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread James Bottomley
On Tue, 2008-01-22 at 15:32 -0500, Jeff Garzik wrote: James Bottomley wrote: Actually, I don't think it's a smaller I/O issue. The SMART protocol specifically mandates that the transfers for SMART READ DATA and SMART READ LOG shall be 512 bytes). However, the pio transfer routine does

Re: [PATCH 1/3] scsi_debug: add get_data_transfer_info helper function

2008-01-22 Thread Douglas Gilbert
FUJITA Tomonori wrote: This adds get_data_transfer_info helper function that get lha and sectors for READ_* and WRITE_* commands (and XDWRITEREAD_10 later). Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] --- drivers/scsi/scsi_debug.c | 83 1

Re: [PATCH 2/3] scsi_debug: add bidi data transfer support

2008-01-22 Thread Douglas Gilbert
FUJITA Tomonori wrote: This enables fill_from_dev_buffer and fetch_to_dev_buffer to handle bidi commands. Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] --- drivers/scsi/scsi_debug.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git

Re: [PATCH 3/3] scsi_debug: add XDWRITEREAD_10 support

2008-01-22 Thread Douglas Gilbert
FUJITA Tomonori wrote: Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] --- drivers/scsi/scsi_debug.c | 70 + include/scsi/scsi.h |1 + 2 files changed, 71 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/scsi_debug.c

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread James Bottomley
On Tue, 2008-01-22 at 22:59 +, Hugh Dickins wrote: On Tue, 22 Jan 2008, James Bottomley wrote: libsas looks to be OK because it specifically kmallocs a 512 byte buffer which should (for off slab data) be 512 byte aligned. I don't remember the various SLAB and SLOB and SLUB rules

RE: Open-FCoE on linux-scsi

2008-01-22 Thread Love, Robert W
-Original Message- From: James Smart [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 15, 2008 2:19 PM To: Love, Robert W Cc: Stefan Richter; Dev, Vasu; FUJITA Tomonori; [EMAIL PROTECTED]; Zou, Yi; Leech, Christopher; linux-scsi@vger.kernel.org; James Smart Subject: Re: Open-FCoE on

Re: [PATCH rc8-mm1] hotfix libata-scsi corruption

2008-01-22 Thread Matt Mackall
On Tue, 2008-01-22 at 22:59 +, Hugh Dickins wrote: On Tue, 22 Jan 2008, James Bottomley wrote: libsas looks to be OK because it specifically kmallocs a 512 byte buffer which should (for off slab data) be 512 byte aligned. I don't remember the various SLAB and SLOB and SLUB rules

AACRAID driver broken in 2.6.22.x (and beyond?) [WAS: Re: 2.6.22.16 MD raid1 doesn't mark removed disk faulty, MD thread goes UN]

2008-01-22 Thread Mike Snitzer
On Jan 22, 2008 12:29 AM, Mike Snitzer [EMAIL PROTECTED] wrote: cc'ing Tanaka-san given his recent raid1 BUG report: http://lkml.org/lkml/2008/1/14/515 On Jan 21, 2008 6:04 PM, Mike Snitzer [EMAIL PROTECTED] wrote: Under 2.6.22.16, I physically pulled a SATA disk (/dev/sdac, connected to

[PATCH 01/10] [FCoE] Changing all ASSERT_NOTIMPL to WARN_ON(1)

2008-01-22 Thread Robert Love
Trigger the warning every time the block is encountered. Signed-off-by: Robert Love [EMAIL PROTECTED] --- drivers/scsi/ofc/libfc/fc_exch.c | 11 +-- drivers/scsi/ofc/libfc/fc_frame.c |2 +- drivers/scsi/ofc/libfc/fc_local_port.c |2 +-

[PATCH 03/10] [FCoE] Remove DEBUG_ASSERTS statements

2008-01-22 Thread Robert Love
--- drivers/scsi/ofc/include/fc_els.h | 17 - drivers/scsi/ofc/include/fc_fs.h | 13 - drivers/scsi/ofc/include/fc_gs.h | 12 drivers/scsi/ofc/libfc/fc_ils.h | 33 - drivers/scsi/ofc/libfc/fc_sess.c | 14

[PATCH 02/10] [FCoE] Convert one ASSERT_NOTREACHED to WARN_ON(1)

2008-01-22 Thread Robert Love
--- drivers/scsi/ofc/openfc/openfc_if.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/ofc/openfc/openfc_if.c b/drivers/scsi/ofc/openfc/openfc_if.c index 8725845..0b0c782 100644 --- a/drivers/scsi/ofc/openfc/openfc_if.c +++

[PATCH 04/10] [FCoE] Remove ASSERTs from libfc

2008-01-22 Thread Robert Love
--- drivers/scsi/ofc/include/fc_frame.h | 17 + drivers/scsi/ofc/libfc/fc_disc_targ.c | 25 ++-- drivers/scsi/ofc/libfc/fc_exch.c| 89 --- drivers/scsi/ofc/libfc/fc_frame.c |1 drivers/scsi/ofc/libfc/fc_local_port.c

[PATCH 05/10] [FCoE] Remove ASSERTs from libsa.

2008-01-22 Thread Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED] --- drivers/scsi/ofc/libsa/sa_event.c | 24 drivers/scsi/ofc/libsa/sa_hash_kern.c |7 --- drivers/scsi/ofc/libsa/sa_timer.c |1 - 3 files changed, 0 insertions(+), 32 deletions(-) diff --git

[PATCH 06/10] [FCoE] Remove ASSERTs from openfc

2008-01-22 Thread Robert Love
--- drivers/scsi/ofc/openfc/openfc_attr.c |1 - drivers/scsi/ofc/openfc/openfc_if.c|3 --- drivers/scsi/ofc/openfc/openfc_ioctl.c |1 - drivers/scsi/ofc/openfc/openfc_pkt.c |4 drivers/scsi/ofc/openfc/openfc_scsi.c | 24 +++- 5 files changed,

[PATCH 07/10] [FCoE] Remove ASSERTs from fcoe

2008-01-22 Thread Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED] --- drivers/scsi/ofc/fcoe/fcoe_def.h |1 - drivers/scsi/ofc/fcoe/fcoe_dev.c | 16 ++-- drivers/scsi/ofc/fcoe/fcoe_if.c |4 drivers/scsi/ofc/fcoe/fcoeinit.c |1 - drivers/scsi/ofc/fcoe/fcoeioctl.c |1 - 5 files

[PATCH 08/10] [FCoE] Remove ASSERTs from frame headers.

2008-01-22 Thread Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED] --- drivers/scsi/ofc/include/fc_frame.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/ofc/include/fc_frame.h b/drivers/scsi/ofc/include/fc_frame.h index 6f8e85e..3fce700 100644 ---

[PATCH 09/10] [FCoE] Remove sa_assert files

2008-01-22 Thread Robert Love
Signed-off-by: Robert Love [EMAIL PROTECTED] --- drivers/scsi/ofc/include/sa_assert.h | 85 -- drivers/scsi/ofc/libsa/Makefile |1 drivers/scsi/ofc/libsa/sa_assert.c | 50 3 files changed, 0 insertions(+), 136 deletions(-)

[PATCH 10/10] [FCoE] Removing unused defines

2008-01-22 Thread Robert Love
These defines were used with the DEBUG_ASSERT code that has been removed. Removed defines are, FC_ELS_CSP_LEN FC_ELS_CSSP_LEN FC_ELS_FLOGI_LEN FC_ELS_SPP_LEN FC_ELS_RRQ_LEN FC_ELS_PRLI_LEN FC_ELS_LOGO_LEN Signed-off-by: Robert Love [EMAIL PROTECTED] --- drivers/scsi/ofc/include/fc_els.h |

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-22 Thread Jeff Garzik
Comments inline, mostly minor stuff cleaning up the source. Major problem though: your mailer converted tabs to spaces, so our automated patch tools won't work on your submission. It usually takes a few attempts to get your email setup working, such that all the automated tools used in the

Re: [linux-usb-devel] [PATCH] [2.6.23.13] udev hangs USB-storage (HP r707 camera)

2008-01-22 Thread Phil Dibowitz
Grant Grundler wrote: On Sat, Jan 19, 2008 at 10:11:05PM -0600, James Bottomley wrote: ... Add the device to drivers/usb/storage/unusual_devs.h with US_FL_FIX_CAPACITY. You'll need to know it's USB ids as well for this file. James, Thanks! Patch below (for Alan) works for me. Patch

Re: [linux-usb-devel] [PATCH] [2.6.23.13] udev hangs USB-storage (HP r707 camera)

2008-01-22 Thread Grant Grundler
On Tue, Jan 22, 2008 at 09:27:09PM -0800, Phil Dibowitz wrote: ... Patch looks fine to me. Let me get my tree in order (sorry, been really swamped lately so I haven't updated in a while), make sure this diff's nicely against the latest rc's, It's not. It's against 2.6.23. But I expect it to