Mikey,
Thanks for reviewing. Responses to your comments inline below.
-matt
On Aug 10, 2015, at 9:05 PM, Michael Neuling mi...@neuling.org wrote:
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
Introduce support for enhanced I/O error handling.
This needs more description of
On Aug 10, 2015, at 10:41 PM, Benjamin Herrenschmidt
b...@kernel.crashing.org wrote:
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
Introduce support for enhanced I/O error handling.
Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com
Signed-off-by: Manoj N. Kumar
A device may report an OPTIMAL UNMAP GRANULARITY and UNMAP GRANULARITY
ALIGNMENT in the Block Limits VPD. These parameters describe the
device's internal provisioning allocation units. By default the block
layer will round and align any discard requests based on these limits.
If a device reports
Hi Christoph,
On Tue, 4 Aug 2015 09:11:05 +0200, Christoph Hellwig wrote:
This series adds support for a simplified persistent reservation API
to the block layer. The intent is that both in-kernel and userspace
consumers can use the API instead of having to hand craft SCSI or NVMe
command
Actually, I forgot one thing:
config CXLFLASH
tristate Support for IBM CAPI Flash
- depends on PCI SCSI CXL
+ depends on PCI SCSI CXL EEH
Should you depend on CXL_EEH here, seeing as you use CONFIG_CXL_EEH?
+#ifndef CONFIG_CXL_EEH
+#define
From: Viswas G viswa...@pmcs.com
Bump pm80xx driver version to 0.1.38.
Changes From V1:
None
Signed-off-by: Viswas G viswa...@pmcs.com
Reviewed-by: Suresh Thiagarajan suresh.thiagara...@pmcs.com
Reviewed-by: Hannes Reinecke h...@suse.com
Reviewed-by: Jack Wang jinpu.w...@profitbricks.com
From: Viswas G viswa...@pmcs.com
In pm8001_ccb_task_free(), the dma unmapping is done based on
ccb-n_elem value. This should be initialized to zero in the
task_abort(). Otherwise, pm8001_ccb_task_free() will try for
dma_unmap_sg() which is invalid for task abort and can lead to
kernel crash.
From: Viswas G viswa...@pmcs.com
PORT RECOVERY TIMEOUT is the maximum time between the controller's
detection of the PHY down until the receipt of the ID_Frame (from the
same remote SAS port). If the time expires before the ID_FRAME is
received, the port is considered INVALID and can be removed.
From: Viswas G viswa...@pmcs.com
The request has to be retried incase if the length of the SSP
Response IU is invalid.
Changes From V1:
None
Signed-off-by: Viswas G viswa...@pmcs.com
Reviewed-by: Suresh Thiagarajan suresh.thiagara...@pmcs.com
Reviewed-by: Hannes Reinecke h...@suse.com
From: Viswas G viswa...@pmcs.com
Thermal page code has been changed to 7 for the 12G controllers.
Changes From V1:
None
Signed-off-by: Viswas G viswa...@pmcs.com
Reviewed-by: Suresh Thiagarajan suresh.thiagara...@pmcs.com
Reviewed-by: Hannes Reinecke h...@suse.com
Reviewed-by: Jack Wang
From: Viswas G viswa...@pmcs.com
Updated 12G linkrate to libsas.
Changes from V1:
None
Signed-off-by: Viswas G viswa...@pmcs.com
Reviewed-by: Suresh Thiagarajan suresh.thiagara...@pmcs.com
Reviewed-by: Hannes Reinecke h...@suse.com
Reviewed-by: Jack Wang jinpu.w...@profitbricks.com
- put_unaligned_be64(info, buf[3]);
+ /*
+* Fixed format sense reserves only 32 bits for the
+* 'information' field
+*/
+ put_unaligned_be32((u32)info, buf[3]);
}
}
Comments inline.
I'm not keen on the numerous pr_err() in here. I think it'll make the driver
chatty especially with a badly behaving userspace.
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
Add support for physical LUN segmentation (virtual LUNs) to device
driver supporting the
Hi David,
if you want to add SCSI-2 RESERVE/RELEASE it would be at least
different opcodes if not an entirely different API. But what for?
RESERVE/RELEASE are basially unsuable and that's why there are
almost no users out there, and they can usually prefer SCSI-3
semantics.
If you have a real
On Tue, 11 Aug 2015 14:26:34 +0200, Christoph Hellwig wrote:
if you want to add SCSI-2 RESERVE/RELEASE it would be at least
different opcodes if not an entirely different API. But what for?
RESERVE/RELEASE are basially unsuable and that's why there are
almost no users out there, and they can
On Tue, 2015-08-11 at 16:21 +1000, Daniel Axtens wrote:
Actually, I forgot one thing:
config CXLFLASH
tristate Support for IBM CAPI Flash
- depends on PCI SCSI CXL
+ depends on PCI SCSI CXL EEH
Should you depend on CXL_EEH here, seeing as you use CONFIG_CXL_EEH?
10.08.2015 18:30, Bart Van Assche пишет:
On 08/10/2015 08:18 AM, Konstantin Krotov wrote:
I was faced with the following problem:
Im exported to compute-node scsi disks through ib_srp from storages. And
if reconnect occurs for any reason, eg
[1201117.626498] scsi host62: ib_srp: REJ
On Aug 10, 2015, at 6:52 PM, Daniel Axtens d...@axtens.net wrote:
@@ -487,11 +515,27 @@ static int cxlflash_eh_host_reset_handler(struct
scsi_cmnd *scp)
get_unaligned_be32(((u32 *)scp-cmnd)[2]),
get_unaligned_be32(((u32 *)scp-cmnd)[3]));
-rcr =
On Aug 10, 2015, at 8:32 PM, Michael Neuling mi...@neuling.org wrote:
This patch set is intended for the 4.3 release and adds support for
error recovery and the superpipe features provided by the IBM CXL
Flash adapter. The superpipe function was originally presented in an
RFC patch set in
Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to
user setting the time or due to NTP.
Monotonic time is constantly increasing time better suited for comparing two
timestamps.
Signed-off-by: Abhilash Jindal klock.andr...@gmail.com
---
drivers/scsi/bfa/bfa_port.c |
Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to
user setting the time or due to NTP. Boot time is constantly increasing time
better suited for comparing two timestamps.
Signed-off-by: Abhilash Jindal klock.andr...@gmail.com
---
drivers/scsi/bfa/bfa_svc.c | 16
On 07/08/15 17:34, Julien Grall wrote:
Hi all,
This patch series aims to use the memory terminologies described in
include/xen/mm.h [1] for Linux xen code.
Applied to for-linus-4.3, thanks.
David
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message
On 08/11/2015 06:41 AM, Konstantin Krotov wrote:
Hello, thanks for reply.
I build a package version 2.0.34, but problem is reproduced:
[ 260.266374] scsi host15: ib_srp: REJ received
[ 260.266383] scsi host15: ib_srp: SRP LOGIN from
fe80::::0002:c903:0008:c884 to
Description:
Controller BIOS/UEFI driver used to send this request. But for
IBM-Power system there is no BIOS/UEFI driver. So this change is
required for IBM, otherwise controller will be read-only mode.
Changes from V2:
None
Signed-off-by: Mahesh Rajashekhara
Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com
---
drivers/scsi/aacraid/aacraid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h
index 2de5ebc..074878b 100644
--- a/drivers/scsi/aacraid/aacraid.h
Description:
As pci_enable_msix() deprecated, replaced with pci_enable_msix_range()
Changes from V5:
Merged 10 and 11 of V5 into this patch.
AAC_MAX_MSIX definition change.
Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com
---
drivers/scsi/aacraid/aacraid.h | 2 +-
Thanks for your review comments, Tomas
Rajinikanth Pandurangan is no longer with PMC-Sierra now. I have taken care
your review comments in V6 patch set.
Thanks,
Mahesh
-Original Message-
From: Tomas Henzl [mailto:the...@redhat.com]
Sent: Thursday, July 23, 2015 8:04 PM
To:
On Aug 11, 2015, at 12:23 AM, Michael Neuling mi...@neuling.org wrote:
Some comments inline
Thanks for reviewing, responses below.
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote:
Add superpipe supporting infrastructure to device driver for the IBM CXL
Flash adapter. This patch
Mikey: Thanks for your review. Comments inline below.
On 8/11/2015 5:54 AM, Michael Neuling wrote:
I'm not keen on the numerous pr_err() in here. I think it'll make the driver
chatty especially with a badly behaving userspace.
Will look at all the pr_err() and limit them to errors that are
Ben:
Comments inline below.
On 8/11/2015 12:29 AM, Benjamin Herrenschmidt wrote:
So in a similar vein to the previous review, I am missing a lot of
context here but a few things did spring to me eyes:
Thanks for your review.
+ list_for_each_entry_safe(lli, temp, cfg-lluns, list)
+
+ pr_debug(%s: Wait for user context to quiesce...\n, __func__);
+ wake_up_all(cfg-limbo_waitq);
+ ssleep(1);
Why 1 sec and why in a loop? Can’t you poll/wait for completion somewhere?
This routine is called when the device is being removed and we need to
Christoph == Christoph Hellwig h...@lst.de writes:
Slightly more verbose patch description would be nice. Code looks OK.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe
Be good to do some clear sanity check the struct dk_cxlflash_resize
*resize
here. It's passed from userspace but then gets propogated to a bunch of
other
things here like nsectors, get_context etc who will all now be responsible
for
handling any dodgy data passed in.
Same
Quoting Matthew R. Ochs mro...@linux.vnet.ibm.com:
Introduce support for enhanced I/O error handling.
Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com
Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com
---
drivers/scsi/cxlflash/Kconfig | 2 +-
drivers/scsi/cxlflash/common.h |
Christoph == Christoph Hellwig h...@lst.de writes:
Happy to see a generic interface for this. I wish PR semantics were
simpler but the code looks good to me.
Reviewed-by: Martin K. Petersen martin.peter...@oracle.com
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from
Christoph == Christoph Hellwig h...@lst.de writes:
Christoph Split out helpers for all non-trivial ioctls to make this
Christoph function simpler, and also start passing around a pointer
Christoph version of the argument, as that's what most ioctl handlers
Christoph actually need.
Looks good.
Quoting Matthew R. Ochs mro...@linux.vnet.ibm.com:
Add superpipe supporting infrastructure to device driver for the IBM CXL
Flash adapter. This patch allows userspace applications to take advantage
of the accelerated I/O features that this adapter provides and bypass the
traditional filesystem
Quoting Matthew R. Ochs mro...@linux.vnet.ibm.com:
Add superpipe supporting infrastructure to device driver for the IBM CXL
Flash adapter. This patch allows userspace applications to take advantage
of the accelerated I/O features that this adapter provides and bypass the
traditional filesystem
Sumit,
@@ -1239,7 +1239,9 @@ union megasas_sgl_frame {
typedef union _MFI_CAPABILITIES {
struct {
#if defined(__BIG_ENDIAN_BITFIELD)
- u32 reserved:25;
+ u32 reserved:23;
+ u32 support_ext_io_size:1;
+ u32
Sumit,
@@ -973,7 +973,12 @@ struct megasas_ctrl_info {
struct {
#if defined(__BIG_ENDIAN_BITFIELD)
- u32 reserved:12;
+ u32 reserved:7;
+ u32 useSeqNumJbodFP:1;
+ u32 supportExtendedSSCSize:1;
+ u32
11.08.2015 23:28, Bart Van Assche пишет:
On 08/11/2015 06:41 AM, Konstantin Krotov wrote:
Hello, thanks for reply.
I build a package version 2.0.34, but problem is reproduced:
[ 260.266374] scsi host15: ib_srp: REJ received
[ 260.266383] scsi host15: ib_srp: SRP LOGIN from
41 matches
Mail list logo
