Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

Hi Martin, We would test this internally and then ACK within a week. Thanks, Nilesh On 29/11/16, 10:15 PM, "Martin K. Petersen" wrote: >> "Christoph" == Christoph Hellwig writes: > >Christoph> And simplify the MSI-X logic in general - just request

RE: [PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

> -Original Message- > From: Cathy Avery [mailto:cav...@redhat.com] > Sent: Wednesday, November 23, 2016 5:47 AM > To: KY Srinivasan ; Haiyang Zhang > ; j...@linux.vnet.ibm.com; > martin.peter...@oracle.com > Cc: de...@linuxdriverproject.org;

RE: [PATCH 5/5] megaraid_sas: add mmio barrier after register writes

> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Monday, November 21, 2016 9:27 PM > To: Kashyap Desai; Hannes Reinecke; Martin K. Petersen > Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux- > s...@vger.kernel.org; Hannes Reinecke > Subject: Re:

RE: [PATCH][V2] scsi: megaraid-sas: fix spelling mistake of "outstanding"

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Wednesday, November 30, 2016 12:50 AM > To: Colin King; Kashyap Desai; Sumit Saxena; Shivasharan S; James E . J . > Bottomley; Martin K . Petersen; megaraidlinux@broadcom.com; linux- >

Re: qed, qedi patchset submission

Hi David, As we are preparing to post V3 of the qed (drivers/net/) and qedi (drivers/scsi/), I would like to get your opinion on the "qedi" part. As qedi (the iSCSI driver) is dependent on the accompanying "qed" changes, qedi changes have to follow or be together with qed changes. Martin is ok

[PATCH] mpt3sas: Recognize and act on iopriority info

From: Adam Manzanares This patch adds support for request iopriority handling in the mpt3sas layer. This works only when a ATA device is behind the SATL. The ATA device also has to indicate that it supports command priorities in the identify information that is pulled

Donation

Hello, My name is Gloria C. Mackenzie, i have a Monetary Donation to make for less privilege and yourself and your organization, am writing you with a friend's email, please contact me on g_macken...@rogers.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

Re: [PATCH][V2] scsi: megaraid-sas: fix spelling mistake of "outstanding"

On 11/29/2016 11:13 AM, Colin King wrote: Trivial fix to spelling mistake "oustanding" to "outstanding" in dev_info and scmd_printk messages. Also join wrapped literal string in the scmd_printk. Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send

[PATCH][V2] scsi: megaraid-sas: fix spelling mistake of "outstanding"

From: Colin Ian King Trivial fix to spelling mistake "oustanding" to "outstanding" in dev_info and scmd_printk messages. Also join wrapped literal string in the scmd_printk. Signed-off-by: Colin Ian King ---

Re: [PATCH] scsi: megaraid-sas: fix spelling mistake of "outstanding"

On 11/29/2016 11:00 AM, Colin King wrote: scmd_printk(KERN_NOTICE, scmd, "Command for which abort is" - " issued is not found in oustanding commands\n"); + " issued is not found in outstanding commands\n"); Hello Colin, Since you are

[PATCH] scsi: megaraid-sas: fix spelling mistake of "outstanding"

From: Colin Ian King Trivial fix to spelling mistake "oustanding" to "outstanding" in dev_info and scmd_printk messages Signed-off-by: Colin Ian King --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-

[GIT PULL] SCSI fixes for 4.9-rc7

Four small fixes. The be2iscsi is a potential device overrun in consistent memory, which could have nasty consequences if the consistent allocations are packed. The hpsa one fixes a regression where older controllers can now get a numbering clash between the first internal disk and the

Re: [PATCH v1 00/11] scsi: ufs: bug fixes patch series #3

> "Subhash" == Subhash Jadavani writes: Subhash> This bug fix patch series is intended to bring in important bug Subhash> fixes required for UFS stability and functionality. Applied to 4.10/scsi-queue. PS. Don't forget to CC: linux-scsi on your cover letters. --

Re: [PATCH v2 0/6] Add QLogic FastLinQ iSCSI (qedi) driver.

> "Manish" == Manish Rangankar writes: Manish> This series introduces hardware offload iSCSI initiator driver Manish> for the 41000 Series Converged Network Adapters (579xx chip) by Manish> Qlogic. The overall driver design includes a common module Manish>

Re: [PATCH v2 04/14] cxlflash: Avoid command room violation

Uma, This looks better, thanks for reworking. -matt > On Nov 28, 2016, at 6:41 PM, Uma Krishnan wrote: > > During test, a command room violation interrupt is occasionally seen > for the master context when the CXL flash devices are stressed. > > After studying

Re: [PATCH] cciss: remove unneeded void pointer cast

> "Javier" == Javier Martinez Canillas writes: >> I'm happy to queue it. However, I never saw Don's ack and neither did >> patchwork. Was that done in a private email? Javier> Strange, it wasn't a private email but for some reason I see Javier> that it didn't made it

Re: [PATCH] scsi: lpfc: Replace pci_pool_alloc by pci_pool_zalloc

> "Souptick" == Souptick Joarder writes: Souptick> In lpfc_new_scsi_buf_s3() and lpfc_new_scsi_buf_s4() Souptick> pci_pool_alloc followed by memset will be replaced by Souptick> pci_pool_zalloc() James, Dick: Please review! -- Martin K. Petersen Oracle Linux

Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI

> "Benjamin" == Benjamin Herrenschmidt writes: Benjamin> LSIs must be ack'ed with an MMIO otherwise they remain Benjamin> asserted forever. This is controlled by the "clear_isr" flag. Benjamin> While we set that flag properly when deciding initially Benjamin>

Re: [PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

> "Cathy" == Cathy Avery writes: Cathy> On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array Cathy> requires. Also the buffer needs to be cleared or the upper bytes Cathy> will contain junk. K.Y.: Please review! -- Martin K. Petersen Oracle Linux

Re: bnx2i + bnx2fc: convert to generic workqueue (#2)

> "Sebastian" == Sebastian Andrzej Siewior writes: Sebastian> This is the a repost + fixups to get the patches applied Sebastian> against v4.9-rc4. mkp's scsi for-next tree can be merged Sebastian> with no conflicts. Chad? -- Martin K. Petersen Oracle Linux

Re: [PATCH] [SCSI] dpt_i2o: Add a missing call to kfree

> "Quentin" == Quentin Lambert writes: Quentin> Most error branches following the call to kzalloc contain a Quentin> call to kfree. This patch add these calls where they are Quentin> missing. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [PATCH] cxgb4i: Add a missing call to neigh_release

> "Quentin" == Quentin Lambert writes: Quentin> Most error branches following the call to dst_neigh_lookup Quentin> contain a call to neigh_release. This patch add these calls Quentin> where they are missing. Varun: Please review! -- Martin K. Petersen

Re: [PATCH] cciss: remove unneeded void pointer cast

Hello Martin, On 11/29/2016 01:35 PM, Martin K. Petersen wrote: >> "Javier" == Javier Martinez Canillas writes: > casting value returned by memory allocation function to (struct cciss_scsi_adapter_data_t *) is useless. Signed-off-by: Javier

Re: [PATCH] isci: Add a missing call to pci_unmap_biosrom

> "Quentin" == Quentin Lambert writes: Quentin> Most error branches following the call to pci_map_biosrom Quentin> contain a call to pci_unmap_biosrom. This patch add these calls Quentin> where they are missing. Applied to 4.10/scsi-queue. -- Martin K. Petersen

Re: [PATCH] isci: avoid array subscript warning

> "Arnd" == Arnd Bergmann writes: Arnd> I'm getting a new warning with gcc-7: isci/remote_node_context.c: Arnd> In function 'sci_remote_node_context_destruct': Arnd> isci/remote_node_context.c:69:16: error: array subscript is above Arnd> array bounds [-Werror=array-bounds]

Re: [PATCH] qla4xxx: switch to pci_alloc_irq_vectors

> "Christoph" == Christoph Hellwig writes: Christoph> And simplify the MSI-X logic in general - just request the Christoph> two vectors directly instead of going through an indirection Christoph> table. Vikas: Please review! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] pmcraid: switch to pci_alloc_irq_vectors

> "Christoph" == Christoph Hellwig writes: Somebody please review. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] isci: switch to pci_alloc_irq_vectors

> "Christoph" == Christoph Hellwig writes: Artur or Dan: Please review! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] vmw_pvscsi: switch to pci_alloc_irq_vectors

> "Christoph" == Christoph Hellwig writes: Christoph> And simply the interrupt handler by splitting the INTx case Christoph> that needs to deal with shared interrupts into a separate Christoph> helper. Jim: Please review! -- Martin K. Petersen Oracle Linux Engineering --

Re: [PATCH] cciss: remove unneeded void pointer cast

> "Javier" == Javier Martinez Canillas writes: >>> casting value returned by memory allocation function to (struct >>> cciss_scsi_adapter_data_t *) is useless. >>> >>> Signed-off-by: Javier Martinez Canillas >> >> Acked-by: Don Brace

Re: [patch] scsi: hisi_sas: shift vs compare typos

> "Dan" == Dan Carpenter writes: Dan> There are some typos where we intended "<<" but have "<". Seems Dan> likely to cause a bunch of problems. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH 1/2] SRP transport: Move queuecommand() wait code to SCSI core

> "Bart" == Bart Van Assche writes: Bart> On 11/25/16 15:21, Max Gurtovoy wrote: >> the arg is sdev. Bart> Good catch. Bart> Martin, do you want me to repost this patch or do you want me to Bart> post a fix-up patch? I fixed it up. -- Martin K. Petersen

Re: [PATCH v2] scsi: aic94xx: Add a missing call to kfree

> "Quentin" == Quentin Lambert writes: Quentin> Most error branches following the call to kzalloc contain a Quentin> call to kfree. This patch add these calls where they are Quentin> missing and set the relevant pointers to NULL. Applied to 4.10/scsi-queue. --

Re: [PATCH 0/3] hpsa compatility fixes

> "Hannes" == Hannes Reinecke writes: Hannes> Hi all, this is a patchset to get hpsa working on older Hannes> controllers. Most notably older controller do not support the Hannes> extended REPORT PHYS command, so we need to fallback to the Hannes> legacy version here. I've

Re: [PATCH 2/3] hpsa: fallback to use legacy REPORT PHYS command

> "Hannes" == Hannes Reinecke writes: Hannes> Older SmartArray controller do not support the extended REPORT Hannes> PHYS command, so fallback to use the legacy version here. Don: Please review. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

[PATCH] scsi: hisi_sas: fix free'ing in probe and remove

From: Xiaofei Tan This patch addresses 4 problems in the module probe/remove: - When hisi_sas_shost_alloc() fails after we alloc shost memory, we should free shost memory before the function returns. - When hisi_sas_probe() fails after we alloc the HBA memories, we should

Patch "scsi: mpt3sas: Fix secure erase premature termination" has been added to the 4.8-stable tree

This is a note to let you know that I've just added the patch titled scsi: mpt3sas: Fix secure erase premature termination to the 4.8-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "scsi: mpt3sas: Fix secure erase premature termination" has been added to the 4.4-stable tree

This is a note to let you know that I've just added the patch titled scsi: mpt3sas: Fix secure erase premature termination to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH 1/2] SRP transport: Move queuecommand() wait code to SCSI core

On 11/25/16 15:21, Max Gurtovoy wrote: > On 11/23/2016 2:17 AM, Bart Van Assche wrote: >> + >> +/** >> + * scsi_wait_for_queuecommand() - wait for ongoing queuecommand() calls >> + * @shost: SCSI host pointer. > > the arg is sdev. Good catch. Martin, do you want me to repost this patch or do you

Re: [PATCH] cciss: remove unneeded void pointer cast

Hello Don, On 10/13/2016 03:12 PM, Don Brace wrote: >> -Original Message- >> From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com] >> Sent: Thursday, October 13, 2016 11:11 AM >> To: linux-ker...@vger.kernel.org >> Cc: Javier Martinez Canillas; esc.storagedev;

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

On 29/11/16 12:40, Jan Beulich wrote: On 29.11.16 at 12:19, wrote: >> On 29/11/16 12:14, Jan Beulich wrote: >> On 29.11.16 at 11:50, wrote: --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -184,8 +184,6 @@ static

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

>>> On 29.11.16 at 12:19, wrote: > On 29/11/16 12:14, Jan Beulich wrote: > On 29.11.16 at 11:50, wrote: >>> --- a/drivers/scsi/xen-scsifront.c >>> +++ b/drivers/scsi/xen-scsifront.c >>> @@ -184,8 +184,6 @@ static struct vscsiif_request

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

On 29/11/16 12:28, David Vrabel wrote: > On 29/11/16 11:19, Juergen Gross wrote: >> On 29/11/16 12:14, Jan Beulich wrote: >> On 29.11.16 at 11:50, wrote: --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -184,8 +184,6 @@ static struct

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

On 29/11/16 11:19, Juergen Gross wrote: > On 29/11/16 12:14, Jan Beulich wrote: > On 29.11.16 at 11:50, wrote: >>> --- a/drivers/scsi/xen-scsifront.c >>> +++ b/drivers/scsi/xen-scsifront.c >>> @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct >>>

Re: [patch] scsi: hisi_sas: shift vs compare typos

On 29/11/2016 10:47, Dan Carpenter wrote: There are some typos where we intended "<<" but have "<". Seems likely to cause a bunch of problems. Fixes: d3b688d3c69d ("scsi: hisi_sas: add v2 hw support for ECC and AXI bus fatal error") Signed-off-by: Dan Carpenter ---

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

On 29/11/16 12:14, Jan Beulich wrote: On 29.11.16 at 11:50, wrote: >> --- a/drivers/scsi/xen-scsifront.c >> +++ b/drivers/scsi/xen-scsifront.c >> @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct >> vscsifrnt_info *info) >> >> ring_req =

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

>>> On 29.11.16 at 11:50, wrote: > --- a/drivers/scsi/xen-scsifront.c > +++ b/drivers/scsi/xen-scsifront.c > @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct > vscsifrnt_info *info) > > ring_req = RING_GET_REQUEST(&(info->ring),

[PATCH] xen/scsifront: don't advance ring request pointer in case of error

When allocating a new ring slot for a request don't advance the producer index until the request is really ready to go to the backend. Otherwise only partially filled requests will be visible to the backend in case of errors on the frontend side. In scsifront_action_handler() free the request id

[patch] scsi: hisi_sas: shift vs compare typos

There are some typos where we intended "<<" but have "<". Seems likely to cause a bunch of problems. Fixes: d3b688d3c69d ("scsi: hisi_sas: add v2 hw support for ECC and AXI bus fatal error") Signed-off-by: Dan Carpenter --- There is another static checker warning to

[PATCH] dm-zoned: Zoned block device target

The dm-zoned device mapper provides transparent write access to zoned block devices (ZBC and ZAC compliant devices). dm-zoned hides to the device user (a file system or an application doing raw block device accesses) any constraint imposed on write requests by the zoned block device. Its primary

Re: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading

Hi Don, On Tue, 2016-11-29 at 01:52 +, Don Brace wrote: > > -Original Message- > > From: Martin Wilck [mailto:mwi...@suse.de] > > Sent: Monday, November 21, 2016 8:04 AM > > To: Don Brace > > Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com; > > linux- > >