Re: [PATCH 3/3] Storvsc: Select channel based on available percentage of ring buffer to write

Hi Long, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc6] [cannot apply to linus/master net-next/master net/master next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #22 from Bart Van Assche (bvanass...@acm.org) --- This ticket has category IO/Storage; SCSI. That category does not cover mounting filesystems. I'm fine with closing this ticket and creating a new ticket if for the mount issue if

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #21 from Chuck Burt (chuck.burt+kernel@gmail.com) --- Thank you again. Should we close this issue as duplicate / resolves elsewhere? -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH 1/6] esas2r: remove initialization / cleanup dead wood

Looks fine. Acked-by: Bradley Grove On 03/19/2018 03:37 AM, Christoph Hellwig wrote: esas2r has been converted to hotplug style initialization long ago, but kept various remant of the old-style scsi_module.c initialization around. Remove those. Signed-off-by: Christoph

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #20 from Bart Van Assche (bvanass...@acm.org) --- As far as I can see merging Dave's tree pulled in only the following three SCSI changes: * qed*: Utilize Firmware 8.15.3.0 * qedf: fix wrong le16 conversion * netlink: extended ACK

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #19 from Chuck Burt (chuck.burt+kernel@gmail.com) --- (Also, to clarify, the mounting does not actually fail... it produces that error as a dialog in the GUI, but mounting does actually succeed.) -- You are receiving this mail

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #18 from Chuck Burt (chuck.burt+kernel@gmail.com) --- Yet it appears there were numerous revisions in the `drivers/scsi` area...?

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #17 from Bart Van Assche (bvanass...@acm.org) --- At the end of bisect log 2 I found the following: first bad commit: [8d65b08debc7e62b2c6032d7fe7389d895b92cbc] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next It

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #16 from Chuck Burt (chuck.burt+kernel@gmail.com) --- Git Bisect Log 2 - https://bugzilla.kernel.org/attachment.cgi?id=274897 This identifies a separate issue (should I file a separate bug for this?) where mounting/unmounting

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #15 from Bart Van Assche (bvanass...@acm.org) --- Sorry but I lost track. What was the second issue? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #14 from Chuck Burt (chuck.burt+kernel@gmail.com) --- I tested with v4.15.0-041500. Great news, the hang is resolved! The second issue I found still exists, but that is not nearly as severe (it doesn't block my usage). It also

Re: [PATCH 2/2] target: remove spin_lock_assert() in __target_(attach|detach)_tg_pt_gp()

On Fri, 2018-03-23 at 18:50 +0100, bige...@linutronix.de wrote: > On 2018-03-23 17:44:46 [+], Bart Van Assche wrote: > > In other words, do we really need to remove these checks? I think that these > > checks are useful as documentation to people who read the SCSI target code. > > The target

Re: [PATCH 2/2] target: remove spin_lock_assert() in __target_(attach|detach)_tg_pt_gp()

On 2018-03-23 17:44:46 [+], Bart Van Assche wrote: > On Fri, 2018-03-23 at 18:19 +0100, bige...@linutronix.de wrote: > > __target_attach_tg_pt_gp() and __target_detach_tg_pt_gp() check if the > > caller > > holds lun_tg_pt_gp_lock(). Both functions are static, the callers are > > acquiring

Re: [PATCH 1/2 v2] target: drop spin_lock_assert() + irqs_disabled() combo checks

On Fri, 2018-03-23 at 18:36 +0100, Sebastian Andrzej Siewior wrote: > There are a few functions which check for if the lock is held > (spin_lock_assert()) and the interrupts are disabled (irqs_disabled()). > > From looking at the code, each function is static, the caller is near by > > and does

Re: [PATCH v2 13/38] cxlflash: Support adapter file descriptors for OCXL

> On Mar 22, 2018, at 12:12 PM, Frederic Barrat > wrote: > > > > Le 26/02/2018 à 23:21, Uma Krishnan a écrit : >> Allocate a file descriptor for an adapter context when requested. In order >> to allocate inodes for the file descriptors, a pseudo filesystem is

Re: [PATCH 2/2] target: remove spin_lock_assert() in __target_(attach|detach)_tg_pt_gp()

On Fri, 2018-03-23 at 18:19 +0100, bige...@linutronix.de wrote: > __target_attach_tg_pt_gp() and __target_detach_tg_pt_gp() check if the caller > holds lun_tg_pt_gp_lock(). Both functions are static, the callers are > acquiring the lock before the invocation of the function so the check > looks

RE: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate ring buffer percentage

> Subject: RE: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate ring > buffer percentage > > > > > -Original Message- > > From: Haiyang Zhang > > Sent: Friday, March 23, 2018 8:01 AM > > To: Long Li ; KY Srinivasan > > ; Stephen

[PATCH 1/2 v2] target: drop spin_lock_assert() + irqs_disabled() combo checks

There are a few functions which check for if the lock is held (spin_lock_assert()) and the interrupts are disabled (irqs_disabled()). >From looking at the code, each function is static, the caller is near by and does spin_lock_irq|safe(). As Linus puts it: |It's not like this is some function

[PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks

There are a few functions which check for if the lock is held (spin_lock_assert()) and the interrupts are disabled (irqs_disabled()). >From looking at the code, each function is static, the caller is near by and does spin_lock_irq|safe(). As Linus puts it: |It's not like this is some function

[PATCH 2/2] target: remove spin_lock_assert() in __target_(attach|detach)_tg_pt_gp()

__target_attach_tg_pt_gp() and __target_detach_tg_pt_gp() check if the caller holds lun_tg_pt_gp_lock(). Both functions are static, the callers are acquiring the lock before the invocation of the function so the check looks superfluous. Remove it. Signed-off-by: Sebastian Andrzej Siewior

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Fri, Mar 23, 2018 at 9:25 AM, Bart Van Assche wrote: > > Have you considered to delete the WARN_ON_ONCE(!irqs_disabled()) statement? > I think that check duplicates functionality that already exists in lockdep > since lockdep is already able to detect spinlock use

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On 2018-03-23 16:25:25 [+], Bart Van Assche wrote: > On Fri, 2018-03-23 at 16:55 +0100, Sebastian Andrzej Siewior wrote: > > I am going take this into -RT tree for now until we have different > > solution. > > Have you considered to delete the WARN_ON_ONCE(!irqs_disabled()) statement? > I

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Fri, 2018-03-23 at 16:55 +0100, Sebastian Andrzej Siewior wrote: > I am going take this into -RT tree for now until we have different > solution. Have you considered to delete the WARN_ON_ONCE(!irqs_disabled()) statement? I think that check duplicates functionality that already exists in

[PATCH 5/8] scsi: hisi_sas: consolidate command check in hisi_sas_get_ata_protocol()

From: Xiaofei Tan Currently we check the fis->command value in 2 locations in hisi_sas_get_ata_protocol() switch statement. Fix this by consolidating the check for fis->command value to 1 location only. Signed-off-by: Xiaofei Tan Signed-off-by:

[PATCH 4/8] scsi: hisi_sas: use dma_zalloc_coherent()

From: Xiang Chen This is a warning coming from Coccinelle, and need to use new interface dma_zalloc_coherent() instead of dma_alloc_coherent()/memset(). Signed-off-by: Xiang Chen Signed-off-by: John Garry ---

[PATCH 1/8] scsi: hisi_sas: make SAS address of SATA disks unique

From: Xiang Chen When directly connected with SATA disks in different SAS cores, fill SAS address with scsi_host's id to make it's fake SAS address unique. Signed-off-by: Xiang Chen Signed-off-by: John Garry ---

[PATCH 3/8] scsi: hisi_sas: delete timer when removing hisi_sas driver

From: Xiang Chen Delete timer for v1 and v3 hw when removing hisi_sas driver. Signed-off-by: Xiang chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +++

[PATCH 2/8] scsi: hisi_sas: update RAS feature for later revision of v3 HW

From: Xiaofei Tan There is an modification for later revision of v3 hw. More HW errors are reported through RAS interrupt. These errors were originally reported only through MSI. When report to RAS, some combinations are done to port AXI errors and FIFO OMIT errors. For

[PATCH 6/8] scsi: hisi_sas: check IPTT is valid before using it for v3 hw

From: Xiaofei Tan There is a bug of v3 hw development version. When AXI error happen, hw may return an abnormal CQ that IPTT value is 0x. This will cause IPTT out-of-bounds reference. This patch add an check of IPTT in cq_tasklet_v3_hw(), and discard invalid slot.

[PATCH 0/8] hisi_sas: some misc changes

This patchset introduces some minor, more trivial patches, some of which have been sitting on our internal dev branch for a while. The only bug fixes (hw workaround or sw) are the IPTT range check fix and a timer fix for module removal. Others are trivial. John Garry (2): scsi: hisi_sas: print

[PATCH 7/8] scsi: hisi_sas: print device id for errors

When we find an erroneous slot completion, to help aid debugging add the device index to the current debug log. Signed-off-by: John Garry Reviewed-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 4 ++--

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #13 from Bart Van Assche (bvanass...@acm.org) --- Thanks for having run a bisect, that really helps. Recently the following commit went upstream: commit c9f926000fe3b84135a81602a9f7e63a6a7898e2 (mkp-scsi/4.15/scsi-fixes) Author:

[PATCH 8/8] scsi: hisi_sas: remove some unneeded structure members

This patch removes unneeded structure elements: - hisi_sas_phy.dev_sas_addr: only ever written - Also remove associated function which writes it, hisi_sas_init_add(). - hisi_sas_device.attached_phy: only ever written - Also remove code to set it in hisi_sas_dev_found()

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On 2018-03-22 06:37:45 [-0300], Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > >

Multi-Actuator SAS HDD First Look

Seagate announced their split actuator SAS drive, which will probably require some kernel changes for full support. It's targeted at cloud provider JBODs and RAID. Here are some of the drive's architectural points. Since the two LUNs share many common components (e.g. spindle) Seagate allocated

RE: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate ring buffer percentage

> -Original Message- > From: Haiyang Zhang > Sent: Friday, March 23, 2018 8:01 AM > To: Long Li ; KY Srinivasan > ; Stephen Hemminger ; > James E . J . Bottomley ; Martin K . Petersen >

RE: [PATCH 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

> -Original Message- > From: Long Li > Sent: Thursday, March 22, 2018 8:16 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > James E . J . Bottomley ; Martin

RE: [PATCH 2/3] Netvsc: Use the vmbus functiton to calculate ring buffer percentage

> -Original Message- > From: Long Li > Sent: Thursday, March 22, 2018 8:16 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > James E . J . Bottomley ; Martin

[PATCH] scsi: qla2xxx: Fix small memory leak in qla2x00_probe_one on probe failure

The code that fixes the crashes in the following commit introduced a small memory leak: commit 6a2cf8d3663e ("scsi: qla2xxx: Fix crashes in qla2x00_probe_one on probe failure") Fixing this requires a bit of reworking, which I've explained. Also provide some code cleanup. Fixes: 6a2cf8d3663e

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #12 from Chuck Burt (chuck.burt+kernel@gmail.com) --- I finally got around to bisecting. I had to do it twice as I identified two issues here. Git Bisect Log 1 - https://bugzilla.kernel.org/attachment.cgi?id=274895 This

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #11 from Chuck Burt (chuck.burt+kernel@gmail.com) --- Created attachment 274897 --> https://bugzilla.kernel.org/attachment.cgi?id=274897=edit Git Bisect Log 2 - 20180323 -- You are receiving this mail because:

[Bug 197875] Processes hang on attempted access of WDC WD30-EZRX 3TB HDD on HP Z420 Workstation

https://bugzilla.kernel.org/show_bug.cgi?id=197875 --- Comment #10 from Chuck Burt (chuck.burt+kernel@gmail.com) --- Created attachment 274895 --> https://bugzilla.kernel.org/attachment.cgi?id=274895=edit Git Bisect Log 1 - 20180323 -- You are receiving this mail because:

[PATCH] scsi: don't look for NULL devices handlers by name

Currently scsi_dh_lookup() doesn't check for NULL as a device name. This combined with nvme over dm-mapth results in the following messages emitted by device-mapper: device-mapper: multipath: Could not failover device 259:67: Handler scsi_dh_(null) error 14. Let scsi_dh_lookup() fail fast on