Re: [PATCH] st: implement sysfs based tape statistics v2

I pulled this this morning and will be testing. The prior version was stable for me on the upstream and RHEL 6.5 kernel without exhaustive testing. We also just received more requests to get this into RHEL from HP / Red Hat customers. Kai, what are your thoughts. I realize this is a large amount

Re: [PATCH] st: implement sysfs based tape statistics v2

- Original Message - From: Kai Mäkisara (Kolumbus) kai.makis...@kolumbus.fi To: Laurence Oberman oberma...@gmail.com Cc: Shane M Seymour shane.seym...@hp.com, lober...@redhat.com, linux-scsi@vger.kernel.org, James E.J. Bottomley (jbottom...@parallels.com) jbottom...@parallels.com, je

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

Hello Its not going to be tens of thousands of devices. That count was an aggregate based on 1000's of servers. In reality its unlikely to ever be more than 100 tapes drives per individual Linux kernel instance. Therefore sysfs will be the valid way to do this and make the data available to user

Re: [PATCH] st: implement sysfs based tape statistics v2

- Original Message - From: Kai Mäkisara (Kolumbus) kai.makis...@kolumbus.fi To: Laurence Oberman lober...@redhat.com Cc: Laurence Oberman oberma...@gmail.com, Shane M Seymour shane.seym...@hp.com, linux-scsi@vger.kernel.org, James E.J. Bottomley (jbottom...@parallels.com) jbottom

[PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module

/sys/module/tcm_qla2xxx/parameters/jammer_flag sleep $sleep_time echo 0 /sys/module/tcm_qla2xxx/parameters/jammer_flag echo We stopped the jammer logger Jammer stopped This Patch diff against 3.19.1 Tested by: Laurence Oberman lober...@redhat.com Signed-off-by: Laurence Oberman lober

Re: [PATCH ] qla2xxx Add SCSI command jammer/discard capabilty to the qla2xxx target module - revision3

case. Tested by: Laurence Oberman lober...@redhat.com Signed-off-by: Laurence Oberman lober...@redhat.com diff -Nurp a/Documentation/scsi/qla2xxx.txt b/Documentation/scsi/qla2xxx.txt --- a/Documentation/scsi/qla2xxx.txt1969-12-31 19:00:00.0 -0500 +++ b/Documentation/scsi/qla2xxx.txt

Re: [PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module

in that latest thread with a new version. Many Thanks for the consideration Laurence Laurence Oberman Red Hat Global Support Service SEG Team - Original Message - From: Quinn Tran quinn.t...@qlogic.com To: Laurence Oberman lober...@redhat.com, Andy Grover agro...@redhat.com, linux-scsi linux-scsi

Resend: [PATCH ] qla2xxx Add SCSI command jammer/discard capabilty to the qla2xxx target module - revision3

Oberman Red Hat Global Support Service SEG Team - Original Message - From: Laurence Oberman lober...@redhat.com To: Bart Van Assche bart.vanass...@sandisk.com, Quinn Tran quinn.t...@qlogic.com Cc: Andy Grover agro...@redhat.com, linux-scsi@vger.kernel.org, n...@daterainc.com, Laurence

Re: [PATCH v6] st implement tape statistics

Hello, I pulled the latest revision of this patch and tested it. I can vouch for it working as expected with out any obvious impact to the existing st driver Is there any way we can move this along. Thanks Tested-by:Laurence Oberman lober...@redhat.com On Thu, Feb 12, 2015 at 6:15 AM, Seymour,

Re: [PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision2

/scripts/checkpatch.pl latest-upstream-jammer-path total: 0 errors, 0 warnings, 60 lines checked latest-upstream-jammer-path has no obvious style problems and is ready for submission. Tested by: Laurence Oberman lober...@redhat.com Signed-off-by: Laurence Oberman lober...@redhat.com diff -Nurp

Re: mvsas panics and dies when attached to a port extender on newer kernels

Any chance you can capture a vmcore (kernel only pages), I will provide an upload location. Thanks Laurence On Tue, Apr 14, 2015 at 5:16 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Tue, 2015-04-14 at 14:03 -0700, Adam Talbot wrote: To make a very long debugging story

Re: [PATCH] st: trivial: remove form feed characters

Reviewed-by: Laurence Oberman <lober...@redhat.com> On Wed, Nov 4, 2015 at 4:52 AM, Maurizio Lombardi <mlomb...@redhat.com> wrote: > Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com> > --- > drivers/scsi/st.c | 24 > 1 file changed,

Re: [PATCH] st: allow debug output to be enabled or disabled via sysfs

I support this addition as it can be done without the module reload provided by my prior patch. Reviewed-by: Laurence Oberman <oberma...@gmail.com> On Mon, Oct 12, 2015 at 12:31 AM, Seymour, Shane M <shane.seym...@hpe.com> wrote: > > Change st driver to allow enabling or disa

Re: st driver doesn't seem to grok LTO partitioning

Thanks Doug Trying that now Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Douglas Gilbert" <dgilb...@interlog.com> To: "Laurence Oberman" <lober...@redhat.com>, "Emmanuel

Re: st driver doesn't seem to grok LTO partitioning

] Rewinding tape. # mt -f /dev/nst0 mkpartition 1 /dev/nst0: Input/output error Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Emmanuel Florac" <eflo...@intellique.com> To: "Laurence Oberman&

Re: st driver doesn't seem to grok LTO partitioning

. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Laurence Oberman" <lober...@redhat.com> To: "Emmanuel Florac" <eflo...@intellique.com> Cc: "Laurence Oberman" <obe

Re: st driver doesn't seem to grok LTO partitioning

: 802, cmd: 15 10 0 0 18 0 [ 5499.370495] st 0:0:0:0: [st0] Sense Key : Illegal Request [current] [ 5499.371109] st 0:0:0:0: [st0] Add. Sense: Invalid field in parameter list [ 5499.371714] st 0:0:0:0: [st0] Partitioning of tape failed. Laurence Oberman Principal Software Maintenance Engineer Red Hat

Re: st driver doesn't seem to grok LTO partitioning

] [ 798.754289] st 0:0:0:0: [st0] Add. Sense: Invalid field in parameter list [ 798.757546] st 0:0:0:0: [st0] Partitioning of tape failed. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services From: Emmanuel Florac <eflo...@intellique.com> Date: Mon, Jan 4

Re: st driver doesn't seem to grok LTO partitioning

I am just waiting on some LTO5 tape cartridges and then will start working on this. I only have LTO cartridges so had to order a couple of LTO5's On Tue, Dec 22, 2015 at 5:04 AM, Emmanuel Florac <eflo...@intellique.com> wrote: > Le Tue, 22 Dec 2015 02:20:31 -0500 > Laurence Obe

Re: [PATCH] bnx2i: fix spelling mistake "complection" -> "completion"

; return; > } > > -- > 2.8.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Si

Re: [PREEMPT-RT] [PATCH v2] scsi/fcoe: convert to kworker

- Original Message - > From: "Sebastian Andrzej Siewior" <bige...@linutronix.de> > To: "Laurence Oberman" <lober...@redhat.com>, "James Bottomley" > <j...@linux.vnet.ibm.com> > Cc: "Christoph Hellwig" &l

Re: [PATCH] tcm_qla2xxx Add SCSI command jammer/discard capability to the tcm_qla2xxx module

- Original Message - > From: "Himanshu Madhani" <himanshu.madh...@qlogic.com> > To: "Laurence Oberman" <lober...@redhat.com>, "Nicholas A. Bellinger" > <n...@linux-iscsi.org> > Cc: "Bart Van Assche" <bart.vana

Re: [PATCH] aic7xxx: fix wrong return values

e_mem_region(struct ahc_softc *ahc, > if (start != 0) { > *bus_addr = start; > if (!request_mem_region(start, 0x1000, "aic7xxx")) > - error = ENOMEM; > + error = -ENOMEM; > if (error == 0) { > *maddr = ioremap_nocache(start, 256); > if (*maddr == NULL) { > - error = ENOMEM; > + error = -ENOMEM; > release_mem_region(start, 0x1000); > } > } > } else > - error = ENOMEM; > + error = -ENOMEM; > return (error); > } > > diff --git a/drivers/scsi/aic7xxx/aic7xxx_pci.c > b/drivers/scsi/aic7xxx/aic7xxx_pci.c > index 22d5a94..40e1c9b 100644 > --- a/drivers/scsi/aic7xxx/aic7xxx_pci.c > +++ b/drivers/scsi/aic7xxx/aic7xxx_pci.c > @@ -806,7 +806,7 @@ ahc_pci_config(struct ahc_softc *ahc, const struct > ahc_pci_identity *entry) > > error = ahc_reset(ahc, /*reinit*/FALSE); > if (error != 0) > - return (ENXIO); > + return -ENXIO; > > if ((ahc->features & AHC_DT) != 0) { > u_int sfunct; > @@ -2387,7 +2387,7 @@ static int > ahc_raid_setup(struct ahc_softc *ahc) > { > printk("RAID functionality unsupported\n"); > - return (ENXIO); > + return -ENXIO; > } > > static int > -- > 2.5.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Patch looks simple as the change is straightforward. However can you make the code consistent, some have parenthesis in return, some not. How did this work before though if it was returning non-negative to the caller or upper layer Has this been tested to work with the changes Reviewed-by Laurence Oberman <lober...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Connect-IB not performing as well as ConnectX-3 with iSER

- Original Message - > From: "Bart Van Assche" > To: "Robert LeBlanc" , "Sagi Grimberg" > > Cc: linux-r...@vger.kernel.org, linux-scsi@vger.kernel.org, "Max Gurtovoy" > > Sent: Wednesday, June

Re: [PATCH] snic: Fix use-after-free in case of a dma mapping error

snic_req_free(snic, rqi); > ret = -EINVAL; > > goto error; > -- > 2.8.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo

Re: [PATCH] tcm_qla2xxx: fix spelling mistake: "seperator" -> "separator"

to locate NPIV '@' seperator\n"); > + pr_err("Unable to locate NPIV '@' separator\n"); > return ERR_PTR(-EINVAL); > } > *p++ = '\0'; > -- > 2.8.1 > > -- > To unsubscribe from this list: send the line "unsubscribe li

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

: [st0] PP: max 1, add 1, xdp 1, psum 02, pofmetc 0, rec 03, units 00, sizes: 1 65535 Feb 04 13:48:42 srp-server kernel: st 6:0:1:0: [st0] MP: 11 08 01 01 30 03 00 00 27 10 ff ff Tested-by: Laurence Oberman <lober...@redhat.com> Laurence Oberman Principal Software Maintenance Engineer R

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Hi Kai What kernel was the last patch you attached against. Thanks Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Kai Mäkisara (Kolumbus)" <kai.makis...@kolumbus.fi> To: "Shane M Seymour"

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Meant to mention, still waiting for my new LTO5, also this is the first time I am testing the DAT72. Shane, have you had the DAT working before this last patch, if so which patch Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

] Rewinding tape. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Shane M Seymour" <shane.seym...@hpe.com> To: "Kai Mäkisara (Kolumbus)" <kai.makis...@kolumbus.fi> Cc: "Laurence Ober

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Kai Mäkisara (Kolumbus)" <kai.makis...@kolumbus.fi> To: "Shane M Seymour" <shane.seym...@hpe.com> Cc: "Laurence Oberman" <l

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

the f/w on that one) Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Kai Mäkisara (Kolumbus)" <kai.makis...@kolumbus.fi> To: "Shane M Seymour" <shane.seym...@hpe.com> Cc: "Laurence Ober

Re: What partition should the MTMKPART argument specify? Was: Re: st driver doesn't seem to grok LTO partitioning

it. But lets see what the others have to say Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Kai Mäkisara (Kolumbus)" <kai.makis...@kolumbus.fi> To: "Shane M Seymour" <shane.seym...@hpe.com>

Re: [PATCH] scsi_sysfs: Fix typo in is_bin_visible()

Reviewed-by:Laurence Oberman lober...@redhat.com> Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Ewan Milne" <emi...@redhat.com> To: "Hannes Reinecke" <h...@suse.de> Cc: "Martin

Re: [PATCH v2 0/2] Update SCSI target removal path

I can test this next week. I can test pre and then post patch. Will update when its validated. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Ewan D. Milne" <emi...@redhat.com> To: "jthumshirn&quo

Cant write to max_sectors_kb on 4.5.0 SRP target

SCSI name string: 0xfe807cfe900300726e4e Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message ----- From: "Laurence Oberman" <lober...@redhat.com> To: emi...@redhat.com Cc: "Martin K. Petersen" <martin.peter...@oracle.com>, "lin

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

to all that responded. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Ewan D. Milne" <emi...@redhat.com> To: "Laurence Oberman" <lober...@redhat.com> Cc: "Martin K. Petersen" <mart

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

4 3 2 0 78 03:56:59 sdc 0 000 1101824 0 1076 10241024 3 2 0 72 03:56:59 dm-4 0 0 00 1101824 0 1076 10241024 3 2 0 77 Laurence Oberman Principal Software Maintenance Enginee

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

o- mapped_lun3 ... [lun3 block/block-4 (rw)] | | | o- mapped_lun4 ... [lun4 block/block-5 (rw)] .. ,, Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - O

Re: [PATCH 1/2] scsi: add a max_segment_size limitation to struct Scsi_Host

Thanks Bart Good catch, I completely missed it. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Bart Van Assche" <bart.vanass...@sandisk.com> To: "Christoph Hellwig" <h...@lst.de>, li

Re: [PATCH 1/2] scsi: add a max_segment_size limitation to struct Scsi_Host

Modified patch to use min_not_zero() Ran a number of tests overnight on F/C, SCSI/SAS and SRP (RDMA) and no issues found. Tested-by: Laurence Oberman <lober...@redhat.com> Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message

Re: [PATCH 1/2] scsi: add a max_segment_size limitation to struct Scsi_Host

has many dependencies of course. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Bart Van Assche" <bart.vanass...@sandisk.com> To: "Christoph Hellwig" <h...@lst.de>, linux-r...@vger.kernel.

Re: [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes

Simple change, looks fine to me. Reviewed-by: Laurence Oberman <lober...@redhat.com> Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Denys Vlasenko" <dvlas...@redhat.com> To: "Jam

Re: [PATCH 1/2] scsi: add a max_segment_size limitation to struct Scsi_Host

This looks fine to me. I am pulling this in to my SRP initiator and target testing ongoing at the moment so will be testing. Up to now this has likely not affected me but I am pulling in all RDMA patches to test. Reviewed-by: Laurence Oberman <lober...@redhat.com> Laurence Oberman Pri

Re: [PATCHv3] scsi: disable automatic target scan

Hi Hannes, Please share those dracut patches because I want to test this patch series. Which kernel is the diff against for the scan patches. Thanks Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Hannes Reineck

Re: [PATCH] fnic: move printk()s outside of the critical code section.

Reviewed-by: Laurence Oberman <lober...@redhat.com> Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Maurizio Lombardi" <mlomb...@redhat.com> To: linux-scsi@vger.kernel.org Cc: hiral...@cisco.com, s

Re: [PATCHv3] scsi: disable automatic target scan

to async, so before I boot with scsi_mod.scan=manual want to prepare my test system. This feature may be a very useful feature we would want to include in RHEL as we struggle with large LUN boot configurations all the time. When you have time and thanks Laurence Oberman Principal Software Maintenance

Re: [PATCHv3] scsi: disable automatic target scan

Hannes's original dracut lunmask patch. For Hannes's scan disable patch Tested-by: Laurence Oberman <lober...@redhat.com> linux16 /vmlinuz-4.4.5scan root=/dev/mapper/rhel-root ro crashkernel=512M@64M rd.lvm.lv=rhel/root rd.lvm.lv=rhel/swap console=ttyS0,115200n8 scsi_mod.scan=manual rd.

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

Looks fine to me. Reviewed-by: Laurence Oberman <lober...@redhat.com> Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Joe Lawrence" <joe.lawre...@stratus.com> To: linux-scsi@vger.kernel.o

Re: tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision3

here to include the module parameter and code only if set to "yes" The default unless expicitly set will be no change. Thanks Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Himanshu Madhani" <hima

[PATCH] tcm_qla2xxx Add SCSI command jammer/discard capability to the tcm_qla2xxx module

./kernel/config/target/qla2xxx/21:00:00:24:ff:27:8f:af/tpgt_1/attrib/jam_host I tested this and here are the patches in the format you require. Hopefully this new functionality will be useful for others. I am not set for emailing directly from git. Tested by: Laurence Oberman <lober...@redhat.

Re: tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision3

Hello Himanshu Thanks, I will rework and post back to the thread. Thank you Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Himanshu Madhani" <himanshu.madh...@qlogic.com> To: "Nicholas A. B

Re: tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision4

parameter jam_host if its >= 0 and matches vha->host_no , jamming is enabled when jam_host >=0 If parameter set to -1 (default) no jamming is enabled. Tested by: Laurence Oberman <lober...@redhat.com> Signed-off-by: Laurence Oberman <lober...@redhat.com> diff -Nurp linux-4

Re: tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision4

in the Emulex, Qlogic and other F/C drivers. Works by checking new parameter jam_host if its >= 0 and matches vha->host_no , jamming is enabled when jam_host >=0 If parameter set to -1 (default) no jamming is enabled. Tested by: Laurence Oberman <lober...@redhat.com> Signed-off-by: L

Re: [PATCH] tcm_qla2xxx Add SCSI command jammer/discard capability to the tcm_qla2xxx module

-tcm_qla2xxx-Add-SCSI-command-jammer-discard-capabili.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Tested by: Laurence Oberman <lober...@redhat.com> Signed-off-by: Laurence Oberman

tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module - revision3

and other F/C drivers. Works by checking new parameter jam_host if its >= 0 and matches vha->host_no , jamming is enabled when jam_host >=0 If parameter set to -1 (default) no jamming is enabled. Tested by: Laurence Oberman <lober...@redhat.com> Signed-off-by: Laurence

Re: [PATCH] qla1280: Reduce can_queue to 32

and that is reported as working. So other changes in 4.4 must be "abusing" this high value. Reviewed-by Laurence Oberman <lober...@redhat.com> Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Johanne

Re: [PATCH] qla1280: Reduce can_queue to 32

Johannes OK , yes thanks for pointing out the commit. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Johannes Thumshirn" <jthmsh...@suse.de> To: "Laurence Oberman" <lober...@redhat

Re: [PREEMPT-RT] [PATCH v2] scsi/fcoe: convert to kworker

I have fcoe for testing. I will pull this in next week and test it. Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "James Bottomley" <j...@linux.vnet.ibm.com> To: "Sebastian Andrzej Siewior&qu

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

-mapper starts declaring paths down we are blocked. Apr 29 17:20:51 localhost kernel: sd 1:0:1:0: Device offlined - not ready after error recovery Apr 29 17:20:51 localhost kernel: sd 1:0:1:13: Device offlined - not ready after error recovery Laurence Oberman Principal Software Maintenance Engineer

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

the device offline. This can take a while and differs depending on Qlogic, Emulex or fnic etc. First thing tomorrow will set this up and show you what I mean. Thanks!! Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From

Re: [Lsf] Notes from the four separate IO track sessions at LSF/MM

. Thanks Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Bart Van Assche" <bart.vanass...@sandisk.com> To: "James Bottomley" <james.bottom...@hansenpartnership.com>, "Mike Snitze

Re: [PATCH] scsi: use spinlock instead of mutex for RCU-protected VPD inquiry data

ata */ > const char * vendor;/* [back_compat] point into 'inquiry' > ... */ > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Look fine to me: Reviewed by: Laurence Oberman <lober...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

st: I/O error, dev sdbn, sector 0 Apr 29 17:21:18 localhost kernel: sd 0:0:1:8: rejecting I/O to offline device Apr 29 17:21:18 localhost kernel: sd 0:0:1:8: [sdbn] killing request Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Messa

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

:0:12 sdr 65:16 active ready running `- 1:0:1:12 sdbi 67:192 failed faulty offline Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Laurence Oberman" <lober...@redhat.com> To: "Bart Van

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

- Original Message - From: "Bart Van Assche" <bart.vanass...@sandisk.com> To: "Laurence Oberman" <lober...@redhat.com> Cc: "James Bottomley" <james.bottom...@hansenpartnership.com>, "linux-scsi" <linux-scsi@vge

Re: [dm-devel] [Lsf] Notes from the four separate IO track sessions at LSF/MM

Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Bart Van Assche" <bart.vanass...@sandisk.com> To: "Laurence Oberman" <lober...@redhat.com> Cc: linux-bl...@vger.kernel.org, "li

Re: [PATCH] st: clear ILI if Medium Error

Looks good Reviewed-by Laurence Oberman <lober...@redhat.com> Laurence Oberman Principal Software Maintenance Engineer Red Hat Global Support Services - Original Message - From: "Kai Makisara" <kai.makis...@kolumbus.fi> To: linux-scsi@vger.kernel.org Cc: mlomb...@r

Re: [PATCH] tcm_qla2xxx Add SCSI command jammer/discard capability to the tcm_qla2xxx module

- Original Message - > From: "Laurence Oberman" <lober...@redhat.com> > To: "Nicholas A. Bellinger" <n...@linux-iscsi.org> > Cc: "Himanshu Madhani" <himanshu.madh...@qlogic.com>, "Bart Van Assche" > <bart.vanass...

Re: [PATCH] scsi: Delete an unnecessary check before the function call "kfree"

line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Looks fine, small comment is that the function call prior to check in the fucntion sets up variables etc. So is more expensive than a simple NULL check prior. Reviewed-by: Laurence Oberman <lober...@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro

tape_cmds, int, 0644); > +module_param(cciss_tape_cmds, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(cciss_tape_cmds, > "number of commands to allocate for tape devices (default: 6)"); > static int cciss_simple_mode; > -- > 2.9.2 > > -- > To unsub

Re: dm-mq and end_clone_request()

--- Original Message - > From: "Mike Snitzer" <snit...@redhat.com> > To: "Bart Van Assche" <bart.vanass...@sandisk.com> > Cc: dm-de...@redhat.com, "Laurence Oberman" <lober...@redhat.com>, > linux-scsi@vger.kernel.org > Sent: Tuesday

Re: dm-mq and end_clone_request()

- Original Message - > From: "Mike Snitzer" <snit...@redhat.com> > To: "Laurence Oberman" <lober...@redhat.com> > Cc: "Bart Van Assche" <bart.vanass...@sandisk.com>, dm-de...@redhat.com, > linux-scsi@vger.kernel.org >

Re: dm-mq and end_clone_request()

- Original Message - > From: "Laurence Oberman" <lober...@redhat.com> > To: "Mike Snitzer" <snit...@redhat.com> > Cc: "Bart Van Assche" <bart.vanass...@sandisk.com>, dm-de...@redhat.com, > linux-scsi@vger.kernel.org >

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Laurence Oberman" <lober...@redhat.com> > To: "Bart Van Assche" <bart.vanass...@sandisk.com> > Cc: dm-de...@redhat.com, linux-scsi@vger.kernel.org, "Mike Snitzer" > <snit...@redhat.com>, "Joh

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Bart Van Assche" <bart.vanass...@sandisk.com> > To: "Laurence Oberman" <lober...@redhat.com> > Cc: dm-de...@redhat.com, linux-scsi@vger.kernel.org, "Mike Snitzer" > <snit...@redhat.com>, "Joh

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Bart Van Assche" <bart.vanass...@sandisk.com> > To: "Laurence Oberman" <lober...@redhat.com> > Cc: dm-de...@redhat.com, "Mike Snitzer" <snit...@redhat.com>, > linux-scsi@vger.kernel.org, "Joh

Re: dm-mq and end_clone_request()

- Original Message - > From: "Laurence Oberman" <lober...@redhat.com> > To: "Mike Snitzer" <snit...@redhat.com> > Cc: "Bart Van Assche" <bart.vanass...@sandisk.com>, dm-de...@redhat.com, > linux-scsi@vger.kernel.org >

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Bart Van Assche" <bart.vanass...@sandisk.com> > To: "Laurence Oberman" <lober...@redhat.com>, "Mike Snitzer" > <snit...@redhat.com> > Cc: dm-de...@redhat.com, linux-scsi@vger.kernel.org > Sent:

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Bart Van Assche" <bart.vanass...@sandisk.com> > To: "Laurence Oberman" <lober...@redhat.com>, "Mike Snitzer" > <snit...@redhat.com> > Cc: dm-de...@redhat.com, linux-scsi@vger.kernel.org > Sent:

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Laurence Oberman" <lober...@redhat.com> > To: "Bart Van Assche" <bart.vanass...@sandisk.com> > Cc: dm-de...@redhat.com, linux-scsi@vger.kernel.org, "Mike Snitzer" > <snit...@redhat.com>, "Joh

Re: [PATCH 1/2] lpfc: call lpfc_sli_validate_fcp_iocb() with the hbalock held

; return sum; > } > -- > 1.8.5.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Hi Johannes The code

Re: [PATCH trivial] fcoe: use defines from ethtool for 20Gbit and 40Gbit speeds

break; > - case 4: > + case SPEED_4: > lport->link_speed = FC_PORTSPEED_40GBIT; > break; > default: > -- > 1.8.5.6 > > -- > To unsubscribe from this list: send th

Re: dm-mq and end_clone_request()

- Original Message - > From: "Mike Snitzer" <snit...@redhat.com> > To: "Bart Van Assche" <bart.vanass...@sandisk.com> > Cc: dm-de...@redhat.com, "Laurence Oberman" <lober...@redhat.com>, > linux-scsi@vger.kernel.org >

Re: dm-mq and end_clone_request()

- Original Message - > From: "Laurence Oberman" <lober...@redhat.com> > To: "Mike Snitzer" <snit...@redhat.com> > Cc: "Bart Van Assche" <bart.vanass...@sandisk.com>, dm-de...@redhat.com, > linux-scsi@vger.kernel.org >

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Bart Van Assche" <bart.vanass...@sandisk.com> > To: "Laurence Oberman" <lober...@redhat.com> > Cc: dm-de...@redhat.com, "Mike Snitzer" <snit...@redhat.com>, > linux-scsi@vger.kernel.org, "Jo

Re: linux-4.8-rc1/drivers/scsi/sd.c:317: pointless test ?

return -EACCES; err = kstrtouint(buf, 10, ); ***** if (err) return err; if (val >= 0 && val <= SD_DIF_TYPE3_PROTECTION) sdkp->protection_type = val; Reviewed-by Laurence Oberman <lober...@redhat.com> return count; }

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Bart Van Assche" <bart.vanass...@sandisk.com> > To: "Laurence Oberman" <lober...@redhat.com>, "Mike Snitzer" > <snit...@redhat.com> > Cc: dm-de...@redhat.com, linux-scsi@vger.kernel.org > Sent:

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Laurence Oberman" <lober...@redhat.com> > To: "Bart Van Assche" <bart.vanass...@sandisk.com> > Cc: dm-de...@redhat.com, "Mike Snitzer" <snit...@redhat.com>, > linux-scsi@vger.kernel.org, "Jo

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Bart Van Assche" <bvanass...@acm.org> > To: "Laurence Oberman" <lober...@redhat.com> > Cc: "Mike Snitzer" <snit...@redhat.com>, dm-de...@redhat.com, > linux-scsi@vger.kernel.org > Sent: Su

Re: [dm-devel] dm-mq and end_clone_request()

- Original Message - > From: "Johannes Thumshirn" <jthumsh...@suse.de> > To: "Laurence Oberman" <lober...@redhat.com> > Cc: "Bart Van Assche" <bvanass...@acm.org>, "Mike Snitzer" > <snit...@redhat.com>, dm-de.

Patch: lpfc: Modify Emulex lpfc LPFC_DEFAULT_SG_SEG_CNT to 128 for default larger sg_io capability

like to avoid having to set this in the module parameters to 128. Tested-by: Laurence Oberman <lober...@redhat.com> Signed-off-by: Laurence Oberman <lober...@redhat.com> >From 23996dcbdd9b505d18d59ecde961c87f76fc9c2e Mon Sep 17 00:00:00 2001 From: Laurence Oberman <lober...@r

Re: Patch: lpfc: Modify Emulex lpfc LPFC_DEFAULT_SG_SEG_CNT to 128 for default larger sg_io capability

- Original Message - > From: "Laurence Oberman" <lober...@redhat.com> > To: "Linux SCSI List" <linux-scsi@vger.kernel.org> > Sent: Wednesday, February 8, 2017 3:07:12 PM > Subject: Patch: lpfc: Modify Emulex lpfc LPFC_DEFAULT_SG_SEG_CNT t

Re: [PATCH] scsi_error: count medium access timeout only once per EH run

0x2008 > #define FAST_IO_FAIL 0x2009 > +#define NEEDS_RESET 0x2010 > > /* > * Midlevel queue return values. > -- > 1.8.5.6 > > Hello Hannes This makes sense to me what you are doing here. I will also wait for Ewan to weigh in but I wonder if we should make a simple change. Maybe good to clarify the RESET here by simply changing the name. Change +#define NEEDS_RESET 0x2010 to +#define MAX_MEDIUM_ERROR_NEEDS_RESET Of course then also change + if (eh_disp == NEEDS_RESET) { to + if (eh_disp == MAX_MEDIUM_ERROR_NEEDS_RESET) { Reviewed-by: Laurence Oberman <lober...@redhat.com

Re: iscsi_trx going into D state

- Original Message - > From: "Robert LeBlanc" <rob...@leblancnet.us> > To: "Laurence Oberman" <lober...@redhat.com> > Cc: "Doug Ledford" <dledf...@redhat.com>, "Nicholas A. Bellinger" > <n...@linux-iscsi.org>,

Re: dm-mq and end_clone_request()

- Original Message - > From: "Laurence Oberman" <lober...@redhat.com> > To: "Mike Snitzer" <snit...@redhat.com> > Cc: "Bart Van Assche" <bart.vanass...@sandisk.com>, dm-de...@redhat.com, > linux-scsi@vger.kernel.org &g

sg driver, sg_io and sg tablesize

Hi Doug I have a quick question here regarding the sg tablesize and retrieval of the supported size via a userspace ioctl. lpfc defaults to lpfc_sg_seg_cnt:Max Scatter Gather Segment Count (uint) = 64 For sg_io sent from qemu if we exceed 512K I/O we fail, qlogic allows 128 by default.

Re: sg driver, sg_io and sg tablesize

- Original Message - > From: "Laurence Oberman" <lober...@redhat.com> > To: dgilb...@interlog.com, "Linux SCSI List" <linux-scsi@vger.kernel.org> > Sent: Wednesday, March 1, 2017 10:44:32 AM > Subject: sg driver, sg_io and sg tablesize

[PATCH] tcm_qla2xxx Add SCSI command jammer/discard capability to the tcm_qla2xxx module - enhancements

, second is updating the documentation. Tested by: Laurence Oberman <lober...@redhat.com> Signed-off-by: Laurence Oberman <lober...@redhat.com> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 7 +++ drivers/scsi/qla2xxx/tcm_qla2xxx.h | 1 + 2 files changed, 8 insertions(+) diff --git a/

  1   2   3   >