[PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Convert to use the generic boolean. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Diffed against linus-git Checked with script/checkpatch.pl (warned about long lines, but it is not introduced by this patch) dpt_i2o.c | 22 +++--- dpti.h|9 ++--- 2 files

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: Convert to use the generic boolean. - u8 initialized; - u8 in_use; /* is the management node open*/ + bool initialized:8; + bool in_use:8

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 05:46:08PM +0100, Richard Knutsson wrote: I just don't see the reason why expressing a boolean as an integer. Some advantage? This is C, not Java, or some other highly-typed language. if (int) and if (ptr) are perfectly acceptable in C

[PATCH 32/33][SCSI] wd7000: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-error. diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c index 03cd44f..185e1b5

[PATCH 33a/33] include/scsi/scsi_tcq.h: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h index cf4c219..341ed5a 100644 --- a/include/scsi/scsi_tcq.h +++ b/include/scsi/scsi_tcq.h @@ -86,7 +86,7 @@ static

[PATCH 33b/33] include/scsi/scsi_tcq.h: Correct the parameter-name

Change to the correct argument-name. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h index cf4c219..341ed5a 100644 --- a/include/scsi/scsi_tcq.h +++ b/include/scsi/scsi_tcq.h @@ -86,7 +86,7 @@ static inline void

[PATCH 6/33][SCSI] atari_NCR5380: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors (so no ' 80 lines'-warning). diff --git a/drivers/scsi/atari_NCR5380.c b/drivers/scsi

[PATCH 4/33][SCSI] aha1542: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors (so no ' 80 lines'-warning). diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542

[PATCH 2/33][SCSI] advansys: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 9dd3952..a9a8685 100644 --- a/drivers/scsi

[PATCH 0/33][SCSI] Arrange for removal of 'scsi_typedefs.h'

, Richard Knutsson PS If someone know of a tool to chain-mail patches and still be able to customize the mail-addresses between them, please let me know. - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[PATCH 1/33][SCSI] 3w-xxxx: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/3w-.c b/drivers/scsi/3w-.c index 59716eb..54374e3 100644 --- a/drivers/scsi/3w-.c

[PATCH 28/33][SCSI] oktagon_esp: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors. diff --git a/drivers/scsi/oktagon_esp.c b/drivers/scsi/oktagon_esp.c index 8e5eadb

[PATCH 26/33][SCSI] NCR53C9x: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors (so no ' 80 lines'-warning). diff --git a/drivers/scsi/NCR53C9x.c b/drivers/scsi

[PATCH 23/33][SCSI] megaraid: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors. diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 66c6520..9353472

[PATCH 22/33][SCSI] mca_53c9x: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/mca_53c9x.c b/drivers/scsi/mca_53c9x.c index d693d0f..5dbc259 100644 --- a/drivers/scsi

[PATCH 21/33][SCSI] mac_esp: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors. diff --git a/drivers/scsi/mac_esp.c b/drivers/scsi/mac_esp.c index bcb4902..85f3d47

[PATCH 15/33][SCSI] gdth: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index b253b8c..3c3e271 100644 --- a/drivers/scsi/gdth.c +++ b

[PATCH 14/33][SCSI] fd_mcs: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors (so no ' 80 lines'-warning). diff --git a/drivers/scsi/fd_mcs.c b/drivers/scsi/fd_mcs.c

[PATCH 12/33][SCSI] dtc: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/dtc.h b/drivers/scsi/dtc.h index 0b205f8..524b711 100644 --- a/drivers/scsi/dtc.h +++ b

[PATCH 11/33][SCSI] cyberstormII: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/cyberstormII.c b/drivers/scsi/cyberstormII.c index e336e85..e1d9c56 100644 --- a/drivers/scsi

[PATCH 10/33][SCSI] cyberstorm: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/cyberstorm.c b/drivers/scsi/cyberstorm.c index c6b98a4..3f8d1b0 100644 --- a/drivers/scsi

[PATCH 7/33][SCSI] atari_scsi: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-warnings. diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c index f5732d8

[PATCH 8/33][SCSI] blz1230: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/blz1230.c b/drivers/scsi/blz1230.c index 23f7c24..323038c 100644 --- a/drivers/scsi/blz1230.c

[PATCH 9/33][SCSI] blz2060: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/blz2060.c b/drivers/scsi/blz2060.c index b6203ec..c7b98b8 100644 --- a/drivers/scsi/blz2060.c

[PATCH 13/33][SCSI] fastlane: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/fastlane.c b/drivers/scsi/fastlane.c index 4266a21..c16df66 100644 --- a/drivers/scsi

[PATCH 17/33][SCSI] g_NCR5380: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c index 75585a5..5303e1d 100644 --- a/drivers/scsi

[PATCH 18/33][SCSI] ibmmca: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors (so no ' 80 lines'-warning). diff --git a/drivers/scsi/ibmmca.c b/drivers/scsi/ibmmca.c

[PATCH 19/33][SCSI] ibmvscsi: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 5f2396c..d517f32 100644

[PATCH 20/33][SCSI] in2000: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors (so no ' 80 lines'-warning). diff --git a/drivers/scsi/in2000.c b/drivers/scsi/in2000.c

[PATCH 24/33][SCSI] NCR5380: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors (so no ' 80 lines'-warning, and etc). diff --git a/drivers/scsi/NCR5380.c b/drivers

[PATCH 25/33][SCSI] NCR53c406a: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors (so no ' 80 lines'-warning). diff --git a/drivers/scsi/NCR53c406a.c b/drivers/scsi

[PATCH 27/33][SCSI] nsp32_debug: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/nsp32_debug.c b/drivers/scsi/nsp32_debug.c index ef3c59c..96cce0b 100644 --- a/drivers/scsi

[PATCH 29/33][SCSI] pas16: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/pas16.h b/drivers/scsi/pas16.h index 8dc5b1a..dc87366 100644 --- a/drivers/scsi/pas16.h +++ b

[PATCH 30/33][SCSI] sun3x_esp: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-warnings. diff --git a/drivers/scsi/sun3x_esp.c b/drivers/scsi/sun3x_esp.c index 1bc4190

[PATCH 31/33][SCSI] sym53c416: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. diff --git a/drivers/scsi/sym53c416.c b/drivers/scsi/sym53c416.c index 90cee94..689408a 100644 --- a/drivers/scsi

[PATCH 3/33][SCSI] aha152x: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors (so no ' 80 lines'-warning). diff --git a/drivers/scsi/aha152x.c b/drivers/scsi

[PATCH 5/33][SCSI] aha1740: Convert 'Scsi_Cmnd' to 'struct scsi_cmnd'

Convert the typedef'ed 'Scsi_Cmnd' to 'struct scsi_cmnd'. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Last item before 'drivers/scsi/scsi_typedefs.h' can be removed. Cleaned up checkpatch.pl-errors (so no ' 80 lines'-warning). diff --git a/drivers/scsi/aha1740.c b/drivers/scsi/aha1740

Re: [PATCH 0/33][SCSI] Arrange for removal of 'scsi_typedefs.h'

James Bottomley wrote: On Sun, 2008-01-06 at 04:02 +0100, Richard Knutsson wrote: Hi all drivers/scsi/scsi_typedefs.h is about ready to be removed, only the 'struct scsi_cmnd' typedef Scsi_Cmnd is left. This set converts all the Scsi_Cmnd's, except in: Changelogs Documentation/scsi

[PATCH] drivers/scsi/pci2000.h: Remove unused file

Remove the unused header drivers/scsi/pci2000.h Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- 'grep -nr pci2000' on the whole tree results only in a reference to pci2000.h Diffed against Linus' git-tree. diff --git a/drivers/scsi/pci2000.h b/drivers/scsi/pci2000.h deleted file mode

Re: [PATCH] drivers/scsi/pci2000.h: Remove unused file

James Bottomley wrote: On Tue, 2007-05-01 at 14:16 -0400, Robert P. J. Day wrote: On Tue, 1 May 2007, Richard Knutsson wrote: Remove the unused header drivers/scsi/pci2000.h i have the same patch in my pending patch directory, dated march 10, so i know i submitted it, but i

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

)/ML, and send them your way if they are not picked up (is one week enough, or should it be longer?) Regards Richard Knutsson - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

[PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean

Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested with all(yes|mod|no)config on x86(|_64) sparc(|64) got some warnings on some builds, none related to this patch Diffed against Linus' git-tree. aic7xxx_old.c | 326

[PATCH] megaraid.c: Convert pci_module_init() to pci_register_driver()

Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- PS The mailing-list is marked as S: instead of L: DS diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 77d9d38..4fd4960 100644 --- a/drivers/scsi/megaraid.c +++ b/drivers/scsi/megaraid.c @@ -5072,7 +5072,7 @@ static int

Re: [PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

James Bottomley wrote: On Sat, 2007-02-10 at 18:46 +0100, Richard Knutsson wrote: Convert: FALSE - false TRUE - true Actually, downcasing true and false in this driver is pretty much a retrograde step. The reason for their being uppercased is that they represent constants

[PATCH] scsi/megaraid.c: pci_module_init to pci_register_driver

Convert pci_module_init() to pci_register_driver(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested with allyes, allmod allno on i386 diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 808a1b8..0aa3304 100644 --- a/drivers/scsi/megaraid.c +++ b/drivers

[PATCH] scsi/tmscsim.c: pci_module_init to pci_register_driver

Convert pci_module_init() to pci_register_driver(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested with allyes, allmod allno on i386 diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c index fa5382e..ce8845e 100644 --- a/drivers/scsi/tmscsim.c +++ b/drivers/scsi

Re: [PATCH 3/6] scsi: megaraid_sas - throttle io if FW is busy

megasas_instance { atomic_t fw_outstanding; u32 hw_crit_error; + u8 is_busy; Why not bool is_busy:8;? It obviously is a boolean. I would also think false/true would be more descriptive then 0/1. Richard Knutsson - To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

James Bottomley wrote: On Fri, 2007-02-16 at 19:04 +0100, Richard Knutsson wrote: James Bottomley wrote: On Mon, 2007-02-12 at 12:27 -0800, Andrew Morton wrote: Given that we now have a standard kernel-wide, c99-friendly way of expressing true and false, I'd suggest

[PATCH] drivers/scsi/eata_generic.h: Remove FALSE/TRUE defines

Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Only included by drivers/scsi/eata_pio.c and it only uses FALSE/TRUE in comments. diff --git a/drivers/scsi/eata_generic.h b/drivers/scsi/eata_generic.h index 635c148..5016af5 100644 --- a/drivers/scsi/eata_generic.h +++ b/drivers/scsi