Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org
---
drivers/target/target_core_sbc.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/target
assoicated with the ramdisk backend device.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org
---
drivers
BLOCK APPLICATION TAG CHECK FAILED
LOGICAL BLOCK REFERENCE TAG CHECK FAILED
that used by DIF TYPE1 and TYPE3 failure cases.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl
Grimberg's original patch.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org
target: more defs
Signed
explicit
and this routine should be called upon getting FORMAT_UNIT as well.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas
[10,12,16] +
WRITE_[10,12,16] to perform DIF sanity checking.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas Bellinger n...@linux
It is more correct to seperate connections protection domains
and dma_mr handles. protection information support requires to
do so.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 46 ---
drivers/infiniband/ulp/isert
Use fast registration lingo. fast registration will
also incorporate signature/DIF registration.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 84 ---
drivers/infiniband/ulp/isert/ib_isert.h |8 ++--
2 files
replace prot_interleaved with prot_handover in se_cmd.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
include/target/target_core_base.h | 22 ++
1 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/include/target/target_core_base.h
b/include/target
ccb0a907 IB/mlx5: Break wqe handling to begin finish routines
cda0569 IB/mlx5: Initialize mlx5_ib_qp signature related
33b4079 IB/mlx5, mlx5_core: Support for create_mr and destroy_mr
8b343e6 IB/core: Introduce Signature Verbs API
c1b0358 IB/core: Introduce protected memory regions
Sagi Grimberg (11
This routine may be called both by fast registration
descriptors for data and for integrity buffers.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 52 +++
1 files changed
This routine may help for protection registration as well.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 28
1 files changed, 12 insertions(+), 16 deletions(-)
diff --git
. This is a hook for the iscsi target layer to signal the transport
at connection establishment that this connection will carry protected
transactions.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/iscsi/iscsi_target_core.h |5 -
drivers/target/iscsi/iscsi_target_tpg.c |2 ++
2
Upon connection establishment check if network portal is T10-PI
enabled and allocate T10-PI resources if necessary, allocate
signature enabled memory regions and mark connection queue-pair
as signature enabled.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert
completion check the signature status
- if succeeded send good SCSI response
- if failed send SCSI bad response with appropriate sense buffer
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert/ib_isert.c | 376 ++-
1 files changed
In case of protected transactions, we will need to check the
protection status of the transaction before sending SCSI response.
So be ready for RDMA_WRITE completions. currently we don't ask
for these completions, but for T10-PI we will.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
User may enable T10-PI support per network portal group. any connection
established on top of it, will be required to serve protected transactions.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/iscsi/iscsi_target_configfs.c |6 ++
drivers/target/iscsi
This commit generalizes isert_fast_reg_mr to receive mr
and frpl instead of fr_desc to do registration. In T10-PI
we also register protection memory region so we want to
use this routine.
This commit does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers
On 1/10/2014 10:46 PM, Martin K. Petersen wrote:
Andy == Andy Grover agro...@redhat.com writes:
Andy Yes, don't you need FORMAT UNIT because protection information is
Andy going to mean the pi-enabled lun will need to report less blocks?
Modern disk drives won't shrink when you reformat them
SNIP
I wander how we can skip sbc_dif_verify_ if the transport already
offloaded DIF verify.
I think that the transport should signal the core layer that it is able
to offload DIF (ADD/STRIP/PASS/VERIFY), in which case the core should
turn off the backstore DIF verify emulation to sustain
On 1/10/2014 9:04 AM, Nicholas A. Bellinger wrote:
On Thu, 2014-01-09 at 16:58 +0200, Sagi Grimberg wrote:
On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds sbc_check_prot() for performing various DIF
related CDB sanity checks
On 1/10/2014 10:39 PM, Martin K. Petersen wrote:
Sagi == Sagi Grimberg sa...@mellanox.com writes:
Sagi What about FORMAT_UNIT emulation? The backstore protection
Sagi configuration is done at the target side via configfs/targetcli,
I don't know of any non-disk devices that actually implement
On 1/10/2014 9:00 AM, Nicholas A. Bellinger wrote:
On Thu, 2014-01-09 at 13:01 +0200, Sagi Grimberg wrote:
On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for exposing DIF protection device
attributes via configfs
On 1/10/2014 10:39 PM, Martin K. Petersen wrote:
Sagi == Sagi Grimberg sa...@mellanox.com writes:
Sagi What about FORMAT_UNIT emulation? The backstore protection
Sagi configuration is done at the target side via configfs/targetcli,
I don't know of any non-disk devices that actually implement
SNIP
nab This patch adds support for exposing DIF protection device
nab attributes via configfs. This includes:
nabpi_prot_type: Protection Type (0, 1, 3 currently support)
nabpi_prot_version: Protection Version (DIF v1 currently supported)
What's DIF v2?
nabpi_guard_type: Guard
On 1/11/2014 11:09 PM, Or Gerlitz wrote:
On Thu, Jan 9, 2014 at 6:40 PM, Sagi Grimberg sa...@mellanox.com wrote:
@@ -557,8 +629,14 @@ isert_connect_request(struct rdma_cm_id *cma_id, struct
rdma_cm_event *event)
goto out_mr;
}
+ if (pi_support !device
On 1/12/2014 2:33 PM, Martin K. Petersen wrote:
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes:
I don't know of any non-disk devices that actually implement FORMAT
UNIT. Usually such configuration is done using the array management
interface.
Sagi So this takes me to a corner I still
Back to the original question, I don't think Sagi was
asking if it was valid to do a legacy/unprotected READ,
it was what to expect with a protected READ on
unwritten blocks:
So this takes me to a corner I still don't understand, if
a LUN is pre-formatted as T10-protected, what happens to
On 1/10/2014 8:53 AM, Nicholas A. Bellinger wrote:
On Thu, 2014-01-09 at 12:43 +0200, Sagi Grimberg wrote:
On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for DIF related CHECK_CONDITION ASC/ASCQ
exception cases
On 1/14/2014 10:53 AM, Nicholas A. Bellinger wrote:
On Tue, 2014-01-14 at 09:44 +0200, Sagi Grimberg wrote:
On 1/10/2014 8:53 AM, Nicholas A. Bellinger wrote:
On Thu, 2014-01-09 at 12:43 +0200, Sagi Grimberg wrote:
On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n
On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
Hi MKP SCSI folks,
This series contains initial support for target mode DIF Type1+Type3
emulation within target core, RAMDISK_MCP device backend, and tcm_loop
fabric driver.
DIF emulation is
On 1/16/2014 3:42 AM, Martin K. Petersen wrote:
nab == Nicholas A Bellinger n...@linux-iscsi.org writes:
nab The issue is that existing fs/bio-integrity.c code always assumes
nab client/initiator mode, in that it will attempt to
nab bio_integrity_generate() protection information in the
Hey SCSI folks,
I'd like to propose the following topic for upcoming LSF-MM:
T10-PI standard is becoming more and more appealing for storage and
cloud solutions. Since error-detection
coding comes with its cost of CPU computation overhead, state-of-the-art
ASICs offer the ability to offload
User may enable T10-PI support per network portal group. any connection
established on top of it, will be required to serve protected transactions.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/iscsi/iscsi_target_configfs.c |6 ++
drivers/target/iscsi
In case of protected transactions, we will need to check the
protection status of the transaction before sending SCSI response.
So be ready for RDMA_WRITE completions. currently we don't ask
for these completions, but for T10-PI we will.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Upon connection establishment check if network portal is T10-PI
enabled and allocate T10-PI resources if necessary, allocate
signature enabled memory regions and mark connection queue-pair
as signature enabled.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/isert
. This is a hook for the iscsi target layer to signal the transport
at connection establishment that this connection will carry protected
transactions.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/target/iscsi/iscsi_target_core.h |5 -
drivers/target/iscsi/iscsi_target_tpg.c |2 ++
2
This commit generalizes isert_fast_reg_mr to receive mr
and frpl instead of fr_desc to do registration. In T10-PI
we also register protection memory region so we want to
use this routine.
This commit does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers
:
- Dropped applied preperation patches
- Restored break statement for RDMA_WRITE completions
- Used core rroutine for sending CHECK_CONDITION for PI errors
- checkpatch errors
Sagi Grimberg (7):
Target/core: use sense_reason_t for se_cmd-pi_err
Target/iscsi: Add T10-PI indication
Hey SCSI (and LSF) folks,
I'd like to propose the following topic for upcoming LSF-MM:
T10-PI standard is becoming more and more appealing for storage and
cloud solutions.
Since error-detection coding comes with its cost of CPU computation
overhead,
state-of-the-art ASICs offer the ability to
On 1/16/2014 1:05 AM, Nicholas A. Bellinger wrote:
Hi all,
I'd like to discuss the current state of scsi-mq prototype code.
And now that blk-mq is upstream for v3.13, exploring the remaining TODO
items towards an initial scsi-mq merge sometime before 2015 is upon us.
The benefits of scsi-mq
Possible double free on in-mailbox.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/mr.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
index bc27f6b..f023711 100644
Use DIF CRC INC with apptag escape (0x8) and update IP-CSUM entries.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
Use DIF CRC INC with apptag escape (0x8) and update IP-CSUM entries.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org
---
drivers/target/target_core_sbc.c | 62 ++
1 file
...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org
---
drivers/target/loopback/tcm_loop.c |2 +-
drivers/target
. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org
---
drivers/target/Kconfig |1 +
drivers/target
...
v1 changes:
- Fix sparse warnings in fd_init_format_buf (Fengguang)
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas Bellinger n
, and
uses a locally allocated fd_prot-prot_buf + fd_prot-prot_sg for
interacting with SBC DIF verify emulation code.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl
On 1/19/2014 12:37 PM, Sagi Grimberg wrote:
Use DIF CRC INC with apptag escape (0x8) and update IP-CSUM entries.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/hw/mlx5/qp.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
On 1/16/2014 6:34 PM, Sagi Grimberg wrote:
On 1/10/2014 8:27 PM, Mike Snitzer wrote:
I would like to attend to participate in discussions related to topics
listed in the subject. As a maintainer of DM I'd be interested to
learn/discuss areas that should become a development focus in the months
On 1/22/2014 2:43 AM, Roland Dreier wrote:
On Tue, Jan 21, 2014 at 2:00 PM, Or Gerlitz or.gerl...@gmail.com wrote:
Roland, ping! the signature patches were posted three months ago. We
deserve a response from the maintainer that goes beyond I need to
think on that.
Responsiveness was stated by
On 1/22/2014 12:17 AM, Nicholas A. Bellinger wrote:
On Sun, 2014-01-19 at 14:12 +0200, Sagi Grimberg wrote:
On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support to target_submit_cmd_map_sgls() for
accepting 'sgl_prot
On 1/22/2014 3:52 AM, Martin K. Petersen wrote:
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes:
Sagi Please remind me why we ignore IP-CSUM guard type again? MKP,
Sagi will this be irrelevant for the initiator as well? if so, I don't
Sagi see a reason to expose this in RDMA verbs.
I
On 1/22/2014 12:28 AM, Nicholas A. Bellinger wrote:
On Sun, 2014-01-19 at 14:31 +0200, Sagi Grimberg wrote:
On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
This patch adds support for DIF protection init/format support into
the FILEIO backend
BLOCK APPLICATION TAG CHECK FAILED
LOGICAL BLOCK REFERENCE TAG CHECK FAILED
that used by DIF TYPE1 and TYPE3 failure cases.
Cc: Martin K. Petersen martin.peter...@oracle.com
Cc: Christoph Hellwig h...@lst.de
Cc: Hannes Reinecke h...@suse.de
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl
On 1/22/2014 12:48 AM, Nicholas A. Bellinger wrote:
+ cmd-prot_handover = PROT_SEPERATED;
I know that we are not planning to support interleaved mode at the
moment, But I think
that the protection handover type is the backstore preference and should
be taken from se_dev.
But it is not
On 2/5/2014 2:41 PM, Christoph Hellwig wrote:
Add support for using the blk-mq code to submit requests to SCSI
drivers. There is very little blk-mq specific code, but that's
partially because important functionality like partial completions
and request requeueing is still missing in blk-mq. I
Hey,
I stumbled on a nasty crash with 3.14-rc1 when playing with scsi_debug
DIF emulation.
It's late (IL time..), so I thought I'd post this one up and ask if
anyone else noticed it before digging into this one.
it comes from the condition:
BUG_ON(total bio-bi_integrity-bip_iter.bi_size);
phase, it is worth considering passing these
parameters from iscsid via nlmsg. This will allow these
parameters to be connection based rather than global.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.c |8
drivers/infiniband/ulp/iser
of repeating the logic of which key to use.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_memory.c | 101 +
1 files changed, 59 insertions(+), 42 deletions(-)
diff --git a/drivers
For T10-PI offload support, we will need to know the
device signature offload capability upon every connection
establishment.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.h |1 +
drivers/infiniband
FRWR stands for fast registration work request. We
want to avoid calling the fastreg pool with that name,
instead we name it fastreg which stands for fast registration.
This pool will include more elements in the future, so
it is a good idea to generalize the name.
Signed-off-by: Sagi Grimberg
In T10-PI support we will have memory keys for protection
buffers and signature transactions. We prefer to compact
indicators rather than keeping multiple bools.
This commit does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser
.
In addition Introduce iser_reg_sig_mr which performs fast
registration work-request for a signature enabled memory region
(IB_WR_REG_SIG_MR). In this routine we set all the protection
relevants for the device to offload protection data-transfer
and verification.
Signed-off-by: Sagi Grimberg sa
During connection establishment we also initiatlize
T10-PI resources (QP, PI contexts) in order to support
SCSI's protection operations.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.h | 19 ++
drivers/infiniband/ulp/iser/iser_initiator.c
fastreg descriptor will include protection information context.
In order to place the logic in one place we introduce
iser_create_fr_desc function.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_verbs.c | 58
: APPTAG_CHECK_FAILED
- 0x3: REFTAG_CHECK_FAILED
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/scsi/libiscsi.c | 32
include/scsi/libiscsi.h |4
include/scsi/scsi_transport_iscsi.h |1 +
3 files changed, 37
of repeating the logic of which key to use.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_memory.c | 101 +
1 files changed, 59
In T10-PI support we will have memory keys for protection
buffers and signature transactions. We prefer to compact
indicators rather than keeping multiple bools.
This commit does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al
For T10-PI offload support, we will need to know the
device signature offload capability upon every connection
establishment.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp
fastreg descriptor will include protection information context.
In order to place the logic in one place we introduce
iser_create_fr_desc function.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
Unaligned SG-lists may also happen for protection
information. Genrelize bounce buffer routine to handle
any iser_data_buf which may be data and/or protection.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser
: APPTAG_CHECK_FAILED
- 0x3: REFTAG_CHECK_FAILED
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/scsi/libiscsi.c | 32
include/scsi/libiscsi.h |4
include/scsi
From: Alex Tabachnik al...@mellanox.com
During connection establishment we also initiatlize
T10-PI resources (QP, PI contexts) in order to support
SCSI's protection operations.
Signed-off-by: Alex Tabachnik al...@mellanox.com
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers
the wire, only CRC is allowed.
In the next phase, it is worth considering passing these
parameters from iscsid via nlmsg. This will allow these
parameters to be connection based rather than global.
Signed-off-by: Alex Tabachnik al...@mellanox.com
Signed-off-by: Sagi Grimberg sa...@mellanox.com
FRWR stands for fast registration work request. We
want to avoid calling the fastreg pool with that name,
instead we name it fastreg which stands for fast registration.
This pool will include more elements in the future, so
it is a good idea to generalize the name.
Signed-off-by: Sagi Grimberg
Once the iSCSI transaction is completed we must
imeplement check_protection in order to notify
on DIF errors that may have occured.
The routine boils down to calling ib_check_mr_status
to get the signature status of the transaction.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off
Tabachnik (2):
IB/iser: Introduce pi_enable, pi_guard module parameters
IB/iser: Initialize T10-PI resources
Sagi Grimberg (11):
IB/iser: Avoid FRWR notation, use fastreg instead
IB/iser: Push the desicion what memory key to use into fast_reg_mr
routine
IB/iser: Move fast_reg_descriptor
This routines operates on data buffers and may also work with
protection infomation buffers. So we generalize them to handle
an iser_data_buf which can be the command data or command protection
information.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa
.
In addition Introduce iser_reg_sig_mr which performs fast
registration work-request for a signature enabled memory region
(IB_WR_REG_SIG_MR). In this routine we set all the protection
relevants for the device to offload protection data-transfer
and verification.
Signed-off-by: Sagi Grimberg sa
After allocating a scsi_host we set protection types
and guard type supported.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 23 ++-
1 files changed, 22 insertions(+), 1
On 3/3/2014 6:41 AM, Mike Christie wrote:
On 02/27/2014 05:13 AM, Sagi Grimberg wrote:
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 4046241..a58a6bb 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -395,6 +395,10 @@ static int iscsi_prep_scsi_cmd_pdu
On 3/3/2014 6:44 AM, Mike Christie wrote:
On 02/27/2014 05:13 AM, Sagi Grimberg wrote:
diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c
b/drivers/infiniband/ulp/iser/iser_initiator.c
index 58e14c7..7fd95fe 100644
--- a/drivers/infiniband/ulp/iser/iser_initiator.c
+++ b/drivers
On 3/4/2014 9:49 AM, Or Gerlitz wrote:
On 04/03/2014 02:01, Nicholas A. Bellinger wrote:
This is necessary because even though IB_SEND_SIGNALED is
not set for RDMA WRITEs + READs, during a QP failure event
the work requests will be returned with exception status
from the TX completion queue.
On 3/4/2014 11:38 AM, Or Gerlitz wrote:
On 03/03/2014 06:44, Mike Christie wrote:
The xmit_task callout does handle failures like EINVAL. If the above map
calls fail then you would get infinite retries. You would currently want
to do the mapping in the init_task callout instead.
If it makes it
On 3/4/2014 1:25 PM, Or Gerlitz wrote:
On 04/03/2014 11:59, Sagi Grimberg wrote:
On 3/4/2014 11:38 AM, Or Gerlitz wrote:
On 03/03/2014 06:44, Mike Christie wrote:
The xmit_task callout does handle failures like EINVAL. If the
above map
calls fail then you would get infinite retries. You would
.
This is necessary because even though IB_SEND_SIGNALED is not
set for either work request, during a QP failure event the work
requests will be returned with exception status from the TX
completion queue.
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Or Gerlitz ogerl...@mellanox.com
Signed-off-by: Nicholas
On 3/4/2014 2:00 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
Hi Or Sagi,
This series addresses a number of active I/O shutdown related issues
in iser-target code that have come up recently during stress testing.
Note there is still a seperate iser-target
On 3/4/2014 6:16 PM, Or Gerlitz wrote:
On 04/03/2014 16:44, Sagi Grimberg wrote:
@@ -1707,10 +1707,17 @@ int iscsi_queuecommand(struct Scsi_Host
*host, struct scsi_cmnd *sc)
goto prepd_fault
On 3/5/2014 2:06 AM, Nicholas A. Bellinger wrote:
On Tue, 2014-03-04 at 17:17 +0200, Sagi Grimberg wrote:
On 3/4/2014 2:00 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger n...@linux-iscsi.org
Hi Or Sagi,
This series addresses a number of active I/O shutdown related issues
in iser
of repeating the logic of which key to use.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_memory.c | 101 +
1 files changed, 59
fastreg descriptor will include protection information context.
In order to place the logic in one place we introduce
iser_create_fr_desc function.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
.
In addition Introduce iser_reg_sig_mr which performs fast
registration work-request for a signature enabled memory region
(IB_WR_REG_SIG_MR). In this routine we set all the protection
relevants for the device to offload protection data-transfer
and verification.
Signed-off-by: Sagi Grimberg sa
Once the iSCSI transaction is completed we must
imeplement check_protection in order to notify
on DIF errors that may have occured.
The routine boils down to calling ib_check_mr_status
to get the signature status of the transaction.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off
the block layer merges bios.
- Don't fail connections on devices without DIF support - warn and continue
without DIF.
- reword FR - FastReg
Alex Tabachnik (2):
IB/iser: Introduce pi_enable, pi_guard module parameters
IB/iser: Initialize T10-PI resources
Sagi Grimberg (11):
IB/iser: Avoid FRWR
FRWR stands for fast registration work request. We
want to avoid calling the fastreg pool with that name,
instead we name it fastreg which stands for fast registration.
This pool will include more elements in the future, so
it is a good idea to generalize the name.
Signed-off-by: Sagi Grimberg
After allocating a scsi_host we set protection types
and guard type supported.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 23 ++-
1 files changed, 22 insertions(+), 1
For T10-PI offload support, we will need to know the
device signature offload capability upon every connection
establishment.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Alex Tabachnik al...@mellanox.com
---
drivers/infiniband/ulp
This routines operates on data buffers and may also work with
protection infomation buffers. So we generalize them to handle
an iser_data_buf which can be the command data or command protection
information.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa
101 - 200 of 519 matches
Mail list logo
