Re: [PATCH 1/1] scsi: storvsc: Avoid allocating memory for temp cpumasks

memory allocation. > > Signed-off-by: Michael Kelley <mikel...@microsoft.com> Acked-by: Stephen Hemminger <sthem...@microsoft.com>

Re: [Patch v2] Storvsc: Select channel based on available percentage of ring buffer to write

S=8192 (default > value when CONFIG_MAXSMP=y). Don't use kernel stack for it by pre-allocating > them using kmalloc when channels are first initialized. > > Signed-off-by: Long Li <lon...@microsoft.com> Reviewed-by: Stephen Hemminger <sthem...@microsoft.com>

RE: [Resend Patch 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

, 2018 3:43 PM To: Martin K. Petersen <martin.peter...@oracle.com>; Long Li <lon...@linuxonhyperv.com> Cc: KY Srinivasan <k...@microsoft.com>; Haiyang Zhang <haiya...@microsoft.com>; Stephen Hemminger <sthem...@microsoft.com>; James E . J . Bottomley <jbottom...@odin.c

Re: [PATCH] storvsc: Set up correct queue depth values for IDE devices

r all devices. > > Signed-off-by: Long Li <lon...@microsoft.com> Looks correct. Acked-by: Stephen Hemminger <sthem...@microsoft.com>

Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error

receiving I/O > errors before a failover can occur. > > Signed-off-by: Cathy Avery <cav...@redhat.com> > Signed-off-by: Long Li <lon...@microsoft.com> When working on the DVD probe issue I saw that error handling was problematic. Thanks for fixing. Reviewed-by: Stephen Hemminger <step...@networkplumber.org>

Re: [PATCH] storvsc: fix memory leak on ring buffer busy

On Tue, 29 Aug 2017 21:31:11 -0400 "Martin K. Petersen" wrote: > Long, > > > When storvsc is sending I/O to Hyper-v, it may allocate a bigger > > buffer descriptor for large data payload that can't fit into a > > pre-allocated buffer descriptor. This bigger buffer is

[PATCH 0/2] storvsc: changes for scsi next

These are refactoring changes to the Hyper-V scsi driver. Stephen Hemminger (2): storvsc: use in place iterator function storvsc: remove unnecessary channel inbound lock drivers/hv/channel_mgmt.c | 1 - drivers/scsi/storvsc_drv.c | 52

[PATCH 1/2] storvsc: use in place iterator function

In 4.12-rc1, new functions were added to support iterating over elements in the vmbus event ring. This patch uses them to simplify the ring buffer handling in virtual SCSI driver as well. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/scsi/storvsc_drv.

[PATCH 2/2] storvsc: remove unnecessary channel inbound lock

In storvsc driver, inbound messages do not go through inbound lock. The only effect of this lock was is to provide a barrier for connect and remove logic. Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> --- drivers/hv/channel_mgmt.c | 1 - drivers/scsi/storvsc_drv

RE: [REGRESSION][Stable][v3.12.y][v4.4.y][v4.9.y][v4.10.y][v4.11-rc1] scsi: storvsc: properly set residual data length on errors

Are you sure the real problem is not the one fixed by this commit? commit f1c635b439a5c01776fe3a25b1e2dc546ea82e6f Author: Stephen Hemminger <step...@networkplumber.org> Date: Tue Mar 7 09:15:53 2017 -0800 scsi: storvsc: Workaround for virtual DVD SCSI version Hyper-

Re: [PATCH] scsi: storvsc: Add support for FC rport.

On Tue, 14 Mar 2017 12:01:03 -0400 Cathy Avery wrote: > #if IS_ENABLED(CONFIG_SCSI_FC_ATTRS) > if (host->transportt == fc_transport_template) { > + struct fc_rport_identifiers ids; > + > + ids.node_name = 0; > + ids.port_name = 0; > +

[PATCH] storvsc: workaround for virtual DVD SCSI version

into a death spiral doing block reads on the non-existent LUNs. By setting the correct blacklist flags, the target with the DVD device is scanned with REPORTLUN and that works correctly. Patch needs to go in current 4.11, it is safe but not necessary in older kernels. Signed-off-by: Stephen Hemminger

Re: [RFC] hv_storvsc: error handling.

> > I will try it, but it can't work for two reasons. > > First, the INVALID_LUN error is masked off on INQUIRY in current code. > > Second, the scsi_device is instantiated already as part of scan probe > > process > > before it gets here. > > Was the invalid LUN in the LUN0 position. Inquiry

Re: [RFC] hv_storvsc: error handling.

On Sat, 4 Mar 2017 21:03:41 + KY Srinivasan <k...@microsoft.com> wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Friday, March 3, 2017 4:50 PM > > To: James Bottomley <james.bottom...@hans

[RFC] hv_storvsc: error handling.

Needs more testing but this does fix the observed problem. From: Stephen Hemminger <sthem...@microsoft.com> Subject: [PATCH] hv_storvsc: fix error handling The Hyper-V storvsc SCSI driver was hiding all errors in INQUIRY and MODE_SENSE commands. This caused the scan process to incorrectly

Re: SCSI regression in 4.11

On Thu, 02 Mar 2017 11:18:23 -0800 James Bottomley <james.bottom...@hansenpartnership.com> wrote: > On March 2, 2017 11:05:05 AM PST, Stephen Hemminger > <step...@networkplumber.org> wrote: > >On Thu, 02 Mar 2017 10:36:17 -0800 > >James Bottomley <james.botto

Re: SCSI regression in 4.11

On Thu, 02 Mar 2017 10:36:17 -0800 James Bottomley <james.bottom...@hansenpartnership.com> wrote: > On March 2, 2017 10:23:24 AM PST, Stephen Hemminger > <step...@networkplumber.org> wrote: > >On Thu, 2 Mar 2017 14:25:14 +0100 > >Hannes Reinecke <h...@suse.de>

Re: SCSI regression in 4.11

On Thu, 2 Mar 2017 14:25:14 +0100 Hannes Reinecke <h...@suse.de> wrote: > On 03/02/2017 02:40 AM, Stephen Hemminger wrote: > > On Thu, 2 Mar 2017 01:56:15 +0100 > > Christoph Hellwig <h...@lst.de> wrote: > > > >> On Thu, Mar 02, 2017 at 01:01:35AM +010

Re: SCSI regression in 4.11

On Thu, 2 Mar 2017 14:25:14 +0100 Hannes Reinecke <h...@suse.de> wrote: > On 03/02/2017 02:40 AM, Stephen Hemminger wrote: > > On Thu, 2 Mar 2017 01:56:15 +0100 > > Christoph Hellwig <h...@lst.de> wrote: > > > >> On Thu, Mar 02, 2017 at 01:01:35AM +010

Re: SCSI regression in 4.11

On Thu, 2 Mar 2017 01:56:15 +0100 Christoph Hellwig <h...@lst.de> wrote: > On Thu, Mar 02, 2017 at 01:01:35AM +0100, Christoph Hellwig wrote: > > On Wed, Mar 01, 2017 at 07:54:12AM -0800, Stephen Hemminger wrote: > > > > > > > > http://git.infra

Re: SCSI regression in 4.11

On Thu, 2 Mar 2017 01:01:35 +0100 Christoph Hellwig <h...@lst.de> wrote: > On Wed, Mar 01, 2017 at 07:54:12AM -0800, Stephen Hemminger wrote: > > > > > > http://git.infradead.org/users/hch/block.git/commitdiff/148cff67b401e2229c076c0ea418712654be77e4 &

Re: SCSI regression in 4.11

On Wed, 01 Mar 2017 15:09:44 -0800 James Bottomley <james.bottom...@hansenpartnership.com> wrote: > On Wed, 2017-03-01 at 13:27 -0800, Stephen Hemminger wrote: > > Ok here is much better data, wasn't accounting for the offset in the > > payload > > But now

Re: SCSI regression in 4.11

Ok here is much better data, wasn't accounting for the offset in the payload Working 4.10 [1.020041] scsi host0: storvsc_host_t [1.024998] hv_storvsc: INQUIRY cmd 0x12 0x0 0x0 scsi status 0x0 srb status 0x1 length 36 [1.027452] hv_storvsc: payload size 288 count 1 offset 3072 len

Re: SCSI regression in 4.11

On Wed, 01 Mar 2017 11:20:22 -0800 James Bottomley <james.bottom...@hansenpartnership.com> wrote: > On Wed, 2017-03-01 at 10:57 -0800, James Bottomley wrote: > > On Wed, 2017-03-01 at 10:48 -0800, Stephen Hemminger wrote: > > > On Tue, 28 Feb 2017 22:20:58 -0800

Re: SCSI regression in 4.11

On Tue, 28 Feb 2017 22:20:58 -0800 James Bottomley <j...@linux.vnet.ibm.com> wrote: > On Tue, 2017-02-28 at 17:25 -0800, Stephen Hemminger wrote: > > [1.346023] hv_storvsc: IO cmd 0x12 0x0 0x0 scsi status 0x0 srb > > status 0x20 length 36 > > [1.352913] in

Re: SCSI regression in 4.11

Dexuan has reproduced the same problem and discovered that is related to whether virtual DVD is attached to the VM. My VM had empty virtual DVD (offline) from the installation of the ISO. If the DVD device is removed then the VM boots. This makes the problem less of a catastrophic but we still

Re: SCSI regression in 4.11

On Wed, 1 Mar 2017 16:50:57 +0100 Christoph Hellwig <h...@lst.de> wrote: > On Tue, Feb 28, 2017 at 10:48:45PM -0800, Stephen Hemminger wrote: > > Let me know, I can run another test and dump more data. > > Could it be that we keep the old sense buffer values around becau

Re: SCSI regression in 4.11

On Tue, 28 Feb 2017 22:20:58 -0800 James Bottomley <j...@linux.vnet.ibm.com> wrote: > On Tue, 2017-02-28 at 17:25 -0800, Stephen Hemminger wrote: > > [1.346023] hv_storvsc: IO cmd 0x12 0x0 0x0 scsi status 0x0 srb > > status 0x20 length 36 > > [1.352913] in

Re: SCSI regression in 4.11

> Let's concentrate on INQUIRY since that's the first command in the > probe sequence. I think it's completing successfully because your > hyperv layer says it has 36 bytes of transfer and that's the size of a > successful initial INQUIRY, so the fact that the code above would break > stuff if

Re: SCSI regression in 4.11

On Tue, 28 Feb 2017 09:06:13 -0800 James Bottomley <j...@linux.vnet.ibm.com> wrote: > On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote: > > On 02/28/2017 07:08 AM, Christoph Hellwig wrote: > > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: >

Re: SCSI regression in 4.11

On Tue, 28 Feb 2017 09:06:13 -0800 James Bottomley <j...@linux.vnet.ibm.com> wrote: > On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote: > > On 02/28/2017 07:08 AM, Christoph Hellwig wrote: > > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: >

Re: SCSI regression in 4.11

On Tue, 28 Feb 2017 09:06:13 -0800 James Bottomley <j...@linux.vnet.ibm.com> wrote: > On Tue, 2017-02-28 at 08:32 -0700, Jens Axboe wrote: > > On 02/28/2017 07:08 AM, Christoph Hellwig wrote: > > > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: >

Re: SCSI regression in 4.11

On Tue, 28 Feb 2017 15:08:12 +0100 Christoph Hellwig <h...@lst.de> wrote: > On Mon, Feb 27, 2017 at 05:19:31PM -0800, Stephen Hemminger wrote: > > Fixes: ee5242360424 ("scsi: zero per-cmd driver data before each I/O") > > > > but that is already in linux

Re: SCSI regression in 4.11

On Mon, 27 Feb 2017 15:30:30 -0800 Stephen Hemminger <step...@networkplumber.org> wrote: > Something in SCSI in 4.11 broke booting on Hyper-V Generation 2 VM with 8 > VCPU and 4G of memory. > Both Linus's current tree (4.11 pre-rc1) and linux-next fail in a similar > manner.

Re: [PATCHv1] net-next: treewide use is_vlan_dev() helper function.

--- > include/rdma/ib_addr.h | 6 ++ > net/hsr/hsr_slave.c | 3 ++- > 14 files changed, 31 insertions(+), 35 deletions(-) Looks good thanks. Acked-by: Stephen Hemminger <step...@networkplumber.org>

[PATCH 3/4] scsi: make pci error handlers const

Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- Depends on first patch that changes PCI core. drivers/scsi/ipr.c |2 +- drivers/scsi/lpfc/lpfc_init.c|2 +- drivers/scsi/mpt2sas/mpt2sas_scsih.c |2 +- drivers/scsi/qla2xxx/qla_os.c|2

Re: [V2 PATCH 1/9] csiostor: Chelsio FCoE offload driver submission (sources part 1).

On Wed, 5 Sep 2012 18:03:54 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: + +/* FCoE Adapter types its description */ +static struct csio_adap_desc csio_fcoe_adapters[] = { Tables like this should be const. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the

Re: [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2).

On Wed, 5 Sep 2012 18:03:55 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: This patch contains code for driver initialization, driver resource allocation and the Work Request module functionality. Driver initialization includes module entry/exit points, registration with PCI, FC transport

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: +#define CSIO_ROUNDUP(__v, __r) (((__v) + (__r) - 1) / (__r)) This is similar to existing round_up() in kernel.h could you use that? -- To unsubscribe from this list: send the line unsubscribe

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: + +#define CSIO_ASSERT(cond) \ +do { \ + if (unlikely(!((cond

Re: [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2).

On Wed, 5 Sep 2012 23:13:46 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: On 9/5/2012 9:59 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:55 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: This patch contains code for driver initialization, driver resource allocation

Re: [PATCH 1/5] fixing errors handling during pci_driver resume stage [net]

if all the other error printout's use a different interface. -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Something wrong with latest adaptec aic driver

(Found out not to put aic7xxx in subject line because of spam filter...) Running with latest 2.6.11 bk tree, one of my machines takes for ever to boot. The driver is builtin (not a module). It worked fine until today, and works fine with 2.6.11 or earlier. Looks like it is going into some

Re: IP/ethernet/networking-over-SCSI.

On Tue, 25 Jan 2005 16:19:12 + (GMT) S Iremonger [EMAIL PROTECTED] wrote: For some purposes at the moment, working IP-over-SCSI could be rather handy... ;-). You probably are looking for: http://linux-iscsi.sourceforge.net/ -- Stephen Hemminger [EMAIL PROTECTED