Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-14 Thread Christoph Hellwig
On Mon, Jun 13, 2016 at 11:23:52PM -0700, Nicholas A. Bellinger wrote: > AFAICT, the problem with this improvement is that it's not stable > material, which means that Canonical would have to carry this separately > beyond linux-4.4.y, in order to support ibmvscsi-tgt. So who cares? If they have

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-14 Thread Nicholas A. Bellinger
On Fri, 2016-06-10 at 12:03 -0700, Bart Van Assche wrote: > On 05/24/2016 01:00 PM, Bryant G Ly wrote: > > Quoting Bart Van Assche : > >> On 05/24/2016 06:52 AM, Bryant G. Ly wrote: > >>> +static uint64_t ibmvscsis_unpack_lun(const uint8_t *lun, int len) > >>> +{ > >>>

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-06-10 Thread Bart Van Assche
On 05/24/2016 01:00 PM, Bryant G Ly wrote: Quoting Bart Van Assche : On 05/24/2016 06:52 AM, Bryant G. Ly wrote: +static uint64_t ibmvscsis_unpack_lun(const uint8_t *lun, int len) +{ +uint64_t res = NO_SUCH_LUN; +int addressing_method; + +if

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Bryant G Ly
Quoting Bart Van Assche : On 05/24/2016 06:52 AM, Bryant G. Ly wrote: +config SCSI_IBMVSCSIS + tristate "IBM Virtual SCSI Server support" + depends on PPC_PSERIES && SCSI_SRP && TARGET_CORE + help + This is the IBM POWER Virtual SCSI

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Greg KH
On Tue, May 24, 2016 at 09:44:43AM -0700, Bart Van Assche wrote: > On 05/24/2016 09:34 AM, Greg KH wrote: > > On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: > > > > +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, > > > > + u64 word1, u64

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Bart Van Assche
On 05/24/2016 09:34 AM, Greg KH wrote: On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, + u64 word1, u64 word2) +{ + long rc; + struct vio_dev *vdev = adapter->dma_dev; + +

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Greg KH
On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: > > +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, > > + u64 word1, u64 word2) > > +{ > > + long rc; > > + struct vio_dev *vdev = adapter->dma_dev; > > + > > + pr_debug("ibmvscsis:

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Bart Van Assche
On 05/24/2016 06:52 AM, Bryant G. Ly wrote: +config SCSI_IBMVSCSIS + tristate "IBM Virtual SCSI Server support" + depends on PPC_PSERIES && SCSI_SRP && TARGET_CORE + help + This is the IBM POWER Virtual SCSI Target Server + + The userspace component needed to

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Greg KH
On Tue, May 24, 2016 at 08:52:58AM -0500, Bryant G. Ly wrote: > From: bgly Really? Please go get a proper review from the other internal IBM developers to fix this, and the other obvious problems with your patch, before you send it publically and force us to tell you these

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Joe Perches
On Tue, 2016-05-24 at 08:52 -0500, Bryant G. Ly wrote: > From: bgly > > This initial commit contains WIP of the IBM VSCSI Target Fabric > Module. It currently supports read/writes, and I have tested > the ability to create a file backstore with the driver and install > RHEL VIA

[PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Bryant G. Ly
From: bgly This initial commit contains WIP of the IBM VSCSI Target Fabric Module. It currently supports read/writes, and I have tested the ability to create a file backstore with the driver and install RHEL VIA NIM and then boot up the partition via filio backstore through the