Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Johannes Thumshirn
On Mon, Nov 07, 2016 at 08:10:25PM +0100, Christoph Hellwig wrote: > On Mon, Nov 07, 2016 at 06:04:21PM +0100, Sebastian Andrzej Siewior wrote: > > So we keep things as they are right now or are we getting also rid of > > the internal list? This was tested by Johannes and Chad (claimed to do > >

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Christoph Hellwig
On Mon, Nov 07, 2016 at 06:04:21PM +0100, Sebastian Andrzej Siewior wrote: > So we keep things as they are right now or are we getting also rid of > the internal list? This was tested by Johannes and Chad (claimed to do > testing) IFF the patches actually are tested as-is let's get them in. I

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Sebastian Andrzej Siewior
On 2016-11-07 17:48:46 [+0100], Christoph Hellwig wrote: > On Mon, Nov 07, 2016 at 05:46:29PM +0100, Sebastian Andrzej Siewior wrote: > > sorry for the confusion in the subject. If I remember correctly you said > > that we may not have enough room for a larger / work_struct struct and I > > should

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Christoph Hellwig
On Mon, Nov 07, 2016 at 05:46:29PM +0100, Sebastian Andrzej Siewior wrote: > sorry for the confusion in the subject. If I remember correctly you said > that we may not have enough room for a larger / work_struct struct and I > should keep the list for now. But that was for libfc where it only has

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Sebastian Andrzej Siewior
On 2016-11-07 17:38:48 [+0100], Christoph Hellwig wrote: > You're right it does - between the incorrect subject and the fact > that it still keeps the linked list of items arounds instead of fully > using the workqueue infrastructure I was a bit confused before my > first coffee this morning.

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-11-07 Thread Christoph Hellwig
On Mon, Nov 07, 2016 at 05:31:03PM +0100, Thomas Gleixner wrote: > On Mon, 7 Nov 2016, Christoph Hellwig wrote: > > > It seems like the whole damn driver should just use threaded interrupts. > > Of course it's a giant beast and not just the iSCSI one. But even > > if we don't go all the way I'd

Re: [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-09-30 Thread Sebastian Andrzej Siewior
On 2016-09-14 13:25:12 [-0400], Martin K. Petersen wrote: > > "Chad" == Chad Dupuis writes: > > Chad> We're regression testing the patches now. Please hold off on > Chad> applying them. > > OK. I will wait. Chad, any updates on this tests? Sebastian -- To

Re: [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-09-14 Thread Martin K. Petersen
> "Chad" == Chad Dupuis writes: Johannes> Testing was conducted by booting from a QLogic BCM57840 CNA. Chad> We're regression testing the patches now. Please hold off on Chad> applying them. OK. I will wait. -- Martin K. Petersen Oracle Linux Engineering --

Re: [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-09-13 Thread Chad Dupuis
On Fri, 9 Sep 2016, 11:28am -, Martin K. Petersen wrote: > > "Johannes" == Johannes Thumshirn writes: > > >> On Wed, Aug 17, 2016 at 12:09:59PM +0200, Sebastian Andrzej Siewior > wrote: > >> The driver creates its own per-CPU threads which are updated based on > >>

Re: [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-09-09 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: >> On Wed, Aug 17, 2016 at 12:09:59PM +0200, Sebastian Andrzej Siewior wrote: >> The driver creates its own per-CPU threads which are updated based on >> CPU hotplug events. It is also possible to use kworkers and remove >> some

Re: [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-09-08 Thread Johannes Thumshirn
On Wed, Aug 17, 2016 at 12:09:59PM +0200, Sebastian Andrzej Siewior wrote: > The driver creates its own per-CPU threads which are updated based on CPU > hotplug events. It is also possible to use kworkers and remove some of the > infrastructure get the same job done while saving a few lines of

[REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

2016-08-17 Thread Sebastian Andrzej Siewior
The driver creates its own per-CPU threads which are updated based on CPU hotplug events. It is also possible to use kworkers and remove some of the infrastructure get the same job done while saving a few lines of code. The DECLARE_PER_CPU() definition is moved into the header file where it