Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-26 Thread Tejun Heo
Hello, Rusty Russell. Rusty Russell wrote: ATA relies so heavily on scsi that it needs to be converted at the same time. ATA adds padding to scatterlists in scsi commands, but because there was no good way of appending to those scatterlists, it had to use boutique iterators to make sure

[PATCH 3/4] drivers/scsi/lpfc: Use time_before, time_before_eq, etc.

2007-12-26 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the semantic patch making this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // smpl @

[PATCH 4/4] drivers/scsi/u14-34f.c: Use time_before, time_before_eq, etc.

2007-12-26 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the semantic patch making this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // smpl @

[PATCH 3/3] drivers/scsi: Use offsetof

2007-12-26 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] In the patch cc154ac64aa8d3396b187f64cef01ce67f433324, Al Viro observed that the proper way to compute the distance between two structure fields is to use offsetof() or a cast to a pointer to character. The same change can be applied to a few more files. The

Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-26 Thread James Bottomley
On Wed, 2007-12-26 at 17:36 +0900, Tejun Heo wrote: (PS, I haven't followed the sg chaining discussion. Why is sg chaining an optional feature? Performance overhead on low end machines?) The idea of SG chaining is to allow drivers that wish to take advantage of it to increase their transfer

Problems with LSI MegaRaid 1068e

2007-12-26 Thread Cory Visi
To whom it may concern: I am working with a SuperMicro Super Server AS2020A-8RB with an integrated LSI MegaRaid 1068e (Firmware M1068e.01.08221427R). The configuation uses 3x 73 GB SAS drives in a RAID 5 configuration (using the RAID key). I am trying to get some combination of kernel and

RE: Problems with LSI MegaRaid 1068e

2007-12-26 Thread Moore, Eric
On Wednesday, December 26, 2007 12:39 PM, Cory Visi wrote: To whom it may concern: I am working with a SuperMicro Super Server AS2020A-8RB with an integrated LSI MegaRaid 1068e (Firmware M1068e.01.08221427R). The configuation uses 3x 73 GB SAS drives in a RAID 5 configuration (using

Fw: Problems with LSI MegaRaid 1068e

2007-12-26 Thread Cory Visi
To whom it may concern: I am working with a SuperMicro Super Server AS2020A-8RB with an integrated LSI MegaRaid 1068e (Firmware M1068e.01.08221427R). The configuation uses 3x 73 GB SAS drives in a RAID 5 configuration (using the RAID key/iButton). I am trying to get some combination of kernel

RE: Problems with LSI MegaRaid 1068e

2007-12-26 Thread Cory Visi
Eric, Sorry about the confusion and thank you very much for the references to other support addresses. You may want to consider removing the [EMAIL PROTECTED] e-mail address from MAINTAINERS. They really have no idea how to respond to Linux kernel driver requests. Thank you again! Cory

Re: [PATCH 0/5] sg_ring for scsi

2007-12-26 Thread FUJITA Tomonori
On Wed, 26 Dec 2007 11:27:40 +1100 Rusty Russell [EMAIL PROTECTED] wrote: On Friday 21 December 2007 15:37:46 FUJITA Tomonori wrote: Some scsi drivers like ips access to sglist in a tricky way. Indeed. I fail to see how this code works, in fact: drivers/scsi/ips.c:ips_queue() line 1101

Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-26 Thread Tejun Heo
Hello, Rusty. Rusty Russell wrote: On Wednesday 26 December 2007 19:36:36 Tejun Heo wrote: It would be better to build upon sg chaining as we already have it. I think it can be made much easier with a bit more safe guards, generalization and some helpers. I did this work to replace sg

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-26 Thread Balbir Singh
FUJITA Tomonori wrote: On Mon, 24 Dec 2007 10:18:50 +0530 Balbir Singh [EMAIL PROTECTED] wrote: [snip] I might break the IOMMU code. Can you reproduce it easily? If so, reverting my IOMMU patches (I've attached a patch to revert them) fix the problem? [snip] Yes, this patch fixes the

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-26 Thread FUJITA Tomonori
On Thu, 27 Dec 2007 10:08:25 +0530 Balbir Singh [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: On Mon, 24 Dec 2007 10:18:50 +0530 Balbir Singh [EMAIL PROTECTED] wrote: [snip] I might break the IOMMU code. Can you reproduce it easily? If so, reverting my IOMMU patches (I've