RE: [PATCHv2 6/6] cciss: Drop obsolete driver

> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Monday, August 14, 2017 6:19 AM > To: Martin K. Petersen > Cc: Christoph Hellwig ; James Bottomley > ; Don Brace >

[PATCH] sd: read unmap block limits even if lbpme=0

From: Tom Yan Some devices may not be decent enough to report lbpme bit properly even when they do support unmap and report relevant information in the block limits and logical block provisioning VPDs properly (Namely, ASMedia ASM1351, a UAS-SATA bridge). One of the reasons

Re: Spurious DISK_EVENT_MEDIA_CHANGE on USB DVD hotplug?

Hello, Joe. On Thu, Aug 10, 2017 at 10:45:54AM -0400, Joe Lawrence wrote: > In the case of my USB DVD -> laptop example, there is no media in my > device, however I still see the DISK_EVENT_MEDIA_CHANGE event. This is > a bit confusing, and I was wondering if there was an explanation for > the

Re: [PATCH] Revert "scsi: default to scsi-mq"

Christoph, > Defaulting to scsi-mq in 4.13-rc has shown various regressions > on setups that we didn't previously consider. Fixes for them are > in progress, but too invasive to make it in this cycle. So for > now revert the commit that defaults to blk-mq for SCSI. For 4.14 > we'll plan to

答复: [iscsi] Deadlock occurred when network is in error

Hi, Bart, Thank you very much for the quick response. But I'm not using mq, and I run into these two problems in a non-mq system. The patch you pointed out is fix for mq, so I don't think it can resolve this problem. IIUC, mq is for SSD ? I'm not using ssd, so mq is disabled. On Mon,

Re: [PATCHv2 0/2] scsi: pollable 'state' attribute

Hannes, > here's a small patchset to make the 'state' device attribute pollable. > It was supposed to be a small patch, but then hch suggested a rework. Applied to 4.14/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] sym53c8xx: Avoid undefined behaviour in drivers/scsi/sym53c8xx_2/sym_hipd.c:762

Helge, > On parisc I see this UBSAN warning with a sym53c896: > > UBSAN: Undefined behaviour in ./drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24 > index -1903078336 is out of range for type 'u32 [7]' > > Avoid this warning by switching to dev64_ul(). Applied to 4.14/scsi-queue. Thank you, Helge!

Re: [PATCHv3 2/5] scsi: Export blacklist flags to sysfs

Hannes, > + name = sdev_bflags_name(bflags); > + if (name) > + blen = snprintf(ptr, strlen(name) + 1, > + "%s", name); > + else > + blen = snprintf(ptr, 67, "0x%X", bflags); It seems

Re: [PATCHv2 0/6] hpsa legacy support

Hannes, > here's now the second attempt to add support for legacy boards, ie for > boards previously supported by cciss only. With this patchset the > hpsa driver should work with all Smart Array boards if the > 'hpsa_allow_any' module option is set, rendering the cciss driver > obsolete.

Re: [PATCH 3/6] hpsa: disable volume status check for older controller

On 08/11/2017 03:23 PM, Tomas Henzl wrote: > On 8.8.2017 10:35, Hannes Reinecke wrote: >> Older Controller might not support volume status, so assume >> the volume is online here. >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/scsi/hpsa.c | 11 +++ >> 1 file

Re: [PATCH 1/6] hpsa: consolidate status variables

On 08/09/2017 03:40 PM, Christoph Hellwig wrote: > These seem to be modified from sysfs files, so you'll run into > read-modify-write atomicy issues with bitfields. > > That being said while plain ints are somewhat safe the right thing > would be to use proper atomic bitops. > True, but

Re: [PATCH] Revert "scsi: default to scsi-mq"

On 08/13/2017 07:44 PM, Christoph Hellwig wrote: > Defaulting to scsi-mq in 4.13-rc has shown various regressions > on setups that we didn't previously consider. Fixes for them are > in progress, but too invasive to make it in this cycle. So for > now revert the commit that defaults to blk-mq

[PATCHv2 2/6] hpsa: disable volume status check for legacy boards

Legacy boards might not support volume status, so assume the volume is online here. Signed-off-by: Hannes Reinecke Acked-by: Don Brace --- drivers/scsi/hpsa.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/hpsa.c

[PATCHv2 5/6] hpsa: handle unsupported devices more gracefully

From: Jeff Mahoney Add a warning message if an unsupported device is found and the hpsa_allow_any parameter is not set. Also make the hpsa_allow_any parameter writeable once the hpsa driver is loaded. Signed-off-by: Jeff Mahoney Signed-off-by: Hannes Reinecke

[iscsi] Deadlock occurred when network is in error

Hi, I found two hangup problems between iscsid service and iscsi module. And I can reproduce one of them in the latest kernel always. So I think the problems really exist. It really took me a long time to find out why due to my lack of knowledge of iscsi. But I cannot find a good way to solve

[PATCHv2 0/6] hpsa legacy support

Hi all, here's now the second attempt to add support for legacy boards, ie for boards previously supported by cciss only. With this patchset the hpsa driver should work with all Smart Array boards if the 'hpsa_allow_any' module option is set, rendering the cciss driver obsolete. Consequently I've

[PATCHv2 1/6] hpsa: add support for legacy boards

Add support for legacy boards, ensuring to enable the driver for those boards only when 'hpsa_allow_any' is set. The attribute 'legacy_board' is set to '1' if the device is a legacy board, and '0' otherwise. Signed-off-by: Hannes Reinecke Cc: Don Brace

[PATCHv2 3/6] hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page

Legacy boards might not support the LV_DEVICE_ID VPD page, so we shouldn't print out an error message here. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig Acked-by: Don Brace --- drivers/scsi/hpsa.c | 2 +- 1 file changed, 1

[PATCHv2 4/6] hpsa: do not print errors for unsupported report luns format

Legacy boards might not support the 'extended' report luns format, but as this is to be expected we don't need to print out an error here. Signed-off-by: Hannes Reinecke Acked-by: Don Brace --- drivers/scsi/hpsa.c | 21 - 1 file

Re: [PATCH] scsi-sysfs: correct errno for host_reset

On Fri, Aug 11, 2017 at 01:52:17AM +0800, weiping zhang wrote: > if scsi_host_template->host_reset is NULL, when user > "echo adapter > /sys/class/scsi_host/hostx/host_reset", > -EINVAL will return even string compare successfully. It make user confuse. > > change to: > -EINVAL if

Re: [iscsi] Deadlock occurred when network is in error

On Mon, 2017-08-14 at 11:23 +, Tangchen (UVP) wrote: > Problem 2: > > *** > [What it looks like] > *** > When remove a scsi device, and the network error happens, __blk_drain_queue() > could hang forever. > > # cat /proc/19160/stack > [] msleep+0x1d/0x30 > []

Re: [PATCH] Revert "scsi: default to scsi-mq"

On Sun, 2017-08-13 at 19:44 +0200, Christoph Hellwig wrote: > Defaulting to scsi-mq in 4.13-rc has shown various regressions > on setups that we didn't previously consider. Fixes for them are > in progress, but too invasive to make it in this cycle. So for > now revert the commit that defaults

RE: [SCSI] qla2xxx: Fix a memory leak in an error path of qla2x00_process_els()

Bart - I've been porting patches from mainline into a copy of QLogic's target driver tree and ran across an anomaly in this changeset of yours from 2013 (8c0eb596baa51f2b43949c698c644727ef17805c). The commit log says: ... Make it easy for Coverity (and for humans) to recognize that there

Re: [PATCH v2 1/2] nvmet_fc: add defer_req callback for deferment of cmd buffer return

On 08/04/17 17:29, James Smart wrote: > + /* Cleanup defer'ed IOs in queue */ > + list_for_each_entry(deferfcp, >avail_defer_list, req_list) { > + list_del(>req_list); > + kfree(deferfcp); > + } Hello James, Coverity reports a user-after-free for the above

Re: [RFC PATCH 1/6] bsg: fix kernel panic resulting from missing allocation of a reply-buffer

Hey Christoph, I looked over the patch in detail, see below. > From f5b03b82df0569c035022c1c2535696186907f1a Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig > Date: Fri, 11 Aug 2017 11:03:29 +0200 > Subject: bsg-lib: allocate sense data for each request > > Since we split the

Re: [RFC PATCH 1/6] bsg: fix kernel panic resulting from missing allocation of a reply-buffer

On Sun, Aug 13, 2017 at 04:39:40PM +0200, Christoph Hellwig wrote: > On Fri, Aug 11, 2017 at 06:01:42PM +0200, Benjamin Block wrote: > > When the BSG interface is used with bsg-lib, and the user sends a > > Bidirectional command - so when he gives an input- and output-buffer > > (most users of our

Re: [PATCH] Revert "scsi: default to scsi-mq"

On 08/13/2017 12:44 PM, Christoph Hellwig wrote: > Defaulting to scsi-mq in 4.13-rc has shown various regressions > on setups that we didn't previously consider. Fixes for them are > in progress, but too invasive to make it in this cycle. So for > now revert the commit that defaults to blk-mq

Re: [SCSI] qla2xxx: Fix a memory leak in an error path of qla2x00_process_els()

On Mon, 2017-08-14 at 10:38 -0500, Steve Magnani wrote: > I've been porting patches from mainline into a copy of QLogic's target driver > tree > and ran across an anomaly in this changeset of yours from 2013 > (8c0eb596baa51f2b43949c698c644727ef17805c). > > > The commit log says: > > ...