Re: Bug in sr.c

2001-05-23 Thread Jens Axboe
. -- Jens Axboe diff -urN --exclude-from /home/axboe/cdrom/exclude /opt/kernel/linux-2.4.4-pre2/drivers/scsi/sr.c linux/drivers/scsi/sr.c --- /opt/kernel/linux-2.4.4-pre2/drivers/scsi/sr.c Mon Feb 19 19:25:17 2001 +++ linux/drivers/scsi/sr.c Mon Apr 9 09:18:46 2001 @@ -262,7 +262,7

Re: 2.4.7-pre9..

2001-07-20 Thread Jens Axboe
On Fri, Jul 20 2001, Linus Torvalds wrote: On Fri, 20 Jul 2001, Jens Axboe wrote: The paging stuff doesn't use any of this. The paging stuff use the page cache lock bit, and always has. Paging still hits a request, I assumed that's what the (really really) old comment meant

[PATCH] scsi/sata write barrier support

2005-01-27 Thread Jens Axboe
reverse_ordering:1; /* +* ordered write support +*/ + unsigned ordered_flush:1; + unsigned ordered_tag:1; + + /* * Host has rejected a command because it was busy. */ unsigned int host_blocked; -- Jens Axboe - To unsubscribe from this list

Re: [PATCH] scsi/sata write barrier support

2005-01-27 Thread Jens Axboe
On Thu, Jan 27 2005, Jeff Garzik wrote: Doug Maxey wrote: On Thu, 27 Jan 2005 13:02:48 +0100, Jens Axboe wrote: Hi, For the longest time, only the old PATA drivers supported barrier writes with journalled file systems. This patch adds support for the same type of cache flushing barriers

Re: [PATCH] scsi/sata write barrier support

2005-01-27 Thread Jens Axboe
On Thu, Jan 27 2005, Doug Maxey wrote: On Thu, 27 Jan 2005 13:02:48 +0100, Jens Axboe wrote: Hi, For the longest time, only the old PATA drivers supported barrier writes with journalled file systems. This patch adds support for the same type of cache flushing barriers that PATA uses

Re: [PATCH] scsi/sata write barrier support

2005-01-28 Thread Jens Axboe
On Fri, Jan 28 2005, Jeff Garzik wrote: Jens Axboe wrote: On Thu, Jan 27 2005, Jeff Garzik wrote: Doug Maxey wrote: On Thu, 27 Jan 2005 13:02:48 +0100, Jens Axboe wrote: Hi, For the longest time, only the old PATA drivers supported barrier writes with journalled file systems

Re: [PATCH] scsi/sata write barrier support

2005-01-28 Thread Jens Axboe
On Fri, Jan 28 2005, Jens Axboe wrote: On Fri, Jan 28 2005, Jeff Garzik wrote: Jens Axboe wrote: On Thu, Jan 27 2005, Jeff Garzik wrote: Doug Maxey wrote: On Thu, 27 Jan 2005 13:02:48 +0100, Jens Axboe wrote: Hi, For the longest time, only the old PATA drivers supported

Re: 2.6.11-rc[1,2]-mmX scsi cdrom problem, 2.6.10-mm2 ok

2005-01-31 Thread Jens Axboe
On Mon, Jan 31 2005, Douglas Gilbert wrote: Jens Axboe wrote: On Mon, Jan 31 2005, Douglas Gilbert wrote: Jens Axboe wrote: On Mon, Jan 31 2005, Fabio Coatti wrote: Alle 09:00, lunedì 31 gennaio 2005, Jens Axboe ha scritto: At this point k3b is stuck in D stat, needs reboot. I

Re: [PATCH] scsi/sata write barrier support

2005-02-21 Thread Jens Axboe
On Mon, Feb 21 2005, Greg Stark wrote: Jens Axboe [EMAIL PROTECTED] writes: For the longest time, only the old PATA drivers supported barrier writes with journalled file systems. What about for fsync(2)? One of the most frequent sources of data loss on the postgres mailing list has

Re: [PATCH] scsi/sata write barrier support

2005-03-01 Thread Jens Axboe
On Tue, Feb 22 2005, Greg Stark wrote: Jens Axboe [EMAIL PROTECTED] writes: fsync has been working all along, since the initial barrier support for ide. only ext3 and reiserfs support it. Really? That's huge news. Since what kernel version(s) is that? Since 2.6.9. What about a non

Re: [PATCH] dc395x: Fix support for highmem

2005-03-15 Thread Jens Axboe
; + virt_array += DC395x_MAX_SG_LISTENTRY; + } + return 0; } - To unsubscribe from this list: send the line unsubscribe bk-commits-head in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jens Axboe - To unsubscribe from

Re: [PATCH] dc395x: Fix support for highmem

2005-03-16 Thread Jens Axboe
On Wed, Mar 16 2005, James Bottomley wrote: On Wed, 2005-03-16 at 08:58 +0100, Jens Axboe wrote: Guys, who reviewed this? It looks completely bogus, using kmap() for tha entire sg list is just wrong and can deadlock easily. The proper way is of course to skip the virtual address requirement

Re: [PATCH 2.6.11] ide-scsi: map sg buffers in idescsi_input/output_buffers() to kernel virtual address

2005-03-16 Thread Jens Axboe
to non-highmem pages. That would remove the need to add any work arounds in the driver. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dc395x: Fix support for highmem

2005-03-16 Thread Jens Axboe
On Wed, Mar 16 2005, Matthew Wilcox wrote: On Wed, Mar 16, 2005 at 05:04:47PM +0100, Jens Axboe wrote: The kmap() isn't just inefficient, it's a problem to iterate over the sg list and kmap all the pages. That is illegal. But it's not so tricky to get right, if the punting just happens

Re: [PATCH] dc395x: Fix support for highmem

2005-03-16 Thread Jens Axboe
On Wed, Mar 16 2005, Guennadi Liakhovetski wrote: Hi Thanks for reviewing this patch! On Wed, 16 Mar 2005, Jens Axboe wrote: On Wed, Mar 16 2005, James Bottomley wrote: ... I agree the kmap is inefficient. The efficient alternative is to do dma_map_sg() and use kmap_atomic

Re: [PATCH 2.6.11] ide-scsi: map sg buffers in idescsi_input/output_buffers() to kernel virtual address

2005-03-17 Thread Jens Axboe
On Wed, Mar 16 2005, [EMAIL PROTECTED] wrote: Jens Axboe wrote: On Wed, Mar 16 2005, [EMAIL PROTECTED] wrote: Hayes, Stuart wrote: This patch will map the sg buffers to kernel virtual memory space in the functions idescsi_input_buffers() and idescsi_output_buffers(). Without this patch

Re: [PATCH 2.6.11] ide-scsi: map sg buffers in idescsi_input/output_buffers() to kernel virtual address

2005-03-17 Thread Jens Axboe
On Thu, Mar 17 2005, [EMAIL PROTECTED] wrote: Jens Axboe wrote: On Wed, Mar 16 2005, [EMAIL PROTECTED] wrote: Jens Axboe wrote: On Wed, Mar 16 2005, [EMAIL PROTECTED] wrote: Hayes, Stuart wrote: This patch will map the sg buffers to kernel virtual memory space in the functions

Re: [PATCH 2.6.11] ide-scsi: map sg buffers in idescsi_input/output_buffers() to kernel virtual address

2005-03-17 Thread Jens Axboe
On Thu, Mar 17 2005, Jens Axboe wrote: On Thu, Mar 17 2005, [EMAIL PROTECTED] wrote: Jens Axboe wrote: On Wed, Mar 16 2005, [EMAIL PROTECTED] wrote: Jens Axboe wrote: On Wed, Mar 16 2005, [EMAIL PROTECTED] wrote: Hayes, Stuart wrote: This patch will map the sg buffers to kernel

Re: [PATCH 2.6.11] ide-scsi: map sg buffers in idescsi_input/output_buffers() to kernel virtual address

2005-03-18 Thread Jens Axboe
On Thu, Mar 17 2005, [EMAIL PROTECTED] wrote: Jens Axboe wrote: On Thu, Mar 17 2005, Jens Axboe wrote: On Thu, Mar 17 2005, [EMAIL PROTECTED] wrote: Jens Axboe wrote: On Wed, Mar 16 2005, [EMAIL PROTECTED] wrote: Jens Axboe wrote: On Wed, Mar 16 2005, [EMAIL PROTECTED] wrote: Hayes

queue - sdev reference counting problem

2005-03-18 Thread Jens Axboe
is to kill the sdev reference in the queue when the sdev is freed. On invocation of scsi_request_fn(), kill io to this device. Signed-off-by: Jens Axboe [EMAIL PROTECTED] = drivers/scsi/scsi_lib.c 1.151 vs edited = --- 1.151/drivers/scsi/scsi_lib.c 2005-02-17 20:17:22 +01:00 +++ edited

Re: [PATCH] dc395x: Fix support for highmem

2005-03-20 Thread Jens Axboe
On Sun, Mar 20 2005, Guennadi Liakhovetski wrote: On Sun, 20 Mar 2005, Christoph Hellwig wrote: On Wed, Mar 16, 2005 at 06:04:17PM +0100, Jens Axboe wrote: On Wed, Mar 16 2005, Christoph Hellwig wrote: On Wed, Mar 16, 2005 at 05:53:39PM +0100, Jens Axboe wrote: The list doesn't

Re: [PATCH] dc395x: Fix support for highmem

2005-03-21 Thread Jens Axboe
On Mon, Mar 21 2005, [EMAIL PROTECTED] wrote: On Mon, 21 Mar 2005, Jens Axboe wrote: On Sun, Mar 20 2005, Guennadi Liakhovetski wrote: char *kmap_atomic_sg(struct scatterlist *sg, unsigned int offset, int *mapped); void kunmap_atomic_sg(struct scatterlist *sg, int mapped

[PATCH] scsi_allocate_request() reference

2005-03-21 Thread Jens Axboe
Hi, scsi_allocate_request() doesn't hold a reference to the device that it points to, that is not good. This patch fixes that up. Signed-off-by: Jens Axboe [EMAIL PROTECTED] = drivers/scsi/scsi.c 1.157 vs edited = --- 1.157/drivers/scsi/scsi.c 2005-03-03 09:22:17 +01:00 +++ edited

Re: queue - sdev reference counting problem

2005-03-21 Thread Jens Axboe
On Fri, Mar 18 2005, Jens Axboe wrote: Hi, There is a problem with the way sdev is freed currently. The reason is really that there is a circular referencing problem: the sdev needs to hold on to the queue, but the queue (through the request function) also needs to hold on to the sdev

Re: queue - sdev reference counting problem

2005-03-21 Thread Jens Axboe
On Mon, Mar 21 2005, James Bottomley wrote: On Mon, 2005-03-21 at 15:59 +0100, Jens Axboe wrote: This is not even enough, since the queue lock is embedded in sdev structure. Guys, this is a serious issue. Oopsing a kernel is trivial with a hotplug device like a usb stick. Do you have

Re: [PATCH] scsi_allocate_request() reference

2005-03-21 Thread Jens Axboe
On Mon, Mar 21 2005, James Bottomley wrote: On Mon, 2005-03-21 at 14:26 +0100, Jens Axboe wrote: scsi_allocate_request() doesn't hold a reference to the device that it points to, that is not good. This patch fixes that up. Actually, I don't think this is correct. The reference is taken

Re: [PATCH] scsi_allocate_request() reference

2005-03-22 Thread Jens Axboe
On Tue, Mar 22 2005, Tejun Heo wrote: Hello, Jens. Hello, James. On Mon, Mar 21, 2005 at 05:57:52PM +0100, Jens Axboe wrote: On Mon, Mar 21 2005, James Bottomley wrote: On Mon, 2005-03-21 at 14:26 +0100, Jens Axboe wrote: scsi_allocate_request() doesn't hold a reference

Re: When how is the SCSI strategy routine called?

2005-03-23 Thread Jens Axboe
and it is the drivers responsibility to reinvoke the request handler. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH scsi-misc-2.6 08/08] scsi: fix hot unplug sequence

2005-03-23 Thread Jens Axboe
On Wed, Mar 23 2005, James Bottomley wrote: On Wed, 2005-03-23 at 08:19 +0100, Jens Axboe wrote: It is not the oops I am getting. When I get a few minutes today, I'll reproduce with vanilla and post it here. Well, I have news too. Unfortunately, the python script I posted is hanging in D

Re: [PATCH scsi-misc-2.6 01/08] scsi: remove unused bounce-buffer release path

2005-03-23 Thread Jens Axboe
to be bounced in the scsi layer for isa host adapters. I bet that is still true. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-03-29 Thread Jens Axboe
On Tue, Mar 29 2005, Chris Rankin wrote: (please don't top post) --- Jens Axboe [EMAIL PROTECTED] wrote: On Sun, Mar 27 2005, Chris Rankin wrote: [gcc-3.4.3, Linux-2.6.11-SMP, Dual P4 Xeon with HT enabled] Hi, My Linux 2.6.11 box oopsed when I tried to logout. I have switched

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-03-29 Thread Jens Axboe
On Tue, Mar 29 2005, Chris Rankin wrote: I have one IDE hard disc, but I was using a USB memory stick at one point. (Notice the usb-storage and vfat modules in my list.) Could that be the troublesome SCSI device? --- Jens Axboe [EMAIL PROTECTED] wrote: Yes, it probably is. What

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-04-06 Thread Jens Axboe
On Tue, Mar 29 2005, Jens Axboe wrote: On Tue, Mar 29 2005, Chris Rankin wrote: I have one IDE hard disc, but I was using a USB memory stick at one point. (Notice the usb-storage and vfat modules in my list.) Could that be the troublesome SCSI device? --- Jens Axboe [EMAIL

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-04-06 Thread Jens Axboe
On Wed, Apr 06 2005, James Bottomley wrote: On Tue, 2005-03-29 at 14:03 +0200, Jens Axboe wrote: It is quite a serious problem, not just for CFQ. SCSI referencing is badly broken there. OK ... I accept that with regard to the queue lock. It is much deeper than that. The recent hack

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-04-06 Thread Jens Axboe
On Wed, Apr 06 2005, Tejun Heo wrote: Jens Axboe wrote: On Wed, Apr 06 2005, Arjan van de Ven wrote: @@ -324,6 +334,7 @@ issue_flush_fn *issue_flush_fn; prepare_flush_fn*prepare_flush_fn; end_flush_fn*end_flush_fn; + release_queue_data_fn

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-04-06 Thread Jens Axboe
On Wed, Apr 06 2005, James Bottomley wrote: On Wed, 2005-04-06 at 19:58 +0200, Jens Axboe wrote: I rather like the queue lock being a pointer, so you can share at whatever level you want. Lets not grow the request_queue a full lock just to work around a bug elsewhere. I'm not proposing

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-04-07 Thread Jens Axboe
On Wed, Apr 06 2005, James Bottomley wrote: On Wed, 2005-04-06 at 21:08 +0200, Jens Axboe wrote: I think the correct model for all of this is that the block driver shouldn't care (or be tied to) the scsi one. Thus, as long as SCSI can reject requests from a queue whose device has been

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-04-07 Thread Jens Axboe
On Thu, Apr 07 2005, James Bottomley wrote: On Thu, 2005-04-07 at 08:49 +0200, Jens Axboe wrote: On Wed, Apr 06 2005, James Bottomley wrote: My proposal is to correct this by moving the data back to the correct object, and make any object using it hold a reference, so this would make

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-04-07 Thread Jens Axboe
On Thu, Apr 07 2005, James Bottomley wrote: On Thu, 2005-04-07 at 15:32 +0200, Jens Axboe wrote: I think Christophs point is that why add sdev_lock as a pointer, instead of just killing it? It's only used in one location, so it's not really that confusing (and a comment could fix

Re: Regarding posted scsi midlyaer patchsets

2005-04-19 Thread Jens Axboe
the io schedulers don't have to do anything specific to handle it. I have no problem with removing the requeue stuff from blk_insert_request(). That function is horribly weird as it is, it is supposed to look generic but is really just a scsi special case. -- Jens Axboe - To unsubscribe from

Re: Regarding posted scsi midlyaer patchsets

2005-04-19 Thread Jens Axboe
On Tue, Apr 19 2005, James Bottomley wrote: On Tue, 2005-04-19 at 14:34 +0200, Jens Axboe wrote: On Mon, Apr 18 2005, Tejun Heo wrote: And, James, regarding REQ_SOFTBARRIER, if the REQ_SOFTBARRIER thing can be removed from SCSI midlayer, do you agree to change REQ_SPECIAL to mean

Re: Regarding posted scsi midlyaer patchsets

2005-04-19 Thread Jens Axboe
On Tue, Apr 19 2005, Jens Axboe wrote: On Tue, Apr 19 2005, James Bottomley wrote: On Tue, 2005-04-19 at 14:34 +0200, Jens Axboe wrote: On Mon, Apr 18 2005, Tejun Heo wrote: And, James, regarding REQ_SOFTBARRIER, if the REQ_SOFTBARRIER thing can be removed from SCSI midlayer, do you

Re: [PATCH scsi-misc-2.6 01/05] scsi: make blk layer set REQ_SOFTBARRIER when a request is dispatched

2005-04-20 Thread Jens Axboe
-last_merge) q-last_merge = NULL; Do it on requeue, please - not on the initial spotting of the request. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH scsi-misc-2.6 01/05] scsi: make blk layer set REQ_SOFTBARRIER when a request is dispatched

2005-04-20 Thread Jens Axboe
On Wed, Apr 20 2005, Tejun Heo wrote: Nick Piggin wrote: On Wed, 2005-04-20 at 16:40 +0900, Tejun Heo wrote: Hello, Jens. On Wed, Apr 20, 2005 at 08:30:10AM +0200, Jens Axboe wrote: Do it on requeue, please - not on the initial spotting of the request. This is the reworked

Re: [PATCH scsi-misc-2.6 01/05] scsi: make blk layer set REQ_SOFTBARRIER when a request is dispatched

2005-04-20 Thread Jens Axboe
, please detail exactly what behaviour you want documented :) -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH scsi-misc-2.6 01/05] scsi: make blk layer set REQ_SOFTBARRIER when a request is dispatched

2005-04-20 Thread Jens Axboe
On Wed, Apr 20 2005, Nick Piggin wrote: Jens Axboe wrote: On Wed, Apr 20 2005, Nick Piggin wrote: I guess this could be one use of 'reordering' after a requeue. Yeah, or perhaps the io scheduler might determine that a request has higher prio than a requeued one. I'm not sure what

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-21 Thread Jens Axboe
this request, only to call scsi_run_queue() - blk_run_queue() - issue same request. If the point really is to reissue the request immediately, I can think of many ways more efficient than this :-) -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH] dc395x: Fix support for highmem

2005-04-22 Thread Jens Axboe
(virt_to_page(virt), KM_BIO_SRC_IRQ); +} Please remember to test this with highmem debug. The above is buggy, kunmap_atomic() takes the mapped pointer, not the page structure. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-22 Thread Jens Axboe
On Thu, Apr 21 2005, James Bottomley wrote: On Thu, 2005-04-21 at 08:10 +0200, Jens Axboe wrote: I wondered about this action recently myself. What is the point in requeueing this request, only to call scsi_run_queue() - blk_run_queue() - issue same request. If the point really

Re: [RFC][PATCH] libata ATAPI alignment

2005-08-02 Thread Jens Axboe
* 32, Reasoning? I agree, just wondering... How big is the allocated area now? -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] allow bio code to unmap sg io requests and have blk_execute_rq_nowait bounce bios

2005-08-02 Thread Jens Axboe
); extern int blk_execute_rq(request_queue_t *, struct gendisk *, -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] allow bio code to unmap sg io requests and have blk_execute_rq_nowait bounce bios

2005-08-02 Thread Jens Axboe
they are or should be done in a more generic way? Right, that was never the intention of the bio. To have the kind of 'support' for generic commands in struct bio that we have in struct request, would easily double or tripple its size. -- Jens Axboe - To unsubscribe from this list: send the line

Re: calling scsi_adjust_queue_depth() during I/O...

2005-08-05 Thread Jens Axboe
- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

Re: calling scsi_adjust_queue_depth() during I/O...

2005-08-05 Thread Jens Axboe
know if anything else comes up. Looks good so far. Thanks for fixing it so quickly, Tejun! I'll be on vacation next week, can you make sure it gets to Andrew? -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] block,scsi: verify return pointer from blk_get_request

2013-03-17 Thread Jens Axboe
for this, as it has nothing to do with running out of memory. Would probably be best to return the correct error pointer from blk_get_request(), as you would otherwise have to assume this knowledge in the callers. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH RESEND v11 0/4] block layer runtime pm

2013-03-22 Thread Jens Axboe
perspective. Can you re-shuffle the REQ_PM change, just do a separate patch for that. I'll get it queued up for 3.10 then. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v12 0/5] block layer runtime pm

2013-03-22 Thread Jens Axboe
in SCSI layer, suggested by Jens Axboe. Thanks Aaron, I've applied 1, and 3-4. I'll leave 2 and 5 for James to pickup. James, if you want me to carry them, just let me know. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [PATCH] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-03-25 Thread Jens Axboe
allocation I have added the signers to cc. I can resend the patch if it is necessary Can you resend the patch? The above is mangled for me. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH RESEND v2] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-03-25 Thread Jens Axboe
fall through with this patch, we bump bi_phys_segments even if the segments are physicall contig and mergeable. What happens when the segment is physically mergeable, but the resulting merged segment is too large (bigger than q-limits.max_segment_size)? -- Jens Axboe -- To unsubscribe from

Re: [PATCH RESEND v2] block: modify __bio_add_page check to accept pages that don't start a new segment

2013-03-25 Thread Jens Axboe
On Mon, Mar 25 2013, Jan Vesely wrote: 51506edc5741209311913 On Mon 25 Mar 2013 15:24:57 CET, Jens Axboe wrote: On Mon, Mar 25 2013, Jan Vesely wrote: v2: changed a comment The original behavior was to refuse all pages after the maximum number of segments has been reached. However

Re: WARNING: at drivers/scsi/scsi_lib.c:1196 scsi_setup_fs_cmnd during RAID5 startup.

2013-06-12 Thread Jens Axboe
waited for a long time Jens? Sorry, travel ended up getting in the way. Will ship it out today. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

2013-06-24 Thread Jens Axboe
) or it needs to be nicer in when it gives up and goes back to irq driven IO. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

2013-06-24 Thread Jens Axboe
wants to give up those 5us of work time just spinning on the completion of important IO. You obviously can't steal the time of others. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

2013-06-25 Thread Jens Axboe
. Which is why I like the polling. If we can get sufficiently close, then we can shut some of that up. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [Ksummit-2013-discuss] [ATTEND] scsi-mq prototype discussion

2013-07-16 Thread Jens Axboe
, 2013 at 05:23:32PM -0700, Nicholas A. Bellinger wrote: Drilling down the work items ahead of a real mainline push is high on priority list for discussion. The parties to be included in such a discussion are: - Jens Axboe (blk-mq author) - James Bottomley (scsi

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-18 Thread Jens Axboe
() for this. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-18 Thread Jens Axboe
that it gets bounced properly... blk_mq_execute_rq() assumes a fully complete request, so it wont bounce anything. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-20 Thread Jens Axboe
the non mq code and has the block layer free the bios. Thanks Mike, looks good, applied. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Ksummit-2013-discuss] [ATTEND] scsi-mq prototype discussion

2013-07-22 Thread Jens Axboe
On Fri, Jul 19 2013, Ric Wheeler wrote: down the work items ahead of a real mainline push is high on priority list for discussion. The parties to be included in such a discussion are: - Jens Axboe (blk-mq author) - James Bottomley (scsi maintainer) - Christoph Hellwig (scsi

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-25 Thread Jens Axboe
eliminated from I/O fast path. Nice! -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-29 Thread Jens Axboe
, the bitmap should definitely go. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-29 Thread Jens Axboe
there is support for reserving X number of error handling / emergency tags. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Jens Axboe
) { + kfree(ap); + return NULL; + } This should be blk_mq_init_tags(ATA_MAX_QUEUE - 1, 1, ...) since the total depth is normal_tags + reserved_tags. Apart from that, I think it looks alright based on a cursory look. -- Jens Axboe -- To unsubscribe from this list: send the line

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Jens Axboe
On 08/09/2013 09:07 AM, Alexander Gordeev wrote: On Fri, Aug 09, 2013 at 08:24:38AM -0600, Jens Axboe wrote: On 08/09/2013 02:23 AM, Alexander Gordeev wrote: + ap-qc_tags = blk_mq_init_tags(ATA_MAX_QUEUE, 1, NUMA_NO_NODE); + if (!ap-qc_tags) { + kfree(ap); + return

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Jens Axboe
On 08/09/2013 10:46 AM, Alexander Gordeev wrote: On Fri, Aug 09, 2013 at 09:52:19AM -0600, Jens Axboe wrote: On 08/09/2013 09:07 AM, Alexander Gordeev wrote: diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index dcbc2a4..b131a48 100644 --- a/block/blk-mq-tag.c +++ b/block/blk-mq-tag.c

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-06-06 Thread Jens Axboe
=f6be4fb4bcb396fc3b1c134b7863351972de081f since I ran into the same thing on nvme. Either approach is fine with me, as they both allow override of the timeout before insertion. But we've always done the rq-timeout = 0 init, so I think we should just reinstate that behavior. -- Jens Axboe -- To unsubscribe from

Re: scsi-mq

2014-06-17 Thread Jens Axboe
, and no ill effects seen. On top of that, Christophs patches are nicely separated and have general benefits even for the non-blk-mq cases. Time to shove them into the queue for the next merge window? -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: BUG: scheduling while atomic in blk_mq codepath?

2014-06-19 Thread Jens Axboe
. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: scsi-mq V2

2014-06-25 Thread Jens Axboe
scheduling a workqueue on I/O completions when no queues are congested In addition to the patches in this thread there also is a git available at: git://git.infradead.org/users/hch/scsi.git scsi-mq.2 You can add my acked/reviewed-by to the series. -- Jens Axboe -- To unsubscribe from

Re: scsi-mq V2

2014-06-30 Thread Jens Axboe
On 06/25/2014 10:50 PM, Jens Axboe wrote: On 2014-06-25 10:51, Christoph Hellwig wrote: This is the second post of the scsi-mq series. At this point the code is ready for merging and use by developers and early adopters. The core blk-mq code isn't that suitable for slow devices yet, mostly

Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|

2014-07-08 Thread Jens Axboe
to another report and added Jens to the Cc list. As the block maintainer he need to review and merge it. Which patch is this? -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|

2014-07-08 Thread Jens Axboe
On 2014-07-08 11:56, Christoph Hellwig wrote: On Tue, Jul 08, 2014 at 11:54:14AM +0200, Jens Axboe wrote: I've posted the patch in reply to another report and added Jens to the Cc list. As the block maintainer he need to review and merge it. Which patch is this? This one: --- From

Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|

2014-07-08 Thread Jens Axboe
On 2014-07-08 13:25, Hans de Goede wrote: Hi, On 07/08/2014 12:35 PM, Jens Axboe wrote: On 2014-07-08 11:56, Christoph Hellwig wrote: On Tue, Jul 08, 2014 at 11:54:14AM +0200, Jens Axboe wrote: I've posted the patch in reply to another report and added Jens to the Cc list. As the block

Re: scsi-mq V2

2014-07-09 Thread Jens Axboe
(in that order) and see if that changes anything. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: scsi-mq V2

2014-07-10 Thread Jens Axboe
a good enough understanding of other aio use cases to say that this isn't the norm? I would expect it to be, it's the way that the API would most obviously be used. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: scsi-mq V2

2014-07-10 Thread Jens Axboe
On 2014-07-10 15:44, Benjamin LaHaise wrote: On Thu, Jul 10, 2014 at 03:39:57PM +0200, Jens Axboe wrote: That's how fio always runs, it sets up the context with the exact queue depth that it needs. Do we have a good enough understanding of other aio use cases to say that this isn't the norm? I

Re: scsi-mq V2

2014-07-10 Thread Jens Axboe
need to look elsewhere for the culprit. Rob, let me know what scsi_debug setup you use, and I can try and reproduce it here as well. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: scsi-mq V2

2014-07-10 Thread Jens Axboe
On 2014-07-10 15:50, Benjamin LaHaise wrote: On Thu, Jul 10, 2014 at 03:48:10PM +0200, Jens Axboe wrote: On 2014-07-10 15:44, Benjamin LaHaise wrote: On Thu, Jul 10, 2014 at 03:39:57PM +0200, Jens Axboe wrote: That's how fio always runs, it sets up the context with the exact queue depth

Re: scsi-mq V2

2014-07-10 Thread Jens Axboe
(and broken) user ring. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: scsi-mq V2

2014-07-10 Thread Jens Axboe
On 2014-07-10 22:05, Jeff Moyer wrote: Jens Axboe ax...@kernel.dk writes: On 2014-07-10 17:11, Jeff Moyer wrote: Benjamin LaHaise b...@kvack.org writes: [ 186.339064] ioctx_alloc: nr_events=-2 aio_max_nr=65536 [ 186.339065] ioctx_alloc: nr_events=-2 aio_max_nr=65536 [ 186.339067

Re: uas: kernel BUG at block/blk-tag.c:89 is back again :|

2014-07-21 Thread Jens Axboe
On 2014-07-21 10:15, Hans de Goede wrote: Hi, On 07/08/2014 01:25 PM, Hans de Goede wrote: Hi, On 07/08/2014 12:35 PM, Jens Axboe wrote: On 2014-07-08 11:56, Christoph Hellwig wrote: On Tue, Jul 08, 2014 at 11:54:14AM +0200, Jens Axboe wrote: I've posted the patch in reply to another

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-11 Thread Jens Axboe
to '!atomic_read(sdev-device_busy)' fixes the problem. Cc: Christoph Hellwig h...@lst.de Cc: Hannes Reinecke h...@suse.de Cc: Webb Scales web...@hp.com Cc: Jens Axboe ax...@kernel.dk Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/scsi/scsi_lib.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-15 Thread Jens Axboe
On 2014-08-15 12:22, Guenter Roeck wrote: ping ... the problem fixed by this patch still affects the upstream kernel (v3.16-11383-gc9d2642) as well as -next (20140815). James, could you upstream this one in time for -rc1? -- Jens Axboe -- To unsubscribe from this list: send the line

Re: Block/SCSI data integrity update v3

2014-09-08 Thread Jens Axboe
On 09/07/2014 10:29 AM, Christoph Hellwig wrote: On Thu, Aug 28, 2014 at 02:10:49PM -0600, Jens Axboe wrote: On 08/28/2014 01:31 PM, Martin K. Petersen wrote: This is the data integrity patch series originally submitted for 3.16 and 3.17. It has been rebased on top of block/for-3.18/core

Re: [PATCH 0/6] blk-mq: initialize pdu of flush req explicitly

2014-09-08 Thread Jens Axboe
into hctx, I will try to figure out one patch to do that. I had not thought of that, but seems like a great way to clean this up a lot. It just never felt like the right thing to do. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

Re: [PATCH 5/8] block: introduce blk_flush_queue to drive flush machinery

2014-09-09 Thread Jens Axboe
to blk_alloc_flush_queue() and blk_free_flush_queue(). -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: lk 3.17-rc4 blk_mq large write problems

2014-09-10 Thread Jens Axboe
, please don't mix up the REQ_END and -queue_rq() changes with the changed start_request API. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: lk 3.17-rc4 blk_mq large write problems

2014-09-10 Thread Jens Axboe
On 09/10/2014 12:09 PM, Christoph Hellwig wrote: On Wed, Sep 10, 2014 at 10:47:49AM -0600, Jens Axboe wrote: BTW, please don't mix up the REQ_END and -queue_rq() changes with the changed start_request API. I have to. It's set by start_request, so we need to pass down the last argument

Re: lk 3.17-rc4 blk_mq large write problems

2014-09-10 Thread Jens Axboe
On 09/10/2014 12:40 PM, Christoph Hellwig wrote: On Wed, Sep 10, 2014 at 12:26:57PM -0600, Jens Axboe wrote: I have to. It's set by start_request, so we need to pass down the last argument to keep the old behavior. And once we pass the argument we can just it directly. It could still

Re: lk 3.17-rc4 blk_mq large write problems

2014-09-10 Thread Jens Axboe
scsi_log_completion-0x4 28cc:83 bd 54 01 00 00 ff cmpl $0x,0x154(%rbp) This would be more useful if you had DEBUGINFO enabled. At least it would save use some time :-) -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

  1   2   3   4   5   6   7   >