On Fri, 2016-11-18 at 08:32 +0100, Hannes Reinecke wrote:
> Older SmartArray controller do not support the extended REPORT PHYS
> command, so fallback to use the legacy version here.
>
> Signed-off-by: Hannes Reinecke <h...@suse.com>
Tested-by: Martin Wilck <mwi...@suse.c
#1010946
Signed-off-by: Martin Wilck <mwi...@suse.de>
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 8ec77c3..f23f680 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9020,6 +9020,7 @@ stati
This patch set fixes two issues I encountered when removing the
hpsa modules with rmmod.
Comments and reviews are welcome.
Martin Wilck (2):
hpsa: cleanup sas_phy structures in sysfs when unloading
hpsa: destroy sas transport properties before scsi_host
drivers/scsi/hpsa.c | 4 ++--
1 file
-off-by: Martin Wilck <mwi...@suse.de>
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index efe2f36..8ec77c3 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -9547,9 +9547,9 @@ stati
On Mon, 2016-11-21 at 15:13 +0100, Johannes Thumshirn wrote:
> On Mon, Nov 21, 2016 at 03:04:28PM +0100, Martin Wilck wrote:
> > When the hpsa module is unloaded using rmmod, dangling
> > symlinks remain under /sys/class/sas_phy. Fix this by
> > calling sas_phy_delete() rat
Hi Don,
On Tue, 2016-11-29 at 01:52 +, Don Brace wrote:
> > -Original Message-
> > From: Martin Wilck [mailto:mwi...@suse.de]
> > Sent: Monday, November 21, 2016 8:04 AM
> > To: Don Brace
> > Cc: dl-esc-Team ESD Storage Dev Support; iss_stora
On Thu, 2016-12-01 at 23:22 +, Don Brace wrote:
> > -Original Message-
> > From: Martin Wilck [mailto:mwi...@suse.de]
> > Sent: Monday, November 21, 2016 8:04 AM
> > To: Don Brace
> > Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com;
>
ctlr_work;
> struct delayed_work rescan_ctlr_work;
> + struct delayed_work event_monitor_work;
> int remove_in_progress;
> /* Address of h->q[x] is passed to intr handler to know
> which queue */
> u8 q[MAX_REPLY_QUEUES];
The new worker thread duplicates code from hpsa_rescan_ctlr_worker. I
find this a bit irritating. Could you maybe use just a single worker,
and just check using time stamps whether the "big" heartbeat needs to
be performed?
Regards
Martin
--
Dr. Martin Wilck <mwi...@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
ockup_detected(h))
> - return FAILED;
> + h->reset_in_progress = 1;
> +
> + if (lockup_detected(h)) {
> + rc = FAILED;
> + goto return_reset_status;
> + }
if this is meant to communicate host state to other threads, maybe you
shoul
/scsi-fixes but not in mkp/4.12/scsi-queue.
Is there a specific reason for that?
Best regards
Martin W
--
Dr. Martin Wilck <mwi...@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
On Fri, 2017-04-28 at 18:35 +, Bart Van Assche wrote:
> On Fri, 2017-04-28 at 15:06 +0200, Martin Wilck wrote:
> > @@ -886,7 +883,7 @@ static bool alua_rtpg_queue(struct
> > alua_port_group *pg,
> > force = true;
> > }
> > if (pg->rtp
Hi Bart,
On Fri, 2017-04-28 at 18:42 +, Bart Van Assche wrote:
> On Fri, 2017-04-28 at 15:06 +0200, Martin Wilck wrote:
> > From: Hannes Reinecke <h...@suse.de>
> >
> > If a device becomes unmapped on the target we should be returning
> > SCSI_DH_DEV_OFFLINE
From: Hannes Reinecke <h...@suse.de>
We shouldn't modify the interval value, as the struct is accessed
from different devices and hence we might end up scheduling too
early.
Signed-off-by: Hannes Reinecke <h...@suse.com>
Reviewed-by: Martin Wilck <mwi...@suse.com>
Here are 3 fixes we came up with at SUSE to fix problems we encountered
in multipath failover tests. Feedback welcome.
Best regards,
Martin
Hannes Reinecke (2):
scsi_dh_alua: Do not modify the interval value for retries
scsi_dh_alua: Do not retry for unmapped device
Martin Wilck (1
out
but continue silently.
Signed-off-by: Martin Wilck <mwi...@suse.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c
From: Hannes Reinecke <h...@suse.de>
If a device becomes unmapped on the target we should be returning
SCSI_DH_DEV_OFFLINED.
Signed-off-by: Hannes Reinecke <h...@suse.com>
Reviewed-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 9 ++---
ps whether the "big" heartbeat needs
> > to
> > be performed?
> >
> > Regards
> > Martin
> >
> > --
> > Dr. Martin Wilck <mwi...@suse.com>, Tel. +49 (0)911 74053 2107
> > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
> >
On Mon, 2017-05-15 at 16:03 +, Bart Van Assche wrote:
> On Mon, 2017-05-15 at 10:16 +0200, Martin Wilck wrote:
> > On Fri, 2017-05-12 at 16:24 +, Bart Van Assche wrote:
> > > Allowing races like the one this patch tries to address to exist
> > > makes the ALUA c
out
but continue silently.
Signed-off-by: Martin Wilck <mwi...@suse.com>
Reviewed-by: Hannes Reinecke <h...@suse.com>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/device_handler/sc
Modification of the access_state field in struct scsi_device
in alua_rtpg() may race with alua_bus_detach(). Avoid
the scsi_device struct to be freed while it's being processed
in the alua code by taking a reference.
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/device_h
l replace it with a contant expression.
Signed-off-by: Hannes Reinecke <h...@suse.com>
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi
- Protect against sdev being released, as suggested by Bart (added patch 4/4)
Hannes Reinecke (2):
scsi_dh_alua: Do not modify the interval value for retries
scsi_dh_alua: Do not retry for unmapped device
Martin Wilck (2):
scsi_dh_alua: do not call BUG_ON when updating port group
scsi_dh_alua
From: Hannes Reinecke <h...@suse.de>
If a device becomes unmapped on the target we should be returning
SCSI_DH_DEV_OFFLINED.
Signed-off-by: Hannes Reinecke <h...@suse.com>
Reviewed-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 9 ++---
r the BUG() (i.e. patch 3/4) applied in the first place?
AFAICS it would not conflict with a solution like the one you
suggested.
Best regards and thanks for the review,
Martin
--
Dr. Martin Wilck <mwi...@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
kept around
> for now.
Could you explain why you remove the option entirely rather than just
changing the default? Some distributions may wish to keep the ability
to choose the compiled-in default.
Regards,
Martin
--
Dr. Martin Wilck <mwi...@suse.com>, Tel. +49 (0)911 74053 2107
SUSE
Hi Bart,
On Mon, 2017-06-26 at 15:31 +, Bart Van Assche wrote:
> On Mon, 2017-06-26 at 12:13 +, Bart Van Assche wrote:
> > On Thu, 2017-06-22 at 17:05 +0200, Martin Wilck wrote:
> > > On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote:
> > > > Rem
k_irqsave(shost->host_lock, flags);
> }
> }
> spin_unlock_irqrestore(shost->host_lock, flags);
I believe this is fixed in SLES12-SP1 kernel 3.12.53-60.30.1, with the
following patch:
* Mon Jan 18 2016 jthumsh...@suse.de
- scsi: restart list search after unlock in scsi_remove_target
(bsc#944749, bsc#959257).
- Delete
patches.fixes/0001-SCSI-Fix-hard-lockup-in-scsi_remove_target.patch.
- commit 2490876
Regards,
Martin
--
Dr. Martin Wilck <mwi...@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
On Tue, 2017-10-10 at 23:04 +, Don Brace wrote:
> Now that Hannes's patch 9441284fbc39610c0f9ec0ed118ff85d78352906
> has been applied, this patch corrects the stack trace issue.
>
> Would you like to re-submit this patch or would you like me to send
> it up?
> I'll run some quick tests if
ill
not automatically increase the sw limit, but IMO that's actually
expected.
Best Regards,
Martin
--
Dr. Martin Wilck <mwi...@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
d-off-by: Martin K. Petersen <martin.peter...@oracle.com>
This looks good to me. I agree that it's superior to the original
suggestion, because it sets the soft limit to the hard limit when the
device is scanned for the first time.
Regards
Martin
--
Dr. Martin Wilck <mwi...@suse.com>,
ather than a path
property.
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_error.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 38942050b265..dab876c65473 100644
--- a/drivers/scsi/scsi_error
devinfo->vendor and devinfo->model aren't necessarily
zero-terminated.
Fixes: b8018b973c7c "scsi_devinfo: fixup string compare"
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_devinfo.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
dif
e in the SUSE kernel).
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_devinfo.c | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index d6db5697472e..6e784a09b21a 1006
The modification of fc_lport_recv_els_req() in commit fcabb09e59a7
(merged in 4.12-rc1) caused certain requests not to be handled at all.
Fix that.
Fixes: fcabb09e59a7 "scsi: libfc: directly call ELS request handlers"
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
dr
> this value as retry delay time.
>
> Cc:
> Signed-off-by: Anil Gurumurthy
> Signed-off-by: Giridhar Malavali
> Signed-off-by: Himanshu Madhani
Tested successfully by SUSE customers.
Acked-by: Martin Wilck
--
Dr. Martin Wilck , Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
d version I think I caught them all).
Regards,
Martin
--
Dr. Martin Wilck <mwi...@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
the "maybe_retry" logic in scsi_decide_disposition); otherwise dm-multipath
might initiate a failover from a healthy path e.g. for REQ_FAILFAST_DEV
commands.
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_error.c | 10 ++
1 file changed, 10 insertion
11) &&
>
> Blacklist, please.
>
To make sure I understand correctly:
You'd like to spend a precious BLIST bit for this single device which
uses vendor-specific ASC/Q?
Regards,
Martin
--
Dr. Martin Wilck <mwi...@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
If every_nth > 0, the injection flags must be reset for commands
that aren't supposed to fail (i.e. that aren't "nth"). Otherwise,
commands will continue to fail, like in the every_nth < 0 case.
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_debug
internal target error" (Hannes Reinecke)
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_devinfo.c | 4 ++-
drivers/scsi/scsi_error.c | 82 +
include/scsi/scsi_devinfo.h | 6
3 files changed, 91 insertions(+)
If every_nth > 0, the injection flags must be reset for commands
that aren't supposed to fail (i.e. that aren't "nth"). Otherwise,
commands will continue to fail, like in the every_nth < 0 case.
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_debug
On Mon, 2018-01-29 at 23:39 +, Bart Van Assche wrote:
> On Tue, 2018-01-30 at 00:30 +0100, Martin Wilck wrote:
> > + static struct aborted_cmd_blist blist[] = {
>
> Please consider to declare this array const.
That doesn't work because I want to store the "warned"
- use ARRAY_SIZE (Bart van Assche)
- make blist array static const and use separate bitmask for warned flag
(Bart van Assche)
- Fix string comparison for SCSI vendor and model
- Print warning at scsi_logging_level 0, and improve message formatting
Signed-off-by: Martin Wilck <mwi...@suse.c
IMMED case - instead of
falling through to the "respond_in_thread" label immediately, the command will
be put in the work queue with zero delay.
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_debug.c | 53 +--
1 fil
Gentle reminder - reviews welcome ...
On Tue, 2018-01-30 at 11:25 +0100, Martin Wilck wrote:
> Introduce a new blist flag that indicates the device may return
> certain
> sense code/ASC/ASCQ combinations that indicate different treatment
> than
> normal. In particular, so
On Wed, 2018-09-05 at 15:53 +0200, Hannes Reinecke wrote:
> test_bit() is atomic, test_bit() || test_bit() is not.
> So protect consecutive bit tests with a lock to avoid races.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/qedf/qedf_els.c | 9 +++--
>
On Thu, 2018-09-06 at 09:03 +0200, Hannes Reinecke wrote:
> On 09/05/2018 04:09 PM, Martin Wilck wrote:
> > On Wed, 2018-09-05 at 15:53 +0200, Hannes Reinecke wrote:
> > > test_bit() is atomic, test_bit() || test_bit() is not.
> > > So protect consecutive bit tests
On Tue, 2018-04-17 at 17:07 -0700, Linus Torvalds wrote:
> On Tue, Apr 17, 2018 at 4:35 PM, Martin Wilck <mwi...@suse.com>
> wrote:
> > Sparse emits errors about ilog2() in array indices because of the
> > use of
> > __ilog2_32() and __ilog2_64(),
>
> If sparse
parentheses, but that appears
to be a false positive. I can get rid of the warning simply by inserting
whitespace, making checkpatch "see" the whole macro).
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
include/linux/log2.h | 35 ---
1 file change
the length of
blist_flag_t to 64 bit, and used previously unused bits. I also added checking
for obsolete and unused bits.
For the blist_flag_t size increase, I used sparse to try and avoid regressions;
that necessitated fixing sparse's errors for the current code first.
Martin Wilck (6):
ilo
Space for SCSI blist flags is gradually running out. Change the
type to __u64. And fix a checkpatch complaint about symbolic
mode flags in scsi_devinfo.c.
Make checkpatch happy by replacing simple_strtoul() with kstrtoull().
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
driver
Warn if a device (or the user) sets blist flags which are unknown
or have been removed. This should enable us to reuse freed blist
bits in later releases.
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/Makefile | 2 +-
drivers/scsi/scsi_devinfo.c | 6 ++
includ
the "maybe_retry" logic in scsi_decide_disposition); otherwise dm-multipath
might initiate a failover from a healthy path e.g. for REQ_FAILFAST_DEV
commands.
Introduce a new blist flag for this case.
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_devinfo.c | 1
Use the just introduced const_ilog2() macro to avoid sparse
errors.
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_debugfs.c | 2 +-
drivers/scsi/scsi_sysfs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_debugfs.c b/driver
EMC Symmetrix returns 'internal target error' for a variety
of conditions, most of which will be transient.
So we should always retry it, even with failfast set.
Otherwise we'd get spurious path flaps with multipath.
Signed-off-by: Martin Wilck <mwi...@suse.com>
---
drivers/scsi/scsi_dev
By scanning for LUN 0 only, we may encounter a device that the
kernel won't add (e.g. peripheral device type 31) and which may
thus never appear in sysfs for us to use for REPORT LUNS. That
causes LUN additions for such devices to be missed by
"rescan-iscsi-bus.sh -a".
Signed-off-by: Ma
On Thu, 2018-10-25 at 10:49 +0200, Martin Wilck wrote:
> By scanning for LUN 0 only, we may encounter a device that the
> kernel won't add (e.g. peripheral device type 31) and which may
> thus never appear in sysfs for us to use for REPORT LUNS. That
> causes LUN additions for
emory allocation error during driver start-up
on power8"
Tested-by: David Bond
Signed-off-by: Martin Wilck
Cc: sta...@vger.kernel.org # 4.17.x
Cc: sta...@vger.kernel.org # 4.18.x
Cc: sta...@vger.kernel.org # 4.19.x
---
drivers/scsi/lpfc/lpfc_init.c | 6 +-
drivers/scsi/lpfc/lpfc_sli.c
58 matches
Mail list logo
