Re: [PATCH] scsi: default to scsi-mq

2017-07-18 Thread Jonathan Cameron
On Tue, 18 Jul 2017 23:58:03 +0800 Jonathan Cameron wrote: > On Fri, 14 Jul 2017 14:45:39 +0200 > "h...@lst.de" wrote: > > > On Fri, Jul 14, 2017 at 05:56:41PM +0800, Jonathan Cameron wrote: > > > Just wondering if you had any thoughts on how we can

Re: [PATCH] scsi: default to scsi-mq

2017-07-18 Thread Jonathan Cameron
On Fri, 14 Jul 2017 14:45:39 +0200 "h...@lst.de" wrote: > On Fri, Jul 14, 2017 at 05:56:41PM +0800, Jonathan Cameron wrote: > > Just wondering if you had any thoughts on how we can proceed with tracking > > down this regression? > > > > I'm not familiar enough with the multiqueue

Re: [PATCH] scsi: default to scsi-mq

2017-07-14 Thread h...@lst.de
On Fri, Jul 14, 2017 at 05:56:41PM +0800, Jonathan Cameron wrote: > Just wondering if you had any thoughts on how we can proceed with tracking > down this regression? > > I'm not familiar enough with the multiqueue code to really know where > to start. > > If there are any other tests that would

Re: [PATCH] scsi: default to scsi-mq

2017-07-14 Thread Jonathan Cameron
On Wed, 12 Jul 2017 23:54:01 +0800 Jonathan Cameron wrote: > On Wed, 12 Jul 2017 14:18:14 + > Bart Van Assche wrote: > > > On Wed, 2017-07-12 at 09:26 +0100, John Garry wrote: > > > > > What block driver controls the block device for

Re: [PATCH] scsi: default to scsi-mq

2017-07-12 Thread Jonathan Cameron
On Wed, 12 Jul 2017 14:18:14 + Bart Van Assche wrote: > On Wed, 2017-07-12 at 09:26 +0100, John Garry wrote: > > > > What block driver controls the block device for which the performance > > > > regression > > > > has been observed? How many hardware queues were

Re: [PATCH] scsi: default to scsi-mq

2017-07-12 Thread Bart Van Assche
On Wed, 2017-07-12 at 09:26 +0100, John Garry wrote: > > > What block driver controls the block device for which the performance > > > regression > > > has been observed? How many hardware queues were created by that block > > > driver > > > (see also /sys/block/*/mq/...)? > > Just confirming

Re: [PATCH] scsi: default to scsi-mq

2017-07-12 Thread John Garry
What block driver controls the block device for which the performance regression has been observed? How many hardware queues were created by that block driver (see also /sys/block/*/mq/...)? Just confirming that we have only 1 queue: /sys/block/sdc/mq/0 as example Hi Bart, Here's the shost

Re: [PATCH] scsi: default to scsi-mq

2017-07-11 Thread John Garry
On 11/07/2017 16:46, Bart Van Assche wrote: On Tue, 2017-07-11 at 15:14 +0100, John Garry wrote: On 11/07/2017 14:32, Bart Van Assche wrote: On Tue, 2017-07-11 at 11:22 +0100, John Garry wrote: On 10/07/2017 16:50, Bart Van Assche wrote: Since a fix for the performance regression triggered

Re: [PATCH] scsi: default to scsi-mq

2017-07-11 Thread Bart Van Assche
On Tue, 2017-07-11 at 15:14 +0100, John Garry wrote: > On 11/07/2017 14:32, Bart Van Assche wrote: > > On Tue, 2017-07-11 at 11:22 +0100, John Garry wrote: > > > On 10/07/2017 16:50, Bart Van Assche wrote: > > > > Since a fix for the performance regression triggered by this patch will > > > > be

Re: [PATCH] scsi: default to scsi-mq

2017-07-11 Thread John Garry
On 11/07/2017 14:32, Bart Van Assche wrote: On Tue, 2017-07-11 at 11:22 +0100, John Garry wrote: On 10/07/2017 16:50, Bart Van Assche wrote: Since a fix for the performance regression triggered by this patch will be upstream soon (see also

Re: [PATCH] scsi: default to scsi-mq

2017-07-11 Thread Bart Van Assche
On Tue, 2017-07-11 at 11:22 +0100, John Garry wrote: > On 10/07/2017 16:50, Bart Van Assche wrote: > > Since a fix for the performance regression triggered by this patch will be > > upstream > > soon (see also > >

Re: [PATCH] scsi: default to scsi-mq

2017-07-11 Thread John Garry
On 10/07/2017 16:50, Bart Van Assche wrote: On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote: Remove the SCSI_MQ_DEFAULT config option and default to the blk-mq I/O path now that we had plenty of testing, and have I/O schedulers for blk-mq. The module option to disable the blk-mq

Re: [PATCH] scsi: default to scsi-mq

2017-07-10 Thread Bart Van Assche
On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote: > Remove the SCSI_MQ_DEFAULT config option and default to the blk-mq I/O > path now that we had plenty of testing, and have I/O schedulers for > blk-mq. The module option to disable the blk-mq path is kept around > for now. > >

Re: [PATCH] scsi: default to scsi-mq

2017-06-27 Thread Bart Van Assche
On Mon, 2017-06-26 at 20:55 +0200, Martin Wilck wrote: > I personally find it odd that the compile-time choice goes away while > the run-time choice remains available. I understand what Christoph is > trying to achieve, but if it was up to me, I'd prefer to change the > default and mark the "n"

Re: [PATCH] scsi: default to scsi-mq

2017-06-26 Thread Martin Wilck
Hi Bart, On Mon, 2017-06-26 at 15:31 +, Bart Van Assche wrote: > On Mon, 2017-06-26 at 12:13 +, Bart Van Assche wrote: > > On Thu, 2017-06-22 at 17:05 +0200, Martin Wilck wrote: > > > On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote: > > > > Remove the SCSI_MQ_DEFAULT config

Re: [PATCH] scsi: default to scsi-mq

2017-06-26 Thread Bart Van Assche
On Mon, 2017-06-26 at 12:13 +, Bart Van Assche wrote: > On Thu, 2017-06-22 at 17:05 +0200, Martin Wilck wrote: > > On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote: > > > Remove the SCSI_MQ_DEFAULT config option and default to the blk-mq > > > I/O > > > path now that we had plenty of

Re: [PATCH] scsi: default to scsi-mq

2017-06-26 Thread Bart Van Assche
On Thu, 2017-06-22 at 17:05 +0200, Martin Wilck wrote: > On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote: > > Remove the SCSI_MQ_DEFAULT config option and default to the blk-mq > > I/O > > path now that we had plenty of testing, and have I/O schedulers for > > blk-mq. The module option

Re: [PATCH] scsi: default to scsi-mq

2017-06-26 Thread Christoph Hellwig
On Thu, Jun 22, 2017 at 05:05:33PM +0200, Martin Wilck wrote: > Hello Christoph, > > On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote: > > Remove the SCSI_MQ_DEFAULT config option and default to the blk-mq > > I/O > > path now that we had plenty of testing, and have I/O schedulers for >

Re: [PATCH] scsi: default to scsi-mq

2017-06-22 Thread Martin Wilck
Hello Christoph, On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote: > Remove the SCSI_MQ_DEFAULT config option and default to the blk-mq > I/O > path now that we had plenty of testing, and have I/O schedulers for > blk-mq. The module option to disable the blk-mq path is kept around >