Re: [PATCH 20/25] qla2xxx: Remove redundant code

2017-05-31 Thread Tran, Quinn
..@cavium.com>, "martin.peter...@oracle.com" <martin.peter...@oracle.com> Subject: Re: [PATCH 20/25] qla2xxx: Remove redundant code On Mon, 2017-05-22 at 22:14 +, Tran, Quinn wrote: > > I think an initiator could get > really confused if it

Re: [PATCH 20/25] qla2xxx: Remove redundant code

2017-05-31 Thread Bart Van Assche
On Mon, 2017-05-22 at 22:14 +, Tran, Quinn wrote: > > I think an initiator could get > really confused if it receives two responses for the same exchange. > > QT: I do see the window you’re describing in the > qlt_try_to_dequeue_unknown_atios(). > Will have to follow up with another

Re: [PATCH 20/25] qla2xxx: Remove redundant code

2017-05-22 Thread Tran, Quinn
ger.kernel.org>, "james.bottom...@hansenpartnership.com" <james.bottom...@hansenpartnership.com>, "Madhani, Himanshu" <himanshu.madh...@cavium.com>, "martin.peter...@oracle.com" <martin.peter...@oracle.com> Subject: Re: [PATCH 20/25] qla2xxx: Remove

Re: [PATCH 20/25] qla2xxx: Remove redundant code

2017-05-22 Thread Bart Van Assche
On Sun, 2017-05-21 at 21:27 -0700, Nicholas A. Bellinger wrote: > The three lists abort_cmd_for_tag() walks from __qlt_24xx_handle_abts() > are used to track descriptors only before __qlt_do_work() is reached, > and before a descriptor is submitted into tcm_qla2xxx code. > > Or rather, the three

Re: [PATCH 20/25] qla2xxx: Remove redundant code

2017-05-21 Thread Nicholas A. Bellinger
On Fri, 2017-05-19 at 23:43 +, Bart Van Assche wrote: > On Fri, 2017-05-19 at 14:53 -0700, Himanshu Madhani wrote: > > From: Quinn Tran > > > > During ABTS or Abort task, qla2xxx does a pre-search for > > the se_cmd, based on command's tag. The same search is > >

Re: [PATCH 20/25] qla2xxx: Remove redundant code

2017-05-19 Thread Bart Van Assche
On Fri, 2017-05-19 at 14:53 -0700, Himanshu Madhani wrote: > From: Quinn Tran > > During ABTS or Abort task, qla2xxx does a pre-search for > the se_cmd, based on command's tag. The same search is > performed by TCM. Remove the extra search from qla2xxx. > > Signed-off-by: