Re: [PATCH v2 1/2] crypto: KEYS: convert public key to the akcipher api
On Tue, Dec 22, 2015 at 06:23:59AM -0800, Tadeusz Struk wrote: > > What about the first two. This one is completely unrelated. > It only supposed to fix some random configuration issue > reported by a build robot, which isn't really important now. > The other two convert the module verifier to the new API. No this compile breakage was introduced by your first two patches because you changed crypto/public_key.h which is used by entities outside of your patch. So fix your first two patches by not breaking existing users of it. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/2] crypto: KEYS: convert public key to the akcipher api
On Mon, Dec 21, 2015 at 12:59:59PM -0800, Tadeusz Struk wrote: > > The previous patch was broken, re-sending again, sorry. > > I think there is something missing in this configuration. > cat .config | grep KEXEC_BZIMAGE_VERIFY_SIG gives nothing. > Anyways, this patch should fix it. No this is unacceptable. Please fix it properly by making the header file self-contained, e.g., by using a forward declaration. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api
On Wed, Dec 23, 2015 at 06:58:55AM -0800, Tadeusz Struk wrote: > > Because the first patch modifies the struct public_key and removes the MPIs > from it, > which the code modified in the second patch still uses. If bisect only takes > the first > then the build will fail on the security/integrity/digsig_asymmetric.c as > reported by > kbuild test robot: Why not just leave the MPIs in the structure and only remove them by adding a third patch? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
