Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api
On 12/23/2015 12:21 PM, Herbert Xu wrote: > Why not just leave the MPIs in the structure and only remove them > by adding a third patch? Right, I think that's a better way of resolving this. v5 on it's way. Thanks, -- TS -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api
On Wed, Dec 23, 2015 at 06:58:55AM -0800, Tadeusz Struk wrote: > > Because the first patch modifies the struct public_key and removes the MPIs > from it, > which the code modified in the second patch still uses. If bisect only takes > the first > then the build will fail on the security/integrity/digsig_asymmetric.c as > reported by > kbuild test robot: Why not just leave the MPIs in the structure and only remove them by adding a third patch? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api
On 12/23/2015 06:51 AM, Herbert Xu wrote: >> > Changes in v4: >> > - Flatten both patches into one to avoid bisect compilation problems. > Why is this necessary? Because the first patch modifies the struct public_key and removes the MPIs from it, which the code modified in the second patch still uses. If bisect only takes the first then the build will fail on the security/integrity/digsig_asymmetric.c as reported by kbuild test robot: >> security/integrity/digsig_asymmetric.c:95:5: error: 'struct >> public_key_signature' has no member named 'nr_mpi' pks.nr_mpi = 1; Thanks, -- TS -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api
On Wed, Dec 23, 2015 at 06:33:53AM -0800, Tadeusz Struk wrote: > > Changes in v4: > - Flatten both patches into one to avoid bisect compilation problems. Why is this necessary? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html