RE: [PATCH v8] mfd: tps6586x: add RTC driver for TI TPS6586x

2011-03-25 Thread Wei Ni
Hi, all Could anyone review this patch? Thanks Wei. -Original Message- From: Wei Ni Sent: Monday, March 21, 2011 1:43 PM To: a.zu...@towertech.it; rtc-li...@googlegroups.com Cc: linux-tegra@vger.kernel.org; Wei Ni Subject: [PATCH v8] mfd: tps6586x: add RTC driver for TI TPS6586x From

RE: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c

2011-04-29 Thread Wei Ni
Hi, Stephen I think your patches address the different issues with my patches. My patches are used for retry transfer and new slave controller. Thanks Wei. -Original Message- From: Stephen Warren Sent: Thursday, April 28, 2011 12:29 AM To: Wei Ni Cc: kh...@linux-fr.org; ben-li

RE: [PATCH 0/2] i2c: tegra: add some new features for tegra i2c

2011-05-03 Thread Wei Ni
Hi, Stephen I think if doesn't need to apply the slave address codes, we can use your patch. Thanks Wei. -Original Message- From: Stephen Warren Sent: Friday, April 29, 2011 11:20 PM To: Wei Ni Cc: kh...@linux-fr.org; ben-li...@fluff.org; lucas.demar...@profusion.mobi; ccr

RE: Tegra I2C slave address patches

2011-05-13 Thread Wei Ni
. -Original Message- From: Marc Dietrich [mailto:marvi...@gmx.de] Sent: Friday, May 13, 2011 1:39 PM To: Wei Ni Cc: Stephen Warren; Bharat Nihalani; linux-...@vger.kernel.org; linux-tegra@vger.kernel.org Subject: Re: Tegra I2C slave address patches Hi Wei, Am Fri, 13 May 2011 12:28:27 +0800

RE: Where to power on the wifi device before loading the driver.

2012-06-14 Thread Wei Ni
On Thu, Jun 14, 2012 at 05:17:06, Stephen Warren wrote: On 06/13/2012 04:40 AM, Wei Ni wrote: Hi, all I'm working on the tegra30 wifi upstream issue. The tegra30 board (Cardhu) use Broadcom 4329 as wifi device, and use brcmfmac as the wifi driver. In the brcmfmac init routine, it call

RE: Where to power on the wifi device before loading the driver.

2012-06-14 Thread Wei Ni
On Thu, Jun 14, 2012 at 19:27:50, Wei Ni wrote: On Thu, Jun 14, 2012 at 05:17:06, Stephen Warren wrote: On 06/13/2012 04:40 AM, Wei Ni wrote: Hi, all I'm working on the tegra30 wifi upstream issue. The tegra30 board (Cardhu) use Broadcom 4329 as wifi device, and use brcmfmac as the wifi

RE: Where to power on the wifi device before loading the driver.

2012-06-15 Thread Wei Ni
On Thu, Jun 14, 2012 at 23:54:22, Stephen Warren wrote: The core of the issue is that: * Tegra30 support is via device tree. * We have an SDIO bus, and the WiFi device attached to that bus is enumerable. * Since the WiFi device is enumerable, no node exists in the DT to represent it. *

RE: Where to power on the wifi device before loading the driver.

2012-06-18 Thread Wei Ni
On Sat, Jun 16, 2012 at 00:24:41, Franky Lin wrote: On 06/14/2012 11:09 PM, Wei Ni wrote: I talked with Franky, this power sequence is generally for 4329, so it mean this sequence can be put into the wifi driver. Hold on. It's generally for 4329. But fullmac supports 4329/4330 along with USB

RE: Where to power on the wifi device before loading the driver.

2012-06-18 Thread Wei Ni
On Fri, Jun 15, 2012 at 23:49:10, Stephen Warren wrote: I talked with Franky, this power sequence is generally for 4329, so it mean this sequence can be put into the wifi driver. We can use the virtual platform device both for OOB and non OOB. I will send out patches later. Can you please

RE: Where to power on the wifi device before loading the driver.

2012-06-18 Thread Wei Ni
is applied Yes, we can use the regulator notify, but the Tegra30 support is via device tree, I think there have no special board file to run the call back. From: linux-mmc-ow...@vger.kernel.org [linux-mmc-ow...@vger.kernel.org] On Behalf Of Wei Ni [w

RE: Where to power on the wifi device before loading the driver.

2012-06-19 Thread Wei Ni
On Mon, Jun 18, 2012 at 23:01:45, Stephen Warren wrote: On 06/18/2012 02:03 AM, Laxman Dewangan wrote: Rakesh Kumar wrote at Monday, June 18, 2012 1:11 PM: Stephen Warren wrote: Now if this means adding a child node under the SDIO controller to represent the attached device, and storing

RE: Where to power on the wifi device before loading the driver.

2012-06-19 Thread Wei Ni
On Tue, Jun 19, 2012 at 17:17:19, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Jun 19, 2012 at 12:25:58PM +0800, Wei Ni wrote: As Stephen previously said please fix your mail formatting - word wrapping within paragraphs is important! On Tue, Jun 19, 2012 at 09:23:35, Philip Rakity

RE: Where to power on the wifi device before loading the driver.

2012-06-20 Thread Wei Ni
On Wed, Jun 20, 2012 at 08:01:54, Stephen Warren wrote: On 06/19/2012 03:44 AM, Wei Ni wrote: On Tue, Jun 19, 2012 at 17:17:19, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Jun 19, 2012 at 12:25:58PM +0800, Wei Ni wrote: As Stephen previously said please fix your mail formatting

[PATCH 1/5] ARM: tegra: set up wlan clocks for tegra dt

2012-07-04 Thread Wei Ni
Set up the wlan clock tree for Tegra20 and Tegra30. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/mach-tegra/board-dt-tegra20.c |1 + arch/arm/mach-tegra/board-dt-tegra30.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-tegra/board-dt-tegra20.c b

[PATCH 5/5] ARM: tegra: enable wireless in defconfig

2012-07-04 Thread Wei Ni
New options enabled: * WIRELESS: (dependency) * CFG80211: (dependency) * WLAN: (dependency) * BRCMFMAC: wlan driver, enable as module. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/configs/tegra_defconfig |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm

[PATCH 4/5] ARM: dt: t30 cardhu: add pinmux, gpio for wlan

2012-07-04 Thread Wei Ni
This adds wlan pinmux and gpio settings to the Tegra30 Cardhu device tree. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra30-cardhu.dts | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/tegra30-cardhu.dts b

[PATCH 2/5] ARM: dt: t20 seaboard: add pinmux, gpio for wlan

2012-07-04 Thread Wei Ni
This adds wlan pinmux and gpio settings to the Tegra20 Seaboard device tree. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra20-seaboard.dts |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts

[PATCH 3/5] ARM: dt: t20 ventana: add pinmux, gpio for wlan

2012-07-04 Thread Wei Ni
This adds wlan pinmux and gpio settings to the Tegra20 Ventana device tree. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra20-ventana.dts | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/tegra20-ventana.dts b/arch

[PATCH 0/5] ARM: tegra: enable wlan for t20 and t30

2012-07-04 Thread Wei Ni
Set up clocks, pinmux, gpios and configs to enable wlan for following tegra boards: Tegra30: Cardhu. Tegra20: Seaboard, Ventana. Wei Ni (5): ARM: tegra: set up wlan clocks for tegra dt ARM: dt: t20 seaboard: add pinmux, gpio for wlan ARM: dt: t20 ventana: add pinmux, gpio for wlan ARM: dt

Re: [PATCH 1/5] ARM: tegra: set up wlan clocks for tegra dt

2012-07-04 Thread Wei Ni
On Wed, 2012-07-04 at 18:43 +0800, Marc Dietrich wrote: Am Mittwoch, 4. Juli 2012, 17:34:44 schrieb Wei Ni: Set up the wlan clock tree for Tegra20 and Tegra30. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/mach-tegra/board-dt-tegra20.c |1 + arch/arm/mach-tegra/board-dt

Re: Re: [PATCH 1/5] ARM: tegra: set up wlan clocks for tegra dt

2012-07-04 Thread Wei Ni
On Wed, 2012-07-04 at 19:51 +0800, Marc Dietrich wrote: Am Mittwoch, 4. Juli 2012, 19:23:33 schrieb Wei Ni: On Wed, 2012-07-04 at 18:43 +0800, Marc Dietrich wrote: Am Mittwoch, 4. Juli 2012, 17:34:44 schrieb Wei Ni: Set up the wlan clock tree for Tegra20 and Tegra30. Signed-off

Re: [PATCH 5/5] ARM: tegra: enable wireless in defconfig

2012-07-05 Thread Wei Ni
On Fri, 2012-07-06 at 03:59 +0800, Stephen Warren wrote: On 07/04/2012 03:34 AM, Wei Ni wrote: New options enabled: * WIRELESS: (dependency) * CFG80211: (dependency) * WLAN: (dependency) * BRCMFMAC: wlan driver, enable as module. diff --git a/arch/arm/configs/tegra_defconfig b

Re: [PATCH 5/5] ARM: tegra: enable wireless in defconfig

2012-07-05 Thread Wei Ni
On Fri, 2012-07-06 at 04:42 +0800, Stephen Warren wrote: On 07/05/2012 02:35 PM, Marc Dietrich wrote: On Thursday 05 July 2012 13:59:11 Stephen Warren wrote: On 07/04/2012 03:34 AM, Wei Ni wrote: New options enabled: * WIRELESS: (dependency) * CFG80211: (dependency) * WLAN

RE: How to use the generic thermal sysfs.

2012-07-13 Thread Wei Ni
On Fri, 2012-07-13 at 15:41 +0800, Zhang Rui wrote: On 五, 2012-07-13 at 15:30 +0800, Wei Ni wrote: Our tegra thermal framework also will use the generic thermal layer. It will register the cooling device, and run the throttling in this generic framework. But we have a special mechanism

RE: How to use the generic thermal sysfs.

2012-07-13 Thread Wei Ni
On Fri, 2012-07-13 at 16:11 +0800, Wei Ni wrote: On Fri, 2012-07-13 at 15:41 +0800, Zhang Rui wrote: On 五, 2012-07-13 at 15:30 +0800, Wei Ni wrote: Our tegra thermal framework also will use the generic thermal layer. It will register the cooling device, and run the throttling

How to get the irq flags from the dts file

2012-08-09 Thread Wei Ni
Hi, all I'm working on tegra wlan upstream issue. The tegra board use the Broadcom 4329 as wlan device, and the driver is the brcmfmac. This wlan driver support out-band-interrupt (OOB), I want to add DT support to use this OOB. I can add following lines in the dts file to create platform device

Re: How to get the irq flags from the dts file

2012-08-10 Thread Wei Ni
On Thu, 2012-08-09 at 20:05 +0800, Mark Brown wrote: On Thu, Aug 09, 2012 at 11:48:42AM +, Arnd Bergmann wrote: On Thursday 09 August 2012, Wei Ni wrote: The wlan driver wish this flags include the IRQF_TRGGER_* information, and it will use this flags to configure other hw settings

Re: How to get the irq flags from the dts file

2012-08-10 Thread Wei Ni
On Thu, 2012-08-09 at 20:09 +0800, Arend van Spriel wrote: On 08/09/2012 12:43 PM, Wei Ni wrote: Hi, all I'm working on tegra wlan upstream issue. The tegra board use the Broadcom 4329 as wlan device, and the driver is the brcmfmac. This wlan driver support out-band-interrupt (OOB

[PATCH 2/6] brcmfmac: Handling the interrupt in ISR directly for non-OOB

2012-08-27 Thread Wei Ni
directly will prevent thread context switching in wifi driver. It can fix the instability problems. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c |2 ++ drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |8 +++- 2 files changed, 9

[PATCH 1/6] ARM: tegra: set up wlan clocks for tegra dt

2012-08-27 Thread Wei Ni
Set up the wlan clock tree for Tegra20 and Tegra30. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/mach-tegra/board-dt-tegra20.c |4 arch/arm/mach-tegra/board-dt-tegra30.c |4 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-tegra/board-dt

[PATCH 6/6] ARM: tegra: enable wireless in defconfig

2012-08-27 Thread Wei Ni
New options enabled: * WIRELESS: (dependency) * CFG80211_WEXT: (dependency) * WLAN: (dependency) * BRCMFMAC: wlan driver, enable as module. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/configs/tegra_defconfig |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch

[PATCH 5/6] ARM: dt: t30 cardhu: set pinmux and power for wlan

2012-08-27 Thread Wei Ni
Configure pinmux as required for WiFi. Enable the SDHCI1 controller. This is connectted to the WiFi module. For now, always enable the regulator that provides power to the Wifi module. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra30-cardhu.dtsi | 32

[PATCH 4/6] ARM: dt: t20 ventana: set pinmux and power for wlan

2012-08-27 Thread Wei Ni
Configure pinmux as required for WiFi. Enable the SDHCI1 controller, which is connectted to the WiFi module. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra20-ventana.dts | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 0/6] ARM: tegra: enable wlan for t20 and t30

2012-08-27 Thread Wei Ni
Enable wlan for following tegra board: Tegra30: Cardhu. Tegra20: Seaboard, Ventana. Wei Ni (6): ARM: tegra: set up wlan clocks for tegra dt brcmfmac: Handling the interrupt in ISR directly for non-OOB ARM: dt: t20 seaboard: turn on the power for wlan ARM: dt: t20 ventana: set pinmux

[PATCH 3/6] ARM: dt: t20 seaboard: turn on the power for wlan

2012-08-27 Thread Wei Ni
Enable the SDHCI1 controller. This is connected to the WiFi module. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra20-seaboard.dts |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20

Re: [PATCH 2/6] brcmfmac: Handling the interrupt in ISR directly for non-OOB

2012-08-28 Thread Wei Ni
On Tue, 2012-08-28 at 00:24 +0800, Arend van Spriel wrote: On 08/27/2012 12:25 PM, Wei Ni wrote: In case of inband interrupts, if we handle the interrupt in dpc thread, two level of thread switching takes place to process wifi interrupts. One in SDHCI driver and the other in Wifi driver

Re: [PATCH 2/6] brcmfmac: Handling the interrupt in ISR directly for non-OOB

2012-08-28 Thread Wei Ni
On Tue, 2012-08-28 at 04:06 +0800, Stephen Warren wrote: On 08/27/2012 09:24 AM, Arend van Spriel wrote: On 08/27/2012 12:25 PM, Wei Ni wrote: In case of inband interrupts, if we handle the interrupt in dpc thread, two level of thread switching takes place to process wifi interrupts. One

[PATCH v2 0/5] ARM: tegra: enable wlan for t20 and t30

2012-09-21 Thread Wei Ni
-OOB issue, so we remove the patches for brcmfmac driver. -Support Cardhu a02 and a04 board. -Remove the config WLAN and WIRELESS in the patch, because they are default=y -Add bus-width for sdhci in the dts file Wei Ni (5): ARM: tegra: set up wlan clocks for tegra dt ARM: dt

[PATCH v2 5/5] ARM: tegra: enable brcmfmac in defconfig

2012-09-21 Thread Wei Ni
New options enabled: * CFG80211_WEXT: (dependency) * BRCMFMAC: wlan driver, enable as module. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/configs/tegra_defconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs

[PATCH v2 4/5] ARM: dt: t30 cardhu: set pinmux and power for wlan

2012-09-21 Thread Wei Ni
Configure pinmux as required for WiFi. Enable the SDHCI1 controller for a02 and a04 board, which is connected to the WiFi module. For now, always enable the regulator that provides power to the Wifi module. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra30-cardhu-a02.dts |6

[RFC PATCH 0/9] Support for tegra30 thermal.

2013-02-18 Thread Wei Ni
. Next steps: 1. enhance the tegra30 thermal driver, something like handling the irq, setting the sensor limit value. 2. seprate codes to create a new files which is for cooling device, something like tegra3_cooling.c. it will handle dvfs. Wei Ni (9): ARM: dt: t30 cardhu: add dt entry for lm90

[RFC PATCH 1/9] ARM: dt: t30 cardhu: add dt entry for lm90

2013-02-18 Thread Wei Ni
Enable thermal sensor lm90 in the dts file. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra30-cardhu.dtsi |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi index bdb2a66..15ad1ad 100644

[RFC PATCH 5/9] Thermal: Support using dt node to get sensor

2013-02-18 Thread Wei Ni
Add functions to support using dt node with args to get sensor. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/thermal/thermal_sys.c | 30 ++ include/linux/thermal.h |9 + 2 files changed, 39 insertions(+) diff --git a/drivers/thermal

[RFC PATCH 2/9] hwmon: (lm90) split setshow temp as common codes

2013-02-18 Thread Wei Ni
Split setshow temp codes as common functions, so we can use it directly when implement linux thermal framework. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 117 +++--- 1 file changed, 72 insertions(+), 45 deletions(-) diff --git

[RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11

2013-02-18 Thread Wei Ni
Using macros for the indexes and nrs of temp8 and temp11. This make the code much clearer. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 179 -- 1 file changed, 114 insertions(+), 65 deletions(-) diff --git a/drivers/hwmon/lm90

[RFC PATCH 7/9] thermal: tegra30: add tegra30 thermal driver

2013-02-18 Thread Wei Ni
dd Tegra30 thermal driver support. It create thermal zone with thermal sensors and cooling device to participate in the linux thermal management. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/thermal/Kconfig |9 ++ drivers/thermal/Makefile |1 + drivers/thermal

[RFC PATCH 8/9] ARM: dt: t30 cardhu: add dt entry for thermal driver

2013-02-18 Thread Wei Ni
Enable thermal driver in the dts file. Set sensor as lm90 remote sensor, and set throttle data. Signed-off-by: Wei Ni w...@nvidia.com --- .../devicetree/bindings/thermal/tegra3-thermal.txt | 41 arch/arm/boot/dts/tegra30-cardhu.dtsi | 19 + 2 files

[RFC PATCH 9/9] ARM: tegra: defconfig: enable thermal framework

2013-02-18 Thread Wei Ni
Enable tegra30 thermal framework. New options enabled: * TEGRA30_THERMAL: for tegra30 thermal framework. * THERMAL: dependency for TEGRA30_THERMAL. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/configs/tegra_defconfig |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs

[RFC PATCH 6/9] hwmon: (lm90) Register to the thermal framework

2013-02-18 Thread Wei Ni
Register the remote sensor to the thermal framework. It can support to show the temperature and read/write threshold. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra30-cardhu.dtsi |1 + drivers/hwmon/lm90.c | 182 - 2 files

[RFC PATCH 3/9] hwmon: (lm90) add support to handle irq

2013-02-18 Thread Wei Ni
Add support to handle irq. When the temperature touch the limit value, the driver can handle the interrupt. Signed-off-by: Alexandre Courbot acour...@nvidia.com Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 38 ++ 1 file changed, 38

Re: [RFC PATCH 2/9] hwmon: (lm90) split setshow temp as common codes

2013-02-19 Thread Wei Ni
On 02/19/2013 06:29 AM, Matthew Longnecker wrote: Wei, This set of patches seems to include 3 logical subsets 1) lm90 changes 2) dt support in drivers/thermal 3) tegra30 support in drivers/thermal Would it make sense to split this into 3 separate sets of changes? Ok, I will do it in my

Re: [RFC PATCH 1/9] ARM: dt: t30 cardhu: add dt entry for lm90

2013-02-19 Thread Wei Ni
On 02/19/2013 11:28 AM, Alex Courbot wrote: On 02/18/2013 08:30 PM, Wei Ni wrote: Enable thermal sensor lm90 in the dts file. Acked-by: Alexandre Courbot acour...@nvidia.com Btw, shouldn't this patch come last, after all the changes you did to lm90? If you keep the current order, you

Re: [RFC PATCH 8/9] ARM: dt: t30 cardhu: add dt entry for thermal driver

2013-02-19 Thread Wei Ni
On 02/19/2013 11:42 AM, Alex Courbot wrote: On 02/18/2013 08:30 PM, Wei Ni wrote: diff --git a/Documentation/devicetree/bindings/thermal/tegra3-thermal.txt b/Documentation/devicetree/bindings/thermal/tegra3-thermal.txt new file mode 100644 This should go with the previous patch (which

Re: [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11

2013-02-19 Thread Wei Ni
On 02/19/2013 01:39 PM, Alex Courbot wrote: On 02/18/2013 08:30 PM, Wei Ni wrote: Using macros for the indexes and nrs of temp8 and temp11. This make the code much clearer. Signed-off-by: Wei Ni w...@nvidia.com Acked-by: Alexandre Courbot acour...@nvidia.com Great patch. This makes

Re: [lm-sensors] [RFC PATCH 2/9] hwmon: (lm90) split setshow temp as common codes

2013-02-19 Thread Wei Ni
On 02/19/2013 11:31 AM, Guenter Roeck wrote: On Mon, Feb 18, 2013 at 07:30:24PM +0800, Wei Ni wrote: Split setshow temp codes as common functions, so we can use it directly when implement linux thermal framework. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 117

Re: [lm-sensors] [RFC PATCH 3/9] hwmon: (lm90) add support to handle irq

2013-02-19 Thread Wei Ni
On 02/19/2013 11:34 AM, Guenter Roeck wrote: On Mon, Feb 18, 2013 at 07:30:25PM +0800, Wei Ni wrote: Add support to handle irq. When the temperature touch the limit value, the driver can handle the interrupt. Signed-off-by: Alexandre Courbot acour...@nvidia.com Signed-off-by: Wei Ni w

Re: [lm-sensors] [RFC PATCH 6/9] hwmon: (lm90) Register to the thermal framework

2013-02-19 Thread Wei Ni
On 02/19/2013 11:42 AM, Guenter Roeck wrote: On Mon, Feb 18, 2013 at 07:30:28PM +0800, Wei Ni wrote: Register the remote sensor to the thermal framework. It can support to show the temperature and read/write threshold. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra30

Re: [RFC PATCH 6/9] hwmon: (lm90) Register to the thermal framework

2013-02-19 Thread Wei Ni
On 02/19/2013 01:22 PM, Alex Courbot wrote: On 02/18/2013 08:30 PM, Wei Ni wrote: Register the remote sensor to the thermal framework. It can support to show the temperature and read/write threshold. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra30-cardhu.dtsi |1

Re: [RFC PATCH 3/9] hwmon: (lm90) add support to handle irq

2013-02-20 Thread Wei Ni
On 02/20/2013 11:27 AM, Alex Courbot wrote: On 02/20/2013 08:00 AM, Stephen Warren wrote: On 02/18/2013 04:30 AM, Wei Ni wrote: Add support to handle irq. When the temperature touch the limit value, the driver can handle the interrupt. diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c

Re: [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11

2013-02-20 Thread Wei Ni
On 02/20/2013 07:02 AM, Stephen Warren wrote: On 02/18/2013 04:30 AM, Wei Ni wrote: Using macros for the indexes and nrs of temp8 and temp11. This make the code much clearer. Sorry to nit-pick, but those aren't macros, but rather they're enums. Yes, you are right, it's better to write enums

Re: [RFC PATCH 5/9] Thermal: Support using dt node to get sensor

2013-02-20 Thread Wei Ni
On 02/20/2013 07:12 AM, Stephen Warren wrote: On 02/18/2013 04:30 AM, Wei Ni wrote: Add functions to support using dt node with args to get sensor. You need to write a device tree binding document to explain this. diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c

Re: [RFC PATCH 6/9] hwmon: (lm90) Register to the thermal framework

2013-02-20 Thread Wei Ni
On 02/20/2013 07:18 AM, Stephen Warren wrote: On 02/18/2013 04:30 AM, Wei Ni wrote: Register the remote sensor to the thermal framework. It can support to show the temperature and read/write threshold. arch/arm/boot/dts/tegra30-cardhu.dtsi |1 + drivers/hwmon/lm90.c

Re: [RFC PATCH 8/9] ARM: dt: t30 cardhu: add dt entry for thermal driver

2013-02-20 Thread Wei Ni
On 02/20/2013 07:28 AM, Stephen Warren wrote: On 02/18/2013 04:30 AM, Wei Ni wrote: Enable thermal driver in the dts file. Set sensor as lm90 remote sensor, and set throttle data. diff --git a/Documentation/devicetree/bindings/thermal/tegra3-thermal.txt b/Documentation/devicetree/bindings

Re: [RFC PATCH 7/9] thermal: tegra30: add tegra30 thermal driver

2013-02-20 Thread Wei Ni
On 02/20/2013 07:48 AM, Stephen Warren wrote: On 02/18/2013 04:30 AM, Wei Ni wrote: dd Tegra30 thermal driver support. It create thermal zone with thermal sensors and cooling device to participate in the linux thermal management. diff --git a/drivers/thermal/tegra3_thermal.c b/drivers

Re: [RFC PATCH 7/9] thermal: tegra30: add tegra30 thermal driver

2013-02-20 Thread Wei Ni
On 02/20/2013 07:56 AM, Russell King - ARM Linux wrote: On Mon, Feb 18, 2013 at 07:30:29PM +0800, Wei Ni wrote: +static struct tegra_thermal_data * __devinit thermal_tegra_dt_parse_pdata( __dev* no longer exists. Ok, I will change it. +tdata = devm_kzalloc(pdev-dev, sizeof(*tdata

Re: [RFC PATCH 2/9] hwmon: (lm90) split setshow temp as common codes

2013-02-20 Thread Wei Ni
On 02/20/2013 06:56 AM, Stephen Warren wrote: On 02/18/2013 04:30 AM, Wei Ni wrote: Split setshow temp codes as common functions, so we can use it directly when implement linux thermal framework. diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c -static ssize_t show_temp8(struct

[PATCH 2/3] hwmon: (lm90) add support to handle irq

2013-07-04 Thread Wei Ni
Add support to handle irq. When the temperature touch the limit value, the driver can handle the interrupt. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c

[PATCH 0/3] Lm90 Enhancements

2013-07-04 Thread Wei Ni
. Changes from RFC: 1. change _show_temp() to read_temp(), _set_temp() to write_temp(). 2. simply return value for the read_temp(), not use pointer. 3. use devm_request_threaded_irq() to request irq and set flag IRQF_ONESHOT. Wei Ni (3): hwmon: (lm90) split setshow temp as common codes hwmon

[PATCH 0/2] Enable lm90 in Tegra30 and Tegra114.

2013-07-04 Thread Wei Ni
Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore. This series is v1, based on [RFC 1/9] submitted here: http://thread.gmane.org/gmane.linux.power-management.general/31056 Changes from RFC: 1. Enable it for Tegra114 Dalmore. Wei Ni (2): ARM: dt: t30 cardhu: add dt entry

[PATCH 1/2] ARM: dt: t30 cardhu: add dt entry for lm90

2013-07-04 Thread Wei Ni
Enable thermal sensor lm90 for t30 cardhu. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra30-cardhu.dtsi |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi index f65b53d..8778c94 100644

[PATCH 2/2] ARM: dt: t114 dalmore: add dt entry for lm90

2013-07-04 Thread Wei Ni
Enable thermal sensor lm90 for t114 dalmore. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra114-dalmore.dts |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts index cb640eb..8325797

Re: [PATCH 1/2] ARM: dt: t30 cardhu: add dt entry for lm90

2013-07-08 Thread Wei Ni
On 07/06/2013 01:38 AM, Stephen Warren wrote: On 07/04/2013 03:09 AM, Wei Ni wrote: Enable thermal sensor lm90 for t30 cardhu. diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi +nct1008: nct1008 { +compatible

Re: [lm-sensors] [PATCH 1/2] ARM: dt: t30 cardhu: add dt entry for lm90

2013-07-08 Thread Wei Ni
On 07/08/2013 03:50 PM, Jean Delvare wrote: On Mon, 8 Jul 2013 15:35:48 +0800, Wei Ni wrote: On 07/06/2013 01:38 AM, Stephen Warren wrote: On 07/04/2013 03:09 AM, Wei Ni wrote: Enable thermal sensor lm90 for t30 cardhu. diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts

[PATCH v2 2/3] hwmon: (lm90) add support to handle IRQ.

2013-07-10 Thread Wei Ni
When the temperature exceed the limit range value, the driver can handle the interrupt. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 77 +- 1 file changed, 64 insertions(+), 13 deletions(-) diff --git a/drivers/hwmon/lm90.c b

[PATCH v2 1/3] hwmon: (lm90) split setshow temp as common codes

2013-07-10 Thread Wei Ni
Split setshow temp codes as common functions, so we can use it directly when implement linux thermal framework. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 118 -- 1 file changed, 75 insertions(+), 43 deletions(-) diff --git

[PATCH v2 2/2] ARM: dt: t114 dalmore: add dt entry for nct1008

2013-07-10 Thread Wei Ni
Enable thermal sensor nct1008 for t114 dalmore. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra114-dalmore.dts |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts index cb640eb..95c5079

[PATCH v2 0/2] Enable lm90 in Tegra30 and Tegra114.

2013-07-10 Thread Wei Ni
for nct1008 node. Changes from RFC: 1. Enable it for Tegra114 Dalmore. Wei Ni (2): ARM: dt: t30 cardhu: add dt entry for nct1008 ARM: dt: t114 dalmore: add dt entry for nct1008 arch/arm/boot/dts/tegra114-dalmore.dts |7 +++ arch/arm/boot/dts/tegra30-cardhu.dtsi |7 +++ 2

Re: [PATCH v2 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008

2013-07-11 Thread Wei Ni
On 07/11/2013 01:13 AM, Thierry Reding wrote: * PGP Signed by an unknown key On Wed, Jul 10, 2013 at 07:29:57PM +0800, Wei Ni wrote: Enable thermal sensor nct1008 for t30 cardhu. Nit: Tegra30 Cardhu diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30

Re: [PATCH v2 2/3] hwmon: (lm90) add support to handle IRQ.

2013-07-11 Thread Wei Ni
On 07/11/2013 02:12 AM, Guenter Roeck wrote: On Wed, Jul 10, 2013 at 10:05:53AM -0700, Thierry Reding wrote: On Wed, Jul 10, 2013 at 07:25:38PM +0800, Wei Ni wrote: When the temperature exceed the limit range value, the driver can handle the interrupt. Signed-off-by: Wei Ni w...@nvidia.com

Re: [PATCH v2 2/3] hwmon: (lm90) add support to handle IRQ.

2013-07-11 Thread Wei Ni
On 07/11/2013 02:18 AM, Guenter Roeck wrote: On Wed, Jul 10, 2013 at 07:25:38PM +0800, Wei Ni wrote: When the temperature exceed the limit range value, the driver can handle the interrupt. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 77

Re: [PATCH v2 1/3] hwmon: (lm90) split setshow temp as common codes

2013-07-11 Thread Wei Ni
On 07/11/2013 02:21 AM, Guenter Roeck wrote: On Wed, Jul 10, 2013 at 07:25:37PM +0800, Wei Ni wrote: Split setshow temp codes as common functions, so we can use it directly when implement linux thermal framework. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 118

[PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit

2013-07-12 Thread Wei Ni
Add bit defines for the status register. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 72 ++ 1 file changed, 49 insertions(+), 23 deletions(-) diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c index 5f30f90..c90037f

[PATCH v3 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008

2013-07-12 Thread Wei Ni
Enable thermal sensor nct1008 for t30 cardhu. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra30-cardhu.dtsi |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi index f65b53d..e5759ca 100644

[PATCH v3 0/4] Lm90 Enhancements

2013-07-12 Thread Wei Ni
defines for the alarm status 3. consider the shared IRQ. Changes from RFC: 1. change _show_temp() to read_temp(), _set_temp() to write_temp(). 2. simply return value for the read_temp(), not use pointer. 3. use devm_request_threaded_irq() to request irq and set flag IRQF_ONESHOT. Wei Ni (4): hwmon

[PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-12 Thread Wei Ni
When the temperature exceed the limit range value, the driver can handle the interrupt. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c index c90037f

[PATCH v3 4/4] hwmon: (lm90) use enums for the indexes of temp8 and temp11

2013-07-12 Thread Wei Ni
Using enums for the indexes and nrs of temp8 and temp11. This make the code much more readable. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 179 -- 1 file changed, 114 insertions(+), 65 deletions(-) diff --git a/drivers/hwmon

[PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

2013-07-12 Thread Wei Ni
-kernel@vger.kernel.org/msg465561.html Changes from v2: 1. remove the label nct1008. Changes from v1: 1. add vendor strings onnn for nct1008 node. Changes from RFC: 1. Enable it for Tegra114 Dalmore. Wei Ni (2): ARM: dt: t30 cardhu: add dt entry for nct1008 ARM: dt: t114 dalmore: add dt entry

[PATCH v3 2/2] ARM: dt: t114 dalmore: add dt entry for nct1008

2013-07-12 Thread Wei Ni
Enable thermal sensor nct1008 for t114 dalmore. Signed-off-by: Wei Ni w...@nvidia.com --- arch/arm/boot/dts/tegra114-dalmore.dts |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts index cb640eb..47ec7eb

[PATCH v3 1/4] hwmon: (lm90) split setshow temp as common codes

2013-07-12 Thread Wei Ni
Split setshow temp codes as common functions, so we can use it directly when implement linux thermal framework. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 112 +++--- 1 file changed, 69 insertions(+), 43 deletions(-) diff --git

Re: [PATCH v3 1/4] hwmon: (lm90) split setshow temp as common codes

2013-07-15 Thread Wei Ni
to be that fast on my end, sorry about that. On Fri, 12 Jul 2013 15:48:04 +0800, Wei Ni wrote: Split setshow temp codes as common functions, so we can use it directly when implement linux thermal framework. Can I see a recent version of the code which will need this change? It makes no sense to apply

Re: [PATCH v3 1/4] hwmon: (lm90) split setshow temp as common codes

2013-07-15 Thread Wei Ni
On 07/12/2013 10:40 PM, Guenter Roeck wrote: On Fri, Jul 12, 2013 at 04:30:34PM +0200, Jean Delvare wrote: Hi Guenter, On Fri, 12 Jul 2013 06:50:00 -0700, Guenter Roeck wrote: On Fri, Jul 12, 2013 at 03:26:15PM +0200, Jean Delvare wrote: One thing I am a little worried about (but maybe I'm

Re: [PATCH v3 1/4] hwmon: (lm90) split setshow temp as common codes

2013-07-15 Thread Wei Ni
On 07/15/2013 03:24 PM, Jean Delvare wrote: On Mon, 15 Jul 2013 14:25:29 +0800, Wei Ni wrote: On 07/12/2013 10:40 PM, Guenter Roeck wrote: On Fri, Jul 12, 2013 at 04:30:34PM +0200, Jean Delvare wrote: If that means that for example the ACPI thermal zone is no longer displayed by sensors

Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

2013-07-16 Thread Wei Ni
On 07/16/2013 01:13 AM, Stephen Warren wrote: On 07/15/2013 10:48 AM, Stephen Warren wrote: On 07/12/2013 01:49 AM, Wei Ni wrote: Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore. I have applied the series to Tegra's for-3.12/dt branch. Actually, I see the following

Re: [PATCH v3 1/4] hwmon: (lm90) split setshow temp as common codes

2013-07-17 Thread Wei Ni
On 07/17/2013 01:14 PM, Guenter Roeck wrote: On Wed, Jul 17, 2013 at 06:26:20AM +0200, Thierry Reding wrote: On Mon, Jul 15, 2013 at 09:24:15AM +0200, Jean Delvare wrote: On Mon, 15 Jul 2013 14:25:29 +0800, Wei Ni wrote: On 07/12/2013 10:40 PM, Guenter Roeck wrote: On Fri, Jul 12, 2013 at 04

Re: [PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit

2013-07-17 Thread Wei Ni
On 07/16/2013 12:57 AM, Jean Delvare wrote: Hi Wei, Guenter, On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote: Add bit defines for the status register. Regarding the subject: for me these are constants, not macros. AFAIK the term macro refers to defines with parameters only. How about

Re: [PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit

2013-07-17 Thread Wei Ni
On 07/17/2013 03:03 PM, Wei Ni wrote: On 07/16/2013 12:57 AM, Jean Delvare wrote: Hi Wei, Guenter, + + if ((status 0x7f) == 0 (status2 0xfe) == 0) + return false; It's a bit disappointing to not use the freshly introduced constants. That being said I agree it would make

Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

2013-07-17 Thread Wei Ni
On 07/17/2013 04:23 PM, Mikko Perttunen wrote: On 07/17/2013 11:17 AM, Wei Ni wrote: On 07/16/2013 07:14 PM, Wei Ni wrote: On 07/16/2013 01:13 AM, Stephen Warren wrote: On 07/15/2013 10:48 AM, Stephen Warren wrote: On 07/12/2013 01:49 AM, Wei Ni wrote: Enable thermal sensor lm90 for Tegra30

Re: [PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit

2013-07-17 Thread Wei Ni
On 07/17/2013 04:28 PM, Jean Delvare wrote: Hi Wei, On Wed, 17 Jul 2013 15:03:35 +0800, Wei Ni wrote: On 07/16/2013 12:57 AM, Jean Delvare wrote: On Fri, 12 Jul 2013 15:48:05 +0800, Wei Ni wrote: Add bit defines for the status register. Regarding the subject: for me these are constants

Re: [PATCH v3 1/4] hwmon: (lm90) split setshow temp as common codes

2013-07-17 Thread Wei Ni
On 07/17/2013 05:11 PM, Jean Delvare wrote: On Wed, 17 Jul 2013 14:26:54 +0800, Wei Ni wrote: On 07/17/2013 01:14 PM, Guenter Roeck wrote: On Wed, Jul 17, 2013 at 06:26:20AM +0200, Thierry Reding wrote: On Mon, Jul 15, 2013 at 09:24:15AM +0200, Jean Delvare wrote: On Mon, 15 Jul 2013 14:25:29

Re: [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ

2013-07-29 Thread Wei Ni
On 07/27/2013 11:02 PM, Jean Delvare wrote: Hi Wei, Sorry for the late reply. On Fri, 19 Jul 2013 14:41:54 +0800, Wei Ni wrote: On 07/18/2013 11:58 PM, Jean Delvare wrote: First of all, how is the chip wired on your system? You are using an NCT1008, right? Which output of the chip

  1   2   3   >