commit 65b3d52d02a558fbfe08e43688e15390c5ab3067
(usb: musb: add musb_ida for multi instance support)
used musbid in ux500_remove() but nerver declared it.
I found this in x86_64 platform, but not sure whether
this is a error on the correct ARCH.
$ make drivers/usb/musb/ux500.o
make[1]: Nothing
From: Justin P. Mattock justinmatt...@gmail.com
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
The below patch fixes a typo in staging: ehci-w90x900
drivers/usb/host/ehci-w90x900.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Justin P. Mattock justinmatt...@gmail.com
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
The below patch fixes a typo in staging: winbond
drivers/staging/winbond/mds.c |2 +-
drivers/staging/winbond/wbhal.h |4 ++--
2 files changed, 3 insertions(+), 3
From: Bjørn Mork bj...@mork.no
Date: Mon, 22 Oct 2012 22:56:27 +0200
The USB Communications Device Class Mobile Broadband Interface Model
(MBIM) is the USB-IFs alternative to the current chipset/vendor
specific solutions to Mobile Broadband device management. The
specification, including the
On Mon, Oct 22, 2012 at 11:18:58AM +0800, Peter Chen wrote:
On Fri, Oct 19, 2012 at 07:20:01PM +0300, Felipe Balbi wrote:
Hi,
On Tue, Oct 16, 2012 at 09:36:46AM +0800, Peter Chen wrote:
The patch includes both API change and caller change.
The main changes like below:
- add
ACPI provide _PLD and _UPC aml methods to describe usb port
visibility and connectability. This patch is to use those information
to set usb port's DeviceRemovable.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
drivers/usb/core/hub.c | 23 +++
To show the relationship between usb port and child device,
add link file port under usb device's sysfs directoy and
child under usb port device's sysfs directory. They are linked
to each other.
Signed-off-by: Lan Tianyu tianyu@intel.com
---
drivers/usb/core/hub.c | 17 +
1
On Tue, Oct 23, 2012 at 09:56:45AM +0300, Felipe Balbi wrote:
that's fine, it doesn't matter how many files you touch as long as the
patch is a single, logical, self-contained change. Look at how many
things you're doing in a single patch:
you add new function pointers to a structure, you
Hi Greg,
here's my second set of fixes for v3.7-rc cycle. Let me know if you
want any changes.
cheers
The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556:
Linux 3.7-rc2 (2012-10-20 12:11:32 -0700)
are available in the git repository at:
flush_work_sync and flush_work are now the same and flush_work_sync
has been deprecated. This fixes the following warning:
drivers/usb/core/hub.c: In function hub_quiesce:
drivers/usb/core/hub.c:1216:3: warning: flush_work_sync is deprecated (declared
at include/linux/workqueue.h:448)
This if is a no-op, as OTG_ are defined as:
#define OTGSC_AVVIS BIT(17)
#define OTGSC_AVVIE BIT(25)
Resulting in queue_work() never called from here.
+
spin_unlock(ci-lock);
I'm not that deep into the OTG stuff to fix it properly.
Yes, we have many
On Mon, Oct 22, 2012 at 10:37 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Mon, 22 Oct 2012, Ming Lei wrote:
+ /*
+ * Don't allocate memory with GFP_KERNEL in current
+ * context to avoid possible deadlock if usb mass
+ * storage interface or usbnet interface(iSCSI
Hi Kelvin,
On Tuesday 23 October 2012 16:13:01 Kelvin Cheung wrote:
Thank Florian.
It looks great.
However, you forget to remove corresponding section in
drivers/usb/host/ehci-hcd.c
...
#ifdef CONFIG_MACH_LOONGSON1
#include ehci-ls1x.c
#define PLATFORM_DRIVER ehci_ls1x_driver
On 10/23/2012 08:54 AM, Felipe Balbi wrote:
Hi,
Hi,
On Mon, Oct 22, 2012 at 04:26:35PM +0200, Sebastian Andrzej Siewior wrote:
after a mkdir config0 you should allocate a struct usb_configuration for this.
|+-function0
|+ name (= ether)
Here I am not
Hello Felipe, Hello Sebastian,
On Tuesday, October 23, 2012 8:55 AM Felipe Balbi wrote:
snip
Hi,
On Mon, Oct 22, 2012 at 04:26:35PM +0200, Sebastian Andrzej Siewior wrote:
after a mkdir config0 you should allocate a struct usb_configuration for
this.
|+-function0
|
On Mon, Oct 15, 2012 at 2:30 PM, Oliver Neukum oneu...@suse.de wrote:
v1:
- drop previous patch 12, and let net/core handle
runtime PM in ioctl path
Acked-by: Oliver Neukum oneu...@suse.de
David, could you queue the patchset on net-next since my some usbnet
runtime PM patches
Hi,
On Wed, Aug 8, 2012 at 11:28 AM, Rajaram R rajaram.officem...@gmail.com wrote:
On Tue, Aug 7, 2012 at 6:39 PM, Roger Quadros rog...@ti.com wrote:
Do not rely on any hints from gadget drivers and use DMA mode 1
whenever we expect data of at least the endpoint's packet size and
have not yet
Commit cfa49b4b (USB: ohci: merge ohci_finish_controller_resume with
ohci_resume) merged ohci_finish_controller_resume with ohci_resume but forgot
to update the ohci-sm501 driver accordingly, thus causing the folllowing build
failure:
drivers/usb/host/ohci-sm501.c: In function
-Original Message-
From: Venu Byravarasu
Sent: Monday, October 22, 2012 4:04 PM
To: 'ba...@ti.com'
Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
u...@vger.kernel.org; linux-ker...@vger.kernel.org
Subject: RE: [PATCH v3 resend] USB: PHY: Re-organize Tegra USB PHY
Hi,
On Tue, Oct 23, 2012 at 04:23:19PM +0530, Venu Byravarasu wrote:
-Original Message-
From: Venu Byravarasu
Sent: Monday, October 22, 2012 4:04 PM
To: 'ba...@ti.com'
Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
u...@vger.kernel.org;
On Fri, Oct 19, 2012 at 04:53:18PM +0200, Johan Hovold wrote:
Fix port-data memory leak by moving port data deallocation to
port_remove for regular ports.
Greg, please ignore this one for now.
Only moving deallocation to port probe, fixes the memory leak at
release, but port data must also be
On 10/8/2012 6:47 PM, Constantine Shulyupin wrote:
From: Constantine Shulyupin co...@makelinux.com
Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly
CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST
and set MUSB_OTG configuration by default
because this
Hi,
On Tue, Oct 23, 2012 at 06:04:53PM +0530, Sekhar Nori wrote:
On 10/8/2012 6:47 PM, Constantine Shulyupin wrote:
From: Constantine Shulyupin co...@makelinux.com
Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly
CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL
Hi Bhupesh,
On Wednesday 01 August 2012 14:57:09 Laurent Pinchart wrote:
Hi,
These 6 patches clean up the UVC gadget driver after Bhupesh Sharma's UVC
webcam gadget related changes patch series. They're what I would have asked
during patch review if the original patches hadn't been merged
Hi Laurent,
-Original Message-
From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
Sent: Tuesday, October 23, 2012 6:31 PM
To: linux-usb@vger.kernel.org
Cc: Bhupesh SHARMA
Subject: Re: [PATCH 0/6] UVC gadget cleanup
Hi Bhupesh,
On Wednesday 01 August 2012
On Mon, Oct 22, 2012 at 5:40 PM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
On Sun, Oct 21, 2012 at 06:03:24PM +0200, Ulrich Eckhardt wrote:
Hello,
I have problems to get my USB3 cardreader to work reliably when
connected to the USB3 port. Due to lack of other USB3 devices I
don't know
Hi,
On Tue, Oct 23, 2012 at 09:50:10PM +0800, Bhupesh SHARMA wrote:
Hi Laurent,
-Original Message-
From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
Sent: Tuesday, October 23, 2012 6:31 PM
To: linux-usb@vger.kernel.org
Cc: Bhupesh SHARMA
Subject: Re: [PATCH
On Tue, 23 Oct 2012, Florian Fainelli wrote:
Commit cfa49b4b (USB: ohci: merge ohci_finish_controller_resume with
ohci_resume) merged ohci_finish_controller_resume with ohci_resume but forgot
to update the ohci-sm501 driver accordingly, thus causing the folllowing build
failure:
Hi,
Whenever, software asserts, HC resets during xHCI initialization, host
controller is setting PRC and CSC (one of the version of host controller sets
WRC bit also). However, there is no handling of these bits in xHCI software.
1. At Initialization - device is NOT connected and due to HC
On Tue, 23 Oct 2012, Ankit Patel wrote:
Hi,
Whenever, software asserts, HC resets during xHCI initialization, host
controller is setting PRC and CSC (one of the version of host controller sets
WRC bit also). However, there is no handling of these bits in xHCI software.
What do you mean
Make sure command buffer is deallocated in case of errors during attach.
Cc: supp...@connecttech.com
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/whiteheat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/whiteheat.c
Here are some more fixes against v3.7-rc2. The first five
USB: metro-usb: fix port-data memory leak
USB: metro-usb: fix io after disconnect
USB: whiteheat: fix memory leak in error path
USB: whiteheat: fix port-data memory leak
USB: ch341: fix port-data memory leak
are simply resends
Make sure no control urb is submitted during close after a disconnect by
checking the disconnected flag.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/metro-usb.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git
Fix port-data memory leak by replacing attach and release with
port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Compile-only tested.
Cc:
Make sure to allocate the control-message buffer dynamically as some
platforms cannot do DMA from stack.
Note that only the first byte of the old buffer was used.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/opticon.c | 7 ++-
1 file
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that this
Fix memory leak in write error path.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/opticon.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c
index 459c288..6aba731
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the
Fix memory leak in attach error path where the read urb was never freed.
Cc: Bill Pemberton wf...@virginia.edu
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/quatech2.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Make sure no control urb is submitted during close after a disconnect by
checking the disconnected flag.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold jhov...@gmail.com
---
drivers/usb/serial/quatech2.c | 7 +++
1 file changed, 7 insertions(+)
diff --git
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the oob
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the
On Tue, Oct 23, 2012 at 10:15 PM, Alan Stern st...@rowland.harvard.edu wrote:
+ .idVendor = 0x05e3,
Can you make this a symbolic constant (USB_VENDOR_GENESYS_LOGIC)? Or
at least put a comment there?
OK, will do it in v5.
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the
On Tuesday 23 October 2012 10:20:15 Alan Stern wrote:
On Tue, 23 Oct 2012, Florian Fainelli wrote:
Hi Kelvin,
On Tuesday 23 October 2012 16:13:01 Kelvin Cheung wrote:
Thank Florian.
It looks great.
However, you forget to remove corresponding section in
On 10/23/2012 08:10 AM, Alan Stern wrote:
On Mon, 22 Oct 2012, Stephen Warren wrote:
I see. But why would it be done this way instead having a separate
property?
Well, I did say normally:-)
I can certainly see an argument for representing these differences using
custom properties,
From: Ming Lei ming@canonical.com
Date: Tue, 23 Oct 2012 17:19:29 +0800
On Mon, Oct 15, 2012 at 2:30 PM, Oliver Neukum oneu...@suse.de wrote:
v1:
- drop previous patch 12, and let net/core handle
runtime PM in ioctl path
Acked-by: Oliver Neukum oneu...@suse.de
David,
Fix NULL-pointer dereference at release by moving port data allocation
and deallocation to port_probe and port_remove.
Fix NULL-pointer dereference at disconnect by stopping port urbs at
port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the
On Tue, 23 Oct 2012, Stephen Warren wrote:
So, rather than:
compatible = usb-ehci;
You should always have e.g.:
compatible = nvidia,tegra20-ehci, usb-ehci;
Given that, there is then always enough information in the device tree
for the driver to be able to derive the other
On Tue, 23 Oct 2012, Ming Lei wrote:
With the problem of non-SMP-safe bitfields access, the power.lock should
be held, but that is not enough to prevent children from being probed or
disconnected. Looks another lock is still needed. I think a global lock
is OK in the infrequent path.
Agreed.
On Tue, 23 Oct 2012, Stephen Warren wrote:
Nothing intrinsically distinguishes this class of hardware. The only
thing these devices have in common is that they can be managed by
Linux's ehci-platform driver.
I don't agree. They're all EHCI USB controllers (or all EHCI USB
controllers
On 10/23/2012 02:33 PM, Alan Stern wrote:
On Tue, 23 Oct 2012, Stephen Warren wrote:
Nothing intrinsically distinguishes this class of hardware. The only
thing these devices have in common is that they can be managed by
Linux's ehci-platform driver.
I don't agree. They're all EHCI USB
The following changes since commit 3b6054da68f9b0d5ed6a7ed0f42a79e61904352c:
usb hub: send clear_tt_buffer_complete events when canceling TT clear work
(2012-10-22 11:34:41 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
From: Oliver Neukum oli...@neukum.org
An le16 is accessed without conversion.
This patch should be backported to kernels as old as 3.5, that contain
the commit e3567d2c15a7a8e2f992a5f7c7683453ca406d82 xhci: Add Intel
U1/U2 timeout policy.
Signed-off-by: Oliver Neukum oneu...@suse.de
From: Lan Tianyu tianyu@intel.com
Struct usb_hub_descriptor.ss.DeviceRemovable has been defined as __le16
and (__force__ __u16) doesn't need.
Signed-off-by: Lan Tianyu tianyu@intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-hub.c |5 ++---
Coverity complains that xhci_evaluate_context_result() is missing a
break statement after the COMP_EBADSLT switch case. It's not a big
deal, since we wanted to return the same error code as the case
statement below it does. The end result would be one that a Slot
Disabled error completion code
Remove the variable slot_ctx from xhci_dbg_ctx(), since it is assigned
but unused. Caught by Coverity.
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-dbg.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-dbg.c
On Tue, Oct 23, 2012 at 10:35:54AM +0300, Felipe Balbi wrote:
Hi Greg,
here's my second set of fixes for v3.7-rc cycle. Let me know if you
want any changes.
cheers
The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556:
Linux 3.7-rc2 (2012-10-20 12:11:32 -0700)
On Tue, Oct 23, 2012 at 03:53:26PM -0700, Sarah Sharp wrote:
The following changes since commit 3b6054da68f9b0d5ed6a7ed0f42a79e61904352c:
usb hub: send clear_tt_buffer_complete events when canceling TT clear work
(2012-10-22 11:34:41 -0700)
are available in the git repository at:
There are two patches on usb hub autosuspend.
Change log:
V5:
- convert a symbolic constant into macro as suggested by Alan
V4:
- rebase on 3.7-rc2-next-20121022
V3:
- don't stop suspend for !PMSG_IS_AUTO() case(1/2)
- remove one unnecessary check on
59 matches
Mail list logo