Re: Alcatel X220S HSDPA modem

2013-08-05 Thread Dan Williams
On Sun, 2013-08-04 at 01:59 +0200, Enrico Mioso wrote: Hello everybody! I'm going to investigate a little bit on an obscure Alcatel device - the Alcatel X220s, manifactured by TCT Mobile Phones. It supports a NDIS network interface, as you will be able to discover looking at the driver

Re: [PATCH] USB: serial: move the simple drivers into usb-serial-simple.c

2013-08-05 Thread Dan Williams
On Mon, 2013-08-05 at 19:41 +0800, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org Instead of having to create a new driver for a simple usb to serial device, mush them all into one file, with a macro, so as to make it easy to add new ones. Cc: René Bürgel

Re: [PATCH 1/2] net/usb: hso: allocate URB setup_packets as separate buffers

2013-08-07 Thread Dan Williams
. Tested-by: Dan Williams d...@redhat.com Cc: sta...@vger.kernel.org Signed-off-by: Jussi Kivilinna jussi.kivili...@iki.fi --- drivers/net/usb/hso.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index

Re: [PATCH 2/2] net/usb: hso: allocate serial_state_notification as separate buffer

2013-08-07 Thread Dan Williams
tested. Tested-by: Dan Williams d...@redhat.com Cc: sta...@vger.kernel.org Signed-off-by: Jussi Kivilinna jussi.kivili...@iki.fi --- drivers/net/usb/hso.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c

Re: I: Sierra.c USB Serial Driver FAQ/Feature Request

2013-08-14 Thread Dan Williams
On Wed, 2013-08-14 at 11:43 -0500, Peter Hyman wrote: Linux Kernel: 3.9.10 Device Driver: usb/serial/sierra.c Device Driver version: not known Apparently Sierra has sold the AirCard 250U product to Netgear, so I am sure driver development on drivers/usb/serial/sierra.c will be in limbo for

Re: I: Sierra.c USB Serial Driver FAQ/Feature Request

2013-08-15 Thread Dan Williams
On Thu, 2013-08-15 at 11:02 +0200, Bjørn Mork wrote: Peter Hyman p...@peterhyman.com writes: On 08/14/2013 01:42 PM, Bjørn Mork wrote: snip... Great! And if you can snoop on Windows trying to figure out how to switch the modes, then that would also help. I believe Wireshark with

Re: I: Sierra.c USB Serial Driver FAQ/Feature Request

2013-08-15 Thread Dan Williams
On Thu, 2013-08-15 at 03:47 -0500, Peter Hyman wrote: On 08/14/2013 06:03 PM, Dan Williams wrote: snip... It's almost certainly not the domain of the driver to switch this mode, it's the responsibility of userland. Kernel drivers must only talk to the device, they are not supposed to do

Re: I: Sierra.c USB Serial Driver FAQ/Feature Request

2013-08-15 Thread Dan Williams
On Thu, 2013-08-15 at 10:47 -0500, Peter Hyman wrote: On 08/15/2013 09:47 AM, Dan Williams wrote: On Thu, 2013-08-15 at 11:02 +0200, Bjørn Mork wrote: Peter Hyman p...@peterhyman.com writes: On 08/14/2013 01:42 PM, Bjørn Mork wrote: snip... Great! And if you can snoop on Windows

Re: I: Sierra.c USB Serial Driver FAQ/Feature Request

2013-08-26 Thread Dan Williams
On Sat, 2013-08-17 at 18:05 -0400, Peter Hyman wrote: On 08/17/2013 04:58 PM, Forest Bond wrote: snip... Okay, I published it here: http://www.alittletooquiet.net/media/2131024%20CDMA%20EVDO%20CnS%20Reference.pdf For the record, the document states its license as follows:

Re: [RFC 10/21] xhci: replace xhci_readl() with readl() in xhci-dbg.c

2013-09-20 Thread Dan Williams
On Thu, Sep 19, 2013 at 2:37 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Fri, Sep 13, 2013 at 03:50:48PM +0530, Pratyush Anand wrote: On Fri, Sep 13, 2013 at 3:40 PM, Xenia Ragiadakou burzalod...@gmail.comwrote: Nope :). There is still Kumar 's patch that keeps the wrappers, so

Re: [RFC 10/21] xhci: replace xhci_readl() with readl() in xhci-dbg.c

2013-09-20 Thread Dan Williams
On Thu, Sep 19, 2013 at 10:24 PM, Pratyush Anand pratyush.an...@st.com wrote: On Fri, Sep 20, 2013 at 05:37:50AM +0800, Sarah Sharp wrote: On Fri, Sep 13, 2013 at 03:50:48PM +0530, Pratyush Anand wrote: On Fri, Sep 13, 2013 at 3:40 PM, Xenia Ragiadakou burzalod...@gmail.comwrote: Nope

[PATCH 0/4] usb: xhci: change default enumeration scheme and trivial cleanups

2013-09-23 Thread Dan Williams
3.13 material. We may want the enumeration change in -stable at some point, but for now it needs more exposure. Comments welcome. -- Dan --- Dan Williams (4): usb: hub_activate kill an 'else' usb: xhci: kill a conditional when toggling cycle usb: xhci: remove the unused

[PATCH 1/4] usb: hub_activate kill an 'else'

2013-09-23 Thread Dan Williams
Remove a few extra lines and make it clear that all implementations disable the port by sharing the same line of code. Cc: Alan Stern st...@rowland.harvard.edu Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/hub.c | 11 --- 1 files changed, 4 insertions(+), 7

[PATCH 2/4] usb: xhci: kill a conditional when toggling cycle

2013-09-23 Thread Dan Williams
Perform an unconditional toggle of the cycle bit with 'xor'. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci-ring.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 411da1f

[PATCH 3/4] usb: xhci: remove the unused -address field

2013-09-23 Thread Dan Williams
Only used for debug output, so we don't need to save it. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci.c | 10 ++ drivers/usb/host/xhci.h |2 -- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb

[PATCH 4/4] usb: xhci: change enumeration scheme to 'new scheme' by default

2013-09-23 Thread Dan Williams
a SetAddress command (BSR == block set address request). Then, after GetDescriptor completes, follow up with the full AddressDevice+SetAddress operation. Reported-by: David Moore david.mo...@gmail.com Suggested-by: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Dan Williams dan.j.willi

Re: Huawei Wireless data modem in Freescale i.MX6 Board

2013-09-30 Thread Dan Williams
On Mon, 2013-09-30 at 08:37 +, Thomas TJ wrote: I'm trying to connect Huawei wireless data modem in Freescale i.MX6 Board. It's detected as a usb device and the result of lsusb is Bus 002 Device 007: ID 12d1:140b Huawei Technologies Co., Ltd. EC1260 Wireless Data Modem HSD USB Card But

Re: [PATCH 4/4] usb: xhci: change enumeration scheme to 'new scheme' by default

2013-09-30 Thread Dan Williams
On Mon, Sep 23, 2013 at 4:29 PM, Dan Williams dan.j.willi...@intel.com wrote: Change the enumeration scheme for xhci attached devices from: SetAddress GetDescriptor(8) GetDescriptor(18) ...to: GetDescriptor(64) SetAddress GetDescriptor(18) ...as some devices

Re: [PATCH 4/4] usb: xhci: change enumeration scheme to 'new scheme' by default

2013-09-30 Thread Dan Williams
Is there a commit id for this, please? and, where can I find this patch? I would like to try this on my machine as I have a device that does not enumerate on xhci only. Not upstream yet, but you can give the attached one a try. -- Dan xhci-new-scheme.patch Description: Binary data

[PATCH v2 0/5] usb: xhci: change default enumeration scheme and trivial cleanups

2013-10-07 Thread Dan Williams
or an address setup address device BSR=0 4/ Patch 1, 2, 3: unchanged [1]: http://marc.info/?l=linux-usbm=137997896602457w=2 [2]: http://marc.info/?l=linux-usbm=138074667626129w=2 This Set is against usb-next as of cccd3a25 usb: wusbcore: fix build warning on 64-bit builds --- Dan Williams (5

[PATCH v2 2/5] usb: xhci: kill a conditional when toggling cycle

2013-10-07 Thread Dan Williams
Perform an unconditional toggle of the cycle bit with 'xor'. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- No change since v1 drivers/usb/host/xhci-ring.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci

[PATCH v2 1/5] usb: hub_activate kill an 'else'

2013-10-07 Thread Dan Williams
Remove a few extra lines and make it clear that all implementations disable the port by sharing the same line of code. Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Dan Williams dan.j.willi...@intel.com --- No change since v1 drivers/usb/core/hub.c | 11 --- 1 files

[PATCH v2 3/5] usb: xhci: remove the unused -address field

2013-10-07 Thread Dan Williams
Only used for debug output, so we don't need to save it. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- No change since v1 drivers/usb/host/xhci.c | 10 ++ drivers/usb/host/xhci.h |2 -- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host

[PATCH v2 5/5] xhci: clarify logging in xhci_setup_device

2013-10-07 Thread Dan Williams
Specify whether we are only performing the context setup portion of the 'address device' command, or the full operation issuing 'SetAddress' on the wire. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- New in v2 drivers/usb/host/xhci.c | 22 -- 1 files changed

Re: [PATCH v2 4/5] usb: xhci: change enumeration scheme to 'new scheme' by default

2013-10-07 Thread Dan Williams
On Mon, Oct 7, 2013 at 12:41 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 7 Oct 2013, Dan Williams wrote: Change the default enumeration scheme for xhci attached USB 3 devices from: Careful about the distinction between USB-3 and SuperSpeed. They aren't synonymous. Ok, my

Re: Looking for a USB device that uses cdc-wdm driver

2013-10-08 Thread Dan Williams
On Tue, 2013-10-08 at 11:29 -0400, Don Zickus wrote: Hi Oliver, I am trying to verify a fix for the cdc-wdm driver and am having trouble figuring out what devices requires that driver. It seems related to cell phones but I wasn't sure if there was a particular one or all of them in general

Re: [PATCH 1/1] support new huawei devices in option.c

2013-10-11 Thread Dan Williams
On Fri, 2013-10-11 at 13:57 -0700, gre...@linuxfoundation.org wrote: On Fri, Oct 11, 2013 at 03:48:21AM +, Fangxiaozhi (Franko) wrote: 1. Add new supporting declarations to option.c, to support Huawei new devices with new bInterfaceSubClass value. Signed-off-by: fangxiaozhi

Re: [PATCH] usb: serial: option: blacklist Olivetti Olicard200

2013-10-15 Thread Dan Williams
-by: Dan Williams d...@redhat.com diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 80a7104..d7c10d6 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1257,7 +1257,9 @@ static const struct usb_device_id option_ids

Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support

2013-10-15 Thread Dan Williams
-by: Dan Williams d...@redhat.com diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 3d6aaf7..818ce90 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -714,6 +714,7 @@ static const struct usb_device_id products[] = { {QMI_FIXED_INTF

Re: [PATCH v2 4/5] usb: xhci: change enumeration scheme to 'new scheme' by default

2013-10-17 Thread Dan Williams
On Wed, Oct 16, 2013 at 3:58 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: Hi Dan, I'm attempting to put my queue together for usb-next, and this patch doesn't apply, due to conflicts in the USB core. Can you rebase this patchset on top of my for-usb-next-queue branch, and resend the

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 mbim?

2013-10-23 Thread Dan Williams
On Wed, 2013-10-23 at 22:56 +0200, Thomas Schäfer wrote: Hi, I have some news about this device. Under Windows 8.1 (6.3)(testversion) with these IDs: USB\VID_12D1PID_1F16REV_0102MI_00 USB\VID_12D1PID_1F16MI_00 USB\Class_02SubClass_0eProt_00 USB\Class_02SubClass_0e USB\Class_02

[RFC PATCH 02/15] usbcore: introduce usb_domain for tracking port-connector relationships

2013-10-24 Thread Dan Williams
_PLD (Physical Device Location) Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/Kconfig|4 + drivers/usb/core/Makefile |1 drivers/usb/core/hcd-pci.c | 17 +++- drivers/usb/core/hcd.c |2 drivers/usb/core/hub.h |8

[RFC PATCH 00/15] rework port power control

2013-10-24 Thread Dan Williams
). --- Dan Williams (15): usb: xhci: fix memleak on module removal usbcore: introduce usb_domain for tracking port-connector relationships usbcore: add sysfs linkage for connector peers PM / Runtime: Allow drivers to intercept pm qos flag changes usbcore: port power

[RFC PATCH 03/15] usbcore: add sysfs linkage for connector peers

2013-10-24 Thread Dan Williams
Use the connector association information provided by platform firmware to create links between peer ports in a connector. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/usb-platform.c | 51 +-- 1 files changed, 49 insertions(+), 2

[RFC PATCH 01/15] usb: xhci: fix memleak on module removal

2013-10-24 Thread Dan Williams
set to trigger usb_remove_hcd() to be called. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/host/xhci.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 4265b48856f6..0ea11724c5d1 100644

[RFC PATCH 04/15] PM / Runtime: Allow drivers to intercept pm qos flag changes

2013-10-24 Thread Dan Williams
...@sisk.pl Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Alan Stern st...@rowland.harvard.edu Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- Documentation/ABI/testing/sysfs-devices-power | 21 +++ Documentation/power

[RFC PATCH 05/15] usbcore: port power policy / prep for usb_port as usb_device parent

2013-10-24 Thread Dan Williams
| offsuspend 0 Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/port.c | 73 --- 1 files changed, 43 insertions(+), 30 deletions(-) diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c index 237b91bb2079

[RFC PATCH 13/15] usbcore: show port power policy

2013-10-24 Thread Dan Williams
of pm_qos_no_power_off + connect_type + peer port constraints. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/port.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c index 71fbedaf8a93

[RFC PATCH 09/15] usbcore: convert khubd to a workqueue and flush khubd on port power off

2013-10-24 Thread Dan Williams
the conversions to the async pm_runtime_put interfaces. Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Alan Stern st...@rowland.harvard.edu Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/hub.c | 118

[RFC PATCH 14/15] usbcore: add usbcore.noacpi

2013-10-24 Thread Dan Williams
Port power management places a lot of trust in the firmware api tables. Set this flag if it turns out that trust was misplaced. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- Documentation/kernel-parameters.txt |4 drivers/usb/core/usb-acpi.c |7 +++ 2 files

[RFC PATCH 08/15] usbcore: kill -is_power_on and -did_runtime_put

2013-10-24 Thread Dan Williams
re-enables ports that should otherwise be powered Yes, this is still racy, but no worse than the current solution, synchronization to come. Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/hub.c | 95

[RFC PATCH 10/15] usbcore: cleanup hub_port_connect_change and hub_power_on

2013-10-24 Thread Dan Williams
Before adding another hub-ports[port1 - 1] invocation just convert to local port_dev. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/hub.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c

[RFC PATCH 06/15] usbcore: make usb_port a proper parent of a usb_device

2013-10-24 Thread Dan Williams
| +---^---+ | +---+---+ | port | +---^---+ | +---+---+ |device | +---+ Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Alan Stern st...@rowland.harvard.edu Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/hub.c

[RFC PATCH 12/15] usbcore: allow the connect_type of ports to be changed

2013-10-24 Thread Dan Williams
hotplug ports maintain power awaiting hotplug events. Allow userspace to override this disctinction on a per port basis. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/port.c | 32 +- drivers/usb/core/usb-platform.c | 42

[RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Dan Williams
-foundation.org Cc: Joe Perches j...@perches.com Cc: Andy Whitcroft a...@canonical.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- scripts/checkpatch.pl |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 66cad506b8a2

[RFC PATCH 11/15] usbcore: power down peer port on endpoint connect

2013-10-24 Thread Dan Williams
device sleep | on suspend 0 device wake | on active child device disconnect | on suspend 0 peer connect | offsuspend 0 peer disconnect | on suspend 0 disable hotplug | offsuspend 0 Signed-off-by: Dan Williams dan.j.willi...@intel.com

[RFC PATCH 07/15] usbcore: pm_runtime honor children

2013-10-24 Thread Dan Williams
Now that ports are in the hierarchy above endpoints we can take advantage of the automatic power management of the device tree. There is now no need to power manage the hub in usb_port_runtime_{suspend|resume} Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/usb/core/hub.c

Re: [RFC PATCH 04/15] PM / Runtime: Allow drivers to intercept pm qos flag changes

2013-10-24 Thread Dan Williams
[ adding Rafael ] On Thu, Oct 24, 2013 at 12:35 AM, Dan Williams dan.j.willi...@intel.com wrote: ...because struct dev_pm_ops is too clean and uniform. USB port power management needs to manage ports that are colocated in a given connector. If we power down a connector we need to arrange

Re: [RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Dan Williams
[ adding Andy and Joe ] On Thu, Oct 24, 2013 at 12:36 AM, Dan Williams dan.j.willi...@intel.com wrote: Permit list_for_each redifinitions like: #define for_each_connector_peer(peer, port, c) \ list_for_each_entry(peer, (c)-ports, node) \ if (port != peer) ...which

Re: [RFC PATCH 00/15] rework port power control

2013-10-24 Thread Dan Williams
Hi Alan, thanks for taking a look. On Thu, Oct 24, 2013 at 10:25 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 24 Oct 2013, Dan Williams wrote: Summary: Address the following issues for port power control: 1/ Port power policy needs 'connector' awareness. 2/ Reliable port power

Re: [RFC PATCH 04/15] PM / Runtime: Allow drivers to intercept pm qos flag changes

2013-10-24 Thread Dan Williams
Hi Rafael, sorry about the email mix up. On Thu, Oct 24, 2013 at 4:08 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: + +What: /sys/devices/.../power/pm_qos_no_notify_flags +Date: October 2013 +Contact: Dan Williams dan.j.willi...@intel.com +Description

Re: [RFC PATCH 15/15] checkpatch: allow list_for_each helper macros

2013-10-24 Thread Dan Williams
On Thu, Oct 24, 2013 at 9:48 PM, Paul Zimmerman paul.zimmer...@synopsys.com wrote: From: Joe Perches [mailto:j...@perches.com] Sent: Thursday, October 24, 2013 9:34 PM On Fri, 2013-10-25 at 03:52 +, Paul Zimmerman wrote: From: Dan Williams Sent: Thursday, October 24, 2013 12:45 AM

Re: [RFC PATCH 00/15] rework port power control

2013-10-25 Thread Dan Williams
On Fri, Oct 25, 2013 at 8:23 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 24 Oct 2013, Dan Williams wrote: Details: 1/ Port power policy needs 'connector' awareness. It is a recipe for unintended device disconnects to turn off a port while leaving its peer active

Re: [RFC PATCH 00/15] rework port power control

2013-10-25 Thread Dan Williams
a working implementation that tackled the peer disconnect case, I did not expect 15 patches to fall out of that. However, after talking through this I think it can be abbreviated. On Fri, 25 Oct 2013, Dan Williams wrote: Why treat companion ports differently? Companion-ports share 1 physical

Re: [RFC PATCH 00/15] rework port power control

2013-10-28 Thread Dan Williams
On Sat, Oct 26, 2013 at 7:40 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 25 Oct 2013, Dan Williams wrote: This patch set makes a large number of significant changes to important and subtle aspects of the USB stack. It would be a lot easier to discuss in pieces; I can't possibly

Re: [RFC PATCH 00/15] rework port power control

2013-10-29 Thread Dan Williams
On Tue, Oct 29, 2013 at 8:05 AM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 28 Oct 2013, Dan Williams wrote: In fact, the reason for calling usb_autopm_get_interface was to prevent the hub from being suspended while we change the port's power state. Something like this may still

Re: [RFC] Revert sierra_net: keep status interrupt URB active

2013-11-04 Thread Dan Williams
On Fri, 2013-11-01 at 13:53 +0100, Bjørn Mork wrote: This reverts commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf. It's not easy to create a driver for all the various firmware bugs out there. This change caused regressions for a number of devices, which started to fail link detection and

Re: [RFC] Revert sierra_net: keep status interrupt URB active

2013-11-08 Thread Dan Williams
On Mon, 2013-11-04 at 14:27 -0600, Dan Williams wrote: On Fri, 2013-11-01 at 13:53 +0100, Bjørn Mork wrote: This reverts commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf. It's not easy to create a driver for all the various firmware bugs out there. This change caused regressions

Re: [RFC] Revert sierra_net: keep status interrupt URB active

2013-11-08 Thread Dan Williams
On Fri, 2013-11-08 at 21:44 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: On Mon, 2013-11-04 at 14:27 -0600, Dan Williams wrote: On Fri, 2013-11-01 at 13:53 +0100, Bjørn Mork wrote: This reverts commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf. It's not easy to create

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: Gustavo Zacarias gust...@zacarias.com.ar writes: With minicom on /dev/cdc-wdm0 after patching qmi_wwan it seems to be responsive to AT commands so yes it seems we are dealing with ECM here. I'll send a followup patch to include

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 18:03 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: Maybe run a small discussion on the ModemManager list first? This would be the first non-QMI device there, and I don't think userspace

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 18:27 +0100, Bjørn Mork wrote: Gustavo Zacarias gust...@zacarias.com.ar writes: On 11/11/2013 01:10 PM, Dan Williams wrote: This is a bit confusing... so you added the device to qmi_wwan, and now one of the AT ports works (cdc-wdm0) and the net port also works

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 18:41 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: On Mon, 2013-11-11 at 18:03 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: Maybe run a small discussion on the ModemManager

Re: [RFC] Revert sierra_net: keep status interrupt URB active

2013-11-12 Thread Dan Williams
On Tue, 2013-11-12 at 10:25 -0600, Dan Williams wrote: On Fri, 2013-11-08 at 15:29 -0600, Dan Williams wrote: On Fri, 2013-11-08 at 21:44 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: On Mon, 2013-11-04 at 14:27 -0600, Dan Williams wrote: On Fri, 2013-11-01 at 13:53

Re: TP-LINK HSUPA Modem

2013-01-09 Thread Dan Williams
On Wed, 2013-01-09 at 16:54 +0800, hockseng leow wrote: I got the dmesg after having the parameters, usbserial.vendor=0x2357 usbserial.product=0x0200 in the linux start-up. I already got the modem working under usb_modeswitch. No further work need to be done in the kernel. Are you able to

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-14 Thread Dan Williams
On Sat, 2013-01-12 at 15:35 -0800, David Miller wrote: From: Wei Shuai cpuw...@gmail.com Date: Sat, 12 Jan 2013 19:34:39 +0800 Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I introduce a flag CDC_NCM_DRIVER_DATA_NOARP which is defined in driver_info:data. so later

Re: close blocks, if FIFO full on gagdet serial

2013-01-14 Thread Dan Williams
On Sun, 2013-01-13 at 20:09 +0100, mas...@georadis.com wrote: Hello guys, I've found a following problems on BeagleBoard and Kernel 3.0.8 with gadget serial driver. Attached is a small program, which opens gadget serial tty at /dev/ttyGS0. USB is NOT connected to host. Then it fills it's

Re: [PATCH 1/2] usbnet: allow status interrupt URB to always be active

2013-01-14 Thread Dan Williams
On Sat, 2013-01-05 at 12:01 +0100, Oliver Neukum wrote: On Friday 04 January 2013 19:26:33 Dan Williams wrote: On Fri, 2013-01-04 at 23:16 +0100, Oliver Neukum wrote: On Friday 04 January 2013 10:48:16 Dan Williams wrote: Some drivers (ex sierra_net) need the status interrupt URB

Re: [PATCH 1/2] usbnet: allow status interrupt URB to always be active

2013-01-14 Thread Dan Williams
On Fri, 2013-01-11 at 11:06 +0800, Ming Lei wrote: On Sat, Jan 5, 2013 at 9:26 AM, Dan Williams d...@redhat.com wrote: On Fri, 2013-01-04 at 23:16 +0100, Oliver Neukum wrote: On Friday 04 January 2013 10:48:16 Dan Williams wrote: Some drivers (ex sierra_net) need the status interrupt URB

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-16 Thread Dan Williams
On Sat, 2013-01-12 at 19:34 +0800, Wei Shuai wrote: Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I introduce a flag CDC_NCM_DRIVER_DATA_NOARP which is defined in driver_info:data. so later on, if more such buggy devices are found, they could use same flag to handle.

Re: [PATCH 1/1] USB: option: add support for Telit LE920

2013-01-29 Thread Dan Williams
On Mon, 2013-01-28 at 16:47 +0100, Daniele Palmas wrote: From: danielepa danielepa@L2011.(none) Add PID and special handling for Telit LE920 Any idea what interfaces 1 and 5 are? Is one perhaps a pseudo-ethernet interface that could be used instead of PPP? What's the lsusb -v output for the

Re: [PATCH 1/1] USB: option: add support for Telit LE920

2013-01-29 Thread Dan Williams
On Tue, 2013-01-29 at 11:19 -0600, Dan Williams wrote: On Mon, 2013-01-28 at 16:47 +0100, Daniele Palmas wrote: From: danielepa danielepa@L2011.(none) Add PID and special handling for Telit LE920 Any idea what interfaces 1 and 5 are? Is one perhaps a pseudo-ethernet interface

Re: Adding a driver for my device

2013-01-31 Thread Dan Williams
On Thu, 2013-01-31 at 19:50 +0100, Bjørn Mork wrote: Bastian Löffler allgem...@bastian-loeffler.de writes: Hello, my device seems to be out of order since a few weeks: [ 5965.767060] usbserial_generic 1-2:1.1: generic converter detected [ 5965.767198] usb 1-2: generic converter now

[PATCH] qmi_wwan, cdc-ether: add ADU960S

2013-02-06 Thread Dan Williams
It advertises a standard CDC-ETHER interface, which actually should be driven by qmi_wwan. Signed-off-by: Dan Williams d...@redhat.com --- diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 3f3d12d..cc6d0c1 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb

[PATCH 1/2 v2] usbnet: allow status interrupt URB to always be active

2013-02-06 Thread Dan Williams
killed/re-submitted for suspend/resume, as before. Signed-off-by: Dan Williams d...@redhat.com --- Note: unchanged from previous version, but rebased. drivers/net/usb/usbnet.c | 43 +++ include/linux/usb/usbnet.h | 3 +++ 2 files changed, 34 insertions

[PATCH 2/2 v2] sierra_net: fix issues with SYNC/RESTART messages and interrupt pipe setup

2013-02-06 Thread Dan Williams
. Second, move the code that sends the SYNC message out of the bind() hook and after usbnet_probe() to ensure the interrupt URB is set up before trying to use it. Signed-off-by: Dan Williams d...@redhat.com --- drivers/net/usb/sierra_net.c | 33 ++--- 1 file changed, 26

Re: [PATCH] qmi_wwan, cdc-ether: add ADU960S

2013-02-07 Thread Dan Williams
On Wed, 2013-02-06 at 20:51 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: It advertises a standard CDC-ETHER interface, which actually should be driven by qmi_wwan. Signed-off-by: Dan Williams d...@redhat.com --- diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net

Re: [PATCH 2/2 v2] sierra_net: fix issues with SYNC/RESTART messages and interrupt pipe setup

2013-02-07 Thread Dan Williams
On Wed, 2013-02-06 at 22:11 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: As part of the initialization sequence, the driver sends a SYNC message via the control pipe to the firmware, which appears to request a firmware restart. The firmware responds with an indication

Re: [PATCH 2/2 v2] sierra_net: fix issues with SYNC/RESTART messages and interrupt pipe setup

2013-02-07 Thread Dan Williams
On Wed, 2013-02-06 at 21:17 +0100, Oliver Neukum wrote: On Wednesday 06 February 2013 12:42:56 Dan Williams wrote: As part of the initialization sequence, the driver sends a SYNC message via the control pipe to the firmware, which appears to request a firmware restart. The firmware

Re: [RFC] USB: cdc-wdm: add msgsize sysfs attribute

2013-02-13 Thread Dan Williams
On Wed, 2013-02-13 at 15:27 +0100, Oliver Neukum wrote: On Saturday 09 February 2013 20:16:20 Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: On Saturday 09 February 2013 18:41:52 Bjørn Mork wrote: Well, OK..., generic then. In the sense that the attribute stays the same

qcaux: add Franklin U600

2013-02-18 Thread Dan Williams
4 ports; AT/PPP is standard CDC-ACM. The other three (added by this patch) are QCDM/DIAG, possibly GPS, and unknown. Signed-off-by: Dan Williams d...@redhat.com --- diff --git a/drivers/usb/serial/qcaux.c b/drivers/usb/serial/qcaux.c index 9b1b96f..31f81c3 100644 --- a/drivers/usb/serial/qcaux.c

[PATCH v2] qmi_wwan, cdc-ether: add ADU960S

2013-02-18 Thread Dan Williams
It advertises a standard CDC-ETHER interface, which actually should be driven by qmi_wwan. Signed-off-by: Dan Williams d...@redhat.com --- index 3f3d12d..57136dc 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c @@ -615,6 +615,13 @@ static const struct usb_device_id

[PATCH] qcaux: add Franklin U600

2013-02-19 Thread Dan Williams
4 ports; AT/PPP is standard CDC-ACM. The other three (added by this patch) are QCDM/DIAG, possibly GPS, and unknown. Signed-off-by: Dan Williams d...@redhat.com --- This time with a [PATCH] prefix. diff --git a/drivers/usb/serial/qcaux.c b/drivers/usb/serial/qcaux.c index 9b1b96f..31f81c3

Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-06 Thread Dan Williams
On Wed, 2013-03-06 at 09:44 +0800, Greg KH wrote: On Wed, Mar 06, 2013 at 01:34:44AM +, Linlei (Lei Lin) wrote: Hello Mork, -- Because in the embedded linux system, Android, or Chrome OS, etc. They don't integrate userspace usb_modeswitch utility for switching. Why

Re: RFC: [PATCH 1/3] usb: cdc_ncm: patch for VMware

2013-03-08 Thread Dan Williams
On Fri, 2013-03-08 at 22:03 +0100, Loic Domaigne wrote: This patch limits the Rx URB size to 16kB if the driver is compiled for a VMware environment. As of workstation 9, there are some major performance problems if the Rx URB size exceeds that limit. This patch applies to longterm kernel

[RFC PATCH] qmi_wwan: set correct altsetting for Gobi 1K devices

2013-03-12 Thread Dan Williams
With Gobi 1K devices, USB interface #3's altsetting is 0 by default, but altsetting 0 only provides one interrupt endpoint and is not sufficent for QMI. Altsetting 1 provides all 3 endpoints required for qmi_wwan and works with QMI. IIRC the altsetting used to be set by qcserial back before we

Re: [PATCH net,stable-3.8] net: qmi_wwan: set correct altsetting for Gobi 1K devices

2013-03-13 Thread Dan Williams
-interface functions. Using the existence of this descriptor to detect two-interface functions is the logically correct method. Reported-by: Dan Williams d...@redhat.com Signed-off-by: Bjørn Mork Works on my UML290, Gobi3K, Gobi1K, Gobi2K, and E362. Tested-by: Dan Williams d...@redhat.com

[PATCH] qcserial: bind to DM/DIAG port on Gobi 1K devices

2013-03-13 Thread Dan Williams
Turns out we just need altsetting 1 and then we can talk to it. Signed-off-by: Dan Williams d...@redhat.com --- diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index 2466254..59b32b7 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c

Re: [PATCH] qcserial: bind to DM/DIAG port on Gobi 1K devices

2013-03-13 Thread Dan Williams
On Wed, 2013-03-13 at 08:11 -0700, Greg KH wrote: On Wed, Mar 13, 2013 at 09:58:18AM -0500, Dan Williams wrote: Turns out we just need altsetting 1 and then we can talk to it. Signed-off-by: Dan Williams d...@redhat.com Should this go to the -stable releases as well? Yeah, likely

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Dan Williams
On Wed, 2013-03-27 at 16:13 -0700, Greg KH wrote: On Wed, Mar 27, 2013 at 09:28:11PM +0100, Wesley W. Terpstra wrote: On Wed, 2013-03-27 at 13:06 -0700, Greg KH wrote: Our current prototypes borrow the Sierra VID And the USB-IF might revoke your vendor id, if they find you shipping a

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Dan Williams
On Thu, 2013-03-28 at 15:58 +0100, Wesley W. Terpstra wrote: On Thu, 2013-03-28 at 09:39 -0500, Dan Williams wrote: Greg's right, there's no reason not to use cdc-acm if you want to do that, since not all cdc-acm devices are modems. If you get a USBIF vendor ID, then I'll happily add your

[PATCH 1/2 v3] usbnet: allow status interrupt URB to always be active

2013-03-28 Thread Dan Williams
stopped it. The URB is still killed and re-submitted for suspend/resume, as before, with the same refcount it had at suspend. Signed-off-by: Dan Williams d...@redhat.com --- diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 51f3192..6431a03 100644 --- a/drivers/net/usb/usbnet.c

[PATCH 2/2 v3] sierra_net: keep status interrupt URB active

2013-03-28 Thread Dan Williams
be received even if the netdev is closed, which is the case right after device insertion. Signed-off-by: Dan Williams d...@redhat.com --- diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c index 79ab243..c707225 100644 --- a/drivers/net/usb/sierra_net.c +++ b/drivers/net/usb

[PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

2013-04-09 Thread Dan Williams
stopped it. The URB is still killed and re-submitted for suspend/resume, as before, with the same refcount it had at suspend. Signed-off-by: Dan Williams d...@redhat.com --- drivers/net/usb/usbnet.c | 79 ++ include/linux/usb/usbnet.h | 5 +++ 2 files

[PATCH 2/2 v4] sierra_net: keep status interrupt URB active

2013-04-09 Thread Dan Williams
be received even if the netdev is closed, which is the case right after device insertion. Signed-off-by: Dan Williams d...@redhat.com --- drivers/net/usb/sierra_net.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/net/usb

Re: [PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

2013-04-10 Thread Dan Williams
On Wed, 2013-04-10 at 09:23 +0200, Oliver Neukum wrote: On Tuesday 09 April 2013 18:02:27 Dan Williams wrote: Some drivers (sierra_net) need the status interrupt URB active even when the device is closed, because they receive custom indications from firmware. Add functions to refcount

Re: [PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

2013-04-10 Thread Dan Williams
On Wed, 2013-04-10 at 15:06 +0200, Oliver Neukum wrote: On Wednesday 10 April 2013 07:49:11 Dan Williams wrote: On Wed, 2013-04-10 at 09:23 +0200, Oliver Neukum wrote: On Tuesday 09 April 2013 18:02:27 Dan Williams wrote: +/* Submit the interrupt URB if it hasn't been submitted yet

Re: [PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

2013-04-10 Thread Dan Williams
On Wed, 2013-04-10 at 15:29 +0200, Oliver Neukum wrote: On Wednesday 10 April 2013 08:18:57 Dan Williams wrote: On Wed, 2013-04-10 at 15:06 +0200, Oliver Neukum wrote: On Wednesday 10 April 2013 07:49:11 Dan Williams wrote: On Wed, 2013-04-10 at 09:23 +0200, Oliver Neukum wrote

Re: [PATCH 2/2 v4] sierra_net: keep status interrupt URB active

2013-04-10 Thread Dan Williams
On Wed, 2013-04-10 at 09:15 +0200, Oliver Neukum wrote: On Tuesday 09 April 2013 18:05:51 Dan Williams wrote: The driver and firmware sync up through SYNC messages, and the firmware's affirmative reply to these SYNC messages appears to be the Reset indication received via the status

Re: [PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

2013-04-10 Thread Dan Williams
On Wed, 2013-04-10 at 15:58 +0200, Oliver Neukum wrote: On Wednesday 10 April 2013 08:54:43 Dan Williams wrote: The refcounting is very good. Just don't mess around with force That's easy to do if the helpers aren't used for suspend/resume, which is what I had previously in my v2

  1   2   3   4   5   6   7   >