Re: [RFC] scripts/get_maintainer: add emails based on keywords in the patch

2009-10-10 Thread Wolfram Sang
Perhaps it's better to use the existing MAINTAINERS file and extend it with a new K: for keyword entry. Yeah, makes sense to have everything in one file. + K: Keyword perl regex pattern to match content in patch +All patterns are surrounded by \b +for instance: K:

[patch 22/28] macintosh: Remove BKL from ans-lcd

2009-10-10 Thread Thomas Gleixner
The ans-lcd driver got the cycle_kernel_lock() in anslcd_open() from the BKL pushdown and it still uses the locked ioctl. The BKL serialization in this driver is more than obscure and definitely does not cover all possible corner cases. Protect the access to the hardware with a local mutex and

Re: [patch 22/28] macintosh: Remove BKL from ans-lcd

2009-10-10 Thread Alan Cox
There were 4 checkpatch errors on this patch, all of the type ERROR: spaces required around that '=' (ctx:WxO) #1466: FILE: drivers/macintosh/ans-lcd.c:112: + ret =-EACCES; Here's a suggestion. If a few spaces bug you that much then instead of complaining about it and