Re: [PATCH] mpc512x: Reset module

2009-09-07 Thread Wolfram Sang
in the device tree before writing to the reset module. Heh, my patch looks quite similar :) From: Wolfram Sang w.s...@pengutronix.de Subject: mpc5121: add restart capability Hack? Not intended for upstream yet. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- arch/powerpc/platforms/512x

Removing deprecated drivers from drivers/i2c/chips

2009-09-09 Thread Wolfram Sang
Hi, continuing the quest to clean up and ultimately remove the drivers/i2c/chips directory, this patch series removes three drivers for GPIO-expanders which are obsoleted and marked as deprecated for more than a year. The newer (and better) drivers can be found in drivers/gpio. As it is ensured

[PATCH 1/4] gpio/pcf857x: copy i2c_device_id from old pcf8574-driver

2009-09-09 Thread Wolfram Sang
The deprecated pcf8574 driver is going to be removed. Make sure this replacement-driver inherits all i2c_device_ids for a smooth transition. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: David Brownell dbrown...@users.sourceforge.net Cc: Jean Delvare kh...@linux-fr.org --- drivers/gpio

[PATCH 2/4] i2c/chips: Remove deprecated pcf8575-driver

2009-09-09 Thread Wolfram Sang
The pcf8575-driver in drivers/i2c/chips which just exports its register to sysfs is superseeded by drivers/gpio/pcf857x.c which properly uses the gpiolib. As this driver has been deprecated for more than a year, finally remove it. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Bart Van

[PATCH 3/4] i2c/chips: Remove deprecated pca9539-driver

2009-09-09 Thread Wolfram Sang
The pca9539-driver in drivers/i2c/chips which just exports its registers to sysfs is superseeded by drivers/gpio/pca953x.c which properly uses the gpiolib. As this driver has been deprecated for more than a year, finally remove it. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Ben Gardner

[PATCH 4/4] i2c/chips: Remove deprecated pcf8574-driver

2009-09-09 Thread Wolfram Sang
The pcf8574-driver in drivers/i2c/chips which just exports its register to sysfs is superseeded by drivers/gpio/pcf857x.c which properly uses the gpiolib. As this driver has been deprecated for more than a year, finally remove it. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Aurelien

Re: [Uclinux-dist-devel] Removing deprecated drivers from drivers/i2c/chips

2009-09-10 Thread Wolfram Sang
the Blackfin defconfigs refer to an input driver for the PCF8574, not the I2C client driver Yup, I am aware of that. With the exception of: blackfin/configs/PNAV-10_defconfig:773:CONFIG_SENSORS_PCF8574=m Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH 2/4] i2c/chips: Remove deprecated pcf8575-driver

2009-09-10 Thread Wolfram Sang
part (Detection) and 4th part (sysfs-interface) are obsolete for the new drivers. The gpiolib interface again is covered in Documentation/gpio.txt So I concluded to simply drop the documentation. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: Removing deprecated drivers from drivers/i2c/chips

2009-09-10 Thread Wolfram Sang
Not sure about the patch to drivers/gpio/pcf857x.c, as there is no gpio tree and no maintainer either AFAIK, I guess I shall pick it too? I'd say so. An Ack from David Brownell would be nice, though. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang

[PATCH] powerpc/boot/dts: drop obsolete 'fsl5200-clocking'

2009-09-10 Thread Wolfram Sang
The 'fsl5200-clocking'-property was dropped since 0d1cde235874b00905bce23f659690d060ebf475. Remove all occurences in dts-files. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca --- arch/powerpc/boot/dts/cm5200.dts |1 - arch/powerpc/boot/dts

[PATCH] powerpc/include/asm/irq.h: improve nanodoc

2009-09-10 Thread Wolfram Sang
The OF helpers look like nanodoc but are missing the header. Fix this and a typo (s/nad/and/) while we are here. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Benjamin Herrenschmidt b...@kernel.crashing.org --- arch/powerpc/include/asm/irq.h |7 --- 1 files changed, 4 insertions

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-09-14 Thread Wolfram Sang
; Please drop the clocking-line. It became obsolete. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [spi-devel-general] [PATCH] mpc52xx_psc_spi: enlarge clock range

2009-09-16 Thread Wolfram Sang
*/ + out_be32(psc-ccr, 0x0713); /* default SPI Clk 1MHz */ /* Set 2ms DTL delay */ out_8(psc-ctur, 0x00); -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: [spi-devel-general] [PATCH] mpc52xx_psc_spi: enlarge clock range

2009-09-17 Thread Wolfram Sang
query the device tree for 'fsl,mpc5200-psc-spi' or 'fsl,mpc5200b-psc-spi' and make the driver use the proper function. (BTW I haven't checked for further differences between 5200 and 5200B; there may be more) Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH] powerpc/5200: make BestComm gen_bd microcode exchangeable

2009-10-03 Thread Wolfram Sang
+bcom_gen_bd_set_microcode(struct bcom_task *tsk, u32 *microcode); + /* PSC support utility wrappers */ struct bcom_task * bcom_psc_gen_bd_rx_init(unsigned psc_num, int queue_len, -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH] powerpc/5200: make BestComm gen_bd microcode exchangeable

2009-10-03 Thread Wolfram Sang
submitted a while ago make it into the stock kernel? I have some pending extra work (16-bit LPB RAM access) building on top of it... Yup, since -rc1. (git log --grep=mtd-ram) Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux

Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101

2009-10-05 Thread Wolfram Sang
: - add comments from Grant Likely grant.lik...@secretlab.ca use mpc5200_defconfig as default configuration - add comments from Wolfram Sang w.s...@pengutronix.de - rebase against current next arch/powerpc/boot/dts/uc101.dts | 317 ++ arch/powerpc

Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101

2009-10-06 Thread Wolfram Sang
it later this day. The we can hopefully work out something. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] powerpc/boot/dts: drop obsolete 'fsl5200-clocking'

2009-10-07 Thread Wolfram Sang
On Thu, Sep 10, 2009 at 09:05:46AM -0600, Grant Likely wrote: On Thu, Sep 10, 2009 at 8:55 AM, Wolfram Sang w.s...@pengutronix.de wrote: The 'fsl5200-clocking'-property was dropped since 0d1cde235874b00905bce23f659690d060ebf475. Remove all occurences in dts-files. Signed-off

Re: [RFC PATCH 00/12] Merge common OpenFirmware device tree code

2009-10-07 Thread Wolfram Sang
However, I've completely devoted to this work for at least the next two months, so there are plenty more patches to follow. Once I've \o/ Thanks, Grant! A seperate tree would be great. Patches look good to me: Acked-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K

Re: [PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-10-07 Thread Wolfram Sang
this is sorted out, you could add my: Reviewed-by: Wolfram Sang w.s...@pengutronix.de --- - based on: git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next - checked with: $ ./scripts/checkpatch.pl 0002-mpc5200-support-for-the-MAN-mpc5200-based-board-muc.patch total: 0 errors, 0

[RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-08 Thread Wolfram Sang
to the hardware and I have seen devices with equal name and still having different pagesizes. Not too sure about 'read-only' though, I just copied it from flash-partitions :) Tested on a phyCORE-MPC5200-IO and build-tested on x86. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-08 Thread Wolfram Sang
, it can be easily extended to any arch, because there is no arch-specific stuff, but a get/put pattern for platform data. Will check this tomorrow. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-08 Thread Wolfram Sang
to come up with the best form for the pdata fetching function, but it will be better contained if it is all at a single place. I might have a try :) -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-08 Thread Wolfram Sang
, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev

[RFC] scripts/get_maintainer: add emails based on keywords in the patch

2009-10-09 Thread Wolfram Sang
approach is proposed. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Joe Perches j...@perches.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: Anton Vorontsov avoront...@ru.mvista.com --- scripts/get_maintainer.pl | 24 1 files changed, 16 insertions(+), 8 deletions

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-09 Thread Wolfram Sang
. The archdata surely helps for this issue, it just seems that a bit more generalization is needed. Kind regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-09 Thread Wolfram Sang
this will not so easily happen again (thus the get_maintainer-patch on lkml). Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [RFC] scripts/get_maintainer: add emails based on keywords in the patch

2009-10-10 Thread Wolfram Sang
OF. +K: of_get_property F: drivers/of/ Will check the script later this weekend. Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital

Re: [PATCH v4] powerpc/5200: Add mpc5200-spi (non-PSC) device driver

2009-10-21 Thread Wolfram Sang
? Or is V4 still 'status quo'? Genki de ;) Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH v4] powerpc/5200: Add mpc5200-spi (non-PSC) device driver

2009-10-21 Thread Wolfram Sang
you fixed a few things according to my review and couldn't find an updated patch for that. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

i2c/janitoral: drop NO_IRQ from the subsystem

2009-10-22 Thread Wolfram Sang
Hello, after having to deal with NO_IRQ confusion more than once, I decided to start a bit of janitorial work and remove it from the i2c-subsystem. Detail for better using 0 as no irq can be found here: http://lkml.org/lkml/2005/11/21/221 Regards, Wolfram

[PATCH 1/3] i2c/mpc: drop NO_IRQ

2009-10-22 Thread Wolfram Sang
Drop NO_IRQ as 0 is the preferred way to describe 'no irq' (http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is only used on powerpc, where NO_IRQ is 0 anyhow. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca Cc: Ben Dooks ben-li

[PATCH 2/3] i2c/cpm: drop NO_IRQ

2009-10-22 Thread Wolfram Sang
Drop NO_IRQ as 0 is the preferred way to describe 'no irq' (http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is only used on powerpc, where NO_IRQ is 0 anyhow. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Jochen Friedrich joc...@scram.de Cc: Ben Dooks ben-li

[PATCH 3/3] i2c/ibm-iic: drop NO_IRQ

2009-10-22 Thread Wolfram Sang
Drop NO_IRQ as 0 is the preferred way to describe 'no irq' (http://lkml.org/lkml/2005/11/21/221). This change is safe, as the driver is only used on powerpc, where NO_IRQ is 0 anyhow. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Sean MacLennan smaclen...@pikatech.com Cc: Ben Dooks ben-li

[PATCH] spi/mpc52xx: check for invalid PSC usage

2009-10-23 Thread Wolfram Sang
Add checks to allow only PSCs capable of SPI. Also turn printk to dev_err while we are here. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca Cc: David Brownell dbrown...@users.sourceforge.net --- Grant, if the patch is OK, maybe it can also go via

SPRN_SVR for MPC5121e?

2009-10-28 Thread Wolfram Sang
in the web. Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list

Re: SPRN_SVR for MPC5121e?

2009-10-30 Thread Wolfram Sang
We saw PVR/SVR = 0x80862010 / 0x80180010 for MPC5121 and PVR/SVR = 0x80862010 / 0x80180030 for MPC5123 Thanx a lot! -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

mpc512x/clock: fix clk_get logic

2009-10-30 Thread Wolfram Sang
is the unique identifier) - dev need not be given; if NULL, it will match any device. if given, it has to match the dev of the clock - using the above rules, both fields need to match in order to claim the clock Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Wolfgang Denk w...@denx.de Cc

Re: mpc512x/clock: fix clk_get logic

2009-10-30 Thread Wolfram Sang
On Fri, Oct 30, 2009 at 10:54:14AM +, Mark Brown wrote: On Fri, Oct 30, 2009 at 10:17:14AM +0100, Wolfram Sang wrote: The matching logic returns a clock even if only the dev-part matches. This is wrong as devices may utilize more than one clock, so the wrong clock may be returned due

[PATCH V2] mpc512x/clock: fix clk_get logic

2009-10-30 Thread Wolfram Sang
). The proposed new method will: - return -EINVAL if both arguments are NULL - skip the relevant check if one argument is NULL (first match wins) - otherwise both arguments need to match Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Mark Brown broo...@sirena.org.uk Cc: Roel Kluin roel.kl...@gmail.com Cc

[PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-10-30 Thread Wolfram Sang
, yet uncommented, patch from me has been incorporated to improve the checks if the selected PSC is valid: http://patchwork.ozlabs.org/patch/36780/ Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Kári Davíðsson kari.davids...@marel.com Cc: Grant Likely grant.lik...@secretlab.ca --- drivers/spi

Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-10-31 Thread Wolfram Sang
= DRIVER_NAME, .owner = THIS_MODULE, }, }; I am hoping that we can remove the owner and name fields from struct of_platform_driver sometime. Sounds good! :) Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux

Re: mpc512x/clock: fix clk_get logic

2009-10-31 Thread Wolfram Sang
the final decision to you maintainers, of course. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-11-02 Thread Wolfram Sang
merge it immediately into -next. One minor comment, but works in general: Acked-by: Wolfram Sang w.s...@pengutronix.de Also, I'm resistant to changing the probe layout on this driver at this time. With the work being done to generalize the OF support code, there is a strong possibility

Re: [PATCH] spi/mpc52xx: check for invalid PSC usage

2009-11-02 Thread Wolfram Sang
This driver calls mpc52xx_set_psc_clkdiv() but doesn't check its return value to see if the PSC is actually valid for SPI use. Add the check and a hint for the user. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca --- drivers/spi/mpc52xx_psc_spi.c | 12

Re: mpc512x/clock: fix clk_get logic

2009-11-02 Thread Wolfram Sang
Sure I don't have major objections against your patch (though who is formally mpc512x maintainer to ack it ?), Grant is maintainer for MPC5xxx. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

[PATCH] mpc512x/clocks: initialize CAN clocks

2009-11-02 Thread Wolfram Sang
Signed-off-by: John Rigby jri...@freescale.com Signed-off-by: Chen Hongjun hong-jun.c...@freescale.com Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Wolfgang Denk w...@denx.de Cc: Grant Likely grant.lik...@secretlab.ca --- Should come after the fix for clk_get to be usable

Re: mpc512x/clock: fix clk_get logic

2009-11-02 Thread Wolfram Sang
are still very handy to bring up a board ;) -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc

Re: [PATCH] mpc512x/clocks: initialize CAN clocks

2009-11-02 Thread Wolfram Sang
-- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

[PATCH] spi/mpc52xx: replace printk with dev_err

2009-11-04 Thread Wolfram Sang
To easily identify which device has problems. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca --- drivers/spi/mpc52xx_psc_spi.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spi/mpc52xx_psc_spi.c b/drivers/spi

[microblaze-uclinux] Re: [PATCH 02/11] of/flattree: merge of_scan_flat_dt

2009-11-09 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/3] mpc52xx_spi: fix clearing status register

2009-11-11 Thread Wolfram Sang
sure to clear the flag. Signed-off-by: Luotao Fu l...@pengutronix.de Nit below, otherwise: Acked-by: Wolfram Sang w.s...@pengutronix.de --- drivers/spi/mpc52xx_spi.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/spi/mpc52xx_spi.c b/drivers/spi

Re: [PATCH 2/3] mpc52xx_spi: add missing mode_bits definition

2009-11-11 Thread Wolfram Sang
On Tue, Nov 10, 2009 at 10:12:08AM +0100, Luotao Fu wrote: Signed-off-by: Luotao Fu l...@pengutronix.de SPI_CS_HIGH should be dropped, otherwise: Reviewed-by: Wolfram Sang w.s...@pengutronix.de --- drivers/spi/mpc52xx_spi.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

Re: [spi-devel-general] [PATCH 3/3] mpc52xx_spi: add gpio chipselect

2009-11-11 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCHv2 3/3] mpc52xx/wdt: remove obsolete old WDT implementation

2009-11-12 Thread Wolfram Sang
-$(CONFIG_MV64X60_WDT) += mv64x60_wdt.o obj-$(CONFIG_PIKA_WDT) += pika_wdt.o ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev -- Pengutronix e.K. | Wolfram Sang

Re: [PATCHv2 3/3] mpc52xx/wdt: remove obsolete old WDT implementation

2009-11-12 Thread Wolfram Sang
On Thu, Nov 12, 2009 at 09:36:42PM +0100, Albrecht Dreß wrote: Hi Wolfram: Am 12.11.09 20:56 schrieb(en) Wolfram Sang: Note: The file drivers/watchdog/mpc5200_wdt.c is now obsolete and should be removed. Ehrm, this is possible within a patch :) Ummm, I tried that (removed the file from

Re: [PATCH] mpc5200/gpt: tiny fix for gpt period limitation

2009-11-12 Thread Wolfram Sang
... -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [PATCH 3/3] [V2] mpc52xx_spi: add gpio chipselect

2009-11-13 Thread Wolfram Sang
while error or removing. Signed-off-by: Luotao Fu l...@pengutronix.de Just the kfree-comment, otherwise: Acked-by: Wolfram Sang w.s...@pengutronix.de --- drivers/spi/mpc52xx_spi.c | 64 ++--- 1 files changed, 60 insertions(+), 4 deletions(-) diff

[PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-13 Thread Wolfram Sang
Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a phyCORE-MPC5200B-IO and a custom board. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Wolfgang Grandegger w...@grandegger.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: David Miller da...@davemloft.net

Re: [PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-16 Thread Wolfram Sang
David, Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a phyCORE-MPC5200B-IO and a custom board. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Applied. Unfortunately too early. I will send my review tomorrow. Sorry for the delay. So, I'd assume

Re: [PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-16 Thread Wolfram Sang
have to find out if it is supported on that board in general. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-16 Thread Wolfram Sang
-terminated, or what do you mean? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list

updates to the mscan-driver in net-next

2009-11-16 Thread Wolfram Sang
on pengutronix.de tomorrow, I seem to have issues when trying that from home :(^ Regards, Wolfram Wolfram Sang (11): net/can/mscan: move defines into .h file net/can/mscan: trivial fixes net/can/mscan: drop support for CAN_MODE_{SLEEP|STOP} net/can/mscan: use {clr|set

[PATCH 01/11] net/can/mscan: move defines into .h file

2009-11-16 Thread Wolfram Sang
Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/net/can/mscan/mscan.c | 29 - drivers/net/can/mscan/mscan.h | 29 + 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers

[PATCH 02/11] net/can/mscan: trivial fixes

2009-11-16 Thread Wolfram Sang
- remove whitespaces - use ! and ?: when apropriate - make braces consistent Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/net/can/mscan/mpc52xx_can.c | 16 +--- drivers/net/can/mscan/mscan.c | 25 + 2 files changed, 18 insertions

[PATCH 03/11] net/can/mscan: drop support for CAN_MODE_{SLEEP|STOP}

2009-11-16 Thread Wolfram Sang
The upper layer does not support it yet. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/net/can/mscan/mscan.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c index 6394de8..839b471 100644

[PATCH 04/11] net/can/mscan: use {clr|set}bits8 macros

2009-11-16 Thread Wolfram Sang
Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/net/can/mscan/mscan.c | 19 +++ 1 files changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c index 839b471..ca8b556 100644 --- a/drivers/net/can/mscan

[PATCH 05/11] net/can/mscan: fix function annotations

2009-11-16 Thread Wolfram Sang
- use extern where apropriate - don't export symbols Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/net/can/mscan/mscan.c |3 --- drivers/net/can/mscan/mscan.h |2 +- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net

[PATCH 06/11] net/can/mscan: drop assignment in while-construct

2009-11-16 Thread Wolfram Sang
As suggested by Wolfgang Grandegger. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/net/can/mscan/mscan.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c index 76e413e..20d1991 100644

[PATCH 07/11] net/can/mpc52xx_can: refactor clock-get routine

2009-11-16 Thread Wolfram Sang
Merge two functions into one. The result is smaller as they can now share some variables. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/net/can/mscan/mpc52xx_can.c | 45 -- 1 files changed, 16 insertions(+), 29 deletions(-) diff --git a/drivers

[PATCH 08/11] net/can/mpc52xx_can: improve properties and their description

2009-11-16 Thread Wolfram Sang
Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: devicetree-disc...@ozlabs.org --- Documentation/powerpc/dts-bindings/fsl/mpc5200.txt |9 + drivers/net/can/mscan/mpc52xx_can.c|3 +-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation

[PATCH 09/11] net/can/mscan: replace hardcoded values with defines

2009-11-16 Thread Wolfram Sang
Not all hardcoded values have been replaced as this made the code quite unreadable. IMHO this compromise serves the purpose of readability. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/net/can/mscan/mscan.c | 15 ++- drivers/net/can/mscan/mscan.h |5 + 2

[PATCH 10/11] net/can/mscan: add error path to mscan_open()

2009-11-16 Thread Wolfram Sang
Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/net/can/mscan/mscan.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c index 263d1a9..bb06dfb 100644 --- a/drivers/net/can/mscan

[PATCH 11/11] net/can/mscan: improve build

2009-11-16 Thread Wolfram Sang
- move Kconfig entries to the subdirectory - do remaining renames of mpc52xx to mpc5xxx Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/net/can/Kconfig | 19 +--- drivers/net/can/mscan/Kconfig | 23 +++ drivers/net/can/mscan/Makefile |4 +- drivers

Re: updates to the mscan-driver in net-next

2009-11-17 Thread Wolfram Sang
I will also update my branch on pengutronix.de tomorrow, Done. === The following changes since commit a0a9020c1725cd5c9a13a7aab65831f3c85ea9ca: Wolfram Sang (1): net/can/mscan: final checkpatch cleanups are available in the git repository at: git://git.pengutronix.de/git/wsa

[PATCH] spi/mpc52xx-spi: cleanups

2009-11-17 Thread Wolfram Sang
- drop own, obsolete include-file - drop IRQF_SAMPLE_RANDOM (deprecated feature) - drop 'if' above kfree() - typos, braces whitespaces Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Luotao Fu l...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca --- This goes ontop of Grant's

Re: [RFC PATCH 1/5] Rework OpenFirmware GPIO handling

2009-11-17 Thread Wolfram Sang
And it turned out that the only sane solution is to write OF-pdata-hooks for the each driver (that we do for many drivers already): Or to support Grant in getting rid of of_platform :) -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: [PATCH 0/4] Merge OF dynamic patches

2009-11-18 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc

Re: [RFC PATCH 00/19] powerpc: nintendo gamecube and wii support

2009-11-22 Thread Wolfram Sang
On Sun, Nov 22, 2009 at 11:01:31PM +0100, Albert Herranz wrote: The following patches add the base support for the Nintendo GameCube and Wii video game consoles on the powerpc arch. Cool stuff! \o/ -- Pengutronix e.K. | Wolfram Sang| Industrial Linux

Re: [PATCH 00/11] Yet another series of OF merge patches.

2009-11-26 Thread Wolfram Sang
) platform. test-devicetree as of today also works fine on my phyCORE-MPC5200B-IO. Tested-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc

Re: MPC5200B XLB Configuration Issues, FEC RFIFO Events, ATA Crashes

2009-12-09 Thread Wolfram Sang
that the most interesting features are simply switched off. Regrads, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [POWERPC] add U-Boot bootcount driver.

2009-12-17 Thread Wolfram Sang
. Also, there are a few printk without loglevel. As probe has access to a device structure, dev_* should be a nice option here. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: Bestcomm tasks and interrupts on MPC5200(B)

2009-01-21 Thread Wolfram Sang
on a new release for both, the pcm030 and pcm032 having 2.6.28 for non-RT and 2.6.26 for RT. Kind regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature

mtd-ram: add of-support

2009-01-21 Thread Wolfram Sang
Hello, as we needed an of-mtd-ram driver to support SRAM on the phyCORE-MPC5200B-IO, I did the following: Patch 1: refactor plat-ram.c to have generic probe and remove routines Patch 2: use the new routines for an of-driver Looking forward to comments. (Sidenote: Converting all these

[PATCH 1/2] maps/mtd-ram: refactor probe and remove

2009-01-21 Thread Wolfram Sang
Refactor the probe and remove routines of the mtd-ram driver to export a generic part which can later be accessed by an of-counterpart of this driver. Tested with a phyCORE-MPC5200B-IO. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mtd/maps/plat-ram.c | 123

[PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-01-21 Thread Wolfram Sang
. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mtd/maps/Kconfig |6 ++ drivers/mtd/maps/Makefile |1 + drivers/mtd/maps/of-ram.c | 120 + 3 files changed, 127 insertions(+), 0 deletions(-) create mode 100644 drivers/mtd/maps

Re: [PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-01-24 Thread Wolfram Sang
Hello, found one question thing myself... On Wed, Jan 21, 2009 at 06:41:25PM +0100, Wolfram Sang wrote: Create an of-aware driver using the now exported generic functions from plat-ram.c. A typical oftree snipplet for it looks like this: s...@04e0 { compatible = mtd-ram

Re: [PATCH 1/8] powerpc/5200: update device tree binding documentation

2009-01-25 Thread Wolfram Sang
described elsewhere. Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: devtree-disc...@ozlabs.org CC: Wolfram Sang w.s...@pengutronix.de --- Documentation/powerpc/dts-bindings/fsl/mpc5200.txt | 181 + .../powerpc/mpc52xx-device-tree-bindings.txt | 277

Re: [PATCH 7/8] powerpc/5200: Refactor mpc5200 interrupt controller driver

2009-01-26 Thread Wolfram Sang
Hi Grant, I chose to line them up because in my opinion it is easier to follow the pattern with them written in horizontal columns instead of in vertical blocks. I also think the original coding style is easier to read. Kind regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http

Re: [PATCH 1/8] powerpc/5200: update device tree binding documentation

2009-01-26 Thread Wolfram Sang
that it is in Hz? Yes, like in the frequency next to it. Kind regards, Wolfram PS: The other patches look good to me, too. I just want to test them on a real phyCORE-tiny this week. -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry

Re: [PATCH 8/8] powerpc/5200: Rework GPT driver to also be an IRQ controller

2009-01-27 Thread Wolfram Sang
... Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: Sascha Hauer s.ha...@pengutronix.de CC: Wolfram Sang w.s...@pengutronix.de CC: linuxppc-dev@ozlabs.org --- arch/powerpc/platforms/52xx/Makefile |2 arch/powerpc/platforms/52xx/mpc52xx_gpio.c | 85 -- arch

Re: [PATCH 1/8] powerpc/5200: update device tree binding documentation

2009-01-29 Thread Wolfram Sang
described elsewhere. Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: devtree-disc...@ozlabs.org CC: Wolfram Sang w.s...@pengutronix.de Can you please send the updated version so I could add an reviewed-by? Regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de

Re: [PATCH 2/8] powerpc/5200: Stop using device_type and port-number properties

2009-01-29 Thread Wolfram Sang
the other devices). Userspace can query sysfs to determine what ttyPSC number is assigned to each PSC instance. Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: Wolfram Sang w.s...@pengutronix.de I like it. One more optimization below, but it's also good for now... Reviewed

Re: [PATCH 3/8] powerpc/5200: Trim cruft from device trees

2009-01-29 Thread Wolfram Sang
audited, not tested on real hardware. Signed-off-by: Grant Likely grant.lik...@secretlab.ca Reviewed-by: Wolfram Sang w.s...@pengutronix.de CC: Wolfram Sang w.s...@pengutronix.de CC: Wolfgang Grandegger w...@grandegger.com CC: Sascha Hauer s.ha...@pengutronix.de CC: Marian Balakowicz m

Re: [PATCH 5/8] powerpc/5200: Don't specify IRQF_SHARED in PSC UART driver

2009-01-29 Thread Wolfram Sang
the IRQF_DISABLED is not guaranteed on shared IRQs warning message from the console output. Signed-off-by: Grant Likely grant.lik...@secretlab.ca What do I give here? Acked-by? Reviewed? Tested? :D I'll make a guess: Reviewed-by: Wolfram Sang w.s...@pengutronix.de --- drivers/serial/mpc52xx_uart.c

Re: [PATCH 6/8] powerpc/5200: Remove pr_debug() from hot paths in irq driver

2009-01-29 Thread Wolfram Sang
. Signed-off-by: Grant Likely grant.lik...@secretlab.ca Yup! Reviewed-by: Wolfram Sang w.s...@pengutronix.de --- arch/powerpc/platforms/52xx/mpc52xx_pic.c | 23 --- 1 files changed, 0 insertions(+), 23 deletions(-) diff --git a/arch/powerpc/platforms/52xx

Re: [PATCH 7/8] powerpc/5200: Refactor mpc5200 interrupt controller driver

2009-01-29 Thread Wolfram Sang
). The simplification is due to splitting off the handling of external IRQs into a separate block so they don't need to be handled as exceptions in the normal CRIT, MAIN and PERP paths. Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: Wolfram Sang w.s...@pengutronix.de Can't say much about this one

Re: [PATCH] powerpc/5200: Bugfix for PCI mapping of memory and IMMR

2009-01-29 Thread Wolfram Sang
. Without this patch, PCI appears to work correctly until a PCI device is inserted which DMAs into memory. Signed-off-by: Grant Likely grant.lik...@secretlab.ca No regression with a phyCORE-MPC5200B-tiny. U-Boot did probably the right thing here... Tested-by: Wolfram Sang w.s...@pengutronix.de

Re: [PATCH] powerpc/5200: update device tree binding documentation

2009-01-29 Thread Wolfram Sang
elsewhere. Signed-off-by: Grant Likely grant.lik...@secretlab.ca One minor nit, then you can add Reviewed-by: Wolfram Sang w.s...@pengutronix.de CC: devicetree-disc...@ozlabs.org CC: Wolfram Sang w.s...@pengutronix.de --- Documentation/powerpc/dts-bindings/fsl/mpc5200.txt | 180

  1   2   3   4   5   6   7   >