Re: [PATCH 0/6] ipmi: Convert to platform remove callback returning void

On Thu, Apr 11, 2024 at 09:15:03AM +0200, Uwe Kleine-König wrote: > Hello, > > On Tue, Mar 05, 2024 at 05:26:57PM +0100, Uwe Kleine-König wrote: > > this series converts all drivers below drivers/char/ipmi to struct > > platform_driver::remove_new(). See commit 5c5a7680e67b ("platform: Provide a

Re: [PATCH 6/9] ipmi: Convert from tasklet to BH workqueue

t; > own > > > workqueue. > > > > > > Thanks for taking time out to review. > > > > After looking and thinking about it a bit, a BH context is still > > probably the best for this. > > > > I have tested this patch under load and vari

Re: [PATCH 6/9] ipmi: Convert from tasklet to BH workqueue

On Thu, Mar 28, 2024 at 10:52:16AM -0700, Allen wrote: > On Wed, Mar 27, 2024 at 11:05 AM Corey Minyard wrote: > > > > I believe that work queues items are execute single-threaded for a work > > queue, so this should be good. I need to test this, though. It may be > &

Re: [PATCH 6/9] ipmi: Convert from tasklet to BH workqueue

On Wed, Mar 27, 2024 at 04:03:11PM +, Allen Pais wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A BH workqueue > behaves

Re: [PATCH 21/30] panic: Introduce the panic pre-reboot notifier list

ent() and the IPMI panic_event()] > due to the risks they offer (may not return, for example). > Proper documentation is going to be provided in a subsequent patch, > that effectively refactors the panic path. For the IPMI portion: Acked-by: Corey Minyard Note that the IPMI panic_event()

Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers

b folder to use new header. > Though for time being include new header back to kernel.h to avoid twisted > indirected includes for existing users. For the IPMI portion: Acked-by: Corey Minyard > > Signed-off-by: Andy Shevchenko > --- > arch/powerpc/kernel/setup-common.c | 1

Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

On 01/17/2018 10:04 PM, Alexey Kardashevskiy wrote: On 17/01/18 22:25, Wei Yongjun wrote: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Reviewed-by: Alexey

Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

On 01/17/2018 05:25 AM, Wei Yongjun wrote: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. I think you are right here.  However, you had a bunch of people on the email that probably didn't need to be there, and

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

On 12/19/2017 12:15 PM, Joe Perches wrote: drivers/char/ipmi/ipmi_msghandler.c| 17 +++--- For ipmi: Acked-by: Corey Minyard <cminy...@mvista.com>

Re: [PATCH] char: ipmi: constify ipmi_smi_handlers structures

On 01/15/2017 01:15 PM, Bhumika Goyal wrote: Declare ipmi_smi_handlers structures as const as they are only passed as an argument to the function ipmi_register_smi. This argument is of type const, so ipmi_smi_handlers structures having similar properties can be declared const too. Done using

Re: [Openipmi-developer] [PATCH 3/4] ipmi: allow dynamic BMC version information

On 09/12/2016 03:55 AM, Jeremy Kerr wrote: Currently, it's up to the IPMI SMIs to provide the product & version details of BMCs behind registered IPMI SMI interfaces. This device ID is provided on SMI regsitration, and kept around for all future queries. However, this version information isn't

Re: [PATCH] ipmi/powernv: Fix potential invalid pointer dereference

Ok, this looks fine. A couple of question... Do I need to send this upstream right now? How well has this been tested? Do you want this backported to 4.0 stable? -corey On 07/16/2015 06:16 AM, Neelesh Gupta wrote: If the OPAL call to receive the ipmi message fails, then we free up the smi

Re: [PATCH v3 2/8] ipmi/powernv: Convert to irq event interface

On 05/06/2015 10:16 PM, Alistair Popple wrote: Convert the opal ipmi driver to use the new irq interface for events. Signed-off-by: Alistair Popple alist...@popple.id.au Cc: Corey Minyard miny...@acm.org Cc: openipmi-develo...@lists.sourceforge.net --- Corey, If this looks ok can you

Re: [PATCH v2] drivers/char/ipmi: Add powernv IPMI driver

This looks good. Can this go into the IPMI tree now, or does it need work done in the PowerPC tree first? Thanks, -corey On 11/12/2014 01:41 AM, Jeremy Kerr wrote: This change adds an initial IPMI driver for powerpc OPAL firmware. The interface is exposed entirely through firmware: we have

[PATCH] powerpc: Add coherent_dma_mask to mv64x60 devices

From: Corey Minyard cminy...@mvista.com DMA ops requires that coherent_dma_mask be set properly for a device, but this was not being done for devices on the MV64x60 that use DMA. Both the serial and ethernet devices need this or they won't be able to allocate memory. Signed-off-by: Corey Minyard

Re: [PATCH] powerpc: Add DMA mask to MPSC serial and network and UART device to serial

Benjamin Herrenschmidt wrote: On Fri, 2010-01-29 at 18:04 -0600, Corey Minyard wrote: From: Corey Minyard cminy...@mvista.com The MPSC drivers that use DMA need to set coherent_dma_mask to allow dma_alloc_xxx routines to work properly. Also, the mpsc serial driver needed to set pi-port.dev

[PATCH] powerpc: Set the port device in the mpsc serial driver

From: Corey Minyard cminy...@mvista.com The mpsc serial driver needx to set the port's device tree element to register properly. Signed-off-by: Corey Minyard cminy...@mvista.com --- Index: linux-2.6/drivers/serial/mpsc.c

[PATCH] powerpc: Add coherent_dma_mask setting to platform devices

From: Corey Minyard cminy...@mvista.com DMA ops requires that coherent_dma_mask be set properly for a device, but this was not being done for platform devices on powerpc. The MPSC drivers, in particular, need this for both serial and ethernet or they won't be able to allocate memory. Signed-off

[PATCH] powerpc: Add a new platform for maple so a different link address can be set

From: Corey Minyard cminy...@mvista.com The maple platform failed to load because it's firmware could not take a link address of 0x400. A new platform type with a link address of 0x40 had to be created for the maple. Signed-off-by: Corey Minyard cminy...@mvista.com --- Without

[PATCH] powerpc: Add DMA mask to MPSC serial and network and UART device to serial

From: Corey Minyard cminy...@mvista.com The MPSC drivers that use DMA need to set coherent_dma_mask to allow dma_alloc_xxx routines to work properly. Also, the mpsc serial driver needed to set pi-port.dev to register properly. With these fixes, the MPSC drivers seem to work again. Signed-off