Re: [LyX/master] BufferParams: get rid of the HSpace class for mathindent as requested by JMarc

2017-04-24 Thread Jean-Marc Lasgouttes
Le 20/04/17 à 23:17, Uwe Stöhr a écrit : In your changes you reverted the allowMathIndent() routine in GuiDocument. This is necessary because now we have a bug: - set default math indent - now change to custom and input a length and press Apply - now uncheck "Indent Formulas" result: the length

Re: [LyX/master] BufferParams: get rid of the HSpace class for mathindent as requested by JMarc

2017-04-20 Thread Uwe Stöhr
El 20.04.2017 a las 23:17, Uwe Stöhr escribió: I have seen your changes but now LyX has no longer the GlueLength ability as you noted. Sorry. This ability was not in LyX. glue lengths are not allowed as parameter of \setspace. So having HSpace there was indeed never necessary. thanks and

Re: [LyX/master] BufferParams: get rid of the HSpace class for mathindent as requested by JMarc

2017-04-20 Thread Uwe Stöhr
El 20.04.2017 a las 18:11, Jean-Marc Lasgouttes escribió: I turns out that I committed it by mistake. Please complain if something is wrong. I did in my previous mail and just put in a fix for the error I get. thanks for your work and regards Uwe

Re: [LyX/master] BufferParams: get rid of the HSpace class for mathindent as requested by JMarc

2017-04-20 Thread Uwe Stöhr
El 19.04.2017 a las 11:58, Jean-Marc Lasgouttes escribió: HSpace is a class that contains a GlueLength, a complex class that handles subleties of a length like 1cm-2mm+3mm. Is that "just a string" to you?? "1cm-2mm+3mm" is a string to me, yes. I did not need the special features of the

Re: [LyX/master] BufferParams: get rid of the HSpace class for mathindent as requested by JMarc

2017-04-20 Thread Jean-Marc Lasgouttes
Le 19/04/2017 à 18:15, Jean-Marc Lasgouttes a écrit : The attached patches (1) revert your patch and (2) use a Length object instead of HSpace (as well as rename variables with the shorter mathindent name). If it is OK with you I will commit these, and then commit a change to make the

Re: [LyX/master] BufferParams: get rid of the HSpace class for mathindent as requested by JMarc

2017-04-19 Thread Jean-Marc Lasgouttes
Le 18/04/2017 à 15:54, Jean-Marc Lasgouttes a écrit : Getting rid of the proper length in favor of the weird string version was definitely not what I had in mind. What I meant is that the HSpace class is not useful and that a simple Length class would have been a better choice. I'll see what I

Re: [LyX/master] BufferParams: get rid of the HSpace class for mathindent as requested by JMarc

2017-04-19 Thread Jean-Marc Lasgouttes
Le 18/04/2017 à 22:45, Uwe Stöhr a écrit : El 18.04.2017 a las 15:54, Jean-Marc Lasgouttes escribió: Getting rid of the proper length in favor of the weird string version was definitely not what I had in mind. I cannot follow you anymore. What i did is just what the HSpace class does - it is

Re: [LyX/master] BufferParams: get rid of the HSpace class for mathindent as requested by JMarc

2017-04-18 Thread Uwe Stöhr
El 18.04.2017 a las 22:45, Uwe Stöhr escribió: I am insisting because I will send right now a patch I sent it now and CCed you. Could you please have a look? thanks and regards Uwe

Re: [LyX/master] BufferParams: get rid of the HSpace class for mathindent as requested by JMarc

2017-04-18 Thread Uwe Stöhr
El 18.04.2017 a las 15:54, Jean-Marc Lasgouttes escribió: Getting rid of the proper length in favor of the weird string version was definitely not what I had in mind. I cannot follow you anymore. What i did is just what the HSpace class does - it is a string using "default" ads default

Re: [LyX/master] BufferParams: get rid of the HSpace class for mathindent as requested by JMarc

2017-04-18 Thread Jean-Marc Lasgouttes
Le 17/04/2017 à 20:32, Uwe Stöhr a écrit : commit d9a2a4026800865b15da186620ffab4c6b409765 Author: Uwe Stöhr Date: Mon Apr 17 20:32:31 2017 +0200 BufferParams: get rid of the HSpace class for mathindent as requested by JMarc Getting rid of the proper length in favor