Re: [PATCH] CT output for pdflatex

2007-05-22 Thread Michael Gerz
José Matos schrieb: On Saturday 12 May 2007 8:48:24 pm Michael Gerz wrote: Folks, this patch brings change tracking output to the PDF world. OK to commit? What is the status of this? It has been committed. Michael

Re: [PATCH] CT output for pdflatex

2007-05-22 Thread Michael Gerz
José Matos schrieb: On Saturday 12 May 2007 8:48:24 pm Michael Gerz wrote: Folks, this patch brings change tracking output to the PDF world. OK to commit? What is the status of this? It has been committed. Michael

Re: [PATCH] CT output for pdflatex

2007-05-19 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: On Sat, 12 May 2007, Michael Gerz wrote: this patch brings change tracking output to the PDF world. What's up with the long lines? What do you mean? Michael

Re: [PATCH] CT output for pdflatex

2007-05-19 Thread christian . ridderstrom
On Sat, 19 May 2007, Michael Gerz wrote: [EMAIL PROTECTED] schrieb: On Sat, 12 May 2007, Michael Gerz wrote: this patch brings change tracking output to the PDF world. What's up with the long lines? What do you mean? My memory might be wrong, but weren't some of the lines rather long?

Re: [PATCH] CT output for pdflatex

2007-05-19 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: On Sat, 12 May 2007, Michael Gerz wrote: this patch brings change tracking output to the PDF world. What's up with the long lines? What do you mean? Michael

Re: [PATCH] CT output for pdflatex

2007-05-19 Thread christian . ridderstrom
On Sat, 19 May 2007, Michael Gerz wrote: [EMAIL PROTECTED] schrieb: On Sat, 12 May 2007, Michael Gerz wrote: > this patch brings change tracking output to the PDF world. What's up with the long lines? What do you mean? My memory might be wrong, but weren't some of the lines rather

Re: [PATCH] CT output for pdflatex

2007-05-17 Thread José Matos
On Saturday 12 May 2007 8:48:24 pm Michael Gerz wrote: Folks, this patch brings change tracking output to the PDF world. OK to commit? What is the status of this? Michael -- José Abílio

Re: [PATCH] CT output for pdflatex

2007-05-17 Thread José Matos
On Saturday 12 May 2007 8:48:24 pm Michael Gerz wrote: > Folks, > > this patch brings change tracking output to the PDF world. > > OK to commit? What is the status of this? > Michael -- José Abílio

Re: [PATCH] CT output for pdflatex

2007-05-15 Thread Herbert Voss
Michael Gerz wrote: Herbert Voss schrieb: Michael Gerz wrote: +\TestPackage{pdfcolmk} is senseless for the current pdftex, which has it already builtin But there are people with elder versions of pdflatex, I guess. The latest MikTeX has MiKTeX-pdfetex 2.5.2645 (1.30.6)

Re: [PATCH] CT output for pdflatex

2007-05-15 Thread Herbert Voss
Michael Gerz wrote: > Herbert Voss schrieb: >> Michael Gerz wrote: >> >> >>> +\TestPackage{pdfcolmk} >>> >> >> is senseless for the current pdftex, which has it already builtin >> > But there are people with elder versions of pdflatex, I guess. The > latest MikTeX has > >

Re: [PATCH] CT output for pdflatex

2007-05-14 Thread Jürgen Spitzmüller
Herbert Voss wrote: \textcolor{blue}{{ foo }}bar baz has a space as first character. This makes no sense at the beginning of a line. {\color{blue}{ foo }}bar baz is correct, no space at the beginning of a line but a space in a line: foo{\color{blue}{ foo }}bar baz this color setting is

Re: [PATCH] CT output for pdflatex

2007-05-14 Thread Jürgen Spitzmüller
Herbert Voss wrote: > \textcolor{blue}{{ foo }}bar baz > has a space as first character. This makes no sense at the beginning of > a line. > > {\color{blue}{ foo }}bar baz > > is correct, no space at the beginning of a line but a space in a > line: > > foo{\color{blue}{ foo }}bar baz > > this

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Andre Poenitz
On Sat, May 12, 2007 at 11:18:50PM +0200, Herbert Voss wrote: Michael Gerz wrote: + \\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n + \\newcommand{\\lyxdeleted}[3]{\\textcolor{red}{\\st{#3}}}\n; I forgot to say, that you should choose names like [EMAIL PROTECTED] and

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Herbert Voss
Andre Poenitz wrote: On Sat, May 12, 2007 at 11:18:50PM +0200, Herbert Voss wrote: Michael Gerz wrote: + \\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n + \\newcommand{\\lyxdeleted}[3]{\\textcolor{red}{\\st{#3}}}\n; I forgot to say, that you should choose names like [EMAIL

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Michael Gerz
Herbert Voss schrieb: better, _after_ the user preamble: \providecolor{lyxinserted}{rgb}{1,0,0} \providecolor{lyxdeleted}{rgb}{0,0,1} +\\newcommand{\\lyxinserted}[3]{\\textcolor{lyxinserted}{#3}}\n + \\newcommand{\\lyxdeleted}[3]{\\textcolor{lyxdeleted}{\\st{#3}}}\n; then the

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Jürgen Spitzmüller
Herbert Voss wrote: why are the colors hardcoded? better, _after_ the user preamble:   \providecolor{lyxinserted}{rgb}{1,0,0}   \providecolor{lyxdeleted}{rgb}{0,0,1} Even better: use the colors that are specified in Prefs-Colors. Jürgen

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Michael Gerz
Michael Gerz schrieb: Herbert Voss schrieb: better, _after_ the user preamble: \providecolor{lyxinserted}{rgb}{1,0,0} \providecolor{lyxdeleted}{rgb}{0,0,1} +\\newcommand{\\lyxinserted}[3]{\\textcolor{lyxinserted}{#3}}\n +

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Jürgen Spitzmüller
Michael Gerz wrote: After some (short) investigation, I came to the conclusion that using the colors defined within LyX is not that trivial. Why? Look at shadecolor (in LaTeXFeatures.cpp) for a model. Something like (untested): RGBColor c =

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Michael Gerz
Jürgen Spitzmüller schrieb: Michael Gerz wrote: After some (short) investigation, I came to the conclusion that using the colors defined within LyX is not that trivial. Why? Look at shadecolor (in LaTeXFeatures.cpp) for a model. Something like (untested): Ah, learning from the

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Herbert Voss
Michael Gerz wrote: +\TestPackage{pdfcolmk} is senseless for the current pdftex, which has it already builtin \TestPackage{prettyref} \TestPackage{preview} \TestPackage{rotating} \TestPackage{setspace} +\TestPackage{soul} \TestPackage{subfigure} subfigure is superseeded by subfig

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Michael Gerz
Herbert Voss schrieb: Michael Gerz wrote: +\TestPackage{pdfcolmk} is senseless for the current pdftex, which has it already builtin But there are people with elder versions of pdflatex, I guess. The latest MikTeX has MiKTeX-pdfetex 2.5.2645 (1.30.6) (MiKTeX 2.5)

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Jürgen Spitzmüller
Michael Gerz wrote: Thanks, Jürgen. Are you happy with the attached patch? Looks good. You need to add documentation for xcolor and soul in LaTeXConfig.lyx.in (at least), though. Jürgen

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Michael Gerz
Jürgen Spitzmüller schrieb: Michael Gerz wrote: Thanks, Jürgen. Are you happy with the attached patch? Looks good. You need to add documentation for xcolor and soul in LaTeXConfig.lyx.in (at least), though. After Wednesday. Currently, I am swamped with work. Michael

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Jürgen Spitzmüller
Michael Gerz wrote: After Wednesday. Currently, I am swamped with work. I'll do that. Furthermore, I have fixed an assert because lyxasserted and lyxdeleted did not have proper x11 names. I wonder why you did not run accross that. I detected another problem: preceeding blanks are swallowed by

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Herbert Voss
Jürgen Spitzmüller wrote: Michael Gerz wrote: After Wednesday. Currently, I am swamped with work. I'll do that. Furthermore, I have fixed an assert because lyxasserted and lyxdeleted did not have proper x11 names. I wonder why you did not run accross that. I detected another problem:

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Jürgen Spitzmüller
Herbert Voss wrote: where is the sense having the spaces inside the argument? The macro embraces all newly added text. So if I have a phrase this is it. and add this is it now. the lyxdeleted macro includes the preceding blank, because it belongs to the added text (and must not be output if the

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Herbert Voss
Jürgen Spitzmüller wrote: Herbert Voss wrote: where is the sense having the spaces inside the argument? The macro embraces all newly added text. So if I have a phrase this is it. and add this is it now. the lyxdeleted macro includes the preceding blank, because it belongs to the added

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread christian . ridderstrom
On Sat, 12 May 2007, Michael Gerz wrote: this patch brings change tracking output to the PDF world. What's up with the long lines? /Christian -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Andre Poenitz
On Sat, May 12, 2007 at 11:18:50PM +0200, Herbert Voss wrote: > Michael Gerz wrote: > > > + "\\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n" > > + "\\newcommand{\\lyxdeleted}[3]{\\textcolor{red}{\\st{#3}}}\n"; > > > I forgot to say, that you should choose names like > > [EMAIL

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Herbert Voss
Andre Poenitz wrote: > On Sat, May 12, 2007 at 11:18:50PM +0200, Herbert Voss wrote: >> Michael Gerz wrote: >> >>> + "\\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n" >>> + "\\newcommand{\\lyxdeleted}[3]{\\textcolor{red}{\\st{#3}}}\n"; >> >> I forgot to say, that you should choose

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Michael Gerz
Herbert Voss schrieb: better, _after_ the user preamble: \providecolor{lyxinserted}{rgb}{1,0,0} \providecolor{lyxdeleted}{rgb}{0,0,1} +"\\newcommand{\\lyxinserted}[3]{\\textcolor{lyxinserted}{#3}}\n" + "\\newcommand{\\lyxdeleted}[3]{\\textcolor{lyxdeleted}{\\st{#3}}}\n"; then

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Jürgen Spitzmüller
Herbert Voss wrote: > why are the colors hardcoded? > > better, _after_ the user preamble: > >   \providecolor{lyxinserted}{rgb}{1,0,0} >   \providecolor{lyxdeleted}{rgb}{0,0,1} Even better: use the colors that are specified in Prefs->Colors. Jürgen

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Michael Gerz
Michael Gerz schrieb: Herbert Voss schrieb: better, _after_ the user preamble: \providecolor{lyxinserted}{rgb}{1,0,0} \providecolor{lyxdeleted}{rgb}{0,0,1} +"\\newcommand{\\lyxinserted}[3]{\\textcolor{lyxinserted}{#3}}\n" +

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Jürgen Spitzmüller
Michael Gerz wrote: > After some (short) investigation, I came to the conclusion that using > the colors defined within LyX is not that trivial. Why? Look at shadecolor (in LaTeXFeatures.cpp) for a model. Something like (untested): RGBColor c =

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Michael Gerz
Jürgen Spitzmüller schrieb: Michael Gerz wrote: After some (short) investigation, I came to the conclusion that using the colors defined within LyX is not that trivial. Why? Look at shadecolor (in LaTeXFeatures.cpp) for a model. Something like (untested): Ah, learning from the

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Herbert Voss
Michael Gerz wrote: > +\TestPackage{pdfcolmk} is senseless for the current pdftex, which has it already builtin > \TestPackage{prettyref} > \TestPackage{preview} > \TestPackage{rotating} > \TestPackage{setspace} > +\TestPackage{soul} > \TestPackage{subfigure} subfigure is superseeded by

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Michael Gerz
Herbert Voss schrieb: Michael Gerz wrote: +\TestPackage{pdfcolmk} is senseless for the current pdftex, which has it already builtin But there are people with elder versions of pdflatex, I guess. The latest MikTeX has MiKTeX-pdfetex 2.5.2645 (1.30.6) (MiKTeX 2.5)

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Jürgen Spitzmüller
Michael Gerz wrote: > Thanks, Jürgen. Are you happy with the attached patch? Looks good. You need to add documentation for xcolor and soul in LaTeXConfig.lyx.in (at least), though. Jürgen

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Michael Gerz
Jürgen Spitzmüller schrieb: Michael Gerz wrote: Thanks, Jürgen. Are you happy with the attached patch? Looks good. You need to add documentation for xcolor and soul in LaTeXConfig.lyx.in (at least), though. After Wednesday. Currently, I am swamped with work. Michael

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Jürgen Spitzmüller
Michael Gerz wrote: > After Wednesday. Currently, I am swamped with work. I'll do that. Furthermore, I have fixed an assert because lyxasserted and lyxdeleted did not have proper x11 names. I wonder why you did not run accross that. I detected another problem: preceeding blanks are swallowed

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Herbert Voss
Jürgen Spitzmüller wrote: > Michael Gerz wrote: >> After Wednesday. Currently, I am swamped with work. > > I'll do that. Furthermore, I have fixed an assert because lyxasserted and > lyxdeleted did not have proper x11 names. I wonder why you did not run > accross that. > > I detected another

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Jürgen Spitzmüller
Herbert Voss wrote: > where is the sense having the spaces inside the argument? The macro embraces all newly added text. So if I have a phrase "this is it." and add "this is it now." the lyxdeleted macro includes the preceding blank, because it belongs to the added text (and must not be output

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread Herbert Voss
Jürgen Spitzmüller wrote: > Herbert Voss wrote: >> where is the sense having the spaces inside the argument? > > The macro embraces all newly added text. So if I have a phrase > "this is it." > and add > "this is it now." > the lyxdeleted macro includes the preceding blank, because it belongs to

Re: [PATCH] CT output for pdflatex

2007-05-13 Thread christian . ridderstrom
On Sat, 12 May 2007, Michael Gerz wrote: this patch brings change tracking output to the PDF world. What's up with the long lines? /Christian -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr

[PATCH] CT output for pdflatex

2007-05-12 Thread Michael Gerz
Folks, this patch brings change tracking output to the PDF world. OK to commit? Michael Index: src/BufferView.cpp === --- src/BufferView.cpp (Revision 18279) +++ src/BufferView.cpp (Arbeitskopie) @@ -891,17 +891,21 @@ case

Re: [PATCH] CT output for pdflatex

2007-05-12 Thread Herbert Voss
Michael Gerz wrote: this patch brings change tracking output to the PDF world. +static string const changetracking_xcolorsoul_def = + \\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n + \\newcommand{\\lyxdeleted}[3]{\\textcolor{red}{\\st{#3}}}\n; why are the colors hardcoded?

Re: [PATCH] CT output for pdflatex

2007-05-12 Thread Michael Gerz
Herbert Voss schrieb: Michael Gerz wrote: this patch brings change tracking output to the PDF world. +static string const changetracking_xcolorsoul_def = + \\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n +

Re: [PATCH] CT output for pdflatex

2007-05-12 Thread Herbert Voss
Michael Gerz wrote: Herbert Voss schrieb: Michael Gerz wrote: this patch brings change tracking output to the PDF world. +static string const changetracking_xcolorsoul_def = +\\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n +

Re: [PATCH] CT output for pdflatex

2007-05-12 Thread Herbert Voss
Michael Gerz wrote: + \\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n + \\newcommand{\\lyxdeleted}[3]{\\textcolor{red}{\\st{#3}}}\n; I forgot to say, that you should choose names like [EMAIL PROTECTED] and [EMAIL PROTECTED] Then it is not so easy, that a user chooses such

[PATCH] CT output for pdflatex

2007-05-12 Thread Michael Gerz
Folks, this patch brings change tracking output to the PDF world. OK to commit? Michael Index: src/BufferView.cpp === --- src/BufferView.cpp (Revision 18279) +++ src/BufferView.cpp (Arbeitskopie) @@ -891,17 +891,21 @@ case

Re: [PATCH] CT output for pdflatex

2007-05-12 Thread Herbert Voss
Michael Gerz wrote: > > this patch brings change tracking output to the PDF world. > +static string const changetracking_xcolorsoul_def = > + "\\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n" > + "\\newcommand{\\lyxdeleted}[3]{\\textcolor{red}{\\st{#3}}}\n"; why are the colors

Re: [PATCH] CT output for pdflatex

2007-05-12 Thread Michael Gerz
Herbert Voss schrieb: Michael Gerz wrote: this patch brings change tracking output to the PDF world. +static string const changetracking_xcolorsoul_def = + "\\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n" +

Re: [PATCH] CT output for pdflatex

2007-05-12 Thread Herbert Voss
Michael Gerz wrote: > Herbert Voss schrieb: >> Michael Gerz wrote: >> >>> this patch brings change tracking output to the PDF world. >>> >> >> >>> +static string const changetracking_xcolorsoul_def = >>> +"\\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n" >>> +

Re: [PATCH] CT output for pdflatex

2007-05-12 Thread Herbert Voss
Michael Gerz wrote: > + "\\newcommand{\\lyxinserted}[3]{\\textcolor{blue}{#3}}\n" > + "\\newcommand{\\lyxdeleted}[3]{\\textcolor{red}{\\st{#3}}}\n"; I forgot to say, that you should choose names like [EMAIL PROTECTED] and [EMAIL PROTECTED] Then it is not so easy, that a user chooses