Andre Poenitz wrote:
Thanks (thank God there are frontends like KFileRename nowadays).
You mean replacements for perl -pie 's/foo/bar/g' *.[Ch] ?
Yes. GUIs for ignorants like me :-)
Jürgen
Andre Poenitz wrote:
> > Thanks (thank God there are frontends like KFileRename nowadays).
>
> You mean replacements for perl -pie 's/foo/bar/g' *.[Ch] ?
Yes. GUIs for ignorants like me :-)
Jürgen
Georg == Georg Baum [EMAIL PROTECTED] writes:
Georg The tabular dialog is so broken that I fear we'd open a can of
Georg worms if we touched it.
Yes.
Georg I have attached a patch that restores 1.3 behaviour. Once I
Georg found out the reason for the crash (it was the recUndo call in
Georg
Jean-Marc Lasgouttes wrote:
I do not like much the new setLayoutWithoutUndo and would have
preferred an optional bool argument to setLayout or maybe even the
removal of the undo step from setLayout: I suspect that there are
other cases where we want to avoid undo (when we switch classes?) and
Georg == Georg Baum [EMAIL PROTECTED] writes:
Georg Jean-Marc Lasgouttes wrote:
I do not like much the new setLayoutWithoutUndo and would have
preferred an optional bool argument to setLayout or maybe even the
removal of the undo step from setLayout: I suspect that there are
other cases
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> The tabular dialog is so broken that I fear we'd open a can of
Georg> worms if we touched it.
Yes.
Georg> I have attached a patch that restores 1.3 behaviour. Once I
Georg> found out the reason for the crash (it was the recUndo
Jean-Marc Lasgouttes wrote:
> I do not like much the new setLayoutWithoutUndo and would have
> preferred an optional bool argument to setLayout or maybe even the
> removal of the undo step from setLayout: I suspect that there are
> other cases where we want to avoid undo (when we switch classes?)
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
Georg> Jean-Marc Lasgouttes wrote:
>> I do not like much the new setLayoutWithoutUndo and would have
>> preferred an optional bool argument to setLayout or maybe even the
>> removal of the undo step from setLayout: I suspect that there are
On Fri, Nov 25, 2005 at 01:10:09PM +0100, Juergen Spitzmueller wrote:
Jean-Marc Lasgouttes wrote:
Juergen Can I commit it if I rename it asString?
Yes.
Thanks (thank God there are frontends like KFileRename nowadays).
You mean replacements for perl -pie 's/foo/bar/g' *.[Ch] ?
Andre'
On Thu, Nov 24, 2005 at 06:09:46PM +0100, Jean-Marc Lasgouttes wrote:
What about this? Of course, it would be better to add a virtual
function to InsetBase like asString that either uses plaintext or does
nothing, but I think this is good enough for now.
What do you think?
Use the virtual
On Fri, Nov 25, 2005 at 01:10:09PM +0100, Juergen Spitzmueller wrote:
> Jean-Marc Lasgouttes wrote:
> > Juergen> Can I commit it if I rename it asString?
> >
> > Yes.
>
> Thanks (thank God there are frontends like KFileRename nowadays).
You mean replacements for perl -pie 's/foo/bar/g' *.[Ch] ?
On Thu, Nov 24, 2005 at 06:09:46PM +0100, Jean-Marc Lasgouttes wrote:
>
> What about this? Of course, it would be better to add a virtual
> function to InsetBase like asString that either uses plaintext or does
> nothing, but I think this is good enough for now.
>
> What do you think?
Use the
Am Freitag, 25. November 2005 12:19 schrieb Jean-Marc Lasgouttes:
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Jean-Marc Lasgouttes wrote: Users will just not understand
Juergen why they cannot change back.
There is no problem of not changing back as long as you have
Am Freitag, 25. November 2005 12:19 schrieb Jean-Marc Lasgouttes:
> > "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
>
> Juergen> Jean-Marc Lasgouttes wrote: Users will just not understand
> Juergen> why they cannot change back.
> >> There is no problem of not changing back as
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Jean-Marc Lasgouttes wrote: If you have a look at bug 1953.
What about disabling changing to variable width cell if there are
several paragraphs?
Juergen I think this is not very user-friendly.
I know I do not work often
Jean-Marc Lasgouttes wrote:
I know I do not work often with big tables, but... Are there really
many cases where a user will be satisfied to see all his paragraphs
merged when clicking on a button? Especially when clicking the option
back does not restore it? (I know undo shold help, but this
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen There are more than enough cases where you have to toggle
Juergen several times between fixed and non-fixed-width columns (at
Juergen least I do very frequently).
With multi-paragraph cells?
Juergen Users will just not
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Jean-Marc Lasgouttes wrote:
Do you feel like doing this tedious-but-trivial task?
Juergen What do you think about the attached? There's also a
Juergen plaintext member in formulamacro. Should this be considered,
Juergen too?
Jean-Marc Lasgouttes wrote:
That would be OK, although I would have named the method asString,
since this is what it does (used for X clipboard too, I think).
Can I commit it if I rename it asString?
Jürgen
Jean-Marc Lasgouttes wrote:
Juergen Users will just not understand why they cannot change back.
There is no problem of not changing back as long as you have not added
a second paragraph to the cell. I am not proposing to disable going to
non-fixed-width unconditionally.
I understand that.
On Fri, Nov 25, 2005 at 10:25:23AM +0100, Jean-Marc Lasgouttes wrote:
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen There are more than enough cases where you have to toggle
Juergen several times between fixed and non-fixed-width columns (at
Juergen least I do very
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Jean-Marc Lasgouttes wrote:
That would be OK, although I would have named the method asString,
since this is what it does (used for X clipboard too, I think).
Juergen Can I commit it if I rename it asString?
Yes.
JMarc
Helge == Helge Hafting [EMAIL PROTECTED] writes:
Helge The alternative seems to be to refuse to change column type, if
Helge you don't want to fix the stuff that becomes unsupported.
Yes, this is what I am proposing.
JMarc
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Jean-Marc Lasgouttes wrote: Users will just not understand
Juergen why they cannot change back.
There is no problem of not changing back as long as you have not
added a second paragraph to the cell. I am not proposing to
Jean-Marc Lasgouttes wrote:
Juergen Yes, certainly.
Could you give me one example? I am not trying to harass you, but to
understand how people interact with tables.
I know.
When using fixed-width columns, I use linebreaks and paragraph breaks to get a
semantically sensible line wrapping. I
Jean-Marc Lasgouttes wrote:
Juergen Can I commit it if I rename it asString?
Yes.
Thanks (thank God there are frontends like KFileRename nowadays). Attached is
the patch with the renames for the record. I'll shove it it now.
Jürgen
Index: paragraph.C
Juergen Spitzmueller wrote:
Thanks (thank God there are frontends like KFileRename nowadays). Attached
is the patch with the renames for the record. I'll shove it it now.
Unfortunately, asString() clashes with a function of the same name in
math_parser (compilation breaks). How about
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Juergen Spitzmueller wrote:
Thanks (thank God there are frontends like KFileRename nowadays).
Attached is the patch with the renames for the record. I'll shove
it it now.
Juergen Unfortunately, asString() clashes with a
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Jean-Marc Lasgouttes wrote: Yes, certainly.
Could you give me one example? I am not trying to harass you, but
to understand how people interact with tables.
Juergen I know. When using fixed-width columns, I use linebreaks and
Jean-Marc Lasgouttes wrote:
I would say fixing 2007 has more priority than fixing 2089...
Is 2007 a regression wrt 1.3?
No. It's also in 1.3.
Jürgen
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote: If you have a look at bug 1953.
>> What about disabling changing to variable width cell if there are
>> several paragraphs?
Juergen> I think this is not very user-friendly.
I know I do not
Jean-Marc Lasgouttes wrote:
> I know I do not work often with big tables, but... Are there really
> many cases where a user will be satisfied to see all his paragraphs
> merged when clicking on a button? Especially when clicking the option
> back does not restore it? (I know undo shold help, but
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> There are more than enough cases where you have to toggle
Juergen> several times between fixed and non-fixed-width columns (at
Juergen> least I do very frequently).
With multi-paragraph cells?
Juergen> Users will just
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote:
>> Do you feel like doing this tedious-but-trivial task?
Juergen> What do you think about the attached? There's also a
Juergen> plaintext member in formulamacro. Should this be considered,
Jean-Marc Lasgouttes wrote:
> That would be OK, although I would have named the method asString,
> since this is what it does (used for X clipboard too, I think).
Can I commit it if I rename it asString?
Jürgen
Jean-Marc Lasgouttes wrote:
> Juergen> Users will just not understand why they cannot change back.
>
> There is no problem of not changing back as long as you have not added
> a second paragraph to the cell. I am not proposing to disable going to
> non-fixed-width unconditionally.
I understand
On Fri, Nov 25, 2005 at 10:25:23AM +0100, Jean-Marc Lasgouttes wrote:
> > "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
>
> Juergen> There are more than enough cases where you have to toggle
> Juergen> several times between fixed and non-fixed-width columns (at
> Juergen>
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote:
>> That would be OK, although I would have named the method asString,
>> since this is what it does (used for X clipboard too, I think).
Juergen> Can I commit it if I rename it asString?
> "Helge" == Helge Hafting <[EMAIL PROTECTED]> writes:
Helge> The alternative seems to be to refuse to change column type, if
Helge> you don't want to fix the stuff that becomes unsupported.
Yes, this is what I am proposing.
JMarc
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote: Users will just not understand
Juergen> why they cannot change back.
>> There is no problem of not changing back as long as you have not
>> added a second paragraph to the cell. I am not
Jean-Marc Lasgouttes wrote:
> Juergen> Yes, certainly.
>
> Could you give me one example? I am not trying to harass you, but to
> understand how people interact with tables.
I know.
When using fixed-width columns, I use linebreaks and paragraph breaks to get a
semantically sensible line
Jean-Marc Lasgouttes wrote:
> Juergen> Can I commit it if I rename it asString?
>
> Yes.
Thanks (thank God there are frontends like KFileRename nowadays). Attached is
the patch with the renames for the record. I'll shove it it now.
Jürgen
Index: paragraph.C
Juergen Spitzmueller wrote:
> Thanks (thank God there are frontends like KFileRename nowadays). Attached
> is the patch with the renames for the record. I'll shove it it now.
Unfortunately, asString() clashes with a function of the same name in
math_parser (compilation breaks). How about
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Juergen Spitzmueller wrote:
>> Thanks (thank God there are frontends like KFileRename nowadays).
>> Attached is the patch with the renames for the record. I'll shove
>> it it now.
Juergen> Unfortunately, asString()
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote: Yes, certainly.
>> Could you give me one example? I am not trying to harass you, but
>> to understand how people interact with tables.
Juergen> I know. When using fixed-width columns, I use
Jean-Marc Lasgouttes wrote:
> I would say fixing 2007 has more priority than fixing 2089...
>
> Is 2007 a regression wrt 1.3?
No. It's also in 1.3.
Jürgen
What about this? Of course, it would be better to add a virtual
function to InsetBase like asString that either uses plaintext or does
nothing, but I think this is good enough for now.
What do you think?
BTW, this also fixes 2028. 617, which is related should be marked as
fixedintrunk, I think.
Jean-Marc Lasgouttes wrote:
What about this? Of course, it would be better to add a virtual
function to InsetBase like asString that either uses plaintext or does
nothing, but I think this is good enough for now.
What do you think?
I think it's ok, though I'd also prefer a virtual function.
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Jean-Marc Lasgouttes wrote:
What about this? Of course, it would be better to add a virtual
function to InsetBase like asString that either uses plaintext or
does nothing, but I think this is good enough for now.
What do you
Jean-Marc Lasgouttes wrote:
Juergen I think it's ok, though I'd also prefer a virtual function.
Do you feel like doing this tedious-but-trivial task?
If you have a look at bug 1953.
Jürgen
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Jean-Marc Lasgouttes wrote: I think it's ok, though I'd also
Juergen prefer a virtual function.
Do you feel like doing this tedious-but-trivial task?
Juergen If you have a look at bug 1953.
What about disabling changing to
Juergen Spitzmueller wrote:
I think it's ok, though I'd also prefer a virtual function.
Me too. The disadvantage is of course that you need to touch more files, but
I think that it is a safe change.
I think we should create a prize for simple patches that fix several bugs at
once :-)
Georg
Jean-Marc Lasgouttes wrote:
Juergen If you have a look at bug 1953.
What about disabling changing to variable width cell if there are
several paragraphs?
I think this is not very user-friendly.
I thought about calling mergeParagraphs for all paragraphs in the cell
somewhere. But first I'd
Juergen Spitzmueller wrote:
I thought about calling mergeParagraphs for all paragraphs in the cell
somewhere. But first I'd like to understand what exactly happend in 1.3. I
still don't understand where the paragraphs are merged there.
Me neither. I have spent some time trying to find it out,
Georg Baum wrote:
Me neither. I have spent some time trying to find it out, but found
nothing. What I then did was to append this to InsetText::setAutoBreakRows:
// merge all paragraphs to one
BufferParams const bp = text_.buffer_owner-params();
while
Jean-Marc Lasgouttes wrote:
Do you feel like doing this tedious-but-trivial task?
What do you think about the attached?
There's also a plaintext member in formulamacro. Should this be considered,
too?
Jürgen
Index: paragraph.C
===
What about this? Of course, it would be better to add a virtual
function to InsetBase like asString that either uses plaintext or does
nothing, but I think this is good enough for now.
What do you think?
BTW, this also fixes 2028. 617, which is related should be marked as
fixedintrunk, I think.
Jean-Marc Lasgouttes wrote:
> What about this? Of course, it would be better to add a virtual
> function to InsetBase like asString that either uses plaintext or does
> nothing, but I think this is good enough for now.
>
> What do you think?
I think it's ok, though I'd also prefer a virtual
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote:
>> What about this? Of course, it would be better to add a virtual
>> function to InsetBase like asString that either uses plaintext or
>> does nothing, but I think this is good enough for
Jean-Marc Lasgouttes wrote:
> Juergen> I think it's ok, though I'd also prefer a virtual function.
>
> Do you feel like doing this tedious-but-trivial task?
If you have a look at bug 1953.
Jürgen
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Jean-Marc Lasgouttes wrote: I think it's ok, though I'd also
Juergen> prefer a virtual function.
>> Do you feel like doing this tedious-but-trivial task?
Juergen> If you have a look at bug 1953.
What about disabling
Juergen Spitzmueller wrote:
> I think it's ok, though I'd also prefer a virtual function.
Me too. The disadvantage is of course that you need to touch more files, but
I think that it is a safe change.
I think we should create a prize for simple patches that fix several bugs at
once :-)
Georg
Jean-Marc Lasgouttes wrote:
> Juergen> If you have a look at bug 1953.
>
> What about disabling changing to variable width cell if there are
> several paragraphs?
I think this is not very user-friendly.
I thought about calling mergeParagraphs for all paragraphs in the cell
somewhere. But first
Juergen Spitzmueller wrote:
> I thought about calling mergeParagraphs for all paragraphs in the cell
> somewhere. But first I'd like to understand what exactly happend in 1.3. I
> still don't understand where the paragraphs are merged there.
Me neither. I have spent some time trying to find it
Georg Baum wrote:
> Me neither. I have spent some time trying to find it out, but found
> nothing. What I then did was to append this to InsetText::setAutoBreakRows:
>
> // merge all paragraphs to one
> BufferParams const & bp = text_.buffer_owner->params();
> while
Jean-Marc Lasgouttes wrote:
> Do you feel like doing this tedious-but-trivial task?
What do you think about the attached?
There's also a plaintext member in formulamacro. Should this be considered,
too?
Jürgen
Index: paragraph.C
66 matches
Mail list logo
