Re: Patches for Python scripts

2021-02-04 Thread Thibaut Cuvelier
On Mon, 1 Feb 2021 at 15:31, José Abílio Matos wrote: > On Monday, February 1, 2021 2:42:43 AM WET Thibaut Cuvelier wrote: > > > More generally, what about the other patches? Are formatting changes > > > considered risky? What about Joel's suggestions? > > My issue is not about the formatting

Re: Patches for Python scripts

2021-02-01 Thread José Abílio Matos
On Monday, February 1, 2021 2:42:43 AM WET Thibaut Cuvelier wrote: > More generally, what about the other patches? Are formatting changes > considered risky? What about Joel's suggestions? My issue is not about the formatting changes, I can live with them even if in some cases I think that it is

Re: Patches for Python scripts

2021-02-01 Thread Enrico Forestieri
On Mon, Feb 01, 2021 at 03:42:43AM +0100, Thibaut Cuvelier wrote: > Thank you for testing on your side :)! What's frustrating with your report > is that this bug can only appear on Python 2, and that it will very likely > be dropped for the next release (I remember seeing people wanting to keep >

Re: Patches for Python scripts

2021-01-31 Thread Thibaut Cuvelier
On Sun, 31 Jan 2021 at 12:39, Enrico Forestieri wrote: > On Sun, Jan 31, 2021 at 04:22:39AM +0100, Thibaut Cuvelier wrote: > > On Sat, 30 Jan 2021 at 12:26, Enrico Forestieri wrote: > > > On Sat, Jan 30, 2021 at 05:31:05AM +0100, Thibaut Cuvelier wrote: > > > > On Sat, 30 Jan 2021 at 02:31,

Re: Patches for Python scripts

2021-01-31 Thread Enrico Forestieri
On Sun, Jan 31, 2021 at 04:22:39AM +0100, Thibaut Cuvelier wrote: > On Sat, 30 Jan 2021 at 12:26, Enrico Forestieri wrote: > > On Sat, Jan 30, 2021 at 05:31:05AM +0100, Thibaut Cuvelier wrote: > > > On Sat, 30 Jan 2021 at 02:31, Enrico Forestieri wrote: > > > > > > > > So, it seems that you have

Re: Patches for Python scripts

2021-01-30 Thread Thibaut Cuvelier
On Sat, 30 Jan 2021 at 12:26, Enrico Forestieri wrote: > On Sat, Jan 30, 2021 at 05:31:05AM +0100, Thibaut Cuvelier wrote: > > On Sat, 30 Jan 2021 at 02:31, Enrico Forestieri wrote: > > > > > > So, it seems that you have to check also for the 32-bit version. > > > > > Indeed. Would the attached

Re: Patches for Python scripts

2021-01-30 Thread Enrico Forestieri
On Sat, Jan 30, 2021 at 05:31:05AM +0100, Thibaut Cuvelier wrote: > On Sat, 30 Jan 2021 at 02:31, Enrico Forestieri wrote: > > > > So, it seems that you have to check also for the 32-bit version. > > > Indeed. Would the attached patch solve the problem? I first look for a > 64-bit version before

Re: Patches for Python scripts

2021-01-29 Thread Thibaut Cuvelier
On Sat, 30 Jan 2021 at 02:31, Enrico Forestieri wrote: > On Fri, Jan 29, 2021 at 11:40:29PM +0100, Thibaut Cuvelier wrote: > > Hi Thibaut, > > > - This way to find Java is quite common on Windows platforms (actually, > > it's a lot like a port of JavaCall.jl's relevant portion of code: > >

Re: Patches for Python scripts

2021-01-29 Thread Joel Kulesza
On Fri, Jan 29, 2021 at 3:40 PM Thibaut Cuvelier wrote: > - The cosmetic changes are based on PEP8, which is the only style guide > for Python. Highly similar patches already went into the code base less > than a year ago ( > http://lists.lyx.org/pipermail/lyx-devel/2020-May/001464.html). Other

Re: Patches for Python scripts

2021-01-29 Thread Enrico Forestieri
On Fri, Jan 29, 2021 at 11:40:29PM +0100, Thibaut Cuvelier wrote: Hi Thibaut, > - This way to find Java is quite common on Windows platforms (actually, > it's a lot like a port of JavaCall.jl's relevant portion of code: > https://github.com/JuliaInterop/JavaCall.jl). It looks like Oracle's JVM >

Re: Patches for Python scripts

2021-01-29 Thread Richard Kimberly Heck
On 1/29/21 7:39 AM, Pavel Sanda wrote: > On Fri, Jan 29, 2021 at 11:07:43AM +, José Abílio Matos wrote: >> With the extent of the patches I fear that there could be bugs (unintended >> changes) lurking specially in relation to python 2. > Riki's call, but I don't think this is the best time

Re: Patches for Python scripts

2021-01-29 Thread Thibaut Cuvelier
I will be answering most concerns here, in no particular order. I think it will simplify the next messages. - This is far from an overhaul of the script. The logic did not really change, neither the code structure. I have ideas on how to do it, and I could do it if you are OK with it, but I

Re: Patches for Python scripts

2021-01-29 Thread Kornel Benko
Am Fri, 29 Jan 2021 13:39:19 +0100 schrieb Pavel Sanda : > On Fri, Jan 29, 2021 at 11:07:43AM +, José Abílio Matos wrote: > > With the extent of the patches I fear that there could be bugs (unintended > > changes) lurking specially in relation to python 2. > > Riki's call, but I don't

Re: Patches for Python scripts

2021-01-29 Thread Pavel Sanda
On Fri, Jan 29, 2021 at 11:07:43AM +, José Abílio Matos wrote: > With the extent of the patches I fear that there could be bugs (unintended > changes) lurking specially in relation to python 2. Riki's call, but I don't think this is the best time for python scripts overhaul. Except the

Re: Patches for Python scripts

2021-01-29 Thread José Abílio Matos
On Friday, January 29, 2021 11:48:40 AM WET Kornel Benko wrote: > Right, the last one should be escaped. > Given the line > # \DeclareLaTeXClass[revtex,revtex.sty]{REVTeX (Obsolete Version)} > and the original regex > >

Re: Patches for Python scripts

2021-01-29 Thread Kornel Benko
Am Fri, 29 Jan 2021 11:07:43 + schrieb José Abílio Matos : > On Friday, January 29, 2021 5:05:19 AM WET Richard Kimberly Heck wrote: > > José, can you look at these please? > > > > Riki > > I think that Thibaut wants to impose black[1] on us. :-D > > Most of the changes are cosmetic, e.g.

Re: Patches for Python scripts

2021-01-29 Thread José Abílio Matos
On Friday, January 29, 2021 3:51:12 AM WET Thibaut Cuvelier wrote: > Dear list, > > While working on the ePub output, I ran through many Python scripts. I > corrected a few bgs and a lot of formatting, plus one feature (find Java in > the Windows registry in configure.py), here are the patches.

Re: Patches for Python scripts

2021-01-29 Thread José Abílio Matos
On Friday, January 29, 2021 5:05:19 AM WET Richard Kimberly Heck wrote: > José, can you look at these please? > > Riki I think that Thibaut wants to impose black[1] on us. :-D Most of the changes are cosmetic, e.g. one import per line, or to use the same indentation for documentation. The

Re: Patches for Python scripts

2021-01-29 Thread Richard Kimberly Heck
On 1/29/21 4:41 AM, Enrico Forestieri wrote: > On Fri, Jan 29, 2021 at 04:51:12AM +0100, Thibaut Cuvelier wrote: >> While working on the ePub output, I ran through many Python scripts. I >> corrected a few bgs and a lot of formatting, plus one feature (find Java in >> the Windows registry in

Re: Patches for Python scripts

2021-01-29 Thread Enrico Forestieri
On Fri, Jan 29, 2021 at 04:51:12AM +0100, Thibaut Cuvelier wrote: > > While working on the ePub output, I ran through many Python scripts. I > corrected a few bgs and a lot of formatting, plus one feature (find Java in > the Windows registry in configure.py), here are the patches. May I push >

Re: Patches for Python scripts

2021-01-28 Thread Richard Kimberly Heck
On 1/28/21 10:51 PM, Thibaut Cuvelier wrote: > Dear list, > > While working on the ePub output, I ran through many Python scripts. I > corrected a few bgs and a lot of formatting, plus one feature (find > Java in the Windows registry in configure.py), here are the patches. > May I push them on the

Re: Patches for Python scripts

2021-01-28 Thread Richard Kimberly Heck
On 1/28/21 10:51 PM, Thibaut Cuvelier wrote: > Dear list, > > While working on the ePub output, I ran through many Python scripts. I > corrected a few bgs and a lot of formatting, plus one feature (find > Java in the Windows registry in configure.py), here are the patches. > May I push them on the