Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Guillaume Munch
Le 24/10/2016 à 01:00, Enrico Forestieri a écrit : On Sun, Oct 23, 2016 at 11:52:55PM +0200, Guillaume Munch wrote: The code does look fragile to me. I do not think that asking that developers care about maintainability is being overzealous. Then, maybe I am mistaken about the code and you got

Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Enrico Forestieri
On Sun, Oct 23, 2016 at 11:52:55PM +0200, Guillaume Munch wrote: > > The code does look fragile to me. I do not think that asking that > developers care about maintainability is being overzealous. Then, maybe > I am mistaken about the code and you got to something found maintainable > enough

Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Guillaume Munch
Le 23/10/2016 à 22:53, Enrico Forestieri a écrit : On Sun, Oct 23, 2016 at 07:02:31PM +0200, Guillaume Munch wrote: Le 23/10/2016 à 18:38, Enrico Forestieri a écrit : commit dea5ba16de1b98d93cf30ab65119bc2364a7ac2b Author: Enrico Forestieri Date: Sun Oct 23 18:23:41 2016

Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Enrico Forestieri
On Sun, Oct 23, 2016 at 07:02:31PM +0200, Guillaume Munch wrote: > Le 23/10/2016 à 18:38, Enrico Forestieri a écrit : > > commit dea5ba16de1b98d93cf30ab65119bc2364a7ac2b > > Author: Enrico Forestieri > > Date: Sun Oct 23 18:23:41 2016 +0200 > > > > Correctly track ulem

Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Enrico Forestieri
On Sun, Oct 23, 2016 at 09:09:22PM +0200, Guillaume Munch wrote: > Le 23/10/2016 à 19:55, Richard Heck a écrit : > > On 10/23/2016 01:02 PM, Guillaume Munch wrote: > > > Le 23/10/2016 à 18:38, Enrico Forestieri a écrit : > > > > commit dea5ba16de1b98d93cf30ab65119bc2364a7ac2b > > > > Author:

Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Guillaume Munch
Le 23/10/2016 à 19:55, Richard Heck a écrit : On 10/23/2016 01:02 PM, Guillaume Munch wrote: Le 23/10/2016 à 18:38, Enrico Forestieri a écrit : commit dea5ba16de1b98d93cf30ab65119bc2364a7ac2b Author: Enrico Forestieri Date: Sun Oct 23 18:23:41 2016 +0200 Correctly track

Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Richard Heck
On 10/23/2016 01:02 PM, Guillaume Munch wrote: > Le 23/10/2016 à 18:38, Enrico Forestieri a écrit : >> commit dea5ba16de1b98d93cf30ab65119bc2364a7ac2b >> Author: Enrico Forestieri >> Date: Sun Oct 23 18:23:41 2016 +0200 >> >> Correctly track ulem commands with change

Re: [LyX/master] Correctly track ulem commands with change tracking

2016-10-23 Thread Guillaume Munch
Le 23/10/2016 à 18:38, Enrico Forestieri a écrit : commit dea5ba16de1b98d93cf30ab65119bc2364a7ac2b Author: Enrico Forestieri Date: Sun Oct 23 18:23:41 2016 +0200 Correctly track ulem commands with change tracking LyX assumes that everything in \lyxdeleted is struck