Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

On 2010-10-21, Vincent van Ravesteijn wrote: but now we have new problem - how to notice user that exporting is stillbr= in progress or finished (some subvserion of hourglass cursor?).br Status bar: Moving icons. Text. Messages. greyed out (or otherwise modified) export toolbar buttons?

Re: r35575 - lyx-devel/trunk/src

Am 22.10.2010 um 01:07 schrieb Pavel Sanda: Stephan Witt wrote: If the principle way is ok I can do the same for the RCS and SVN backend too. One question regarding the View log button of repoUpdate: here on Mac the dialog to display the log is unusable. It is blocked by the next

Re: r35769 - in lyx-devel/trunk/lib: . scripts

Le 22/10/2010 02:10, uwesto...@lyx.org a écrit : Log: - lyxsweave.R: set missing SVN EOL style and add missing makefile entry - lib/Makefile.am: add missing scripts Thanks, Uwe. JMarc

Re: #6710: table dialog broken

On 10/22/2010 03:25 AM, LyX Ticket Tracker wrote: #6710: table dialog broken --+- Reporter: uwestoehr |Owner: nob...@… Type: defect| Status: closed Priority: high |

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Pavel Sanda wrote: this thinko-part smells like trunk stuff unless it really fixes something. It really fixes something. If you drop file a.tex and b.tex onto LyX, current LyX tries to import a.tex twice, and b.tex not at all. The fix assures that both a.tex and b.tex are imported (and only

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

// Asynchronously post the event. DropEvent usually come // from the BufferView. But reloading a file might close // the BufferView from within its own event handler. - guiApp-dispatchDelayed(cmd); + guiApp-addtoFuncRequestQueue(cmd); event-accept();

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Vincent van Ravesteijn wrote: // Asynchronously post the event. DropEvent usually come // from the BufferView. But reloading a file might close // the BufferView from within its own event handler. - guiApp-dispatchDelayed(cmd); +

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

One remark: I refactored the buffer reloading, so I don't think it is still true that a BufferView can close itself now on reloading. So you think I can just ditch the comment? (Actually, it's also not posted asynchronously anymore, unless I do my second proposed change). Jürgen I think

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

Guenter Milde wrote: Status bar: Moving icons. Text. Messages. greyed out (or otherwise modified) export toolbar buttons? wont help in case you use only menu. pavel

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Vincent van Ravesteijn wrote: I think you can. However, I can't judge right now whether it's better to do it asynchronously or not. So, it might be that we should still do it asynchronously, but the reasoning stated in the comment is not valid anymore. I propose the following patch (diff

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

On Fri, Oct 22, 2010 at 1:03 PM, Jürgen Spitzmüller sp...@lyx.org wrote: Vincent van Ravesteijn wrote: I think you can. However, I can't judge right now whether it's better to do it asynchronously or not. So, it might be that we should still do it asynchronously, but the reasoning stated in

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Vincent van Ravesteijn wrote: Only three nitpicks: - There will be some point in time that I will start wondering what the difference is between processing the queue and performing the requests. Then I'll find out that they do the same thing but that the only difference is that performing

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Jürgen Spitzmüller wrote: since it's not only used in GuiApplication itself. not now Jürgen

Re: r35765 - lyx-devel/branches/BRANCH_1_6_X

sa...@lyx.org wrote: Author: sanda Date: Fri Oct 22 01:10:02 2010 New Revision: 35765 URL: http://www.lyx.org/trac/changeset/35765 Log: Allow newer autoconf Modified: lyx-devel/branches/BRANCH_1_6_X/autogen.sh lyx-devel/branches/BRANCH_1_6_X/status.16x Modified:

Re: r35765 - lyx-devel/branches/BRANCH_1_6_X

Le 22/10/2010 14:21, Pavel Sanda a écrit : trunk does not show this behaviour. JMarc, do you have idea? Branch uses libtool, trunk does not. I fear that using recent autoconf means switching to libtool 2. See for example this mail: http://www.spinics.net/lists/ac/msg10004.html

Re: r35575 - lyx-devel/trunk/src

Am 22.10.2010 um 02:11 schrieb Pavel Sanda: Stephan Witt wrote: I made a new patch to implement getDiff() and use it to avoid the query for log message before checkIn() is done and the confirmation on revert when no diff is found. thanks for your patience, i went closely through the

Re: r35765 - lyx-devel/branches/BRANCH_1_6_X

Jean-Marc Lasgouttes wrote: Branch uses libtool, trunk does not. I fear that using recent autoconf means switching to libtool 2. See for example this mail: http://www.spinics.net/lists/ac/msg10004.html ok, so i'll revert this patch. pavel

Re: r35765 - lyx-devel/branches/BRANCH_1_6_X

Am 22.10.2010 um 14:53 schrieb Jean-Marc Lasgouttes: Le 22/10/2010 14:21, Pavel Sanda a écrit : trunk does not show this behaviour. JMarc, do you have idea? Branch uses libtool, trunk does not. I fear that using recent autoconf means switching to libtool 2. See for example this mail:

Re: r35767 - lyx-devel/trunk/lib/doc

On 10/21/2010 07:50 PM, Pavel Sanda wrote: sa...@lyx.org wrote: Author: sanda Date: Fri Oct 22 01:34:22 2010 New Revision: 35767 URL: http://www.lyx.org/trac/changeset/35767 Log: (no log message) Modified: lyx-devel/trunk/lib/doc/Additional.lyx i looked why lyx ignored my

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

On 10/21/2010 07:17 PM, Vincent van Ravesteijn wrote: Status bar: Moving icons. Text. Messages. Op 22 okt 2010 01:13 schreef Pavel Sanda sa...@lyx.org mailto:sa...@lyx.org: Richard Heck wrote: On 10/20/2010 08:59 PM, Peter Kümmel wrote: Am Dienstag, den 19.10.2010, 20... i checked that

Re: r35575 - lyx-devel/trunk/src

Am 22.10.2010 um 15:28 schrieb Stephan Witt: Am 22.10.2010 um 02:11 schrieb Pavel Sanda: Stephan Witt wrote: @@ -212,8 +213,9 @@ docstring text = bformat(_(Reverting to the stored version of the document %1$s will lose all current changes.\n\n

New thread offshoot ( Re: r35767 - lyx-devel/trunk/lib/doc )

Richard Heck wrote: On 10/21/2010 07:50 PM, Pavel Sanda wrote: sa...@lyx.org wrote: Author: sanda Date: Fri Oct 22 01:34:22 2010 New Revision: 35767 URL: http://www.lyx.org/trac/changeset/35767 Log: (no log message) Modified: lyx-devel/trunk/lib/doc/Additional.lyx i

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

Richard Heck wrote: Along these same lines, I wonder if we should pop up an info box when the export is done. If it takes a while, then the user may not notice the status message, and those get over-written quickly, anyway. In a way, that would solve this issue: It's still going until you get

Re: r35575 - lyx-devel/trunk/src

Am 22.10.2010 um 15:28 schrieb Stephan Witt: Am 22.10.2010 um 02:11 schrieb Pavel Sanda: Stephan Witt wrote: While doing some stress test with checkIn() I found the error message when merge is needed Something's wrong with cvs commit not acceptable. Then I tried to change that and

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

i suppose for the same reason that we cannot have a pointing finger when the mouse hovers something clickable... On 2010-10-22, Pavel Sanda sa...@lyx.org wrote: Richard Heck wrote: Along these same lines, I wonder if we should pop up an info box when the export is done. If it takes a while,

Re: r35575 - lyx-devel/trunk/src

Stephan Witt wrote: the error case is suspicious. if tempName fails or cvs diff fails how you detect this on a higher stage? cmiiw but if something fails you identify it with having empty diff, which looks wrong, even more if you release lock automatically in such a case...

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Jurgen, Because I love to nitpick: +void GuiApplication::processFuncRequestQueueAsync() +{ + // We perform the events asynchronously. This prevents potential + // problems in case the BufferView is closed within an event. Well, this comment is not in the right position after all.

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

While eating I thought of more. I moved the functions to another place in the header and made dispatchDelayed a private function, since it's now only used in GuiApplication itself. I think it's better to make it public anyway. - the fact whether a function is public or private should be based

Re: New thread offshoot ( Re: r35767 - lyx-devel/trunk/lib/doc )

On 10/22/2010 10:42 AM, Pavel Sanda wrote: Richard Heck wrote: On 10/21/2010 07:50 PM, Pavel Sanda wrote: sa...@lyx.org wrote: Author: sanda Date: Fri Oct 22 01:34:22 2010 New Revision: 35767 URL: http://www.lyx.org/trac/changeset/35767 Log: (no log message) Modified:

Re: New thread offshoot ( Re: r35767 - lyx-devel/trunk/lib/doc )

On 10/22/2010 01:01 PM, Richard Heck wrote: On 10/22/2010 10:42 AM, Pavel Sanda wrote: Richard Heck wrote: On 10/21/2010 07:50 PM, Pavel Sanda wrote: sa...@lyx.org wrote: Author: sanda Date: Fri Oct 22 01:34:22 2010 New Revision: 35767 URL: http://www.lyx.org/trac/changeset/35767 Log: (no

Re: [Patch] Improving the Citation GUI.

This patch got buried when I was distracted by my thesis. Apologies for the delay. I address the comments to the previous patch. Notes: 1) The potential security issue has been addressed by only using LyX's viewers. 2) Richard suggested that I regenerate the filename/url on demand, I discuss why

Bookmark test on MacOSX

Hi, Can someone on a Mac test the following ? - open LyX - open a document - save a bookmark - close the document and make sure you don't have any views left - try to navigate to the bookmark Does LyX now assert ? Thanks, Vincent

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 2:33 PM, Vincent van Ravesteijn v...@lyx.org wrote: Hi, Can someone on a Mac test the following ? - open LyX - open a document - save a bookmark - close the document and make sure you don't have any views left - try to navigate to the bookmark Does LyX now assert

Re: Bookmark test on MacOSX

Nope -- it works fine for me with near current svn (built yesterday). BH Thanks. But it is strange as I see this code: void GuiApplication::gotoBookmark(unsigned int idx, bool openFile, bool switchToBuffer) { LASSERT(current_view_); } I don't understand this. On a Mac you can

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 2:57 PM, Vincent van Ravesteijn v...@lyx.org wrote: Nope -- it works fine for me with near current svn (built yesterday). BH Thanks. But it is strange as I see this code: void GuiApplication::gotoBookmark(unsigned int idx, bool openFile,   bool switchToBuffer) {

Re: Bookmark test on MacOSX

Sorry -- I had other windows open. If I close everything else, and then try navigating to a bookmark, I get an error beep and nothing else happens. That must be the assert then. Moreover -- something I hadn't noticed before -- if all windows are closed, it's not possible to open a new window

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 3:25 PM, Vincent van Ravesteijn v...@lyx.org wrote: Sorry -- I had other windows open. If I close everything else, and then try navigating to a bookmark, I get an error beep and nothing else happens. That must be the assert then. No. It's just the OS's warning beep

Re: Bookmark test on MacOSX

Yet another question. If you normally would reconfigure LyX, you get a message like Running configure... in the status bar. Then you know you have to wait. What do you expect on Mac if you don't have any window open ? Now, there is no way of telling that configure is running, right ? Do you

Fwd: Bookmark test on MacOSX

Yet another question. If you normally would reconfigure LyX, you get a message like Running configure... in the status bar. Then you know you have to wait. What do you expect on Mac if you don't have any window open ? Now, there is no way of telling that configure is running, right ? Do you

Re: Bookmark test on MacOSX

Incidentally, in testing all this, I had LyX crash on me twice. I don't have time now to get a backtrace, but let me know if you want me to post one later. BH I think the culprit might be in this code: void GuiApplication::processKeySym(KeySymbol const keysym, KeyModifier state) {

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 10:34 PM, Vincent van Ravesteijn v...@lyx.org wrote: Incidentally, in testing all this, I had LyX crash on me twice. I don't have time now to get a backtrace, but let me know if you want me to post one later. BH I fixed a number of problems that might occur without

Re: LyX Additional features Version 1.6.7 suggested corrections

Hi Pavel Thanks. Will do. I will change to 2.0 - Uwe has just made the same suggestion. The way I have worked in the past was because that was the instruction in the Help files when I first began submitting changes occasionally some years ago. John -- On Friday 22 October 2010 20:08:50 you

Re: LyX Additional features Version 1.6.7 suggested corrections

John R Hudson wrote: Hi Pavel Thanks. Will do. I will change to 2.0 - Uwe has just made the same suggestion. The way I have worked in the past was because that was the instruction in the Help files when I first began submitting changes occasionally some years ago. btw are you able to

Re: LyX Additional features Version 1.6.7 suggested corrections

On 22/10/2010 4:15 PM, John R Hudson wrote: 5.19 RevTeX4 [paragraph 1]The Revtex 4 textclass works with the American Physical Sociey's RevTeX 4.1 class. [I haven't tried this but RevTeX4.1 was issued in August 2010 and the announcement refers mostly to bugfixes and additional

Re: Some thoughts on further development process towards beta and RCs

ok, thanks for the info. unless Vincent put it in, i will do before beta goes out. I looked at the patch again and in the Qt Docs and I read: {{{ void QClipboard::dataChanged () [signal] This signal is emitted when the clipboard data is changed. On Mac OS X and with Qt version 4.3 or

Re: Bookmark test on MacOSX

A. Am Freitag, den 22.10.2010, 22:34 +0200 schrieb Vincent van Ravesteijn: Incidentally, in testing all this, I had LyX crash on me twice. I don't have time now to get a backtrace, but let me know if you want me to post one later. BH I think the culprit might be in this

Re: Some thoughts on further development process towards beta and RCs

Am Sonntag, den 17.10.2010, 18:28 +0200 schrieb Pavel Sanda: John McCabe-Dansted wrote: the most problematic cases of our copypaste typically happen when middle button is used for getting, or puting stuff from/into another applications and when more lyx instances are used. dunno whether

Re: New thread offshoot ( Re: r35767 - lyx-devel/trunk/lib/doc )

Am Freitag, den 22.10.2010, 13:28 -0400 schrieb Richard Heck: i wonder why Alert:: code is affected when no preview or export is done? It was a bug in InGuiThread.h, see commit message: bind makes a copy of the arguments by default. This is secure if the bound object survives the existence of

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 4:08 PM, Vincent van Ravesteijn v...@lyx.org wrote: Yet another question. If you normally would reconfigure LyX, you get a message like Running configure... in the status bar. Then you know you have to wait. What do you expect on Mac if you don't have any window open

Re: Change Tracking and Versioning (#6058) was Re: more on collaboration

Hi Gregory, 1) I have a patch set for 1.6.X which will no longer apply because Vincent (vfr) already contributed an alternative.  I presume that I need to modify my patch to layer on top of his. Actually, I wouldn't say I contributed an alternative. I just put in your idea but implemented

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 4:58 PM, Vincent van Ravesteijn v...@lyx.org wrote: On Fri, Oct 22, 2010 at 10:34 PM, Vincent van Ravesteijn v...@lyx.org wrote: Incidentally, in testing all this, I had LyX crash on me twice. I don't have time now to get a backtrace, but let me know if you want me to

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

On 2010-10-21, Vincent van Ravesteijn wrote: > > but now we have new problem - how to notice user that exporting is

Re: r35575 - lyx-devel/trunk/src

Am 22.10.2010 um 01:07 schrieb Pavel Sanda: > Stephan Witt wrote: If the principle way is ok I can do the same for the RCS and SVN backend too. One question regarding the "View log" button of repoUpdate: here on Mac the dialog to display the log is unusable. It

Re: r35769 - in lyx-devel/trunk/lib: . scripts

Le 22/10/2010 02:10, uwesto...@lyx.org a écrit : Log: - lyxsweave.R: set missing SVN EOL style and add missing makefile entry - lib/Makefile.am: add missing scripts Thanks, Uwe. JMarc

Re: #6710: table dialog broken

On 10/22/2010 03:25 AM, LyX Ticket Tracker wrote: #6710: table dialog broken --+- Reporter: uwestoehr |Owner: nob...@… Type: defect| Status: closed Priority: high |

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Pavel Sanda wrote: > this thinko-part smells like trunk stuff unless it really fixes something. It really fixes something. If you drop file a.tex and b.tex onto LyX, current LyX tries to import a.tex twice, and b.tex not at all. The fix assures that both a.tex and b.tex are imported (and only

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

> // Asynchronously post the event. DropEvent usually come > // from the BufferView. But reloading a file might close > // the BufferView from within its own event handler. >- guiApp->dispatchDelayed(cmd); >+ guiApp->addtoFuncRequestQueue(cmd); >

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Vincent van Ravesteijn wrote: > > // Asynchronously post the event. DropEvent usually come > > // from the BufferView. But reloading a file might close > > // the BufferView from within its own event handler. > > > >- guiApp->dispatchDelayed(cmd); > >+

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

>> One remark: I refactored the buffer reloading, so I don't think it is >> still true that a BufferView can close itself now on reloading. > > So you think I can just ditch the comment? (Actually, it's also not posted > asynchronously anymore, unless I do my second proposed change). > > Jürgen >

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

Guenter Milde wrote: > > Status bar: Moving icons. Text. Messages. > > greyed out (or otherwise modified) export toolbar buttons? wont help in case you use only menu. pavel

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Vincent van Ravesteijn wrote: > I think you can. However, I can't judge right now whether it's better > to do it asynchronously or not. So, it might be that we should still > do it asynchronously, but the reasoning stated in the comment is not > valid anymore. I propose the following patch (diff

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

On Fri, Oct 22, 2010 at 1:03 PM, Jürgen Spitzmüller wrote: > Vincent van Ravesteijn wrote: >> I think you can. However, I can't judge right now whether it's better >> to do it asynchronously or not. So, it might be that we should still >> do it asynchronously, but the reasoning

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Vincent van Ravesteijn wrote: > Only three nitpicks: > > - There will be some point in time that I will start wondering what > the difference is between processing the queue and performing the > requests. Then I'll find out that they do the same thing but that the > only difference is that

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Jürgen Spitzmüller wrote: > since it's not only used in GuiApplication itself. not > now Jürgen

Re: r35765 - lyx-devel/branches/BRANCH_1_6_X

sa...@lyx.org wrote: > Author: sanda > Date: Fri Oct 22 01:10:02 2010 > New Revision: 35765 > URL: http://www.lyx.org/trac/changeset/35765 > > Log: > Allow newer autoconf > > Modified: >lyx-devel/branches/BRANCH_1_6_X/autogen.sh >lyx-devel/branches/BRANCH_1_6_X/status.16x > > Modified:

Re: r35765 - lyx-devel/branches/BRANCH_1_6_X

Le 22/10/2010 14:21, Pavel Sanda a écrit : trunk does not show this behaviour. JMarc, do you have idea? Branch uses libtool, trunk does not. I fear that using recent autoconf means switching to libtool 2. See for example this mail: http://www.spinics.net/lists/ac/msg10004.html

Re: r35575 - lyx-devel/trunk/src

Am 22.10.2010 um 02:11 schrieb Pavel Sanda: > Stephan Witt wrote: >> I made a new patch to implement getDiff() and use it to avoid the query for >> log message >> before checkIn() is done and the confirmation on revert when no diff is >> found. > > thanks for your patience, i went closely

Re: r35765 - lyx-devel/branches/BRANCH_1_6_X

Jean-Marc Lasgouttes wrote: > Branch uses libtool, trunk does not. I fear that using recent autoconf > means switching to libtool 2. See for example this mail: > http://www.spinics.net/lists/ac/msg10004.html ok, so i'll revert this patch. pavel

Re: r35765 - lyx-devel/branches/BRANCH_1_6_X

Am 22.10.2010 um 14:53 schrieb Jean-Marc Lasgouttes: > Le 22/10/2010 14:21, Pavel Sanda a écrit : >> trunk does not show this behaviour. JMarc, do you have idea? > > Branch uses libtool, trunk does not. I fear that using recent autoconf means > switching to libtool 2. See for example this mail:

Re: r35767 - lyx-devel/trunk/lib/doc

On 10/21/2010 07:50 PM, Pavel Sanda wrote: sa...@lyx.org wrote: Author: sanda Date: Fri Oct 22 01:34:22 2010 New Revision: 35767 URL: http://www.lyx.org/trac/changeset/35767 Log: (no log message) Modified: lyx-devel/trunk/lib/doc/Additional.lyx i looked why lyx ignored my

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

On 10/21/2010 07:17 PM, Vincent van Ravesteijn wrote: Status bar: Moving icons. Text. Messages. Op 22 okt 2010 01:13 schreef "Pavel Sanda" >: Richard Heck wrote: > On 10/20/2010 08:59 PM, Peter Kümmel wrote: >> Am Dienstag, den 19.10.2010, 20... i

Re: r35575 - lyx-devel/trunk/src

Am 22.10.2010 um 15:28 schrieb Stephan Witt: > Am 22.10.2010 um 02:11 schrieb Pavel Sanda: > >> Stephan Witt wrote: >> >>> @@ -212,8 +213,9 @@ >>> docstring text = bformat(_("Reverting to the stored version of the " >>> "document %1$s will lose all current >>>

New thread offshoot ( Re: r35767 - lyx-devel/trunk/lib/doc )

Richard Heck wrote: > On 10/21/2010 07:50 PM, Pavel Sanda wrote: >> sa...@lyx.org wrote: >> >>> Author: sanda >>> Date: Fri Oct 22 01:34:22 2010 >>> New Revision: 35767 >>> URL: http://www.lyx.org/trac/changeset/35767 >>> >>> Log: >>> (no log message) >>> >>> Modified: >>>

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

Richard Heck wrote: > Along these same lines, I wonder if we should pop up an info box when > the export is done. If it takes a while, then the user may not notice the > status message, and those get over-written quickly, anyway. > > In a way, that would solve this issue: It's still going until

Re: r35575 - lyx-devel/trunk/src

Am 22.10.2010 um 15:28 schrieb Stephan Witt: > Am 22.10.2010 um 02:11 schrieb Pavel Sanda: > >> Stephan Witt wrote: > While doing some "stress test" with checkIn() I found the error message when > merge is needed > "Something's wrong with cvs commit" not acceptable. Then I tried to change >

Re: r35662 - in lyx-devel/trunk/src: . frontends/qt4

i suppose for the same reason that we cannot have a pointing finger when the mouse hovers something clickable... On 2010-10-22, Pavel Sanda wrote: > Richard Heck wrote: >> Along these same lines, I wonder if we should pop up an info box when >> the export is done. If it takes a

Re: r35575 - lyx-devel/trunk/src

Stephan Witt wrote: > > the error case is suspicious. if tempName fails or "cvs diff" fails how you > > detect > > this on a higher stage? cmiiw but if something fails you identify it with > > having > > empty diff, which looks wrong, even more if you release lock automatically > > in such > >

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

Jurgen, Because I love to nitpick: +void GuiApplication::processFuncRequestQueueAsync() +{ + // We perform the events asynchronously. This prevents potential + // problems in case the BufferView is closed within an event. Well, this comment is not in the right position after all.

Re: [RFC] [patch] bug 6944: crash on drag and drop multiple files

While eating I thought of more. >I moved the functions to another place in the header and made >dispatchDelayed a private function, since it's now only used in >GuiApplication itself. I think it's better to make it public anyway. - the fact whether a function is public or private should be

Re: New thread offshoot ( Re: r35767 - lyx-devel/trunk/lib/doc )

On 10/22/2010 10:42 AM, Pavel Sanda wrote: Richard Heck wrote: On 10/21/2010 07:50 PM, Pavel Sanda wrote: sa...@lyx.org wrote: Author: sanda Date: Fri Oct 22 01:34:22 2010 New Revision: 35767 URL: http://www.lyx.org/trac/changeset/35767 Log: (no log message) Modified:

Re: New thread offshoot ( Re: r35767 - lyx-devel/trunk/lib/doc )

On 10/22/2010 01:01 PM, Richard Heck wrote: On 10/22/2010 10:42 AM, Pavel Sanda wrote: Richard Heck wrote: On 10/21/2010 07:50 PM, Pavel Sanda wrote: sa...@lyx.org wrote: Author: sanda Date: Fri Oct 22 01:34:22 2010 New Revision: 35767 URL: http://www.lyx.org/trac/changeset/35767 Log: (no

Re: [Patch] Improving the Citation GUI.

This patch got buried when I was distracted by my thesis. Apologies for the delay. I address the comments to the previous patch. Notes: 1) The potential security issue has been addressed by only using LyX's viewers. 2) Richard suggested that I regenerate the filename/url on demand, I discuss why

Bookmark test on MacOSX

Hi, Can someone on a Mac test the following ? - open LyX - open a document - save a bookmark - close the document and make sure you don't have any views left - try to navigate to the bookmark Does LyX now assert ? Thanks, Vincent

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 2:33 PM, Vincent van Ravesteijn wrote: > Hi, > > Can someone on a Mac test the following ? > > - open LyX > - open a document > - save a bookmark > - close the document and make sure you don't have any views left > - try to navigate to the bookmark > > Does

Re: Bookmark test on MacOSX

> Nope -- it works fine for me with near current svn (built yesterday). > > BH > Thanks. But it is strange as I see this code: "void GuiApplication::gotoBookmark(unsigned int idx, bool openFile, bool switchToBuffer) { LASSERT(current_view_); } I don't understand this. On a Mac you

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 2:57 PM, Vincent van Ravesteijn wrote: >> Nope -- it works fine for me with near current svn (built yesterday). >> >> BH >> > > Thanks. > > But it is strange as I see this code: > > "void GuiApplication::gotoBookmark(unsigned int idx, bool openFile, >   bool

Re: Bookmark test on MacOSX

> Sorry -- I had other windows open. If I close everything else, and > then try navigating to a bookmark, I get an error "beep" and nothing > else happens. That must be the assert then. >Moreover -- something I hadn't noticed before -- if all > windows are closed, it's not possible to open a new

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 3:25 PM, Vincent van Ravesteijn wrote: >> Sorry -- I had other windows open. If I close everything else, and >> then try navigating to a bookmark, I get an error "beep" and nothing >> else happens. > > That must be the assert then. No. It's just the OS's

Re: Bookmark test on MacOSX

Yet another question. If you normally would reconfigure LyX, you get a message like "Running configure..." in the status bar. Then you know you have to wait. What do you expect on Mac if you don't have any window open ? Now, there is no way of telling that configure is running, right ? Do you

Fwd: Bookmark test on MacOSX

Yet another question. If you normally would reconfigure LyX, you get a message like "Running configure..." in the status bar. Then you know you have to wait. What do you expect on Mac if you don't have any window open ? Now, there is no way of telling that configure is running, right ? Do you

Re: Bookmark test on MacOSX

> Incidentally, in testing all this, I had LyX crash on me twice. I > don't have time now to get a backtrace, but let me know if you want me > to post one later. > > BH > I think the culprit might be in this code: void GuiApplication::processKeySym(KeySymbol const & keysym, KeyModifier state) {

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 10:34 PM, Vincent van Ravesteijn wrote: >> Incidentally, in testing all this, I had LyX crash on me twice. I >> don't have time now to get a backtrace, but let me know if you want me >> to post one later. >> >> BH >> I fixed a number of problems that might

Re: LyX Additional features Version 1.6.7 suggested corrections

Hi Pavel Thanks. Will do. I will change to 2.0 - Uwe has just made the same suggestion. The way I have worked in the past was because that was the instruction in the Help files when I first began submitting changes occasionally some years ago. John -- On Friday 22 October 2010 20:08:50 you

Re: LyX Additional features Version 1.6.7 suggested corrections

John R Hudson wrote: > Hi Pavel > > Thanks. Will do. > > I will change to 2.0 - Uwe has just made the same suggestion. The way I have > worked in the past was because that was the instruction in the Help files > when > I first began submitting changes occasionally some years ago. btw are you

Re: LyX Additional features Version 1.6.7 suggested corrections

On 22/10/2010 4:15 PM, John R Hudson wrote: 5.19 RevTeX4 > > [paragraph 1]The Revtex 4 textclass works with the American Physical > > Sociey's RevTeX 4.1 class. [I haven't tried this but RevTeX4.1 was > > issued in August 2010 and the announcement refers mostly to bugfixes and > >

Re: Some thoughts on further development process towards beta and RCs

> ok, thanks for the info. unless Vincent put it in, i will do before > beta goes out. > I looked at the patch again and in the Qt Docs and I read: {{{ void QClipboard::dataChanged () [signal] This signal is emitted when the clipboard data is changed. On Mac OS X and with Qt version 4.3 or

Re: Bookmark test on MacOSX

A. Am Freitag, den 22.10.2010, 22:34 +0200 schrieb Vincent van Ravesteijn: > > Incidentally, in testing all this, I had LyX crash on me twice. I > > don't have time now to get a backtrace, but let me know if you want me > > to post one later. > > > > BH > > > > I think the culprit

Re: Some thoughts on further development process towards beta and RCs

Am Sonntag, den 17.10.2010, 18:28 +0200 schrieb Pavel Sanda: > John McCabe-Dansted wrote: > > > the most problematic cases of our copy typically happen when > > > middle button is used for getting, or puting stuff from/into another > > > applications and when more lyx instances are used. dunno

Re: New thread offshoot ( Re: r35767 - lyx-devel/trunk/lib/doc )

Am Freitag, den 22.10.2010, 13:28 -0400 schrieb Richard Heck: > >> i wonder why Alert:: code is affected when no preview or export is done? It was a bug in InGuiThread.h, see commit message: "bind makes a copy of the arguments by default. This is secure if the bound object survives the existence

Re: Bookmark test on MacOSX

On Fri, Oct 22, 2010 at 4:08 PM, Vincent van Ravesteijn wrote: > Yet another question. > > If you normally would reconfigure LyX, you get a message like "Running > configure..." in the status bar. Then you know you have to wait. > > What do you expect on Mac if you don't have any

  1   2   >