Re: [LyX/master] Add an external template for minted

[Kornel Benko]

Am Sonntag, 28. Mai 2017 um 23:44:22, schrieb Enrico Forestieri 
> commit 85dd9a2f9c81ad8641c31aa1403cab2678590a0e
> Author: Enrico Forestieri 
> Date:   Sun May 28 23:43:19 2017 +0200
> 
> Add an external template for minted
> 
> See #9095

Checking exports:
The following tests FAILED:
3531 - DEFAULTOUTPUT_export/examples/minted_pdf4_texF (Failed)
3532 - DEFAULTOUTPUT_export/examples/minted_pdf4_systemF (Failed)
Errors while running CTest

(Not working compilations with xelatex)


! Undefined control sequence.
l.17 \usemintedstyle
{bw}
The control sequence at the end of the top line
of your error message was never \def'ed. If you have
misspelled it (e.g., `\hobx'), type `I' and the correct
spelling (e.g., `I\hbox'). Otherwise just continue,
and I'll forget about whatever was undefined.


! LaTeX Error: Missing \begin{document}.

Do we have to install something first?

Kornel


signature.asc
Description: This is a digitally signed message part.

Re: dashes and line-breaks (#10543)

[Georg Baum]

Am 26.05.2017 um 21:54 schrieb Scott Kostyshak:

On Fri, May 19, 2017 at 09:12:27AM -0400, Scott Kostyshak wrote:

Günter has written a lot about what to do regarding em- and en-dashes.
For more information, see:

   http://www.lyx.org/trac/ticket/10543

Does anyone else have feedback on what should be done on this for 2.3.0?

If no one has any feedback by Tuesday, then I suppose we should let
Günter do what he thinks is best on this topic.

Scott

Hi,

I have been out of this topic for too long and expressed my opinion in 
the past, so I cannot add anything further. I agree that Günter should 
decide.



Georg

Re: ext_copy.py

[Scott Kostyshak]

On Thu, May 25, 2017 at 12:31:05PM +1200, Andrew Parsloe wrote:
> 
> On 24/05/2017 9:24 p.m., José Abílio Matos wrote:
> > On Wednesday, 24 May 2017 03.51.55 WEST Scott Kostyshak wrote:
> > 
> > > Any objection from anyone else?
> > 
> > 
> > > Scott
> > 
> > Honestly the use of the plus sign as a special character seems unnatural
> > to me. :-)
> > 
> > My suggestion would be to pass an option that specify just that, say -d.
> > The advantage of this approach it that it does not add new special
> > characters.
> > 
> > A patch follows attached. I have not updated the documentation.
> > Regards,
> > 
> > José Abílio
> > 
> Thank you José. I was the person requesting this, and yes, -d is better than
> using +.

José do you think the patch should go in for 2.3.0? If so go ahead.

Scott


signature.asc
Description: PGP signature

Re: Bad Citation Bug in 2.3dev

[Jürgen Spitzmüller]

Am Sonntag, den 28.05.2017, 12:32 -0400 schrieb Richard Heck:
> Some do, not all. 

But if a given style requests a pagination prefix, the bst (or biblatex
cbx) can and should be configured to output that. This is a
prerequisite for portability between different styles (and languages).

> And of course there are other LaTeX constructs you
> might want in such places.

Sure.

> Another question: Should the "literal" flag default to true or false?
> Having it default to true would be consistent with pre-2.3 behavior.
> People who wanted it otherwise could set it once and then it would
> (should) be remembered.

The argument for setting it to false was that novices tend to run into
more severe problems if they enter text that is interpreted as a
command and might not know what happens (as opposed to LaTeX
literates).

For people who are used to the current situation, there will certainly
a learning process. But on the other hand, the situation was not very
clear at all, since some dialogs were outputting verbatim texts, some
not, some partially. 

Jürgen

> 
> Richard
> 

signature.asc
Description: This is a digitally signed message part

Re: Bad Citation Bug in 2.3dev

[Richard Heck]

On 05/27/2017 03:47 AM, Jürgen Spitzmüller wrote:
> Am Freitag, den 26.05.2017, 18:22 -0400 schrieb Richard Heck:
>> So, question: Shouldn't there be some way to set "literal true" as default? 
>> Or shouldn't this setting be remembered? It's annoying to have to set it 
>> every time.
> We could remember the setting via session.

I'd settle for it being remembered during a session, though that would
be a bonus.

> OTOH, writing things such as p.\ 22 into the citation post field
> strikes me odd. The pagination prefix is something the citation style should 
> care about.

Some do, not all. And of course there are other LaTeX constructs you
might want in such places.

Another question: Should the "literal" flag default to true or false?
Having it default to true would be consistent with pre-2.3 behavior.
People who wanted it otherwise could set it once and then it would
(should) be remembered.

Richard

Re: [patch] Fix lyx-2.3dev build failure in FreeBSD

[Scott Kostyshak]

On Sun, Mar 12, 2017 at 11:21:33PM -0400, Scott Kostyshak wrote:
> On Wed, Aug 10, 2016 at 04:57:12PM -0400, Scott Kostyshak wrote:
> > On Thu, Jun 09, 2016 at 02:30:42AM +0200, Shankar Giri Venkita Giri wrote:
> > > Thanks Pavel.
> > >  
> > > I'll try to produce a patch for #1. Then both #1 and #2, after
> > > review, can go into master/branch. I play around in FreeBSD
> > > frequently, so I can help with build issues/regressions in future as
> > > well.
> > 
> > Hi Shankar,
> > 
> > I'm just curious if there's been any progress on this. No worries if
> > you're busy.
> 
> Hi Shankar,
> 
> I just want to make sure this is not forgotten. Are there any issues
> with the master branch of LyX on FreeBSD now?
> 
> Scott

Shankar,

Did you get the previous messages? It's OK if you are busy or you don't
care about this issue, but I just want to know the situation.

The LyX 2.3.0 release is close and if we don't have a patch for this
issue by next week, we will have to delay it until 2.4.0.

Scott

Re: lyx-2.3.0alpha1-1 crash

[Guillaume MM]

Le 26/05/2017 à 23:04, PhilipPirrip a écrit :


I think I caught this one too. I was working on a document with a few 
float figures exported from inkscape as pdf, LyX 2.3.0alpha1 crashed 
after updating (saving as pdf) one of the figures.
I was running J. Matos' version from 
https://copr.fedorainfracloud.org/coprs/jamatos/lyx-next/

Will try to reproduce.




Here is a patch, reviews are welcome.

Guillaume

>From a3b7ae3c752327768952115b5990de455bd6cc48 Mon Sep 17 00:00:00 2001
From: Guillaume MM 
Date: Sun, 28 May 2017 13:25:53 +0200
Subject: [PATCH] Properly track the lifetime of signals2::slots

Starting at 61b2bd5e, boost::bind was progressively replaced with
std::bind. They are not interchangeable though. boost::bind implements
the tracking of boost::signals{,2}::trackable objects. Now that
std::bind has completely replaced boost::bind, tracking never occurred.

This commit replaces boost::signals2::trackable with the new preferred
boost::signals2 methods: scoped_connections or slot::track_foreign. The
support::Trackable class introduced is less safe but easier for transitioning
old code.

Fixes the crash at
https://www.mail-archive.com/lyx-users@lists.lyx.org/msg105230.html and possibly
other crashes.
---
 src/Converter.cpp  | 22 +
 src/LaTeX.h|  5 ++--
 src/Server.cpp | 11 +
 src/Server.h   |  9 ---
 src/frontends/qt4/GuiView.cpp  |  3 ++-
 src/frontends/qt4/GuiWorkArea.cpp  |  7 +++---
 src/graphics/GraphicsCacheItem.cpp | 25 +---
 src/graphics/GraphicsCacheItem.h   |  6 ++---
 src/graphics/GraphicsConverter.cpp | 26 -
 src/graphics/GraphicsConverter.h   |  8 ---
 src/graphics/GraphicsLoader.cpp| 22 +
 src/graphics/GraphicsLoader.h  | 10 
 src/graphics/PreviewImage.cpp  | 12 --
 src/graphics/PreviewLoader.cpp | 21 ++---
 src/graphics/PreviewLoader.h   |  9 +++
 src/insets/InsetExternal.cpp   |  3 +--
 src/insets/InsetExternal.h |  4 +---
 src/insets/RenderPreview.cpp   | 23 ++
 src/insets/RenderPreview.h | 17 +++---
 src/support/FileMonitor.cpp|  3 +--
 src/support/FileMonitor.h  |  8 +++
 src/support/ForkedCalls.cpp| 19 ---
 src/support/ForkedCalls.h  | 20 +---
 src/support/Makefile.am|  1 +
 src/support/Timeout.h  |  4 ++--
 src/support/signals.h  | 48 ++
 26 files changed, 194 insertions(+), 152 deletions(-)
 create mode 100644 src/support/signals.h

diff --git a/src/Converter.cpp b/src/Converter.cpp
index 104ad0a..6e10b18 100644
--- a/src/Converter.cpp
+++ b/src/Converter.cpp
@@ -693,20 +693,6 @@ bool Converters::scanLog(Buffer const & buffer, string const & /*command*/,
 }
 
 
-namespace {
-
-class ShowMessage
-	: public boost::signals2::trackable {
-public:
-	ShowMessage(Buffer const & b) : buffer_(b) {}
-	void operator()(docstring const & msg) const { buffer_.message(msg); }
-private:
-	Buffer const & buffer_;
-};
-
-}
-
-
 bool Converters::runLaTeX(Buffer const & buffer, string const & command,
 			  OutputParams const & runparams, ErrorList & errorList)
 {
@@ -719,8 +705,12 @@ bool Converters::runLaTeX(Buffer const & buffer, string const & command,
 	buffer.filePath(), buffer.layoutPos(),
 	buffer.lastPreviewError());
 	TeXErrors terr;
-	ShowMessage show(buffer);
-	latex.message.connect(show);
+	// The connection closes itself at the end of the scope when latex is
+	// destroyed. One cannot close (and destroy) buffer while the converter is
+	// running.
+	latex.message.connect([](docstring const & msg){
+			buffer.message(msg);
+		});
 	int const result = latex.run(terr);
 
 	if (result & LaTeX::ERRORS)
diff --git a/src/LaTeX.h b/src/LaTeX.h
index f5d66a5..44920c3 100644
--- a/src/LaTeX.h
+++ b/src/LaTeX.h
@@ -18,8 +18,7 @@
 
 #include "support/docstring.h"
 #include "support/FileName.h"
-
-#include 
+#include "support/signals.h"
 
 #include 
 #include 
@@ -148,7 +147,7 @@ public:
 	};
 
 	/// This signal emits an informative message
-	boost::signals2::signal message;
+	signals2::signal message;
 
 
 	/**
diff --git a/src/Server.cpp b/src/Server.cpp
index b89e834..98e1d66 100644
--- a/src/Server.cpp
+++ b/src/Server.cpp
@@ -55,8 +55,7 @@
 #include "support/lassert.h"
 #include "support/lstrings.h"
 #include "support/os.h"
-
-#include "support/bind.h"
+#include "support/signals.h"
 
 #include 
 
@@ -859,8 +858,12 @@ int LyXComm::startPipe(string const & file, bool write)
 	}
 
 	if (!write) {
-		theApp()->registerSocketCallback(fd,
-			bind(::read_ready, this));
+		// Make sure not to call read_ready after destruction.
+		weak_ptr tracker = tracker_.p();
+		theApp()->registerSocketCallback(fd, [=](){
+if