Re: Porting pop-ups in the rae branch

2000-03-14 Thread John Levon
On Sat, 11 Mar 2000, Allan Rae wrote: I don't want every file moved at once and in particular I only want one dialog per .fd file. When a new form is made gui-indep then its .fd should be in the xforms/forms. It doesn't necessarily have to be derived from the old .fd that it may have been

Re: Porting pop-ups in the rae branch

2000-03-14 Thread John Levon
On Sat, 11 Mar 2000, Allan Rae wrote: > I don't want every file moved at once and in particular I only want one > dialog per .fd file. When a new form is made gui-indep then its .fd > should be in the xforms/forms. It doesn't necessarily have to be derived > from the old .fd that it may have

Re: Porting pop-ups in the rae branch

2000-03-11 Thread Lars Gullik Bjønnes
Allan Rae [EMAIL PROTECTED] writes: | FD_form, declared in class FormBase is: | struct FD_form | { |FL_FORM *form; |void *vdata; |char *cdata; |long ldata; | }; | | What are vdata, cdata and ldata? They aren't used in the | code. Are they

Re: Porting pop-ups in the rae branch

2000-03-11 Thread Lars Gullik Bjønnes
Allan Rae <[EMAIL PROTECTED]> writes: | > FD_form, declared in class FormBase is: | > struct FD_form | > { | > FL_FORM *form; | > void *vdata; | > char *cdata; | > long ldata; | > }; | > | > What are vdata, cdata and ldata? They aren't used in the | > code.

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Jean-Marc Lasgouttes
"Lars" == Lars Gullik Bjønnes [EMAIL PROTECTED] writes: Lars The only variable therein should probably be nuked and be set to Lars always be true. Yes. I plan to do it eventually, but never find the time... JMarc

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Angus Leeming
Forwarded to the list as suggested by Allan Rae: You sure give me a lot to think about ... ;) I'll probably spend the rest of the morning trying to digest all that you've said. Anyway, some comments to your comments on my code, rather than to your comments on the "Best way forward" On Thu, 09

Re: Porting pop-ups in the rae branch

2000-03-10 Thread John Levon
On Fri, 10 Mar 2000, Angus Leeming wrote: FINALLY --- and perhaps most importantly for me --- A QUESTION I haven't done anything in the xforms/forms directory, yet all three pop-ups work. Why is the forms directory needed? A. This contains files created by "fdesign". They are used with

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Angus Leeming
On Fri, 10 Mar 2000, you wrote: I think that all the Signal0 pop-ups are functionally identical and that they are crying out to become derived classes. As an exercise, I've continued my stuff with these two classes (FormCopyright and FormCredits). I also have a third class FormVersions

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Roland Krause
Angus,Allan, I really agree with what Angus says. This is a much cleaner more appropriate design for the problem at hand. I think that all the Signal0 pop-ups are functionally identical and that they are crying out to become derived classes. As an exercise, I've continued my stuff with these

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Jean-Marc Lasgouttes
"Angus" == Angus Leeming [EMAIL PROTECTED] writes: Angus Yes, I looked at fdfix.sh. It seems to ensure that all text is Angus internationalised, etc. I don't want to appear difficult, but I Angus still don't get it. form_copyright.fd just seems to replicate Angus FormCopyright::build() in a

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Allan Rae
On Fri, 10 Mar 2000, John Levon wrote: On Fri, 10 Mar 2000, Angus Leeming wrote: FINALLY --- and perhaps most importantly for me --- A QUESTION I haven't done anything in the xforms/forms directory, yet all three pop-ups work. Why is the forms directory needed? A. This

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Allan Rae
On Fri, 10 Mar 2000, Angus Leeming wrote: This is where templates come in, IMO. _IF_ we need different FD_forms then create a templatised version of FormBase I.e.: template class FD_form class FormBase { FD_form * dialog_; } However, I have a few questions about FD_form. The

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> The only variable therein should probably be nuked and be set to Lars> always be true. Yes. I plan to do it eventually, but never find the time... JMarc

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Angus Leeming
Forwarded to the list as suggested by Allan Rae: You sure give me a lot to think about ... ;) I'll probably spend the rest of the morning trying to digest all that you've said. Anyway, some comments to your comments on my code, rather than to your comments on the "Best way forward" On Thu, 09

Re: Porting pop-ups in the rae branch

2000-03-10 Thread John Levon
On Fri, 10 Mar 2000, Angus Leeming wrote: > FINALLY --- and perhaps most importantly for me --- A > QUESTION > > I haven't done anything in the xforms/forms directory, yet > all three pop-ups work. Why is the forms directory needed? > A. > This contains files created by "fdesign". They are

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Angus Leeming
On Fri, 10 Mar 2000, you wrote: > > I think that all the Signal0 pop-ups are functionally identical and > > that they are crying out to become derived classes. As an exercise, > > I've continued my stuff with these two classes (FormCopyright and > > FormCredits). I also have a third class

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Roland Krause
Angus,Allan, I really agree with what Angus says. This is a much cleaner more appropriate design for the problem at hand. > I think that all the Signal0 pop-ups are functionally > identical and that they are crying out to become derived > classes. As an exercise, I've continued my stuff with

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Yes, I looked at fdfix.sh. It seems to ensure that all text is Angus> internationalised, etc. I don't want to appear difficult, but I Angus> still don't get it. form_copyright.fd just seems to replicate Angus>

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Allan Rae
On Fri, 10 Mar 2000, John Levon wrote: > On Fri, 10 Mar 2000, Angus Leeming wrote: > > > FINALLY --- and perhaps most importantly for me --- A > > QUESTION > > > > I haven't done anything in the xforms/forms directory, yet > > all three pop-ups work. Why is the forms directory needed? > > A. >

Re: Porting pop-ups in the rae branch

2000-03-10 Thread Allan Rae
On Fri, 10 Mar 2000, Angus Leeming wrote: > This is where templates come in, IMO. _IF_ we need > different FD_forms then create a templatised version of > FormBase I.e.: > template class FormBase > { > FD_form * dialog_; > } > > However, I have a few questions about FD_form. The current

Re: Porting pop-ups in the rae branch

2000-03-09 Thread Allan Rae
On Wed, 8 Mar 2000, Angus Leeming wrote: I also modified a FEW lines of a few files in src/frontends/xforms/ and, of course, created two more, FormCredits.[Ch] which are closely modelled on FormCopyright.[Ch] The close similarity between FormCredits.[Ch] and FormCopyright.[Ch] (see

Re: Porting pop-ups in the rae branch

2000-03-09 Thread Jean-Marc Lasgouttes
"Allan" == Allan Rae [EMAIL PROTECTED] writes: Allan 2. To avoid several people trying to port the same code ask me Allan if anyone is working on that dialog or at least post to this Allan list. I will add a table of dialogs with some comments to my Allan web pages so it'll be easier to see

Re: Porting pop-ups in the rae branch

2000-03-09 Thread Allan Rae
On 9 Mar 2000, Jean-Marc Lasgouttes wrote: "Allan" == Allan Rae [EMAIL PROTECTED] writes: Allan 2. To avoid several people trying to port the same code ask me Allan if anyone is working on that dialog or at least post to this Allan list. I will add a table of dialogs with some comments to

Re: Porting pop-ups in the rae branch

2000-03-09 Thread Lars Gullik Bjønnes
Allan Rae [EMAIL PROTECTED] writes: | On 9 Mar 2000, Jean-Marc Lasgouttes wrote: | | "Allan" == Allan Rae [EMAIL PROTECTED] writes: | | Allan 2. To avoid several people trying to port the same code ask me | Allan if anyone is working on that dialog or at least post to this | Allan list.

Re: Porting pop-ups in the rae branch

2000-03-09 Thread Allan Rae
On Wed, 8 Mar 2000, Angus Leeming wrote: > I also modified a FEW lines of a few files in src/frontends/xforms/ > and, of course, created two more, FormCredits.[Ch] which are closely > modelled on FormCopyright.[Ch] > > The close similarity between FormCredits.[Ch] and FormCopyright.[Ch] > (see

Re: Porting pop-ups in the rae branch

2000-03-09 Thread Jean-Marc Lasgouttes
> "Allan" == Allan Rae <[EMAIL PROTECTED]> writes: Allan> 2. To avoid several people trying to port the same code ask me Allan> if anyone is working on that dialog or at least post to this Allan> list. I will add a table of dialogs with some comments to my Allan> web pages so it'll be easier

Re: Porting pop-ups in the rae branch

2000-03-09 Thread Allan Rae
On 9 Mar 2000, Jean-Marc Lasgouttes wrote: > > "Allan" == Allan Rae <[EMAIL PROTECTED]> writes: > > Allan> 2. To avoid several people trying to port the same code ask me > Allan> if anyone is working on that dialog or at least post to this > Allan> list. I will add a table of dialogs with

Re: Porting pop-ups in the rae branch

2000-03-09 Thread Lars Gullik Bjønnes
Allan Rae <[EMAIL PROTECTED]> writes: | On 9 Mar 2000, Jean-Marc Lasgouttes wrote: | | > > "Allan" == Allan Rae <[EMAIL PROTECTED]> writes: | > | > Allan> 2. To avoid several people trying to port the same code ask me | > Allan> if anyone is working on that dialog or at least post to this

Porting pop-ups in the rae branch

2000-03-08 Thread Angus Leeming
i thought I'd follow in Allan Rae's footsteps and try and port a pop-up to frontends. Thinking, "let's keep this simple", I chose the Help-Credits pop-up. I now have a FormCredits.[Ch] in the src/frontends/xforms/ directory and... it all works! The changes I've made in src/ are minimal ---

Re: Porting pop-ups in the rae branch

2000-03-08 Thread Lars Gullik Bjønnes
Angus Leeming [EMAIL PROTECTED] writes: | --Boundary-=_qmZrHLajoetbkwlTZTViemHPfybp | Content-Type: text/plain | Content-Transfer-Encoding: 8bit | | i thought I'd follow in Allan Rae's footsteps and try and | port a pop-up to frontends. Allan, are you having a look at this? Lgb

Re: Porting pop-ups in the rae branch

2000-03-08 Thread Allan Rae
I haven't time to look at this straight away. I'll look tonight and give you some feedback on the patches tomorrow. I have a few comments for you at the bottom of this email also. I'll make a few general comments at this point regarding rules for gui-indep of dialogs. These are not directed

Porting pop-ups in the rae branch

2000-03-08 Thread Angus Leeming
i thought I'd follow in Allan Rae's footsteps and try and port a pop-up to frontends. Thinking, "let's keep this simple", I chose the Help->Credits pop-up. I now have a FormCredits.[Ch] in the src/frontends/xforms/ directory and... it all works! The changes I've made in src/ are minimal ---

Re: Porting pop-ups in the rae branch

2000-03-08 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | --Boundary-=_qmZrHLajoetbkwlTZTViemHPfybp | Content-Type: text/plain | Content-Transfer-Encoding: 8bit | | i thought I'd follow in Allan Rae's footsteps and try and | port a pop-up to frontends. Allan, are you having a look at this? Lgb

Re: Porting pop-ups in the rae branch

2000-03-08 Thread Allan Rae
I haven't time to look at this straight away. I'll look tonight and give you some feedback on the patches tomorrow. I have a few comments for you at the bottom of this email also. I'll make a few general comments at this point regarding rules for gui-indep of dialogs. These are not directed