Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
On Thu, Feb 16, 2017 at 07:06:48PM +0100, Jean-Pierre Chrétien wrote: > Happily, ACM decided to shift to the sole acmart.cls class for all their > publications as Jürgen pointed out (see also > https://www.tug.org/tug2016/slides/veytsman.pdf), and made very recently all > their old class files unavailable. > So we rather should cencentrate on creating a layout for the acmart class > rather than fighting with obsolete stuff like I did (it is stated that > obsoleted LaTeX acm packages won't be usable to submit publications after > Spring 2017). Looks like some work has been done on a layout for acmart.cls by John Perry at http://www.lyx.org/trac/ticket/10632 Can someone take a look at that? Scott signature.asc Description: PGP signature
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Am Sonntag, den 19.02.2017, 11:12 +0100 schrieb Jean-Pierre Chrétien: > OK, that's clear now, it works, thanks for the hint. I pushed the fix to master. Richard, this should also go to branch. Jürgen signature.asc Description: This is a digitally signed message part
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Le 18/02/2017 à 19:19, Jürgen Spitzmüller a écrit : Am Samstag, den 18.02.2017, 18:37 +0100 schrieb Jean-Pierre Chrétien: Did your commit really solve this issue ? I'm not sure to understand the added code. Yes. Try the attached patch. OK, that's clear now, it works, thanks for the hint. -- Jean-Pierre
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Am Samstag, den 18.02.2017, 18:37 +0100 schrieb Jean-Pierre Chrétien:
> > OK, I see what you mean now. The following bug needs to be fixed
> > first.
> > http://www.lyx.org/trac/ticket/10215
>
> After git pull and recompiling, I still see the "Lyx specific LaTeX
> commands"
> loaded before the "Textclass specific LaTeX commands".
>
> Did your commit really solve this issue ? I'm not sure to understand
> the added code.
Yes. Try the attached patch.
Jürgendiff --git a/lib/layouts/acmsiggraph-0-92.layout b/lib/layouts/acmsiggraph-0-92.layout
index f9fd34230f..96762d22c7 100644
--- a/lib/layouts/acmsiggraph-0-92.layout
+++ b/lib/layouts/acmsiggraph-0-92.layout
@@ -110,6 +110,10 @@ Style "Copyright_year"
CopyStyle "TOG online ID"
LatexName copyrightyear
LabelString "Year of copyright:"
+ Preamble
+ % Compatibility fix for acmsiggraph >= 0.93.
+ \@ifundefined{copyrightyear}{\let\copyrightyear\CopyrightYear}{}
+ EndPreamble
End
signature.asc
Description: This is a digitally signed message part
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Le 18/02/2017 à 09:07, Jürgen Spitzmüller a écrit : OK, I see what you mean now. The following bug needs to be fixed first. http://www.lyx.org/trac/ticket/10215 After git pull and recompiling, I still see the "Lyx specific LaTeX commands" loaded before the "Textclass specific LaTeX commands". Did your commit really solve this issue ? I'm not sure to understand the added code. -- Jean-Pierre
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Am Freitag, den 17.02.2017, 21:27 +0100 schrieb Jürgen Spitzmüller: > > I tried this on master, I had to change the InPreamble directive to > 0 > > for the > > Copyright_Year style, otherwise the AddToPreamble inserted code is > > exported by > > LyX after the copyrightyear command. > > You should use the Preamble tag of the style. Then you should not > need > to alter InPreamble. Also, this only inserts the code when needed. OK, I see what you mean now. The following bug needs to be fixed first. http://www.lyx.org/trac/ticket/10215 Jürgen signature.asc Description: This is a digitally signed message part
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Am Freitag, den 17.02.2017, 20:48 +0100 schrieb Jean-Pierre Chrétien: > I tried this on master, I had to change the InPreamble directive to 0 > for the > Copyright_Year style, otherwise the AddToPreamble inserted code is > exported by > LyX after the copyrightyear command. You should use the Preamble tag of the style. Then you should not need to alter InPreamble. Also, this only inserts the code when needed. > > I also added a style for acmPrice added in 0.93 in the layout, > without editing > the template. This is a file format change, so it cannot go in without further steps (as documented in Development.lyx). Jürgen > > OK to push ? > signature.asc Description: This is a digitally signed message part
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Le 17/02/2017 à 08:44, Jürgen Spitzmüller a écrit :
Nonetheless Günter's proposal makes sense and is a cheap fix for recent
versions of acmsiggraph. However, I'd stick with the old macro, since
the layout version indicates 0.92, and add to Style "Copyright_year":
Preamble
% Compatibility fix for acmsiggraph >= 0.93.
\@ifundefined{copyrightyear}{\let\copyrightyear\CopyrightYear}{}
EndPreamble
I tried this on master, I had to change the InPreamble directive to 0 for the
Copyright_Year style, otherwise the AddToPreamble inserted code is exported by
LyX after the copyrightyear command.
I also added a style for acmPrice added in 0.93 in the layout, without editing
the template.
OK to push ?
--
Jean-Pierre
commit b4dacd8d652e290fd25a4e9a204c5c408e7782a5
Author: jpc
Date: Fri Feb 17 18:16:27 2017 +0100
Cope with changes in acmsiggraph.cls v0.93
Follwing a suggestion by Günter and Jürgen, avoids to creta a new
layout for a minor change in an obsoleted class.
diff --git a/lib/layouts/acmsiggraph-0-92.layout b/lib/layouts/acmsiggraph-0-92.layout
index f9fd342..d06e7e0 100644
--- a/lib/layouts/acmsiggraph-0-92.layout
+++ b/lib/layouts/acmsiggraph-0-92.layout
@@ -8,6 +8,11 @@
# BibTeX style and template, and the documentation is available at
# http://www.siggraph.org/learn/instructions-authors
#
+# As from Spring 2017, the class will not be usable to submit
+# a publication to ACM, it is OBSOLETE
+# Please use instead the new acmart.cls class file, distributed with
+# TeXLive >= 2016
+#
# Versions:
# siggraph 0.9: initial layout
# siggraph 0.92: Removed styles "TOG project URL", "TOG video URL",
@@ -16,6 +21,11 @@
Format 63
+AddToPreamble
+% Compatibility fix for acmsiggraph >= 0.93.
+\@ifundefined{copyrightyear}{\let\copyrightyear\CopyrightYear}{}
+EndPreamble
+
Columns1
Sides 1
SecNumDepth3
@@ -34,7 +44,6 @@ DefaultFont
ColorNone
EndFont
-
Style Standard
Category MainText
Margin Static
@@ -110,6 +119,7 @@ Style "Copyright_year"
CopyStyle "TOG online ID"
LatexName copyrightyear
LabelString "Year of copyright:"
+ InPreamble 0
End
@@ -131,6 +141,12 @@ Style "ISBN"
LabelString "ISBN:"
End
+# acmPrice added in 0.93
+Style "ACM Price"
+ CopyStyle "TOG online ID"
+ LatexName acmPrice
+ LabelString "ACM Price:"
+End
Style "DOI"
CopyStyle "TOG online ID"
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
On 2017-02-17, Jürgen Spitzmüller wrote:
> [-- Type: text/plain, Encoding: quoted-printable --]
> Am Donnerstag, den 16.02.2017, 19:06 +0100 schrieb Jean-Pierre
> Chrétien:
>> Happily, ACM decided to shift to the sole acmart.cls class for all
>> their
>> publications as Jürgen pointed out (see also
>> https://www.tug.org/tug2016/slides/veytsman.pdf), and made very
>> recently all
>> their old class files unavailable.
>> So we rather should cencentrate on creating a layout for the acmart
>> class rather
>> than fighting with obsolete stuff like I did (it is stated that
>> obsoleted LaTeX
>> acm packages won't be usable to submit publications after Spring
>> 2017).
> Nonetheless Günter's proposal makes sense and is a cheap fix for recent
> versions of acmsiggraph. However, I'd stick with the old macro, since
> the layout version indicates 0.92, and add to Style "Copyright_year":
> Preamble
> % Compatibility fix for acmsiggraph >= 0.93.
> \@ifundefined{copyrightyear}{\let\copyrightyear\CopyrightYear}{}
> EndPreamble
Seems to be the most practicable solution for now.
Günter
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Am Donnerstag, den 16.02.2017, 19:06 +0100 schrieb Jean-Pierre
Chrétien:
> Happily, ACM decided to shift to the sole acmart.cls class for all
> their
> publications as Jürgen pointed out (see also
> https://www.tug.org/tug2016/slides/veytsman.pdf), and made very
> recently all
> their old class files unavailable.
> So we rather should cencentrate on creating a layout for the acmart
> class rather
> than fighting with obsolete stuff like I did (it is stated that
> obsoleted LaTeX
> acm packages won't be usable to submit publications after Spring
> 2017).
Nonetheless Günter's proposal makes sense and is a cheap fix for recent
versions of acmsiggraph. However, I'd stick with the old macro, since
the layout version indicates 0.92, and add to Style "Copyright_year":
Preamble
% Compatibility fix for acmsiggraph >= 0.93.
\@ifundefined{copyrightyear}{\let\copyrightyear\CopyrightYear}{}
EndPreamble
Jürgen
signature.asc
Description: This is a digitally signed message part
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
On Thu, Feb 16, 2017 at 07:06:48PM +0100, Jean-Pierre Chrétien wrote: > Le 15/02/2017 à 02:09, Scott Kostyshak a écrit : > > On Tue, Feb 14, 2017 at 05:20:19PM +0100, Jürgen Spitzmüller wrote: > > > Am Dienstag, den 14.02.2017, 16:16 +0100 schrieb Jean-Pierre Chrétien: > > > > diff --git a/lib/layouts/acmsiggraph-0-92.layout > > > > b/lib/layouts/acmsiggraph-0-92.layout > > > > index 5732ecc..30a35df 100644 > > > > --- a/lib/layouts/acmsiggraph-0-92.layout > > > > +++ b/lib/layouts/acmsiggraph-0-92.layout > > > > @@ -108,7 +108,7 @@ End > > > > > > > > Style "Copyright_year" > > > > CopyStyle "TOG online ID" > > > > - LatexName copyrightyear > > > > + LatexName CopyrightYear > > > > LabelString "Year of copyright:" > > > > > > Are you sure this command was not valid in previous versions? The > > > changelog of 0.93 says: "Corrected \CopyrightYear command". Perhaps you > > > should double-check with version 0.92. > > > > +1 > > > > For more information on how to handle this situation, see the > > Development manual section: > > 3.3 Layouts for document classes with incompatible versions > > Thanks for the pointer, I should have seen that asmsiggraph was the example > used to illustrate the subject, and noticed that I had retrieved the 0.93 > version, so that really I should have rather created a > acmsiggraph-0.93.layout file, and in master rather than in stable. > > Happily, ACM decided to shift to the sole acmart.cls class for all their > publications as Jürgen pointed out (see also > https://www.tug.org/tug2016/slides/veytsman.pdf), and made very recently all > their old class files unavailable. > So we rather should cencentrate on creating a layout for the acmart class > rather than fighting with obsolete stuff like I did (it is stated that > obsoleted LaTeX acm packages won't be usable to submit publications after > Spring 2017). This is good to know. Thanks for looking into it. Scott signature.asc Description: PGP signature
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Le 15/02/2017 à 02:09, Scott Kostyshak a écrit : On Tue, Feb 14, 2017 at 05:20:19PM +0100, Jürgen Spitzmüller wrote: Am Dienstag, den 14.02.2017, 16:16 +0100 schrieb Jean-Pierre Chrétien: diff --git a/lib/layouts/acmsiggraph-0-92.layout b/lib/layouts/acmsiggraph-0-92.layout index 5732ecc..30a35df 100644 --- a/lib/layouts/acmsiggraph-0-92.layout +++ b/lib/layouts/acmsiggraph-0-92.layout @@ -108,7 +108,7 @@ End Style "Copyright_year" CopyStyle "TOG online ID" - LatexName copyrightyear + LatexName CopyrightYear LabelString "Year of copyright:" Are you sure this command was not valid in previous versions? The changelog of 0.93 says: "Corrected \CopyrightYear command". Perhaps you should double-check with version 0.92. +1 For more information on how to handle this situation, see the Development manual section: 3.3 Layouts for document classes with incompatible versions Thanks for the pointer, I should have seen that asmsiggraph was the example used to illustrate the subject, and noticed that I had retrieved the 0.93 version, so that really I should have rather created a acmsiggraph-0.93.layout file, and in master rather than in stable. Happily, ACM decided to shift to the sole acmart.cls class for all their publications as Jürgen pointed out (see also https://www.tug.org/tug2016/slides/veytsman.pdf), and made very recently all their old class files unavailable. So we rather should cencentrate on creating a layout for the acmart class rather than fighting with obsolete stuff like I did (it is stated that obsoleted LaTeX acm packages won't be usable to submit publications after Spring 2017). -- Jean-Pierre
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
On 2017-02-15, Jean-Pierre Chrétien wrote:
> Le 14/02/2017 à 17:20, Jürgen Spitzmüller a écrit :
>> Am Dienstag, den 14.02.2017, 16:16 +0100 schrieb Jean-Pierre Chrétien:
>>> diff --git a/lib/layouts/acmsiggraph-0-92.layout
>>> b/lib/layouts/acmsiggraph-0-92.layout
>>> index 5732ecc..30a35df 100644
>>> --- a/lib/layouts/acmsiggraph-0-92.layout
>>> +++ b/lib/layouts/acmsiggraph-0-92.layout
>>> @@ -108,7 +108,7 @@ End
>>> Style "Copyright_year"
>>> CopyStyle "TOG online ID"
>>> - LatexName copyrightyear
>>> + LatexName CopyrightYear
>>> LabelString "Year of copyright:"
>> Are you sure this command was not valid in previous versions? The
>> changelog of 0.93 says: "Corrected \CopyrightYear command". Perhaps you
>> should double-check with version 0.92.
> Sure, it was copyrightyear in earlier versions.
>> BTW it seems like the class is deprecated anyway in favour of
>> acmart.cls. See
>> http://www.siggraph.org/learn/instructions-authors
> You're right, and acmart.cls is in TeXLive2016.
> So what? Should we remove the acmsiggraph template and layout once a template
> and layout are available for acmart? I can look at this when I find some time
> to
> do so.
> In the meantime, the asmsiggraph template fails to compile without my patch.
> Shoud it be applied (this is for stable)?
If it was copyrightyear in earlier versions, it will fail with your patch
for people using the earlier versions.
I propose to add compatibility code in the preamble, e.g.
\providecommand*{\CopyrightYear}{\copyrightyear}
This way, we don't need one more layout for a deprecated document class'
version.
In addition, the template and layout should get a comment that
>> the class is deprecated anyway in favour of
>> acmart.cls. See http://www.siggraph.org/learn/instructions-authors
Günter
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Le 14/02/2017 à 17:20, Jürgen Spitzmüller a écrit : Am Dienstag, den 14.02.2017, 16:16 +0100 schrieb Jean-Pierre Chrétien: diff --git a/lib/layouts/acmsiggraph-0-92.layout b/lib/layouts/acmsiggraph-0-92.layout index 5732ecc..30a35df 100644 --- a/lib/layouts/acmsiggraph-0-92.layout +++ b/lib/layouts/acmsiggraph-0-92.layout @@ -108,7 +108,7 @@ End Style "Copyright_year" CopyStyle "TOG online ID" - LatexName copyrightyear + LatexName CopyrightYear LabelString "Year of copyright:" Are you sure this command was not valid in previous versions? The changelog of 0.93 says: "Corrected \CopyrightYear command". Perhaps you should double-check with version 0.92. Sure, it was copyrightyear in earlier versions. BTW it seems like the class is deprecated anyway in favour of acmart.cls. See http://www.siggraph.org/learn/instructions-authors You're right, and acmart.cls is in TeXLive2016. So what? Should we remove the acmsiggraph template and layout once a template and layout are available for acmart? I can look at this when I find some time to do so. In the meantime, the asmsiggraph template fails to compile without my patch. Shoud it be applied (this is for stable)? -- Jean-Pierre
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
On Tue, Feb 14, 2017 at 05:20:19PM +0100, Jürgen Spitzmüller wrote: > Am Dienstag, den 14.02.2017, 16:16 +0100 schrieb Jean-Pierre Chrétien: > > diff --git a/lib/layouts/acmsiggraph-0-92.layout > > b/lib/layouts/acmsiggraph-0-92.layout > > index 5732ecc..30a35df 100644 > > --- a/lib/layouts/acmsiggraph-0-92.layout > > +++ b/lib/layouts/acmsiggraph-0-92.layout > > @@ -108,7 +108,7 @@ End > > > > Style "Copyright_year" > > CopyStyle "TOG online ID" > > - LatexName copyrightyear > > + LatexName CopyrightYear > > LabelString "Year of copyright:" > > Are you sure this command was not valid in previous versions? The > changelog of 0.93 says: "Corrected \CopyrightYear command". Perhaps you > should double-check with version 0.92. +1 For more information on how to handle this situation, see the Development manual section: 3.3 Layouts for document classes with incompatible versions Scott signature.asc Description: PGP signature
Re: CopyrightYear is the correct command name in acmsiggraph-0.92.layout
Am Dienstag, den 14.02.2017, 16:16 +0100 schrieb Jean-Pierre Chrétien: > diff --git a/lib/layouts/acmsiggraph-0-92.layout > b/lib/layouts/acmsiggraph-0-92.layout > index 5732ecc..30a35df 100644 > --- a/lib/layouts/acmsiggraph-0-92.layout > +++ b/lib/layouts/acmsiggraph-0-92.layout > @@ -108,7 +108,7 @@ End > > Style "Copyright_year" > CopyStyle "TOG online ID" > - LatexName copyrightyear > + LatexName CopyrightYear > LabelString "Year of copyright:" Are you sure this command was not valid in previous versions? The changelog of 0.93 says: "Corrected \CopyrightYear command". Perhaps you should double-check with version 0.92. BTW it seems like the class is deprecated anyway in favour of acmart.cls. See http://www.siggraph.org/learn/instructions-authors Jürgen signature.asc Description: This is a digitally signed message part
