Re: Testing of the 2.2.x Branch (esp Slowness)
On 01/08/2017 05:22 PM, Enrico Forestieri wrote: > On Sun, Jan 08, 2017 at 03:14:51PM -0500, Richard Heck wrote: >> On 01/08/2017 02:05 PM, Enrico Forestieri wrote: >>> On Sun, Jan 08, 2017 at 01:45:57PM -0500, Richard Heck wrote: >>> On 01/08/2017 09:17 AM, Scott Kostyshak wrote: > On Sun, Jan 08, 2017 at 09:30:32AM +, Jean-Pierre Chrétien wrote: > >> The only thing I noticed is a >> lot of messages >> >> QFile::remove: Empty or null file name >> >> in the calling shell window. > We noticed the same thing at > https://www.mail-archive.com/search?l=mid=a15e9a60-11bb-c081-84cb-9b7f8536b163%40free.fr > > but I could not figure out the root cause. This must be coming from a call to QFile::remove in FileName.cpp. My suggestion would be to put some LYXERR0 messages before each of them and see where it's coming from. Then, once you know that, maybe put a temporary assertion on a non-empty filename. Or even just start with that. >>> Simply don't try to remove a file that has yet to be created. This occurs >>> when cloning InsetExternal. See attached. >> Looks reasonable enough to me. Seems to be in both master and stable. > Committed at 25e6b5da. Please, cherry pick if you want it in stable. Thanks. rh
Re: Testing of the 2.2.x Branch (esp Slowness)
On Sun, Jan 08, 2017 at 03:14:51PM -0500, Richard Heck wrote: > On 01/08/2017 02:05 PM, Enrico Forestieri wrote: > > On Sun, Jan 08, 2017 at 01:45:57PM -0500, Richard Heck wrote: > > > >> On 01/08/2017 09:17 AM, Scott Kostyshak wrote: > >>> On Sun, Jan 08, 2017 at 09:30:32AM +, Jean-Pierre Chrétien wrote: > >>> > The only thing I noticed is a > lot of messages > > QFile::remove: Empty or null file name > > in the calling shell window. > >>> We noticed the same thing at > >>> https://www.mail-archive.com/search?l=mid=a15e9a60-11bb-c081-84cb-9b7f8536b163%40free.fr > >>> > >>> but I could not figure out the root cause. > >> This must be coming from a call to QFile::remove in FileName.cpp. My > >> suggestion would be to put some LYXERR0 messages before each of them and > >> see where it's coming from. Then, once you know that, maybe put a > >> temporary assertion on a non-empty filename. Or even just start with that. > > Simply don't try to remove a file that has yet to be created. This occurs > > when cloning InsetExternal. See attached. > > Looks reasonable enough to me. Seems to be in both master and stable. Committed at 25e6b5da. Please, cherry pick if you want it in stable. -- Enrico
Re: Testing of the 2.2.x Branch (esp Slowness)
On 01/08/2017 02:05 PM, Enrico Forestieri wrote: > On Sun, Jan 08, 2017 at 01:45:57PM -0500, Richard Heck wrote: > >> On 01/08/2017 09:17 AM, Scott Kostyshak wrote: >>> On Sun, Jan 08, 2017 at 09:30:32AM +, Jean-Pierre Chrétien wrote: >>> The only thing I noticed is a lot of messages QFile::remove: Empty or null file name in the calling shell window. >>> We noticed the same thing at >>> https://www.mail-archive.com/search?l=mid=a15e9a60-11bb-c081-84cb-9b7f8536b163%40free.fr >>> >>> but I could not figure out the root cause. >> This must be coming from a call to QFile::remove in FileName.cpp. My >> suggestion would be to put some LYXERR0 messages before each of them and >> see where it's coming from. Then, once you know that, maybe put a >> temporary assertion on a non-empty filename. Or even just start with that. > Simply don't try to remove a file that has yet to be created. This occurs > when cloning InsetExternal. See attached. Looks reasonable enough to me. Seems to be in both master and stable. Richard
Re: Testing of the 2.2.x Branch (esp Slowness)
On Sun, Jan 08, 2017 at 01:45:57PM -0500, Richard Heck wrote:
> On 01/08/2017 09:17 AM, Scott Kostyshak wrote:
> > On Sun, Jan 08, 2017 at 09:30:32AM +, Jean-Pierre Chrétien wrote:
> >
> >> The only thing I noticed is a
> >> lot of messages
> >>
> >> QFile::remove: Empty or null file name
> >>
> >> in the calling shell window.
> > We noticed the same thing at
> > https://www.mail-archive.com/search?l=mid=a15e9a60-11bb-c081-84cb-9b7f8536b163%40free.fr
> >
> > but I could not figure out the root cause.
>
> This must be coming from a call to QFile::remove in FileName.cpp. My
> suggestion would be to put some LYXERR0 messages before each of them and
> see where it's coming from. Then, once you know that, maybe put a
> temporary assertion on a non-empty filename. Or even just start with that.
Simply don't try to remove a file that has yet to be created. This occurs
when cloning InsetExternal. See attached.
--
Enrico
diff --git a/src/insets/InsetExternal.cpp b/src/insets/InsetExternal.cpp
index b68a09d..00c304a 100644
--- a/src/insets/InsetExternal.cpp
+++ b/src/insets/InsetExternal.cpp
@@ -99,7 +99,8 @@ TempName::~TempName()
TempName & TempName::operator=(TempName const & other)
{
if (this != ) {
- tempname_.removeFile();
+ if (!tempname_.empty())
+ tempname_.removeFile();
support::TempFile f("lyxextXX.tmp");
f.setAutoRemove(false);
tempname_ = f.name();
Re: Testing of the 2.2.x Branch (esp Slowness)
On 01/08/2017 09:17 AM, Scott Kostyshak wrote: > On Sun, Jan 08, 2017 at 09:30:32AM +, Jean-Pierre Chrétien wrote: > >> The only thing I noticed is a >> lot of messages >> >> QFile::remove: Empty or null file name >> >> in the calling shell window. > We noticed the same thing at > https://www.mail-archive.com/search?l=mid=a15e9a60-11bb-c081-84cb-9b7f8536b163%40free.fr > > but I could not figure out the root cause. This must be coming from a call to QFile::remove in FileName.cpp. My suggestion would be to put some LYXERR0 messages before each of them and see where it's coming from. Then, once you know that, maybe put a temporary assertion on a non-empty filename. Or even just start with that. Richard
Re: Testing of the 2.2.x Branch (esp Slowness)
On Sun, Jan 08, 2017 at 09:30:32AM +, Jean-Pierre Chrétien wrote: > The only thing I noticed is a > lot of messages > > QFile::remove: Empty or null file name > > in the calling shell window. We noticed the same thing at https://www.mail-archive.com/search?l=mid=a15e9a60-11bb-c081-84cb-9b7f8536b163%40free.fr but I could not figure out the root cause. Scott signature.asc Description: PGP signature
Re: Testing of the 2.2.x Branch (esp Slowness)
Le 07/01/2017 à 02:05, Richard Heck a écrit : We (specifically, Jean-Marc Lasgouttes) have recently made some changes to the text rendering algorithms in LyX. We would appreciate it if those who are able could compile and use the 2.2.x branch of the git repository, so that these changes can receive sufficient testing before we schedule the release of LyX 2.2.3. I just finished updating the French version of the EmbeddedObjects manual using a fresh release compilation of 2.2.x. The only thing I noticed is a lot of messages QFile::remove: Empty or null file name in the calling shell window. Configuration on Debian Jessie: Host type: x86_64-unknown-linux-gnu Special build flags: build=release c++11 std-regex use-hunspell C++ Compiler:g++ (4.9.2) C++ Compiler flags: -std=c++11 -O2 -Wno-deprecated-declarations C++ Compiler user flags: Linker flags: Linker user flags: Qt Frontend: Qt version: 4.8.6 Packaging: posix LyX binary dir: /usr/local/bin LyX files dir: /usr/local/share/lyx-2.2.3dev -- Jean-Pierre
