Re: configure.py: convert warnings to errors for pre-release?

2018-02-17 Thread Scott Kostyshak
On Sat, Feb 17, 2018 at 09:53:42PM +, José Abílio Matos wrote: > Where I would appreciate some help is to categorize those 7 events, as I said > above I do not > think that "Latex not usable (not LaTeX2e) " is warning, I would say that it > critical. +1 > So basically go to

Re: configure.py: convert warnings to errors for pre-release?

2018-02-17 Thread José Abílio Matos
On Saturday, 17 February 2018 15.27.48 WET Scott Kostyshak wrote: > On Sat, Feb 17, 2018 at 01:53:55PM +, José Abílio Matos wrote: > > What are the cases where a bigger warning is expected? > > I don't have anything specific in mind. There are seven instances of > "logger.warning" if you want

Re: configure.py: convert warnings to errors for pre-release?

2018-02-17 Thread Scott Kostyshak
On Sat, Feb 17, 2018 at 01:53:55PM +, José Abílio Matos wrote: > > What are the cases where a bigger warning is expected? I don't have anything specific in mind. There are seven instances of "logger.warning" if you want to search for specific cases. Scott signature.asc Description: PGP

Re: configure.py: convert warnings to errors for pre-release?

2018-02-12 Thread Scott Kostyshak
On Mon, Feb 12, 2018 at 08:57:50AM +, Jean-Marc Lasgouttes wrote: > When I wrote this, I thought about a warnings dialog. But now I think that a > separate log file (configure_errors.log) might be better. It is easier to > check that the file is not empty. Ah I see what you mean. Yeah that

Re: configure.py: convert warnings to errors for pre-release?

2018-02-12 Thread Scott Kostyshak
On Mon, Feb 12, 2018 at 08:47:04AM +, Pavel Sanda wrote: > Scott Kostyshak wrote: > > additionally whether it would > > make sense to turn this option on by default when using > > --enable-build-type=pre (autotools) and -DLYX_RELEASE=OFF (CMake). > > I don't think this is smart, imagine you

Re: configure.py: convert warnings to errors for pre-release?

2018-02-12 Thread Jean-Marc Lasgouttes
Le 10/02/2018 à 23:48, Scott Kostyshak a écrit : On Sat, Feb 10, 2018 at 09:17:04PM +, Jean-Marc Lasgouttes wrote: However warnings could go to standard error, I did not check, but in a quick look we write errors with logger.error() and I assume that goes to standard error. and this

Re: configure.py: convert warnings to errors for pre-release?

2018-02-12 Thread Pavel Sanda
Scott Kostyshak wrote: > additionally whether it would > make sense to turn this option on by default when using > --enable-build-type=pre (autotools) and -DLYX_RELEASE=OFF (CMake). I don't think this is smart, imagine you bisect and have to deal with one layer of "errors" above it. Pavel

Re: configure.py: convert warnings to errors for pre-release?

2018-02-10 Thread Scott Kostyshak
On Sat, Feb 10, 2018 at 09:17:04PM +, Jean-Marc Lasgouttes wrote: > However warnings could go to standard error, I did not check, but in a quick look we write errors with logger.error() and I assume that goes to standard error. > and this could be made > available somehow. What do you

Re: configure.py: convert warnings to errors for pre-release?

2018-02-10 Thread Jean-Marc Lasgouttes
Le 10/02/2018 à 19:44, Scott Kostyshak a écrit : I'm wondering if it would be useful to add an option to configure.py that would turn warnings into errors; and additionally whether it would make sense to turn this option on by default when using --enable-build-type=pre (autotools) and

Re: configure.py: convert warnings to errors for pre-release?

2018-02-10 Thread Scott Kostyshak
On Thu, Feb 01, 2018 at 07:09:47PM +, Scott Kostyshak wrote: > Thanks to Jean-Pierre's hawk eyes, we found a potential issue in > configure.py [1]. I did not see this because I don't manually check the > configure log (although this would be a good thing to do from time to > time). > > I'm