Re: [Mesa-dev] [PATCH 5/9] st/mesa: implement PBO upload for multiple layers

On Thu, Jan 21, 2016 at 5:12 AM, Marek Olšák wrote: > On Mon, Jan 18, 2016 at 11:22 PM, Nicolai Hähnle wrote: >> From: Nicolai Hähnle >> >> Use instancing to generate two triangles for each destination layer and use >> a geometry

Re: [Mesa-dev] [PATCH v4] mesa: enable enums for OES_geometry_shader

On Thu, Dec 10, 2015 at 11:11 AM, Marta Lofstedt wrote: > + case EXTRA_EXT_GPU5_GS: > + api_check = GL_TRUE; > + api_found = (ctx->Extensions.ARB_gpu_shader5 || > + _mesa_has_OES_geometry_shader(ctx)); > + break; >

Re: [Mesa-dev] [PATCH 9/9] gallium/radeon: support PIPE_CAP_SURFACE_REINTERPRET_BLOCKS

Reviewed-by: Marek Olšák FYI, si_resource_copy_region does the reinterpretation for copying. Marek On Mon, Jan 18, 2016 at 11:22 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This is already used internally in the

Re: [Mesa-dev] [PATCH] glsl: always compute proper varying type, irrespective of varying packing

On 21 January 2016 11:30:21 pm AEDT, Timothy Arceri wrote: > > >On 21 January 2016 11:17:06 pm AEDT, Ilia Mirkin >wrote: >>Normally there's a producer and consumer, and the producer var gets >>picked. In both the vertex->gs and tes->gs cases,

[Mesa-dev] [PATCH] glsl: always compute proper varying type, irrespective of varying packing

Normally there's a producer and consumer, and the producer var gets picked. In both the vertex->gs and tes->gs cases, that's the un-arrayed version. In the SSO case, however, there is no producer. So we picked the arrayed GS variable, and as a result, used more slots than we should. More

Re: [Mesa-dev] [PATCH v4] mesa: enable enums for OES_geometry_shader

On Thu, Jan 21, 2016 at 7:57 AM, Lofstedt, Marta wrote: >> -Original Message- >> From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia >> Mirkin >> Sent: Thursday, January 21, 2016 1:46 PM >> To: Lofstedt, Marta >> Cc: Marta Lofstedt;

Re: [Mesa-dev] [PATCH v4] mesa: enable enums for OES_geometry_shader

> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Thursday, January 21, 2016 2:03 PM > To: Lofstedt, Marta > Cc: Marta Lofstedt; mesa-dev@lists.freedesktop.org > Subject: Re: [PATCH v4] mesa: enable enums for

[Mesa-dev] re-visit oes_geometry_shader patches

Due to my involvement in recent trigger happy merging incidents, I am now afraid to merged below patches that all has only one reviewer: http://patchwork.freedesktop.org/patch/66412/ http://patchwork.freedesktop.org/patch/66740/ http://patchwork.freedesktop.org/patch/67671/

Re: [Mesa-dev] [PATCH v4] mesa: enable enums for OES_geometry_shader

> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Thursday, January 21, 2016 1:46 PM > To: Lofstedt, Marta > Cc: Marta Lofstedt; mesa-dev@lists.freedesktop.org > Subject: Re: [PATCH v4] mesa: enable enums for

Re: [Mesa-dev] [PATCH v4] mesa: enable enums for OES_geometry_shader

On Thu, Jan 21, 2016 at 7:41 AM, Lofstedt, Marta wrote: >> -Original Message- >> From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia >> Mirkin >> Sent: Thursday, January 21, 2016 1:25 PM >> To: Marta Lofstedt >> Cc:

Re: [Mesa-dev] New stable-branch 11.0 candidate pushed

On 19 January 2016 at 14:57, Marek Olšák wrote: > On Tue, Jan 19, 2016 at 1:48 PM, Emil Velikov > wrote: >> >> Marek Olšák (3): >> program: add _mesa_reserve_parameter_storage >> st/mesa: fix GLSL uniform updates for glBitmap &

Re: [Mesa-dev] [PATCH] glsl: always compute proper varying type, irrespective of varying packing

On Thu, Jan 21, 2016 at 7:39 AM, Ilia Mirkin wrote: > On Thu, Jan 21, 2016 at 7:37 AM, Timothy Arceri wrote: >> >> >> On 21 January 2016 11:30:21 pm AEDT, Timothy Arceri >> wrote: >>> >>> >>>On 21 January 2016 11:17:06 pm

Re: [Mesa-dev] [PATCH] glsl: always compute proper varying type, irrespective of varying packing

On Thu, Jan 21, 2016 at 7:37 AM, Timothy Arceri wrote: > > > On 21 January 2016 11:30:21 pm AEDT, Timothy Arceri > wrote: >> >> >>On 21 January 2016 11:17:06 pm AEDT, Ilia Mirkin >>wrote: >>>Normally there's a producer and

Re: [Mesa-dev] [Mesa-stable] New stable-branch 11.0 candidate pushed

On 19 January 2016 at 19:05, Oded Gabbay wrote: > On Tue, Jan 19, 2016 at 2:48 PM, Emil Velikov > wrote: >> >> Hello list, >> >> The candidate for the Mesa 11.0.9 is now available. Currently we have: >> - 22 queued >> - 20 nominated

Re: [Mesa-dev] [PATCH] glsl: always compute proper varying type, irrespective of varying packing

On 21 January 2016 11:17:06 pm AEDT, Ilia Mirkin wrote: >Normally there's a producer and consumer, and the producer var gets >picked. In both the vertex->gs and tes->gs cases, that's the un-arrayed >version. > >In the SSO case, however, there is no producer. So we picked

Re: [Mesa-dev] [PATCH v4] mesa: enable enums for OES_geometry_shader

> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Thursday, January 21, 2016 1:25 PM > To: Marta Lofstedt > Cc: mesa-dev@lists.freedesktop.org; Lofstedt, Marta > Subject: Re: [PATCH v4] mesa: enable enums for OES_geometry_shader

Re: [Mesa-dev] [PATCH v4] mesa: enable enums for OES_geometry_shader

On Thu, Jan 21, 2016 at 8:28 AM, Lofstedt, Marta wrote: > > >> -Original Message- >> From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia >> Mirkin >> Sent: Thursday, January 21, 2016 2:03 PM >> To: Lofstedt, Marta >> Cc: Marta Lofstedt;

Re: [Mesa-dev] [PATCH] glsl/lower_instructions: fix regression in dldexp_to_arith

Reviewed-by: Ilia Mirkin On Thu, Jan 21, 2016 at 4:46 AM, Iago Toral Quiroga wrote: > The commit b4e198f47f842 changed the offset and bits parameters of the > bitfield insert operation from scalars to vectors. However, the lowering > of ldexp on doubles

[Mesa-dev] [PATCH] glsl/lower_instructions: fix regression in dldexp_to_arith

The commit b4e198f47f842 changed the offset and bits parameters of the bitfield insert operation from scalars to vectors. However, the lowering of ldexp on doubles operates on each vector component and emits scalar code (since it has to deal with the lower and upper 32-bit chunks of each double

Re: [Mesa-dev] [PATCH 5/9] st/mesa: implement PBO upload for multiple layers

On Mon, Jan 18, 2016 at 11:22 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Use instancing to generate two triangles for each destination layer and use > a geometry shader to route the layer index. A better way is to disable the geometry

Re: [Mesa-dev] [PATCH v3 1.5/10] glsl: always initialize image_* fields, copy them on interface init

On Tue, 2016-01-19 at 01:50 -0500, Ilia Mirkin wrote: > Interfaces can have image properties set in case they are buffer > interfaces. Make sure not to lose this information. Looks good to me, Reviewed-by: Iago Toral Quiroga > Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH] i965: Implement a drirc workaround for broken dual color blending.

Reviewed-by: Marek Olšák So that's why Gallium wasn't affected. Both (loc = 1, index = 0) and (loc = 0, index = 1) map to COLOR[1] in Gallium. Marek On Thu, Jan 21, 2016 at 5:35 AM, Kenneth Graunke wrote: > OpenGL's dual color blending feature was

Re: [Mesa-dev] [PATCH v3 2/10] glsl: keep track of ssbo variable being accessed, add access params

On Tue, 2016-01-19 at 01:50 -0500, Ilia Mirkin wrote: > Currently any access params (coherent/volatile/restrict) are being lost > when lowering to the ssbo load/store intrinsics. Keep track of the > variable being used, and bake its access params in as the last arg of > the load/store intrinsics.

Re: [Mesa-dev] [PATCH] i965: Implement a drirc workaround for broken dual color blending.

On Wed, 2016-01-20 at 20:35 -0800, Kenneth Graunke wrote: > OpenGL's dual color blending feature was specified so that an > implementation could support both multiple render targets (MRT) and > dual source blending. Fragment shader outputs specify both "location" > (the render target number) and

Re: [Mesa-dev] About drm_hwcomposer (Was Re: About the PixelFormat mappings in drm_gralloc)

On Wed, Jan 20, 2016 at 8:49 PM, Chih-Wei Huang wrote: > CC to the android-x86 devel list so more developers can follow. > > 2016-01-21 6:19 GMT+08:00 Rob Clark : > > On Wed, Jan 20, 2016 at 4:59 PM, Rob Herring wrote: > >> Hi Sean,

Re: [Mesa-dev] [PATCH 2/4] mesa: enable enums for OES_geometry_shader

> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Thursday, January 21, 2016 4:24 PM > To: Marta Lofstedt > Cc: mesa-dev@lists.freedesktop.org; Lofstedt, Marta > Subject: Re: [PATCH 2/4] mesa: enable enums for OES_geometry_shader

Re: [Mesa-dev] [PATCH 2/4] mesa: enable enums for OES_geometry_shader

On Thu, Jan 21, 2016 at 10:17 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Enable GL_OES_geometry_shader enums for OpenGL ES 3.1. > > V4: EXTRA tokens updated according to comments from Ilia Mirkin. > > Signed-off-by: Marta

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

I've pushed this patch. Thanks, Andreas 2016-01-21 1:35 GMT+01:00 Jeremy Huddleston Sequoia : > Sorry, I thought I responded to this a while ago. > > Reviewed-by: Jeremy Huddleston Sequoia > Tested-by: Jeremy Huddleston Sequoia > >

Re: [Mesa-dev] [PATCH v4] mesa: enable enums for OES_geometry_shader

On Thu, Jan 21, 2016 at 9:14 AM, Lofstedt, Marta wrote: >> -Original Message- >> From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia >> Mirkin >> Sent: Thursday, January 21, 2016 2:32 PM >> To: Lofstedt, Marta >> Cc: Marta Lofstedt;

[Mesa-dev] [PATCH 4/4] mesa: Update _mesa_has_geometry_shaders

From: Marta Lofstedt Updates the _mesa_has_geometry_shaders function to also look for OpenGL ES 3.1 contexts that has OES_geometry_shader enabled. Reviewed-by: Matt Turner --- src/mesa/main/context.h | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH 3/3] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

Wow... did you actually run into that crash? On 20.01.2016 20:14, Jeremy Huddleston Sequoia wrote: Signed-off-by: Jeremy Huddleston Sequoia --- src/mesa/main/shaderapi.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 2/3] mesa: Fix format warnings

Patches 1 & 2 are Reviewed-by: Nicolai Hähnle On 20.01.2016 20:14, Jeremy Huddleston Sequoia wrote: main/shaderapi.c:1318:51: warning: format specifies type 'unsigned int' but the argument has type 'GLhandleARB' (aka 'unsigned long') [-Wformat]

[Mesa-dev] [Bug 93796] glGetActiveAtomicCounterBufferiv is broken

https://bugs.freedesktop.org/show_bug.cgi?id=93796 --- Comment #7 from Nicolas Koch --- Hey guys, thanks for the replies. I just triple checked my program and figured out I made a really big mistake somewhere else in the program (basically, the results of the openGL

[Mesa-dev] [PATCH 0/4] Resend of initial OES_geometry_shader patches

These patches have been previously reviewed, but after updating according to review comments, I want to give people some time to provide more feedback. I will push in 24 hours unless I hear otherwise. Marta Lofstedt (4): glapi: add GL_OES_geometry_shader extension mesa: enable enums for

[Mesa-dev] [PATCH 1/4] glapi: add GL_OES_geometry_shader extension

From: Marta Lofstedt Add xml definitions for the GL_OES_geometry_shader extension and expose the extension for OpenGL ES 3.1. Signed-off-by: Marta Lofstedt Reviewed-by: Ilia Mirkin ---

[Mesa-dev] [PATCH 3/4] glsl: add support for GL_OES_geometry_shader

From: Marta Lofstedt This adds glsl support of GL_OES_geometry_shader for OpenGL ES 3.1. Signed-off-by: Marta Lofstedt Reviewed-by: Ian Romanick --- src/glsl/builtin_variables.cpp | 25

[Mesa-dev] [PATCH 2/4] mesa: enable enums for OES_geometry_shader

From: Marta Lofstedt Enable GL_OES_geometry_shader enums for OpenGL ES 3.1. V4: EXTRA tokens updated according to comments from Ilia Mirkin. Signed-off-by: Marta Lofstedt Reviewed-by: Tapani Pälli ---

Re: [Mesa-dev] [PATCH v4] mesa: enable enums for OES_geometry_shader

> -Original Message- > From: ibmir...@gmail.com [mailto:ibmir...@gmail.com] On Behalf Of Ilia > Mirkin > Sent: Thursday, January 21, 2016 2:32 PM > To: Lofstedt, Marta > Cc: Marta Lofstedt; mesa-dev@lists.freedesktop.org > Subject: Re: [PATCH v4] mesa: enable enums for OES_geometry_shader

[Mesa-dev] [Bug 93796] glGetActiveAtomicCounterBufferiv is broken

https://bugs.freedesktop.org/show_bug.cgi?id=93796 Tapani Pälli changed: What|Removed |Added Status|NEEDINFO|RESOLVED

Re: [Mesa-dev] [PATCH 3/4] glsl: add support for GL_OES_geometry_shader

On Thu, Jan 21, 2016 at 10:17 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > This adds glsl support of GL_OES_geometry_shader for > OpenGL ES 3.1. > > Signed-off-by: Marta Lofstedt > Reviewed-by: Ian

Re: [Mesa-dev] [PATCH 4/4] mesa: Update _mesa_has_geometry_shaders

Reviewed-by: Ilia Mirkin On Thu, Jan 21, 2016 at 10:17 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Updates the _mesa_has_geometry_shaders function to also look > for OpenGL ES 3.1 contexts that has

Re: [Mesa-dev] [PATCH] r600g: don't leak driver const buffers

On 20.01.2016 18:52, Grazvydas Ignotas wrote: The buffers are referenced from r600_update_driver_const_buffers() -> r600_set_constant_buffer() -> u_upload_data(), but nothing ever releases the reference. Similar case with driver_consts. Found using valgrind. Signed-off-by: Grazvydas Ignotas

[Mesa-dev] [PATCH v2] glx: update to updated version of EXT_create_context_es2_profile

The EXT spec has been updated to: - logically combine the es2_profile and es_profile exts - allow any legal version to be requested dEQP tests request a specific ES version when using GLX, so this allows dEQP upstream to run against GLX with the appropriate X server patch (which had similar

Re: [Mesa-dev] [PATCH v2] glx: update to updated version of EXT_create_context_es2_profile

FWIW see https://bugs.freedesktop.org/show_bug.cgi?id=92869 http://cgit.freedesktop.org/~jrfonseca/mesa/commit/?h=es2_profile On 21/01/16 16:58, Ilia Mirkin wrote: The EXT spec has been updated to: - logically combine the es2_profile and es_profile exts - allow any legal version to be

Re: [Mesa-dev] [PATCH 23/28] glsl: add pack varying to resource list for vertex input / fragment output

On Wed, Jan 20, 2016 at 4:28 PM, Timothy Arceri wrote: > On Wed, 2016-01-20 at 15:38 -0800, Anuj Phogat wrote: >> On Wed, Jan 20, 2016 at 1:39 PM, Timothy Arceri >> wrote: >> > On Wed, 2016-01-20 at 10:06 -0800, Anuj Phogat wrote: >> >

Re: [Mesa-dev] [PATCH 3/3] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

> On Jan 21, 2016, at 07:51, Nicolai Hähnle wrote: > > Wow... did you actually run into that crash? No. I was just paying attention to compiler warnings ;) > > On 20.01.2016 20:14, Jeremy Huddleston Sequoia wrote: >> Signed-off-by: Jeremy Huddleston Sequoia

Re: [Mesa-dev] [PATCH] st/mesa: conditionally enable GL_NV_vdpau_interop

I wonder if something more robust is needed. Let's say a distro builds with vdpau and everything else enabled, but then ships the libraries separately... On Thu, Jan 21, 2016 at 11:05 AM, Christian König wrote: > From: Christian König > > Only

[Mesa-dev] [Bug 92687] Add support for ARB_internalformat_query2

https://bugs.freedesktop.org/show_bug.cgi?id=92687 --- Comment #4 from Eduardo Lima Mitev --- The series was sent to mesa-dev early this week, as RFC: http://lists.freedesktop.org/archives/mesa-dev/2016-January/105277.html -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH v2] glx: update to updated version of EXT_create_context_es2_profile

On Thu, Jan 21, 2016 at 12:10 PM, Jose Fonseca wrote: > FWIW see > > https://bugs.freedesktop.org/show_bug.cgi?id=92869 > http://cgit.freedesktop.org/~jrfonseca/mesa/commit/?h=es2_profile > Ah, I was unaware of your prior work. FWIW I also sent an X server patch, and

[Mesa-dev] [PATCH 2/2] r600,compute: Plug few memory leaks

v2: drop inline keyword drop radeon_llvm_dispose_kernel_module wrapper v3: move definitions to .c file use in radeonsi Signed-off-by: Jan Vesely --- I'd like to keep r600_destroy_shader, even if it's just on line. I have additional patches that might add more

[Mesa-dev] [PATCH 1/2] r600: Typos and whitespace fixes

Signed-off-by: Jan Vesely --- Just some random stuff to make vim scream less src/gallium/drivers/r600/evergreen_compute.c | 6 +++--- src/gallium/drivers/r600/evergreen_state.c | 4 ++-- src/gallium/drivers/r600/r600_asm.h | 4 ++-- 3 files changed, 7

Re: [Mesa-dev] [PATCH 3/3] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

On 21.01.2016 11:34, Jeremy Huddleston Sequoia wrote: On Jan 21, 2016, at 07:51, Nicolai Hähnle wrote: Wow... did you actually run into that crash? No. I was just paying attention to compiler warnings ;) I'm glad someone does ;) On 20.01.2016 20:14, Jeremy

[Mesa-dev] [PATCH] radeonsi: Add option for SI scheduler

Add a debug option to select the LLVM SI Machine Scheduler. R600_DEBUG=sisched Signed-off-by: Axel Davy --- The corresponding llvm patch is on llvm master, and should land soon for 3.8 branch src/gallium/drivers/radeon/r600_pipe_common.c | 1 +

[Mesa-dev] [Bug 93813] Incorrect viewport range when GL_CLIP_ORIGIN is GL_UPPER_LEFT

https://bugs.freedesktop.org/show_bug.cgi?id=93813 Bug ID: 93813 Summary: Incorrect viewport range when GL_CLIP_ORIGIN is GL_UPPER_LEFT Product: Mesa Version: 10.6 Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH 5/4] mesa: Refactor error checking for GL_TEXTURE_BASE_LEVEL vs texture targets

On 01/20/2016 08:29 PM, Jason Ekstrand wrote: > > On Jan 20, 2016 6:20 PM, "Ian Romanick" > wrote: >> >> From: Ian Romanick > >> >> Add a big spec quotation justifying the error

[Mesa-dev] [Bug 93813] Incorrect viewport range when GL_CLIP_ORIGIN is GL_UPPER_LEFT

https://bugs.freedesktop.org/show_bug.cgi?id=93813 --- Comment #1 from Ilia Mirkin --- Without trying to determine whether mesa or your test right, this "fixes" your test: diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c index 7d891429..2881a75 100644 ---

Re: [Mesa-dev] [PATCH v2] glx: update to updated version of EXT_create_context_es2_profile

On Thu, Jan 21, 2016 at 1:43 PM, Ian Romanick wrote: > On 01/21/2016 09:10 AM, Jose Fonseca wrote: >> FWIW see >> >> https://bugs.freedesktop.org/show_bug.cgi?id=92869 >> http://cgit.freedesktop.org/~jrfonseca/mesa/commit/?h=es2_profile >> >> On 21/01/16 16:58, Ilia

Re: [Mesa-dev] [PATCH] radeonsi: Add option for SI scheduler

Reviewed-by: Edward O'Callaghan On 2016-01-22 04:35, Axel Davy wrote: Add a debug option to select the LLVM SI Machine Scheduler. R600_DEBUG=sisched Signed-off-by: Axel Davy --- The corresponding llvm patch is on llvm master, and should land

[Mesa-dev] [Bug 93003] mesa 11.x with vmwgfx (vmware Fusion 8.x) graphical corruption under gnome-shell on GTK applications.

https://bugs.freedesktop.org/show_bug.cgi?id=93003 Sinclair Yeh changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[Mesa-dev] [Bug 93813] Incorrect viewport range when GL_CLIP_ORIGIN is GL_UPPER_LEFT

https://bugs.freedesktop.org/show_bug.cgi?id=93813 --- Comment #2 from Ilia Mirkin --- And FWIW this is what st/nine does (which uses the upper_left/zero-to-one convention): pvport.scale[0] = (float)vport->Width * 0.5f; pvport.scale[1] = (float)vport->Height *

Re: [Mesa-dev] [PATCH v2] glx: update to updated version of EXT_create_context_es2_profile

On 01/21/2016 09:10 AM, Jose Fonseca wrote: > FWIW see > > https://bugs.freedesktop.org/show_bug.cgi?id=92869 > http://cgit.freedesktop.org/~jrfonseca/mesa/commit/?h=es2_profile > > On 21/01/16 16:58, Ilia Mirkin wrote: >> The EXT spec has been updated to: >> - logically combine the

Re: [Mesa-dev] [PATCH 1/4] glapi: add GL_OES_geometry_shader extension

This patch is Reviewed-by: Ian Romanick On 01/21/2016 07:17 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Add xml definitions for the GL_OES_geometry_shader extension > and expose the extension for OpenGL ES 3.1. > > Signed-off-by:

Re: [Mesa-dev] [PATCH] i965: Implement a drirc workaround for broken dual color blending.

On 01/20/2016 08:35 PM, Kenneth Graunke wrote: > OpenGL's dual color blending feature was specified so that an > implementation could support both multiple render targets (MRT) and > dual source blending. Fragment shader outputs specify both "location" > (the render target number) and "index"

Re: [Mesa-dev] [PATCH 4/4] mesa: Update _mesa_has_geometry_shaders

On 01/21/2016 07:17 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Updates the _mesa_has_geometry_shaders function to also look > for OpenGL ES 3.1 contexts that has OES_geometry_shader enabled. Blank line here. :) > Reviewed-by: Matt Turner

[Mesa-dev] [PATCH v2 9/9] gallium/radeon: support PIPE_CAP_SURFACE_REINTERPRET_BLOCKS

From: Nicolai Hähnle This is already used internally in si_resource_copy_region for compressed textures, so the only real change here is the adjusted surface size computation. Reviewed-by: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c

[Mesa-dev] [PATCH 6/6] nir: use const_index helpers

From: Rob Clark Signed-off-by: Rob Clark --- src/glsl/nir/nir_builder.h | 2 +- src/glsl/nir/nir_lower_atomics.c | 4 ++-- src/glsl/nir/nir_lower_clip.c| 8 src/glsl/nir/nir_lower_gs_intrinsics.c

Re: [Mesa-dev] [PATCH v2] glx: update to updated version of EXT_create_context_es2_profile

On 21/01/16 18:43, Ian Romanick wrote: On 01/21/2016 09:10 AM, Jose Fonseca wrote: FWIW see https://bugs.freedesktop.org/show_bug.cgi?id=92869 http://cgit.freedesktop.org/~jrfonseca/mesa/commit/?h=es2_profile On 21/01/16 16:58, Ilia Mirkin wrote: The EXT spec has been updated to: -

Re: [Mesa-dev] [PATCH v2] glx: update to updated version of EXT_create_context_es2_profile

On 21/01/16 17:35, Ilia Mirkin wrote: On Thu, Jan 21, 2016 at 12:10 PM, Jose Fonseca wrote: FWIW see https://bugs.freedesktop.org/show_bug.cgi?id=92869 http://cgit.freedesktop.org/~jrfonseca/mesa/commit/?h=es2_profile Ah, I was unaware of your prior work. FWIW I

Re: [Mesa-dev] [PATCH 5/4] mesa: Refactor error checking for GL_TEXTURE_BASE_LEVEL vs texture targets

On Jan 21, 2016 10:30 AM, "Ian Romanick" wrote: > > On 01/20/2016 08:29 PM, Jason Ekstrand wrote: > > > > On Jan 20, 2016 6:20 PM, "Ian Romanick" > > wrote: > >> > >> From: Ian Romanick >

Re: [Mesa-dev] [PATCH 0/3] Misc GLhandleARB GLuint cleanup

On 20.01.2016 20:21, Jeremy Huddleston Sequoia wrote: This series includes 3 changes related to help reconcile the differences in declaration between Apple's vs Mesa's GLhandleARB type. The first, I expect to be mostly uncontroversial as they are mainly cleaning up and correcting some

[Mesa-dev] [PATCH] st/mesa: conditionally enable GL_NV_vdpau_interop

From: Christian König Only enable it when we compile the state tracker as well. Signed-off-by: Christian König --- configure.ac | 1 + src/mesa/state_tracker/st_extensions.c | 2 ++ src/mesa/state_tracker/st_vdpau.c

Re: [Mesa-dev] [PATCH 3/3] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

On Wed, Jan 20, 2016 at 5:14 PM, Jeremy Huddleston Sequoia wrote: > Signed-off-by: Jeremy Huddleston Sequoia > --- > src/mesa/main/shaderapi.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH] i965/vec4/tcs: Return NULL instead of false in brw_compile_tcs()

brw_compile_tcs() is expected to return 'const unsigned *', so the compiler complains. --- src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp b/src/mesa/drivers/dri/i965/brw_vec4_tcs.cpp index

[Mesa-dev] [PATCH v2] mesa: Deal with size differences between GLuint and GLhandleARB in GetAttachedObjectsARB

Signed-off-by: Jeremy Huddleston Sequoia CC: Nicolai Hähnle CC: Matt Turner --- src/mesa/main/shaderapi.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c

Re: [Mesa-dev] [PATCH 23/28] glsl: add pack varying to resource list for vertex input / fragment output

On Thu, Jan 21, 2016 at 1:47 PM, Timothy Arceri wrote: > On Thu, 2016-01-21 at 09:23 -0800, Anuj Phogat wrote: >> On Wed, Jan 20, 2016 at 4:28 PM, Timothy Arceri >> wrote: >> > On Wed, 2016-01-20 at 15:38 -0800, Anuj Phogat wrote: >> >

Re: [Mesa-dev] [PATCH 23/28] glsl: add pack varying to resource list for vertex input / fragment output

On Thu, 2016-01-21 at 15:28 -0800, Anuj Phogat wrote: > On Thu, Jan 21, 2016 at 1:47 PM, Timothy Arceri > wrote: > > On Thu, 2016-01-21 at 09:23 -0800, Anuj Phogat wrote: > > > On Wed, Jan 20, 2016 at 4:28 PM, Timothy Arceri > > >

Re: [Mesa-dev] [PATCH 23/28] glsl: add pack varying to resource list for vertex input / fragment output

On Thu, 2016-01-21 at 09:23 -0800, Anuj Phogat wrote: > On Wed, Jan 20, 2016 at 4:28 PM, Timothy Arceri > wrote: > > On Wed, 2016-01-20 at 15:38 -0800, Anuj Phogat wrote: > > > On Wed, Jan 20, 2016 at 1:39 PM, Timothy Arceri > > >

Re: [Mesa-dev] [PATCH v2 0/9] st/mesa: accelerate texture uploads from PBOs

To the best of my understanding, this series is now: Reviewed-by: Edward O'Callaghan On 2016-01-22 06:37, Nicolai Hähnle wrote: Hi everybody, here's an updated version of the series. I decided to keep BUFFER_SAMPLER_VIEW_RGBA_ONLY as is, following Fredrik's

Re: [Mesa-dev] [PATCH] radeonsi: Add option for SI scheduler

On 21.01.2016 12:35, Axel Davy wrote: Add a debug option to select the LLVM SI Machine Scheduler. R600_DEBUG=sisched Signed-off-by: Axel Davy --- The corresponding llvm patch is on llvm master, and should land soon for 3.8 branch I'd like to wait with pushing this until it

Re: [Mesa-dev] [PATCH 1/2] r600: Typos and whitespace fixes

On 21.01.2016 11:17, Jan Vesely wrote: Signed-off-by: Jan Vesely --- Just some random stuff to make vim scream less src/gallium/drivers/r600/evergreen_compute.c | 6 +++--- src/gallium/drivers/r600/evergreen_state.c | 4 ++-- src/gallium/drivers/r600/r600_asm.h

[Mesa-dev] [PATCH] glsl: Disable tree grafting optimization for shared variables

Fixes: dEQP-GLES31.functional.compute.basic.shared_atomic_op_multiple_groups From: https://android.googlesource.com/platform/external/deqp Reported-by: Ilia Mirkin Signed-off-by: Jordan Justen --- src/glsl/opt_tree_grafting.cpp | 11 ++-

[Mesa-dev] [PATCH] glsl: Enable debug prints for do_common_optimization

Signed-off-by: Jordan Justen --- src/glsl/glsl_parser_extras.cpp | 80 - 1 file changed, 48 insertions(+), 32 deletions(-) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index 1d74db5..85227bd

Re: [Mesa-dev] [PATCH] glsl: Enable debug prints for do_common_optimization

On Thu, 2016-01-21 at 16:45 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen Nice one. Reviewed-by: Timothy Arceri > --- > src/glsl/glsl_parser_extras.cpp | 80 --- > -- > 1 file changed,

[Mesa-dev] [PATCH 2/2] i965: Do channel expressions on significantly fewer opcodes.

nir_lower_alu_to_scalar() and nir_lower_load_const_to_scalar() handle most cases quite well. They also create nir_ssa_defs rather than ir_variables, which are much less memory intensive. This can mean losing out on a few GLSL IR optimizations, however. In most cases, this is fine. But a few

[Mesa-dev] [PATCH 1/2] i965: Use nir_lower_load_const_to_scalar().

I don't know why, but we never hooked up this pass Eric wrote. Otherwise, you can end up with stupid scalarized code such as: vec4 ssa_7 = load_const (0.0, 0.0, 0.0, 0.0) vec4 ssa_8 = ... vec1 ssa_9 = feq ssa_8, ssa_7 vec1 ssa_10 = feq ssa_8.y, ssa_7.y vec1 ssa_11 = feq ssa_8,

[Mesa-dev] [PATCH v2] glsl: Enable debug prints for do_common_optimization

Signed-off-by: Jordan Justen --- I tested a release build. I think v1 produced comparable code to before the patch, but it was a bit larger. I found that this v2 code would produce identical code to our current code for release builds. Timothy, should I add your

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On 01/20/2016 09:21 PM, Ian Romanick wrote: So... I'm just going to say that this is commit is the new poster child for not committing something as soon as you get a positive review. This patch went out barely 36 hours ago, and there is already a fix-up patch for it. I have also found two

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On 01/20/2016 06:37 PM, Ilia Mirkin wrote: On Wed, Jan 20, 2016 at 6:35 AM, Tapani Pälli wrote: On 01/20/2016 01:11 PM, Ilia Mirkin wrote: On Wed, Jan 20, 2016 at 6:02 AM, Tapani Pälli wrote: Unfortunately putting such a shader together is

Re: [Mesa-dev] [PATCH] glsl: Disable tree grafting optimization for shared variables

Hi Jordan, Thanks for the patch, it also fixes the following dEQP tests (which are related to the multiple groups one): dEQP-GLES31.functional.compute.basic.shared_atomic_op_multiple_invocation dEQP-GLES31.functional.compute.basic.shared_atomic_op_single_group

[Mesa-dev] [PATCH] util/ralloc: Remove double zero'ing of rzalloc buffers

Juha-Pekka found this back in May 2015: <1430915727-28677-1-git-send-email-juhapekka.heikk...@gmail.com> From the discussion, obviously it would be preferable to make ralloc_size no longer return zeroed memory, but Juha-Pekka found that it would break Mesa. For now, let's point out the flaw, and

Re: [Mesa-dev] [PATCH 1/2] texobj: Fix the completeness checks for cube textures

Series is Reviewed-by: Ian Romanick On 01/21/2016 11:02 AM, Neil Roberts wrote: > According to the GL 1.4 spec section 3.8.10, a cubemap texture is only > complete if: > > • The level base arrays of each of the six texture images making up > the cube map have

[Mesa-dev] [PATCH v2 4/9] st/mesa: Accelerate PBO uploads

From: Fredrik Höglund Create a PIPE_BUFFER sampler view on the pixel-unpack buffer, and draw the image on the texture with a fragment shader that maps fragment coordinates to buffer coordinates. Modifications by Nicolai Hähnle: - various cleanups and fixes (e.g. error handling,

[Mesa-dev] [PATCH v2 5/9] st/mesa: implement PBO upload for multiple layers

From: Nicolai Hähnle Use instancing to generate two triangles for each destination layer and use a geometry shader to route the layer index. v2: - directly write layer in VS if supported by the driver (Marek Olšák) --- src/mesa/state_tracker/st_cb_texture.c | 159

[Mesa-dev] [PATCH v2 7/9] st/mesa: redirect CompressedTexSubImage to our own implementation

From: Nicolai Hähnle This is where PBO upload will go. --- src/mesa/state_tracker/st_cb_texture.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c

[Mesa-dev] [PATCH v2 3/9] st/mesa: use the correct address generation functions in st_TexSubImage blit

From: Nicolai Hähnle We need to tell the address generation functions about the dimensionality of the texture to correctly implement the part of Section 3.8.1 (Texture Image Specification) of the OpenGL 2.1 specification which says: "For the purposes of decoding the

[Mesa-dev] [PATCH v2 8/9] st/mesa: implement PBO upload for glCompressedTex(Sub)Image

From: Nicolai Hähnle v2: - use st->pbo_upload.enabled flag --- src/mesa/state_tracker/st_cb_texture.c | 115 + 1 file changed, 115 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c

[Mesa-dev] [PATCH v2 1/9] gallium: Add PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY

From: Nicolai Hähnle This cap indicates that the driver only supports R, RG, RGB and RGBA formats for PIPE_BUFFER sampler views. v2: move into "unsupported features" section for nouveau (Ilia Mirkin) --- src/gallium/docs/source/screen.rst | 4

[Mesa-dev] [PATCH v2 0/9] st/mesa: accelerate texture uploads from PBOs

Hi everybody, here's an updated version of the series. I decided to keep BUFFER_SAMPLER_VIEW_RGBA_ONLY as is, following Fredrik's point that it affects not only the sampler swizzle but also the texture format itself. The major functionality changes are that we now try to fulfill larger

Re: [Mesa-dev] [PATCH] st/mesa: conditionally enable GL_NV_vdpau_interop

Advertising NV_vdpau_interop while the backend for the driver isn't installed is fine, cause this only means that the OpenGL side has support for it. Mesa doesn't have a runtime dependency on libvdpau and to initialize NV_vdpau_interop the application must open libvdpau first. So if

[Mesa-dev] [PATCH 1/2] texobj: Fix the completeness checks for cube textures

According to the GL 1.4 spec section 3.8.10, a cubemap texture is only complete if: • The level base arrays of each of the six texture images making up the cube map have identical, positive, and square dimensions. • The level base arrays were each specified with the same internal format. •

  1   2   >