[Mesa-dev] [PATCH] i965: Fix src0 vs src1 typo

2017-10-02 Thread Matt Turner
A typo caused us to copy src0's reg file to src1 rather than reading src1's as intended. This caused us to fail to compact instructions like mov(8) g4<1>D0D { align1 1Q }; because src1 was set to immediate rather than architecture file. Fixing this reenables compaction

Re: [Mesa-dev] [PATCH] intel: Always set Cube Face Enables for all surfaces.

2017-10-02 Thread Matt Turner
Looks good to me. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] i965 : optimized bucket index calculation

2017-10-02 Thread Muthukumar, Aravindan
Hi Reviewers, Please review and provide the comments on the second version of the patch. Thanks, Aravindan > -Original Message- > From: Marathe, Yogesh > Sent: Friday, September 22, 2017 8:41 AM > To: Ekstrand, Jason ; Palli, Tapani >

Re: [Mesa-dev] Using --enable-opencl-icd by default and deprecating the toggle

2017-10-02 Thread Jan Vesely
On Fri, 2017-09-29 at 16:14 +0100, Emil Velikov wrote: > Hi all, > > Currently nearly all the distributions I've seen* enable and use the ICD. > Only Gentoo does not use it, but manages the OpenCL.so conflicts via eselect. to be fair, you can install and eselect ocl-icd. eselect switches

Re: [Mesa-dev] [PATCH 4/4] i965/gen10: Implement Wa3DStateMode

2017-10-02 Thread Jason Ekstrand
On Mon, Oct 2, 2017 at 4:08 PM, Anuj Phogat wrote: > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/brw_state_upload.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-10-02 Thread Jason Ekstrand
On Mon, Oct 2, 2017 at 4:07 PM, Anuj Phogat wrote: > WaFlushHangWhenNonPipelineStateAndMarkerStalled goes along > with WaSampleOffsetIZ. Both recommends the same. > > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Anuj Phogat > --- >

[Mesa-dev] [PATCH 6/6] tgsi/scan: scan address operands (v2)

2017-10-02 Thread Marek Olšák
From: Marek Olšák v2: set swizzled usage mask --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 43 +- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c

[Mesa-dev] [PATCH 4/6] tgsi/scan: take advantage of already swizzled usage mask in scan_src_operand

2017-10-02 Thread Marek Olšák
From: Marek Olšák It has always been a usage mask *after* swizzling. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 47 -- 1 file changed, 17 insertions(+), 30 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c

[Mesa-dev] [PATCH 2/6] tgsi: implement tgsi_util_get_inst_usage_mask properly

2017-10-02 Thread Marek Olšák
From: Marek Olšák All opcodes are handled. --- src/gallium/auxiliary/tgsi/tgsi_util.c| 307 ++ src/gallium/auxiliary/tgsi/tgsi_util.h| 12 + src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 11 - 3 files changed, 206

[Mesa-dev] [PATCH 5/6] tgsi/scan: set correct usage mask for tex offsets in scan_src_operand

2017-10-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index ee9a261..1f8904c 100644 ---

[Mesa-dev] [PATCH 3/6] tgsi/scan: set non-valid src_index for tex offsets in scan_src_operand

2017-10-02 Thread Marek Olšák
From: Marek Olšák tex offsets are not "Src" operands. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 212d1bb..6f87f8d

[Mesa-dev] [PATCH 1/6] tgsi: add docs for some existing pack opcodes

2017-10-02 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/tgsi.rst | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index 551e9dd..1a51fe9 100644 ---

[Mesa-dev] [PATCH] wayland-egl: redistribute wayland.egl.h include

2017-10-02 Thread Tobias Klausmann
Starting with commit ab0589c6ed ("wayland-egl: remove no longer needed wayland-client dependency") the wayland-egl.h include was missing leading to a build failure: CC wayland-egl.lo wayland-egl.c:33:10: fatal error: wayland-egl.h: Datei oder Verzeichnis nicht gefunden #include

Re: [Mesa-dev] [PATCH 1/2] anv: Fix vkCmdFillBuffer()

2017-10-02 Thread Lionel Landwerlin
Thanks, I modified the CTS slightly to reproduce the problem (will try to send it upstream). Reviewed-by: Lionel Landwerlin On 02/10/17 20:41, Józef Kucia wrote: On Mon, Oct 2, 2017 at 9:19 PM, Lionel Landwerlin wrote: I guess

Re: [Mesa-dev] [PATCH 0/4] i965: ARB_indirect_parameters

2017-10-02 Thread Kenneth Graunke
On Monday, October 2, 2017 1:58:23 PM PDT Plamena Manolova wrote: > A series of patches introducing ARB_indirect_parameters > for i965. We can implement ARB_indirect_parameters for i965 > by taking advantage of the conditional rendering mechanism. > This works by issuing maxdrawcount draw calls

[Mesa-dev] [Bug 103018] Add account for Rhys Kidd

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103018 Kenneth Graunke changed: What|Removed |Added Component|Other |New Accounts

[Mesa-dev] [PATCH 2/4] i965/gen10: Implement WaForceRCPFEHangWorkaround

2017-10-02 Thread Anuj Phogat
Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_pipe_control.c

[Mesa-dev] [PATCH 4/4] i965/gen10: Implement Wa3DStateMode

2017-10-02 Thread Anuj Phogat
Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_state_upload.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c

[Mesa-dev] [PATCH 3/4] i965/gen10: Enable float blend optimization

2017-10-02 Thread Anuj Phogat
This optimization is enabled for previous generations too. See Mesa commit c17e214a6b On CNL this bit is moved to 3DSTATE_3D_MODE. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_defines.h | 3 +++

[Mesa-dev] [PATCH 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-10-02 Thread Anuj Phogat
WaFlushHangWhenNonPipelineStateAndMarkerStalled goes along with WaSampleOffsetIZ. Both recommends the same. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/brw_context.h| 2 +

[Mesa-dev] [PATCH] intel: Always set Cube Face Enables for all surfaces.

2017-10-02 Thread Kenneth Graunke
These shouldn't matter for non-cubes, and we always enable them all for cubes, so we may as well set them all the time. While we're at it, let's make the genxml fields consistent. We pick the boolean-per-face approach because it's clear which bits correspond to which cube faces. v2: Don't use

[Mesa-dev] [PATCH] util: include stdlib.h in u_string.h to silence MinGW warning

2017-10-02 Thread Brian Paul
Otherwise we don't get a prototype for malloc(). --- src/util/u_string.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/u_string.h b/src/util/u_string.h index 48f1125..5a2a3e9 100644 --- a/src/util/u_string.h +++ b/src/util/u_string.h @@ -38,6 +38,7 @@ #if !defined(XF86_LIBC_H)

[Mesa-dev] [Bug 102597] [Regression] mpv, high rendering times (two to three times higher)

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102597 --- Comment #9 from Niklas Haas --- > Thousands of mpv users rely on mesa's now incorrect behaviour to diagnose > performance issues. Well, to be fair, that's going to end up being misleading one way or the other -

[Mesa-dev] [PATCH 2/2] egl/surfaceless: Use KMS swrast fallback

2017-10-02 Thread gurchetansi...@chromium.org
From: Gurchetan Singh The kms_swrast extension is an actively developed software fallback, and platform_surfaceless can use it if there are no available hardware drivers. v2: Split into 2 patches, use booleans, check LIBGL_ALWAYS_SOFTWARE, and modify the eglLog

[Mesa-dev] [PATCH 1/2] egl/surfaceless: add probe device helper function

2017-10-02 Thread gurchetansi...@chromium.org
From: Gurchetan Singh This will help us initialize a software driver, if it's needed or requested. --- src/egl/drivers/dri2/platform_surfaceless.c | 67 + 1 file changed, 39 insertions(+), 28 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2 2/2] etnaviv: Set up unknown GC3000 states

2017-10-02 Thread Christian Gmeiner
2017-10-01 16:23 GMT+02:00 Wladimir J. van der Laan : > Set up new states that the blob started setting for GC3000 consistently. > > This makes sure that when another test or driver leaves the GPU in > unpredictable state, these states are set up correctly for our > rendering. >

Re: [Mesa-dev] [PATCH v2 1/2] etnaviv: Fix point sprite rendering on GC3000

2017-10-02 Thread Christian Gmeiner
2017-10-01 16:23 GMT+02:00 Wladimir J. van der Laan : > Setting PA_VIEWPORT_UNK state correctly is necessary to make point sprite > rendering on GC3000 work. > > Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner

Re: [Mesa-dev] [PATCH 1/2] anv: Fix vkCmdFillBuffer()

2017-10-02 Thread Józef Kucia
On Mon, Oct 2, 2017 at 9:19 PM, Lionel Landwerlin wrote: > I guess it makes things clearer. > Does this fix something? Yes, it fixes buffer fills. After the change buffers are filled with uint32_t values instead of uint8_t or uint16_t values. Before the change,

Re: [Mesa-dev] [PATCH 3/3] nv50, nvc0/ir: Display shared memory usage in pipe_debug_message

2017-10-02 Thread Ilia Mirkin
Looks like this will upset my parser which is the only consumer of this info: https://cgit.freedesktop.org/mesa/shader-db/tree/nv-report.py Should be doable to rewrite it to not care about order. Or stick your new thing at the end. Either way. On Mon, Oct 2, 2017 at 2:57 PM, Pierre Moreau

Re: [Mesa-dev] [PATCH 1/2] anv: Fix vkCmdFillBuffer()

2017-10-02 Thread Lionel Landwerlin
I guess it makes things clearer. Does this fix something? On 02/10/17 18:58, Józef Kucia wrote: The vkCmdFillBuffer() command fills a buffer with an uint32_t value. --- src/intel/vulkan/anv_blorp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] anv: Remove unreachable cases from isl_format_for_size()

2017-10-02 Thread Lionel Landwerlin
Make sense, if you could just update the comment in the unreachable(), should be multiple of 4. With that changed : Reviewed-by: Lionel Landwerlin

[Mesa-dev] [PATCH 3/3] nv50, nvc0/ir: Display shared memory usage in pipe_debug_message

2017-10-02 Thread Pierre Moreau
Signed-off-by: Pierre Moreau --- src/gallium/drivers/nouveau/nv50/nv50_program.c | 7 --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_program.c

[Mesa-dev] [PATCH 1/3] nv50/ir: Store shared memory per block in nv50_ir_prog_info

2017-10-02 Thread Pierre Moreau
Signed-off-by: Pierre Moreau --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h b/src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h index

[Mesa-dev] [PATCH 2/3] nv50, nvc0/ir: Copy shared memory per block to the program info structure and back

2017-10-02 Thread Pierre Moreau
In OpenCL/CUDA kernels, shared memory usage can be defined within the kernel code. Those usage will only be picked up while parsing the SPIR-V, during the translation phase of the program. Signed-off-by: Pierre Moreau --- src/gallium/drivers/nouveau/nv50/nv50_program.c |

Re: [Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Roland Scheidegger
Am 02.10.2017 um 19:36 schrieb Emil Velikov: > On 2 October 2017 at 18:15, Matt Turner wrote: >> On Mon, Oct 2, 2017 at 6:17 AM, Emil Velikov >> wrote: >>> On 2 October 2017 at 07:59, Matt Turner wrote: >>> +#include

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-02 Thread Daniel Stone
On 2 October 2017 at 18:34, Daniel Stone wrote: > Marek, Michel, any ideas? Looks like the winsys buffers we create lose > all their tiling information between client and KMS. You can test it > just by running 'weston-simple-egl -f', with whatever version of > Weston, and

[Mesa-dev] [PATCH 2/2] anv: Remove unreachable cases from isl_format_for_size()

2017-10-02 Thread Józef Kucia
The dstOffset and fillSize parameters must be multiple of 4. --- src/intel/vulkan/anv_blorp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index a8ebdb384c..8dead1d87a 100644 --- a/src/intel/vulkan/anv_blorp.c +++

[Mesa-dev] [PATCH 1/2] anv: Fix vkCmdFillBuffer()

2017-10-02 Thread Józef Kucia
The vkCmdFillBuffer() command fills a buffer with an uint32_t value. --- src/intel/vulkan/anv_blorp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 8d0c275248..a8ebdb384c 100644 ---

Re: [Mesa-dev] [PATCH 10/12] intel/blorp: Handle clearing compressed surfaces

2017-10-02 Thread Jason Ekstrand
On Mon, Oct 2, 2017 at 10:49 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 29/09/17 04:23, Matt Turner wrote: > >> On Fri, Sep 15, 2017 at 9:01 AM, Jason Ekstrand >> wrote: >> >>> --- >>> src/intel/blorp/blorp_clear.c | 24 +--- >>>

Re: [Mesa-dev] [PATCH 10/12] intel/blorp: Handle clearing compressed surfaces

2017-10-02 Thread Lionel Landwerlin
On 29/09/17 04:23, Matt Turner wrote: On Fri, Sep 15, 2017 at 9:01 AM, Jason Ekstrand wrote: --- src/intel/blorp/blorp_clear.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/intel/blorp/blorp_clear.c

Re: [Mesa-dev] [PATCH 03/13] i965: Print subreg in units of type-size on ternary instructions

2017-10-02 Thread Matt Turner
On Fri, Sep 29, 2017 at 5:03 PM, Scott D Phillips wrote: > Matt Turner writes: > >> The instruction word contains SubRegNum[4:2] so it's in units of dwords >> (hence the * 4 to get it in terms of bytes). Before this patch, the >> subreg would have

Re: [Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 18:15, Matt Turner wrote: > On Mon, Oct 2, 2017 at 6:17 AM, Emil Velikov wrote: >> On 2 October 2017 at 07:59, Matt Turner wrote: >> >>> +#include "../../../mesa/main/texcompress_s3tc_tmp.h" >>> >> This feels

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-02 Thread Daniel Stone
Hi Andy, On 2 October 2017 at 17:51, Andy Furniss wrote: > These are still a regression for me over git revert a65db0ad1c > > weston-simple-egl works as does mpv opengl windowed. > > The issue is that kodi or fullscreen mpv is mostly junk, IIRC from an old > bug this is to

Re: [Mesa-dev] Add a travis job for meson vulkan

2017-10-02 Thread Eric Anholt
Dylan Baker writes: > This adds a job to travis to build the vulkan driver and run some driver > checks, > and fix building on travis (which uses a particularly old Ubuntu). This series is: Reviewed-by: Eric Anholt signature.asc Description: PGP

Re: [Mesa-dev] [PATCH 4/5] meson: convert gtest to an internal dependency

2017-10-02 Thread Dylan Baker
Quoting Dylan Baker (2017-10-02 09:45:05) > Quoting Eric Engestrom (2017-10-02 08:33:14) > > On Sunday, 2017-10-01 03:58:27 +, Dylan Baker wrote: > > > In truth gtest is an external dependency that upstream expects you to > > > "vendor" into your own tree. As such, it makes sense to treat it

Re: [Mesa-dev] [PATCH 01/11] radeonsi: use ac helpers for bitcasts

2017-10-02 Thread Marek Olšák
On Mon, Oct 2, 2017 at 4:02 PM, Marek Olšák wrote: > This reply of yours doesn't contain anything. (clipped message?) Nevermind. I've read your reply from the mesa-dev archive. Marek ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Matt Turner
On Mon, Oct 2, 2017 at 6:17 AM, Emil Velikov wrote: > On 2 October 2017 at 07:59, Matt Turner wrote: > >> +#include "../../../mesa/main/texcompress_s3tc_tmp.h" >> > This feels a bit dirty. If people are not too keen on the idea, > another approach is

Re: [Mesa-dev] [PATCH 06/15] mesa: Call DXTn functions directly

2017-10-02 Thread Matt Turner
On Mon, Oct 2, 2017 at 4:23 AM, Nicolai Hähnle wrote: > On 02.10.2017 08:59, Matt Turner wrote: >> >> --- >> src/mesa/main/texcompress_s3tc.c | 117 >> +-- >> 1 file changed, 25 insertions(+), 92 deletions(-) >> >> diff --git

[Mesa-dev] [PATCH] travis: add meson build for vulkan drivers.

2017-10-02 Thread Dylan Baker
v2: - use -isystem`pwd` instead of cp to include fake linux header (Eric, Emil) Signed-off-by: Dylan Baker --- .travis.yml | 36 1 file changed, 36 insertions(+) diff --git a/.travis.yml b/.travis.yml index d9a8bf5a9d4..ca766917f25

Re: [Mesa-dev] [PATCH 05/15] mesa: Remove fprintf referring to libdxtn

2017-10-02 Thread Matt Turner
On Mon, Oct 2, 2017 at 4:20 AM, Nicolai Hähnle wrote: > On 02.10.2017 08:59, Matt Turner wrote: >> >> When this file is included by Gallium, the fprintf causes it to fail to >> compile. This is an unreachable error case, and we shouldn't be calling >> fprintf directly. >> ---

[Mesa-dev] [Bug 101832] [PATCH][regression][bisect] Xorg fails to start after f50aa21456d82c8cb6fbaa565835f1acc1720a5d

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101832 Laurent carlier changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [Bug 102847] swr fail to build with llvm-5.0.0

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102847 Laurent carlier changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [OS]Mesa MinGW AppVeyor Repository

2017-10-02 Thread Eric Engestrom
On Monday, 2017-10-02 14:16:02 +, Trevor (CIMdata) wrote: > Hello Emil, > Yes, I did see the AppVeyor integraton for MSVC. It could be quite > easy to add the MinGW scope to the metrix. > > I don’t really know how to ‘upsteam’ the patches I use mostly because > I am not the author. Do I just

Re: [Mesa-dev] [PATCH v2 2/3] vulkan/wsi: Report the correct min/maxImageCount

2017-10-02 Thread Neil Roberts
Jason Ekstrand writes: > I wish... Unfortunately, the spec says: > > Let *n* be the total number of images in the swapchain, *m* be the > value of VkSurfaceCapabilitiesKHR::minImageCount, and *a* be the > number of presentable images that the application has currently >

Re: [Mesa-dev] [PATCH 3/3] st/va: add RGB support to vlVaPutSurface

2017-10-02 Thread Andy Furniss
Tested-by: Andy Furniss Leo Liu wrote: --- src/gallium/state_trackers/va/surface.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_trackers/va/surface.c index

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-02 Thread Andy Furniss
These are still a regression for me over git revert a65db0ad1c weston-simple-egl works as does mpv opengl windowed. The issue is that kodi or fullscreen mpv is mostly junk, IIRC from an old bug this is to do with direct scan out and tiling. Daniel Stone wrote: When creating a wl_buffer from

Re: [Mesa-dev] [PATCH 5/5] travis: add meson build for vulkan drivers.

2017-10-02 Thread Dylan Baker
Quoting Emil Velikov (2017-10-02 09:13:49) > On 2 October 2017 at 16:51, Eric Engestrom wrote: > > On Sunday, 2017-10-01 03:58:28 +, Dylan Baker wrote: > >> Signed-off-by: Dylan Baker > >> --- > >> .travis.yml | 36

Re: [Mesa-dev] [PATCH] radv: make radv_dynamic_state_copy() static

2017-10-02 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On 2 Oct 2017 12:26, "Samuel Pitoiset" wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 +- > src/amd/vulkan/radv_private.h| 4 > 2

Re: [Mesa-dev] [PATCH 4/5] meson: convert gtest to an internal dependency

2017-10-02 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-02 08:33:14) > On Sunday, 2017-10-01 03:58:27 +, Dylan Baker wrote: > > In truth gtest is an external dependency that upstream expects you to > > "vendor" into your own tree. As such, it makes sense to treat it more > > like a dependency than an internal

Re: [Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Nicolai Hähnle
On 02.10.2017 15:17, Emil Velikov wrote: On 2 October 2017 at 07:59, Matt Turner wrote: +#include "../../../mesa/main/texcompress_s3tc_tmp.h" This feels a bit dirty. If people are not too keen on the idea, another approach is to have the code in src/util/ I like that

[Mesa-dev] [PATCH v2 2/2] egl/wayland: Don't use dmabuf with no modifiers

2017-10-02 Thread Daniel Stone
The dmabuf interface requires a valid modifier to be sent. If we don't explicitly get a modifier from the driver, we can't know what to send; it must be inferred from legacy side-channels (or assumed to linear, if none exists). If we have no modifier, then we can only have a single-plane format

[Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-02 Thread Daniel Stone
When creating a wl_buffer from a DRIImage, we extract all the DRIImage information via queryImage. Check whether or not it actually succeeds, either bailing out if the query was critical, or providing sensible fallbacks for information which was not available in older DRIImage versions. Fixes:

Re: [Mesa-dev] [PATCH v2] meson: change vulkan icd config to - instead of _

2017-10-02 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-02 02:49:51) > On Saturday, 2017-09-30 01:00:56 +, Dylan Baker wrote: > > Just to be consistent. > > > > v2: - update meson.build too > > > > Signed-off-by: Dylan Baker > > --- > > meson.build | 2 +- > > meson_options.txt | 4

[Mesa-dev] [ANNOUNCE] mesa 17.2.2

2017-10-02 Thread Juan A. Suarez Romero
Mesa 17.2.2 is now available. In this release we have: In build and integration system, we add a dependency on libunwind when running make distcheck, as this is optional for libgallium but we want to catch any problem. As consequence, also force LLVM 3.3 in Travis when building Gallium ST Other,

Re: [Mesa-dev] [PATCH 5/5] travis: add meson build for vulkan drivers.

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 16:51, Eric Engestrom wrote: > On Sunday, 2017-10-01 03:58:28 +, Dylan Baker wrote: >> Signed-off-by: Dylan Baker >> --- >> .travis.yml | 36 >> 1 file changed, 36 insertions(+) >>

Re: [Mesa-dev] [PATCH] egl/wayland: Don't use dmabuf with no modifiers

2017-10-02 Thread Daniel Stone
Hey Emil, On 2 October 2017 at 17:08, Emil Velikov wrote: > On 2 October 2017 at 16:55, Daniel Stone wrote: >> The dmabuf interface requires a valid modifier to be sent. If we don't >> explicitly get a modifier from the driver, we can't know what

Re: [Mesa-dev] [PATCH] egl/wayland: Don't use dmabuf with no modifiers

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 16:55, Daniel Stone wrote: > The dmabuf interface requires a valid modifier to be sent. If we don't > explicitly get a modifier from the driver, we can't know what to send; > it must be inferred from legacy side-channels (or assumed to linear, if > none

[Mesa-dev] [Bug 103062] Error starting game FS17

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103062 --- Comment #5 from Emil Velikov --- (In reply to alexander from comment #4) > How to upgrade the version of the Shader? That's not it works. Can you provide a more complete log/output from the game? Alternatively

[Mesa-dev] [PATCH] egl/wayland: Don't use dmabuf with no modifiers

2017-10-02 Thread Daniel Stone
The dmabuf interface requires a valid modifier to be sent. If we don't explicitly get a modifier from the driver, we can't know what to send; it must be inferred from legacy side-channels (or assumed to linear, if none exists). If we have no modifier, then we can only have a single-plane format

Re: [Mesa-dev] [PATCH 6/7] i965: Reported supported context priorities to EGL/DRI

2017-10-02 Thread Kenneth Graunke
On Monday, October 2, 2017 2:44:13 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-09-29 22:59:56) > > On Friday, September 29, 2017 1:03:14 PM PDT Chris Wilson wrote: > > > Quoting Kenneth Graunke (2017-09-29 20:55:53) > > > > On Friday, September 29, 2017 3:25:09 AM PDT Chris Wilson

Re: [Mesa-dev] [PATCH 4/7] i965: Record the presence of the kernel scheduler

2017-10-02 Thread Kenneth Graunke
On Monday, October 2, 2017 1:52:12 AM PDT Joonas Lahtinen wrote: > On Fri, 2017-09-29 at 12:52 -0700, Kenneth Graunke wrote: > > On Friday, September 29, 2017 3:25:07 AM PDT Chris Wilson wrote: > > > Mention to the debug log if the kernel scheduler is enabled; and in > > > particular if it has

Re: [Mesa-dev] [PATCH 5/5] travis: add meson build for vulkan drivers.

2017-10-02 Thread Eric Engestrom
On Sunday, 2017-10-01 03:58:28 +, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > .travis.yml | 36 > 1 file changed, 36 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index d9a8bf5a9d4..e8fff1b66ab 100644 >

Re: [Mesa-dev] [PATCH 7/7] wayland-egl: rework and simplify wl_egl_window initialization

2017-10-02 Thread Emil Velikov
On 29 September 2017 at 21:40, Miguel Angel Vico wrote: >> Miguel I believe the comment correctly describes the design plan, while >> addressing Dan's comment that things look a bit ugly. > > Yes. Thank you. > > Also, the whole series: > > Reviewed-by: Miguel A. Vico

[Mesa-dev] [Bug 103062] Error starting game FS17

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103062 --- Comment #4 from alexander --- (In reply to Emil Velikov from comment #2) > Implementing GL_NV_texture_compression_vtc in Mesa might be problematic > since the extension IP status is "NVIDIA Proprietary". How to

[Mesa-dev] [Bug 103062] Error starting game FS17

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103062 --- Comment #3 from alexander --- Created attachment 134620 --> https://bugs.freedesktop.org/attachment.cgi?id=134620=edit Log FS17 Wine FS17 incorrectly defines my CPU. In fact AMD-A8 6410 with AMD Radeon R5

Re: [Mesa-dev] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

2017-10-02 Thread Daniel Stone
Hi Andy, On 27 September 2017 at 20:34, Andy Furniss wrote: > Marek Olšák wrote: >> Sorry too late, I pushed it. >> >> I don't know if stable is affected. > > It regresses things starting on radeonsi using weston eg. > > mpv - > > [vo/opengl/wayland] error occurred on the

Re: [Mesa-dev] [PATCH 4/5] meson: convert gtest to an internal dependency

2017-10-02 Thread Eric Engestrom
On Sunday, 2017-10-01 03:58:27 +, Dylan Baker wrote: > In truth gtest is an external dependency that upstream expects you to > "vendor" into your own tree. As such, it makes sense to treat it more > like a dependency than an internal library, and collect it's > requirements together in a

Re: [Mesa-dev] [PATCH v2 2/3] vulkan/wsi: Report the correct min/maxImageCount

2017-10-02 Thread Jason Ekstrand
On Sun, Oct 1, 2017 at 10:32 PM, Neil Roberts wrote: > Jason Ekstrand writes: > > > Hey, Neil! > > Hey Jason :) > > > Yeah... That's a bit unfortunate. The problem is that we have no way of > > returning a different number of images depending on the

Re: [Mesa-dev] [PATCH] swr/rast: do not crash on NULL strings returned by getenv

2017-10-02 Thread Emil Velikov
On 19 September 2017 at 21:08, Rowley, Timothy O wrote: > I have a bit of a preference for Eric’s version. > Ack. Amended and pushed to master. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 102847] swr fail to build with llvm-5.0.0

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102847 --- Comment #4 from Juan A. Suarez --- Patch https://patchwork.freedesktop.org/patch/177834/ has been landed upstream. Does it fix this issue? -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH v3 1/2] configure+mesa/st: unify check for -std=c++11 support and enable accordingly

2017-10-02 Thread Gert Wollny
Am Montag, den 02.10.2017, 15:16 +0100 schrieb Emil Velikov: > > > While rebuilding most of Mesa + its tests (as illustrated in 2/2) > only for a single test is very wasteful. > > Let's not do that, pretty please? I'm not quite sure what you mean by that. IHMO as long as mesa is supposed to

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

2017-10-02 Thread Emil Velikov
On 27 September 2017 at 20:27, Juan A. Suarez Romero wrote: > On Wed, 2017-09-27 at 18:09 +0100, Emil Velikov wrote: >> On 27 September 2017 at 17:28, Marek Olšák wrote: >> > On Wed, Sep 27, 2017 at 6:22 PM, Emil Velikov >> >

Re: [Mesa-dev] [OS]Mesa MinGW AppVeyor Repository

2017-10-02 Thread Trevor Sandy
Many thanks for the details - and the reminder on passively contributing to wasting developers' time :-) For the content I created, I will proceed accordingly. I've reached out to the repo owner where I got the patches I use to validate the MinGW build to see his opinion. If there is no conflict,

[Mesa-dev] [Bug 103062] Error starting game FS17

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103062 --- Comment #2 from Emil Velikov --- What hardware are you using? Can you attach the FS17 log (as plain text). Implementing GL_NV_texture_compression_vtc in Mesa might be problematic since the extension IP status is

Re: [Mesa-dev] [OS]Mesa MinGW AppVeyor Repository

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 15:16, Trevor (CIMdata) wrote: > Hello Emil, > > Yes, I did see the AppVeyor integraton for MSVC. It could be quite easy to > add the MinGW scope to the metrix. > > > > I don’t really know how to ‘upsteam’ the patches I use mostly because I am > not

Re: [Mesa-dev] [PATCH 2/4] gallivm: allow additional llc options

2017-10-02 Thread Ben Crocker
- Original Message - > From: "Nicolai Hähnle" > To: "Ben Crocker" , mesa-dev@lists.freedesktop.org > Cc: "Emil Velikov" , "17.2" > > Sent: Monday, October 2, 2017 5:40:31 AM > Subject:

[Mesa-dev] [Bug 103062] Error starting game FS17

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103062 alexander changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 103062] Error starting game FS17

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103062 --- Comment #1 from alexander --- And the proprietary driver cannot be installed (does Not work). -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 103062] Error starting game FS17

2017-10-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103062 Bug ID: 103062 Summary: Error starting game FS17 Product: Mesa Version: 17.2 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH v3 1/2] configure+mesa/st: unify check for -std=c++11 support and enable accordingly

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 15:04, Gert Wollny wrote: > Am Montag, den 02.10.2017, 13:37 +0100 schrieb Emil Velikov: >> Hi Gert, >> >> On 19 September 2017 at 12:35, Gert Wollny >> wrote: >> > Unify the CXX feature tests for C++11 support that is required for

Re: [Mesa-dev] [OS]Mesa MinGW AppVeyor Repository

2017-10-02 Thread Trevor (CIMdata)
Hello Emil, Yes, I did see the AppVeyor integraton for MSVC. It could be quite easy to add the MinGW scope to the metrix. I don’t really know how to ‘upsteam’ the patches I use mostly because I am not the author. Do I just submit a PR? Anyway to help George with his patch – which fixes the

Re: [Mesa-dev] [OS]Mesa MinGW AppVeyor Repository

2017-10-02 Thread Kyriazis, George
Emil, I’m working with Trevor to upstream the correct versions of the swr patches. Thanks, George > On Oct 2, 2017, at 9:04 AM, Emil Velikov wrote: > > Hi Trevor, > > On 2 October 2017 at 13:48, Trevor Sandy wrote: >> Hi George, >> >> You

Re: [Mesa-dev] [OS]Mesa MinGW AppVeyor Repository

2017-10-02 Thread Emil Velikov
Hi Trevor, On 2 October 2017 at 13:48, Trevor Sandy wrote: > Hi George, > > You might be interested to know I have set up a CI env on AppVeyor for MinGW > builds. > > Here is the GitHub repo: https://github.com/trevorsandy/osmesa_mingw_av. > Follow the badge in the README

Re: [Mesa-dev] [PATCH v3 1/2] configure+mesa/st: unify check for -std=c++11 support and enable accordingly

2017-10-02 Thread Gert Wollny
Am Montag, den 02.10.2017, 13:37 +0100 schrieb Emil Velikov: > Hi Gert, > > On 19 September 2017 at 12:35, Gert Wollny > wrote: > > Unify the CXX feature tests for C++11 support that is required for > > SWR, clover, and mesa/st/tests. > > > > Surely we'll have capable

Re: [Mesa-dev] [PATCH 01/11] radeonsi: use ac helpers for bitcasts

2017-10-02 Thread Marek Olšák
This reply of yours doesn't contain anything. (clipped message?) Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 00/15] Import libtxc_dxtn's S3TC code into Mesa!

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 07:59, Matt Turner wrote: > The patent on S3TC has now expired! Rejoice! > It's time to open that 20 year old bottle of wine ;-) > This series imports the code from Roland's libtxc_dxtn into Mesa and cleans up > some mess dealing with the possibility of

Re: [Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 07:59, Matt Turner wrote: > +#include "../../../mesa/main/texcompress_s3tc_tmp.h" > This feels a bit dirty. If people are not too keen on the idea, another approach is to have the code in src/util/ -Emil ___

Re: [Mesa-dev] [PATCH 06/15] mesa: Call DXTn functions directly

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 14:05, Emil Velikov wrote: >> - if (ext_tx_compress_dxtn) { >> - (*ext_tx_compress_dxtn)(3, srcWidth, srcHeight, pixels, >> + if (tx_compress_dxtn) { >> + (*tx_compress_dxtn)(3, srcWidth, srcHeight, pixels, > Please use something like

Re: [Mesa-dev] [PATCH 03/15] mesa: Remove commented-out DXTn fetch code

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 07:59, Matt Turner wrote: > Has been disabled for 12 years. > --- > src/mesa/main/texcompress_s3tc_tmp.h | 80 > > 1 file changed, 80 deletions(-) > I would have made this 2/15 since it's a bit meh to move dead code.

Re: [Mesa-dev] [PATCH 06/15] mesa: Call DXTn functions directly

2017-10-02 Thread Emil Velikov
On 2 October 2017 at 07:59, Matt Turner wrote: > --- > src/mesa/main/texcompress_s3tc.c | 117 > +-- > 1 file changed, 25 insertions(+), 92 deletions(-) > > diff --git a/src/mesa/main/texcompress_s3tc.c >

  1   2   >