[Mesa-dev] [RFC 02/12] dri: extend fence extension to support native fd fences

From: Rob Clark Required to implement EGL_ANDROID_native_fence_sync. Signed-off-by: Rob Clark --- include/GL/internal/dri_interface.h | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [RFC 03/12] egl: add EGL_ANDROID_native_fence_sync

From: Rob Clark [chadv]: Resolve rebase conflicts. Signed-off-by: Rob Clark --- src/egl/drivers/dri2/egl_dri2.c | 49 + src/egl/main/eglapi.c | 36 +++---

[Mesa-dev] [RFC 00/12] egl, i965: Support EGL_ANDROID_native_fence_sync (v2)

so need my libdrm branch: http://cgit.kiwitree.net/~chadv/libdrm/log/?h=wip/fences kernel: I have a kernel branch too where I collect other people's patches. Be warned: if you run it, it will eat your machine's soul. http://cgit.kiwitree.net/~chadv/linux/log/?h=wip/fences Ch

[Mesa-dev] [RFC 01/12] egl: initialize SyncCondition after attr parsing

From: Rob Clark Reduce the noise in the next patch. For EGL_SYNC_NATIVE_FENCE_ANDROID the sync condition is conditional on EGL_SYNC_NATIVE_FENCE_FD_ANDROID attribute. Signed-off-by: Rob Clark --- src/egl/main/eglsync.c | 8 1 file

Re: [Mesa-dev] [PATCH] intel: Fix bash-specific redirection.

$(AM_V_GEN) echo -n "static const uint8_t " > $@; \ > - sed -e 's,_xml.h,,' <<< "`basename $@`_xml[] = {" >> $@; \ > + echo "`basename $@`_xml[] = {" | sed -e 's,_xml.h,,' >> $@; \ >

Re: [Mesa-dev] [PATCH v3 10/10] anv/TODO: Update the HiZ task

On Thu 06 Oct 2016, Nanley Chery wrote: > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> > --- > src/intel/vulkan/TODO | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Chad Versace <

Re: [Mesa-dev] [PATCH v3 09/10] anv: Enable fast depth clears

On Thu 06 Oct 2016, Jason Ekstrand wrote: > Nice and clean!  R-b still applies. > > I think I've reviewed everything now.  If there's still something missing, let > me know.  May also want to give Chad a chance. I agree. Nice and clean. Reviewed-by: Chad Versace <chadvers.

Re: [Mesa-dev] [PATCH v3 07/10] anv/cmd_buffer: Add code for performing HZ operations

++++++++ > 3 files changed, 197 insertions(+) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/4] i965/sync: Fix uninitalized usage and leak of mutex

On Thu 06 Oct 2016, Emil Velikov wrote: > Hi Chad, > > On 4 October 2016 at 23:37, Chad Versace <chadvers...@chromium.org> wrote: > > We locked an unitialized mutex in the callstack > > glClientWaitSync > > intel_gl_client_wait_sync > > brw_fence

[Mesa-dev] [PATCH] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync* (v2)

Pre-patch, there were two code paths for parsing EGLSync attribute lists: one path for old-style EGLint lists, used by eglCreateSyncKHR, and another for new-style EGLAttrib lists, used by eglCreateSync (1.5) and eglCreateSync64 (EGL_KHR_cl_event2). There were two attrib_list parsing functions,

Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

On Wed 05 Oct 2016, Emil Velikov wrote: > On 4 October 2016 at 22:31, Chad Versace <c...@kiwitree.net> wrote: > > On Thu 29 Sep 2016, Emil Velikov wrote: > >> On 28 September 2016 at 07:28, Chad Versace <chadvers...@chromium.org> > >> wrote: > >> &g

Re: [Mesa-dev] [PATCH V2 08/11] anv/cmd_buffer: Add code for performing HZ operations

On Tue 27 Sep 2016, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 11:00:14AM -0700, Chad Versace wrote: > > On Mon 26 Sep 2016, Nanley Chery wrote: > > > Create a function that performs one of three HiZ operations - > > > depth/stencil clears, HiZ resolve, and depth re

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

anleych...@gmail.com> > > > wrote: > > > > > >> On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: > > >> > On Tue 27 Sep 2016, Nanley Chery wrote: > > >> > > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > >> &g

[Mesa-dev] [PATCH 2/4] i965/sync: Replace 'intel' prefix with 'brw'

This is yet another patch for the great renaming begun long ago. --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/intel_syncobj.c | 70 +++ 3 files changed, 37 insertions(+), 37

[Mesa-dev] [PATCH 3/4] i965/sync: Rename intel_syncobj.c -> brw_sync.c

--- src/mesa/drivers/dri/i965/Makefile.sources| 2 +- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/{intel_syncobj.c => brw_sync.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename

[Mesa-dev] [PATCH 0/4] i965: Fixes and cleanups for intel_syncobj.c

I'm preparing to implement EGL_ANDROID_native_fence_sync, and I wanted to land these fixes and cleanups before doing the real work. Patch 1 is a bugfix. The other patches are cleanups. This series lives at http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=review/brw-sync-v02 Chad Versace (4

[Mesa-dev] [PATCH 4/4] i965/sync: Rename awkward variable

What is the difference between a 'driver_fence' and a 'fence'? Do the characters 'driver_' add anything helpful? Nope. They do, though, add an extra 7 chars and pull your eyeballs away to ask "huh? what's that?" one microsecond too many. --- src/mesa/drivers/dri/i965/brw_sync.c | 12 ++--

[Mesa-dev] [PATCH 1/4] i965/sync: Fix uninitalized usage and leak of mutex

We locked an unitialized mutex in the callstack glClientWaitSync intel_gl_client_wait_sync brw_fence_client_wait_sync because we forgot to initialize it in intel_gl_fence_sync. (The EGLSync codepath didn't have this bug. It initialized the mutex in intel_dri_create_sync). We also

Re: [Mesa-dev] [PATCH 2/6] i965/sync: Stop cacheing fence's signal status

On Sun 02 Oct 2016, Kenneth Graunke wrote: > On Tuesday, September 27, 2016 11:51:20 PM PDT Chad Versace wrote: > > Cacheing the signal status complicates the code for questionable > > performance benefit. I added the cacheing long ago, and I now think it > > was the wrong de

Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

On Thu 29 Sep 2016, Emil Velikov wrote: > On 28 September 2016 at 07:28, Chad Versace <chadvers...@chromium.org> wrote: > > Pre-patch, there were two code paths for parsing EGLSync attribute > > lists: one path for old-style EGLint lists, used by eglCreateSyncKHR, > >

Re: [Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

On Thu 29 Sep 2016, Emil Velikov wrote: > On 28 September 2016 at 07:28, Chad Versace <chadvers...@chromium.org> wrote: > > > + if (sizeof(int_list[0]) == sizeof(attrib_list[0])) { > > + attrib_list = (EGLAttrib *) int_list; > > + } else { > > +

Re: [Mesa-dev] [PATCH 0/6] i965/sync: Fix dEQP-EGL.functional.gles2.multithread.*

On Wed 28 Sep 2016, Chris Wilson wrote: > On Tue, Sep 27, 2016 at 11:51:18PM -0700, Chad Versace wrote: > > Test results of dEQP-EGL.functional.gles2.multithread.* on Skylake, > > using deqp-egl directly (no Piglit): > > > > * Before: > > Bajillions

Re: [Mesa-dev] [PATCH 0/6] i965/sync: Fix dEQP-EGL.functional.gles2.multithread.*

On Tue 27 Sep 2016, Chad Versace wrote: > Test results of dEQP-EGL.functional.gles2.multithread.* on Skylake, > using deqp-egl directly (no Piglit): > > * Before: > Bajillions of failures and randomly occuring crashes. The > testrun died on me on 10/10 tri

[Mesa-dev] [PATCH 4/6] i965/sync: Replace 'intel' prefix with 'brw'

'intel' is s yesterday ;) This is yet another patch for the great renaming begun long ago. --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/intel_syncobj.c | 70 +++ 3 files

[Mesa-dev] [PATCH 0/6] i965/sync: Fix dEQP-EGL.functional.gles2.multithread.*

/?h=review/brw-sync-v01 Chad Versace (6): i965/sync: Fix uninitalized usage and leak of mutex i965/sync: Stop cacheing fence's signal status i965/sync: Fold brw_fence_has_completed() into caller i965/sync: Replace 'intel' prefix with 'brw' i965/sync: Rename intel_syncobj.c -> brw_syn

[Mesa-dev] [PATCH 6/6] i965/sync: Rename awkward variable

What is the difference between a 'driver_fence' and a 'fence'? Do the characters 'driver_' add anything helpful? Nope. They do, though, add an extra 7 chars and pull your eyeballs away to ask "huh? what's that?" one microsecond too many. --- src/mesa/drivers/dri/i965/brw_sync.c | 12 ++--

[Mesa-dev] [PATCH 5/6] i965/sync: Rename intel_syncobj.c -> brw_sync.c

--- src/mesa/drivers/dri/i965/Makefile.sources| 2 +- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/{intel_syncobj.c => brw_sync.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename

[Mesa-dev] [PATCH 1/6] i965/sync: Fix uninitalized usage and leak of mutex

We locked an unitialized mutex in the callstack glClientWaitSync intel_gl_client_wait_sync brw_fence_client_wait_sync because we forgot to initialize it in intel_gl_fence_sync. (The EGLSync codepath didn't have this bug. It initialized the mutex in intel_dri_create_sync). We also

[Mesa-dev] [PATCH 2/6] i965/sync: Stop cacheing fence's signal status

Cacheing the signal status complicates the code for questionable performance benefit. I added the cacheing long ago, and I now think it was the wrong decision. When we later add support for fences based on sync fds (that is, a fd backed by struct sync_file in Linux 4.8), the cacheing becomes even

[Mesa-dev] [PATCH 3/6] i965/sync: Fold brw_fence_has_completed() into caller

The function is tiny and called exactly once. There's no need for it. --- src/mesa/drivers/dri/i965/intel_syncobj.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_syncobj.c b/src/mesa/drivers/dri/i965/intel_syncobj.c

[Mesa-dev] [PATCH 7/7] egl: Unify the EGLint/EGLAttrib paths in eglCreateSync*

Pre-patch, there were two code paths for parsing EGLSync attribute lists: one path for old-style EGLint lists, used by eglCreateSyncKHR, and another for new-style EGLAttrib lists, used by eglCreateSync (1.5) and eglCreateSync64 (EGL_KHR_cl_event2). There were two attrib_list parsing functions,

[Mesa-dev] [PATCH 2/7] egl: Fix truncation error in _eglParseSyncAttribList64

The function stores EGLAttrib values in EGLint variables. On 64-bit systems, this truncated the values. Cc: mesa-sta...@lists.freedesktop.org --- src/egl/main/eglsync.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/egl/main/eglsync.c b/src/egl/main/eglsync.c

[Mesa-dev] [PATCH 1/7] egl: Fix missing unlock in eglGetSyncAttribKHR

On the error path, eglGetSyncAttribKHR neglected to unlock the EGLDisplay before returning. Fixes deadlock in dEQP-EGL.functional.fence_sync.invalid.get_invalid_value. Cc: mesa-sta...@lists.freedesktop.org Cc: Mark Janes --- src/egl/main/eglapi.c | 2 +- 1 file changed,

[Mesa-dev] [PATCH 6/7] egl: Drop duplicate check on EGLSync type

_eglInitSync checked that the display supported the sync type (such as EGL_SYNC_FENCE), and did it wrong. When the check failed it emitted EGL_BAD_ATTRIBUTE, but sometimes EGL_BAD_PARAMETER is needed. _eglCreateSync already does the error checking, and it does it right. ---

[Mesa-dev] [PATCH 5/7] egl: Cleanup control flow in _eglParseSyncAttribList

When the function encountered an error, it effectively returned immediately. However, it did so indirectly by breaking out of a loop. Replace the loop breakout with a explicit 'return'. Do the same for _eglParseSyncAttribList64 too. --- src/egl/main/eglsync.c | 14 -- 1 file changed,

[Mesa-dev] [PATCH 0/7] egl: Fixes and cleanups for EGLSync

.* deadlock 27/0 dEQP-EGL.functional.reusable_sync.* : 8/17 8/17 piglit egl_khr_fence_sync pass pass This series lives at git://git.kiwitree.net/~chadv/mesa review/fences-v02 Chad Versace (7): egl: Fix missing unlock in eglGetSyncAttribKHR egl: Fix

[Mesa-dev] [PATCH 4/7] egl: Add _eglConvertIntsToAttribs()

This function converts an attribute list from EGLint[] to EGLAttrib[]. Will be used in following patches to cleanup EGLSync attribute parsing. --- src/egl/main/eglapi.c | 41 + src/egl/main/eglapi.h | 2 ++ 2 files changed, 43 insertions(+) diff --git

[Mesa-dev] [PATCH 3/7] egl: Fix an error path in eglCreateSync*

When the user called eglCreateSync64KHR on a display without EGL_KHR_cl_event2 (the only extension that exposes it), we returned EGL_NO_SYNC but did not update the error code. We also did the same for eglCreateSync on a display without EGL 1.5. --- src/egl/main/eglapi.c | 14 -- 1

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

On Tue 27 Sep 2016, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > As a consequence of that reasoning, we should set > > 3DSTATE_CLEAR_PARAMS.DepthClearValueValid = 1 > > whenever hiz is enabled, even if we don't care about t

Re: [Mesa-dev] [PATCH V2 09/11] genX/cmd_buffer: Enable rendering to HiZ

On Mon 26 Sep 2016, Nanley Chery wrote: > From: Chad Versace <chad.vers...@intel.com> > > Nanley Chery: > (rebase) > - Resolve conflicts with new anv_batch_emit macro > (amend) > - Handle a QPitch TODO > - Emit 3DSTATE_HIER_DEPTH_BUFFER on pre-BDW systems >

Re: [Mesa-dev] [PATCH V2 08/11] anv/cmd_buffer: Add code for performing HZ operations

On Mon 26 Sep 2016, Nanley Chery wrote: > Create a function that performs one of three HiZ operations - > depth/stencil clears, HiZ resolve, and depth resolves. > > Signed-off-by: Nanley Chery > > --- > > v2. Add documentation > Fix the alignment check > Don't

Re: [Mesa-dev] [PATCH V2 05/11] anv: Allocate hiz surface

On Mon 26 Sep 2016, Nanley Chery wrote: > From: Chad Versace <chad.vers...@intel.com> > > Nanley Chery: > (rebase) > - Use isl_surf_get_hiz_surf() > (amend) > - Only add a HiZ surface onto a depth/stencil attachment > - Add comment above HiZ surface addition >

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

On Mon 26 Sep 2016, Nanley Chery wrote: > From: Nanley Chery > > Provides an FPS increase of ~30% on the Sascha triangle and multisampling > demos. > > Clears that happen within a render pass via vkCmdClearAttachments are safe > even if the clear color changes. This is

Re: [Mesa-dev] [PATCH V2 07/11] anv/image: Memset hiz surfaces to 0 when binding memory

> v2. Add asserts (Jason) > Handle NULL return value of the mmap Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 10/12] genX/cmd_buffer: Enable rendering to HiZ

On Mon 26 Sep 2016, Nanley Chery wrote: > On Mon, Sep 19, 2016 at 01:49:09PM -0700, Nanley Chery wrote: > > On Fri, Sep 02, 2016 at 03:16:21PM -0700, Chad Versace wrote: > > > On Wed 31 Aug 2016, Nanley Chery wrote: > > > > From: Chad Versace <chad.vers...@intel.c

[Mesa-dev] [RFC] EGL_MESA_platform_surfaceless

docs/specs/EGL_MESA_platform_surfaceless.txt new file mode 100644 index 000..b700370 --- /dev/null +++ b/docs/specs/EGL_MESA_platform_surfaceless.txt @@ -0,0 +1,108 @@ +Name + +MESA_platform_surfaceless + +Name Strings + +EGL_MESA_platform_surfaceless + +Contributors + +Chad Versace

Re: [Mesa-dev] [PATCH 2/2] intel/isl: Divide QPitch by 2 for 3-D stencil textures on SKL+

eded on SKL, and are deferring the workaround on the other gens until you had a chance to test it on them? Either way, the patch is sound. And the workaround doesn't surprise me. Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] isl/state: Don't set QPitch for GEN4_3D surfaces

f); > + case ISL_DIM_LAYOUT_GEN4_3D: > + /* QPitch doesn't make sense for ISL_DIM_LAYOUT_GEN4_3D since it uses a > + * different pitch at each LOD. Also, the QPitch field is ignored for > + * these surfaces. Yep. Reviewed-by: Chad Versace <chadvers...@chromium.org> __

Re: [Mesa-dev] [PATCH] intel/isl: Ignore base_array_layer and array_len for 3D storage surfaces

trand <ja...@jlekstrand.net> > --- > src/intel/isl/isl_surface_state.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freed

Re: [Mesa-dev] [PATCH 04/12] anv: Add func anv_image_has_hiz()

On Tue 13 Sep 2016, Nanley Chery wrote: > On Wed, Sep 07, 2016 at 03:51:14PM -0700, Chad Versace wrote: > > On Wed 07 Sep 2016, Nanley Chery wrote: > > > On Fri, Sep 02, 2016 at 11:42:24AM -0700, Chad Versace wrote: > > > > On Thu 01 Sep 2016, Jason Ekstrand wrote:

Re: [Mesa-dev] [PATCH 3/3] Revert "i965: Drop the maximum 3D texture size to 512 on Sandy Bridge"

t; > ctx->Const.MaxCubeTextureLevels = 14; /* 8192 */ > > ctx->Const.MaxArrayTextureLayers = brw->gen >= 7 ? 2048 : 512; > > ctx->Const.MaxTextureMbytes = 1536; > > > > To clarify...that limit is GL_MAX_FRAMEBUFFER_LAYERS. Good. If the limit is GL_MAX_FRAMEBUFFER_LAYERS, then I agree with this patch. Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] Revert "i965: Drop the maximum 3D texture size to 512 on Sandy Bridge"

On Mon 12 Sep 2016, Jason Ekstrand wrote: > This reverts commit 6ba88bce64b343761aabe3a6c7ee285c6020a959. The commit > was erroneous because GL already provides a separate guard on the number of > layers you are allowed to render into. On Sandy Bridge, we set this guard > correctly so creating a

Re: [Mesa-dev] [PATCH 2/3] blorp: Handle the 512 layers restriction on Sandy Bridge

you also update blorp_fast_clear()? Oh right, Sandybridge can't do fast clears. Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] intel/isl: Treat 3-D textures as 2-D arrays for rendering

isn't a huge deviation. > > Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> > Cc: Chad Versace <chadvers...@chromium.org> > --- > src/intel/isl/isl.h | 6 ++ > src/intel/isl/isl_surface_state.c | 11 +++ > 2 files changed, 13 insertions(

Re: [Mesa-dev] [PATCH 4/4] i965: Use blorp_copy for all copy_image operations on gen6+

On Fri 09 Sep 2016, Jason Ekstrand wrote: > > On Sep 9, 2016 12:23 PM, "Chad Versace" <chadvers...@chromium.org> wrote: > > Acked-by: Chad Versace <chadvers...@chromium.org> > > Sure, review the easy patch and ack the interesting ones... Yep! > &

Re: [Mesa-dev] [PATCH] egl: Document why EGL_OPENGL{, _ES}_API are mostly identical

ok up the current API from the current > > + * thread, and stash that in the context we're initializing. Our caller is > > + * responsible for determining whether that's an API it supports. > > */ > > EGLBoolean > > _eglInitContext(_EGLContext *ctx, _

Re: [Mesa-dev] [PATCH 4/4] i965: Use blorp_copy for all copy_image operations on gen6+

Patches 3 and 4, despite their craziness, are Acked-by: Chad Versace <chadvers...@chromium.org> Just an ack, because I'm not very familiar with the new blorp code. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedeskt

Re: [Mesa-dev] [PATCH 2/4] intel/isl: Add support for RGB formats in X and Y-tiled memory

surface size wants > the fewest number of horizontal tiles possible while get_intratile_offset > is far more concerned with things aligning nicely. > > Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> > Cc: Chad Versace <c...@kiwitree.net> > --- > src/intel/i

Re: [Mesa-dev] [PATCH 1/4] intel/isl: Allow valign2 for texture-only Y-tiled surfaces on gen7

is should be That isl format doesn't exist. Did you mean R32B32B32_FLOAT (sans S)? > okay because you can't render to that format. > > Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> > Cc: Chad Versace <c...@kiwitree.net> > --- > src/intel/isl/isl_gen7.c | 3 ++

Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

On Thu 08 Sep 2016, Nanley Chery wrote: > Should the title the say needed instead of unneeded? Oops :/ It's already pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

On Thu 08 Sep 2016, Emil Velikov wrote: > On 8 September 2016 at 04:29, Chad Versace <chadvers...@chromium.org> wrote: > > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. > > But it's needed only if HAVE_PLATFORM_X11. > > > > Fixes build of

[Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. But it's needed only if HAVE_PLATFORM_X11. Fixes build of libvulkan_intel.so on Chromium OS, which has no X11 libraries. Cc: Kevin Strasser Cc: Jason Ekstrand Change-Id:

Re: [Mesa-dev] [PATCH 04/12] anv: Add func anv_image_has_hiz()

On Wed 07 Sep 2016, Nanley Chery wrote: > On Fri, Sep 02, 2016 at 11:42:24AM -0700, Chad Versace wrote: > > On Thu 01 Sep 2016, Jason Ekstrand wrote: > > > On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery <nanleych...@gmail.com> > > > wrote: > > >

Re: [Mesa-dev] [PATCH] EGL: Combine the GL and GLES current contexts (v2)

On Wed 07 Sep 2016, Adam Jackson wrote: > On Wed, 2016-09-07 at 11:15 -0400, Adam Jackson wrote: > > From: Kyle Brenneman > > > > Only keep track of a single current context, instead of separate > > contexts for GL and GLES. > > In addition to fixing 1.4+ compliance, this

Re: [Mesa-dev] [PATCH 5/6] intel/isl: Remove tiling checks from choose_msaa_layout

ht reject multisampled HiZ surfaces which wasn't intended. > --- > src/intel/isl/isl_gen7.c | 10 +++--- > src/intel/isl/isl_gen8.c | 11 --- > 2 files changed, 7 insertions(+), 14 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org>

Re: [Mesa-dev] [PATCH 6/6] intel/isl: Add a detailed comment about multisampling with HiZ

/* On SKL+, HiZ is always single-sampled */ > - .samples = ISL_DEV_GEN(dev) >= 9 ? 1 : surf->samples, > + .samples = samples, > .usage = ISL_SURF_USAGE_HIZ_BIT, > .tiling_flags = ISL_TILING_HIZ_BIT); > } > -- Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/6] intel/isl: Handle HiZ and CCS tiling more directly

-- > src/intel/isl/isl.c | 18 -- > src/intel/isl/isl_gen7.c | 14 -- > 2 files changed, 16 insertions(+), 16 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 3/6] intel/isl: Allow multisampling with ISL_FORMAT_HiZ

+ */ > + return devinfo->gen <= 8; There's an element of surprising elegance in this patch. For patches 1-3, Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/12] anv/cmd_buffer: Add code for performing HZ operations

On Fri 02 Sep 2016, Nanley Chery wrote: > On Wed, Aug 31, 2016 at 08:29:55PM -0700, Nanley Chery wrote: > > From: Jason Ekstrand > > > > Nanley Chery: > > (rebase) > > - Resolve conflicts with the new anv_batch_emit macro > > (amend) > > - Update commit title > > -

Re: [Mesa-dev] [PATCH 10/12] genX/cmd_buffer: Enable rendering to HiZ

On Wed 31 Aug 2016, Nanley Chery wrote: > From: Chad Versace <chad.vers...@intel.com> > > Nanley Chery: > (rebase) > - Resolve conflicts with new anv_batch_emit macro > (amend) > - Remove wip! tag and handle a QPitch TODO > - Emit 3DSTATE_HIER_DEPTH_BUFFER on pre

Re: [Mesa-dev] [PATCH 07/12] anv/image: Memset hiz surfaces to 0 when binding memory

On Thu 01 Sep 2016, Jason Ekstrand wrote: > > > On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote: > > From: Jason Ekstrand > > Nanley Chery (amend): >  - Change memset value from 0xff to 0 (a defined value for HiZ). Yep. 0xff

Re: [Mesa-dev] [PATCH 06/12] anv: Move BindImageMemory to anv_image.c

+++ > 2 files changed, 20 insertions(+), 20 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/12] anv: Allocate hiz surface

On Wed 31 Aug 2016, Nanley Chery wrote: > From: Chad Versace <chad.vers...@intel.com> > > Nanley Chery: > (rebase) > - Use isl_surf_get_hiz_surf() > (amend) > - Only add a HiZ surface onto a depth/stencil attachment > - Add comment above HiZ surface addition >

Re: [Mesa-dev] [PATCH 04/12] anv: Add func anv_image_has_hiz()

On Thu 01 Sep 2016, Jason Ekstrand wrote: > On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery <nanleych...@gmail.com> wrote: > > From: Chad Versace <chad.vers...@intel.com> > > Nanley Chery (amend): >  - Remove wip! tag > > Signed-off-by: Na

Re: [Mesa-dev] [PATCH 03/12] anv: Add anv_image::hiz_surface

On Wed 31 Aug 2016, Nanley Chery wrote: > From: Chad Versace <chad.vers...@intel.com> > > Unused. > > Nanley Chery (amend): > - Remove wip! tag There's no need to document that minor change :) > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> >

Re: [Mesa-dev] [PATCH 02/12] isl: Update isl_surf_get_hiz_surf()

.g.ch...@intel.com> > --- > src/intel/isl/isl.c | 39 +-- > 1 file changed, 33 insertions(+), 6 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 01/12] isl: Correct a comment in the isl_format enum

On Wed 31 Aug 2016, Nanley Chery wrote: > HiZ is not a color surface, but an auxiliary depth surface. > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > --- > src/intel/isl/isl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by

Re: [Mesa-dev] [PATCH v2 0/2] *** Aubinator tool for Intel Gen platforms ***

On Fri 19 Aug 2016, Sirisha Gandikota wrote: > From: Sirisha Gandikota > > This is a patch series for adding the aubinator tool to the codebase. > > The aubinator tool is designed to help the driver developers to debug > the driver functionality by decoding the data

Re: [Mesa-dev] [PATCH 03/13] docs: Rename GL3.txt to features.txt

Patches 2, 3 are Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] isl: Allow multisampled array textures

eds and it does fix 8 of the new CTS tests. > > Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> Reviewed-by: Chad Versace <chadvers...@chromium.org> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] docs: add links to clarify patch mailing section

.com> > --- > docs/devinfo.html | 12 ++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Chad Versace <chadvers...@chromium.org> Thanks, and pushed. One more bit of advice: When sending v2 of a patch, it's often a good idea to Cc the person (Eric) who su

Re: [Mesa-dev] [PATCH] isl: Finish tiling filtering for Gen6.

On Fri 26 Aug 2016, Kenneth Graunke wrote: > Gen6 only has one additional restriction over Gen7+, so we just add it > to the existing gen7 function (which actually covers later gens too). > > This should stop FINISHME spew when running GL on Sandybridge. > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [Mesa-stable] [PATCH 0/2] i965: Fix dEQP-EGL.functional.image.create.gles2_cubemap_*

On Thu 25 Aug 2016, Kenneth Graunke wrote: > On Thursday, August 25, 2016 11:06:01 AM PDT Chad Versace wrote: > > Bump. Can I get a reviewed-by? Or at least a tested-by? This patch fixes > > failures on Chrome OS. > > Oh, sorry, I thought these had been reviewed a

Re: [Mesa-dev] [Request for Testing] i965: import prime buffers in the current context, not screen

On Thu 25 Aug 2016, Martin Peres wrote: > This mirrors the codepath taken by DRI2 in IntelSetTexBuffer2() and > fixes many applications when using DRI3: > - Totem with libva on hw-accelerated decoding > - obs-studio, using Window Capture (Xcomposite) as a Source > - gstreamer with VAAPI > >

Re: [Mesa-dev] [PATCH 0/2] i965: Fix dEQP-EGL.functional.image.create.gles2_cubemap_*

Bump. Can I get a reviewed-by? Or at least a tested-by? This patch fixes failures on Chrome OS. On Thu 04 Aug 2016, Chad Versace wrote: > Hi Intel folks, could one of you please run this through Jenkins? > I verified manually that it fixes the listed dEQP tests on Skylake. > > Cha

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix glFramebufferTexture* error codes (v2)

Bump. On Thu 11 Aug 2016, Chad Versace wrote: > If check_textarget() determined that textarget was incorrect, it emitted > GL_INVALID_OPERATION. This is the correct behavior when target and > textarget are mismatched but textarget is a valid textarget enum. > > When textarget

Re: [Mesa-dev] [PATCH 3/3] intel/isl/gen9: Only use the magic 1D alignment for GEN9_2D surfaces

On Thu 25 Aug 2016, Pohjolainen, Topi wrote: > > In the title did you mean GEN_1D? > > Otherwise patches two and three look good also: > > Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> Yep. Patches 2 and 3 are Reviewed-by: Chad Versace &

Re: [Mesa-dev] [PATCH 1/3] intel/isl: Use DIM_LAYOUT_GEN4_2D for tiled 1-D surfaces on SKL

layout is used. > > stencil > > > > > Signed-off-by: Jason Ekstrand <ja...@jlekstrand.net> > > Cc: Chad Versace <c...@kiwitree.net> > > --- > > src/intel/isl/isl.c | 28 +++- > > 1 file changed, 23 insertions(+), 5 deletions

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

| 1 + > src/intel/vulkan/Makefile.am | 7 ++- > src/intel/vulkan/{intel_icd.json => intel_icd.json.in} | 2 +- > 3 files changed, 8 insertions(+), 2 deletions(-) > rename src/intel/vulkan/{intel_icd.json => intel_icd.json.in} (59

Re: [Mesa-dev] [PATCH] mesa: change state query return value for RGB565

al. TEST=dEQP-GLES3.functional.state_query.integers.* Signed-off-by: Haixia Shi <h...@chromium.org <mailto:h...@chromium.org>> Cc: Chad Versace <chadvers...@chromium.org <mailto:chadvers...@chromium.org>> Cc: Stéphane Marchesin <marc...@chromiu

Re: [Mesa-dev] [PATCH] mesa: change state query return value for RGB565

(GL_IMPLEMENTATION_COLOR_READ_TYPE) and glGetIntegerv(GL_IMPLEMENTATION_COLOR_READ_FORMAT) queries. TEST=dEQP-GLES3.functional.state_query.integers.* Does this patch fix all the tests in that group? Just a few tests? Exactly one? Signed-off-by: Haixia Shi <h...@chromium.org> Cc: Chad Versace <

[Mesa-dev] [PATCH 1/2] mesa: Document that _mesa_enum_to_string() returns non-null

It always returns non-null, even if the number is an invalid enum. Cc: Haixia Shi Reviewed-by: Ian Romanick Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 --- src/mapi/glapi/gen/gl_enums.py | 7 ++- 1 file changed, 6 insertions(+), 1

[Mesa-dev] [PATCH 0/3] mesa: Fix a dEQP test (v2)

at git://git.kiwitree.net/~chadv/mesa branch review/fix-deqp-framebuffertexture-error-v02 Chad Versace (3): mesa: Document that _mesa_enum_to_string() returns non-null mesa: Add _mesa_enum_to_string2() mesa: Fix glFramebufferTexture* error codes src/mapi/glapi/gen/gl_enums.py | 24

[Mesa-dev] [PATCH 2/2] mesa: Fix glFramebufferTexture* error codes (v2)

If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when target and textarget are mismatched but textarget is a valid textarget enum. When textarget is not a valid textarget enum, the GL spec requires that GL_INVALID_ENUM be

Re: [Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

On 08/11/2016 10:22 AM, Ilia Mirkin wrote: On Thu, Aug 11, 2016 at 1:11 PM, Chad Versace <c...@kiwitree.net> wrote: If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when textarget is a valid GLenum but an i

Re: [Mesa-dev] [PATCH 2/3] mesa: Add _mesa_enum_to_string2()

On 08/11/2016 10:24 AM, Ian Romanick wrote: On 08/11/2016 10:11 AM, Chad Versace wrote: The new function is identical to _mesa_enum_to_string(), except that it returns false if the given number is an invalid enum. Bundling validation and lookup into a single function allows us to do both

Re: [Mesa-dev] [PATCH 1/3] mesa: Document that _mesa_enum_to_string() returns non-null

On 08/11/2016 10:30 AM, Ian Romanick wrote: On 08/11/2016 10:22 AM, Ian Romanick wrote: On 08/11/2016 10:11 AM, Chad Versace wrote: It always returns non-null, even if the number is an invalid enum. Cc: Haixia Shi <h...@chromium.org> Change-Id: I26e8843c96130be972e66f48a49e362442

[Mesa-dev] [PATCH 3/3] mesa: Fix glFramebufferTexture* error codes

If check_textarget() determined that textarget was incorrect, it emitted GL_INVALID_OPERATION. This is the correct behavior when textarget is a valid GLenum but an invalid parameter to the current variant of glFramebufferTexture*(). However, when textarget is not a GLenum at all, then the GL

[Mesa-dev] [PATCH 1/3] mesa: Document that _mesa_enum_to_string() returns non-null

It always returns non-null, even if the number is an invalid enum. Cc: Haixia Shi Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97 --- src/mapi/glapi/gen/gl_enums.py | 4 1 file changed, 4 insertions(+) diff --git a/src/mapi/glapi/gen/gl_enums.py

[Mesa-dev] [PATCH 2/3] mesa: Add _mesa_enum_to_string2()

The new function is identical to _mesa_enum_to_string(), except that it returns false if the given number is an invalid enum. Bundling validation and lookup into a single function allows us to do both with a single lookup into the enum table. Cc: Haixia Shi Change-Id:

<    4   5   6   7   8   9   10   11   12   13   >