Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

now for a > thorough investigation, but I'll happily take new patches... Perhaps we could make these dummy fences "issued". I'll check how this works in the code. Best regards, Tomasz > > Roland > > > Am 09.01.19 um 02:09 schrieb Roland Scheidegger: > > Am 07.01.19 um 09:

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

ntribution rate to be relatively low, due to a shift to different areas, so I don't think I'm a good candidate for a committer anymore.) Best regards, Tomasz > > Am 14.12.18 um 09:17 schrieb Tomasz Figa: > > If there is no last fence, due to no rendering happening yet, just > > creat

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

Hi everyone, On Fri, Dec 14, 2018 at 5:17 PM Tomasz Figa wrote: > > If there is no last fence, due to no rendering happening yet, just > create a new signaled fence and return it, to match the expectations of > the EGL sync fence API. > > Fixes random "Could not c

[Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

- explain why creating the dummy fence is the right approach. Signed-off-by: Tomasz Figa --- src/gallium/drivers/llvmpipe/lp_setup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/llvmpipe/lp_setup.c b/src/gallium/drivers/llvmpipe/lp_setup.c index b087369473..e72e

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush

Hi Nicolai, On Thu, Nov 22, 2018 at 6:19 PM Haehnle, Nicolai wrote: > > On 22.11.18 06:40, Tomasz Figa wrote: > > Hi Brian, Keith, > > > > +Some more Chromium folks for visibility. > > > > On Wed, Aug 22, 2018 at 4:21 PM Tomasz Figa wrote: > >> &

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush

Hi Brian, Keith, +Some more Chromium folks for visibility. On Wed, Aug 22, 2018 at 4:21 PM Tomasz Figa wrote: > > Hi Michel, > > On Thu, Aug 16, 2018 at 6:43 PM Michel Dänzer wrote: > > > > On 2018-08-16 11:34 AM, Tomasz Figa wrote: > > > If there is n

Re: [Mesa-dev] [PATCH v2] egl/android: rework device probing

On Mon, Sep 3, 2018 at 3:25 PM Tomasz Figa wrote: > > On Mon, Sep 3, 2018 at 2:45 PM Tomasz Figa wrote: > > > > Hi Emil, > > > > On Sat, Sep 1, 2018 at 2:03 AM Emil Velikov > > wrote: > > > > > > From: Emil Velikov > >

Re: [Mesa-dev] [PATCH v3] egl/android: rework device probing

ard declaration for droid_load_driver() > Fixes the HAVE_DRM_GRALLOC build (Mauro) > - split dup() assignment and check in separate lines (Tomasz, Eric) > - make droid_load_driver() static (Tomasz) > - drop unused prop_set variable (Tomasz) Thanks a lot! Reviewed-by: Tomasz F

Re: [Mesa-dev] [PATCH v2] egl/android: rework device probing

On Mon, Sep 3, 2018 at 2:45 PM Tomasz Figa wrote: > > Hi Emil, > > On Sat, Sep 1, 2018 at 2:03 AM Emil Velikov wrote: > > > > From: Emil Velikov > > > > Thanks for the patch! Please see my comments below. > > [snip] > > @@ -1214,10

Re: [Mesa-dev] [PATCH V2] Check if the window is non-NULL before setting swap interval.

On Thu, Aug 30, 2018 at 11:23 PM Emil Velikov wrote: > > On 30 August 2018 at 11:41, Eric Engestrom wrote: > > On Thursday, 2018-08-30 17:55:14 +0900, Tomasz Figa wrote: > >> Hi Erik, Emil, Eric, > >> > >> On Tue, Jul 10, 2018 at 12:41 AM Erik Faye-Lund

Re: [Mesa-dev] [PATCH v2] egl/android: rework device probing

Hi Emil, On Sat, Sep 1, 2018 at 2:03 AM Emil Velikov wrote: > > From: Emil Velikov > Thanks for the patch! Please see my comments below. [snip] > @@ -1214,10 +1215,13 @@ droid_open_device_drm_gralloc(struct dri2_egl_display > *dri2_dpy) >); >

Re: [Mesa-dev] [PATCH V2] Check if the window is non-NULL before setting swap interval.

Hi Erik, Emil, Eric, On Tue, Jul 10, 2018 at 12:41 AM Erik Faye-Lund wrote: > > On Thu, Jul 5, 2018 at 7:02 PM Emil Velikov wrote: > > > > On 5 July 2018 at 17:17, Eric Engestrom wrote: > > > On Thursday, 2018-07-05 14:43:02 +0100, Emil Velikov wrote: > > >> On 5 July 2018 at 10:53, Eric

Re: [Mesa-dev] [PATCH] egl/android: rework device probing

his is the best we can do for the > moment. > > With those (proposed) extensions userspace will be able to create a > separate EGL display for each device, query device details and make the > conscious decision which one to use. > > Cc: Robert Foss > Cc: Tomasz Figa &

Re: [Mesa-dev] [PATCH 6/5] egl/android: continue to next device if dri2_create_screen fails

On Thu, Aug 23, 2018 at 1:44 AM Emil Velikov wrote: > > Hi Tomasz, > > On 21 August 2018 at 14:54, Tomasz Figa wrote: > > Hi Emil, > > > > On Tue, Aug 14, 2018 at 2:05 AM Emil Velikov > > wrote: > >> > >> From: Emil Velikov >

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush

Hi Michel, On Thu, Aug 16, 2018 at 6:43 PM Michel Dänzer wrote: > > On 2018-08-16 11:34 AM, Tomasz Figa wrote: > > If there is no last fence, due to no rendering happening yet, just > > create a new signaled fence and return it, to match the expectations of > >

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

Hi Emil, On Mon, Aug 20, 2018 at 10:47 PM Emil Velikov wrote: > > On 13 August 2018 at 17:18, Tomasz Figa wrote: > > On Tue, Aug 14, 2018 at 1:09 AM Emil Velikov > > wrote: > >> > >> On 13 August 2018 at 16:43, Tomasz Figa wrote: > >> &g

Re: [Mesa-dev] [PATCH 6/5] egl/android: continue to next device if dri2_create_screen fails

L_EXT_explicit_device and > EGL_MESA_query_renderer are MIA, this is the best we can do for the > moment. > > With those (proposed) extensions userspace will be able to create a > separate EGL display for each device, query device details and make the > conscious decision which one to use. > >

[Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush

de: https://android.googlesource.com/platform/frameworks/base/+/master/libs/hwui/pipeline/skia/SkiaOpenGLPipeline.cpp#427 Reproducible especially with thread count >= 4. Signed-off-by: Tomasz Figa --- src/gallium/drivers/llvmpipe/lp_setup.c | 8 +++- 1 file changed, 7 insertions(+), 1 dele

Re: [Mesa-dev] [PATCH 2/5] egl/android: use strcmp with drmVersion::name

On Tue, Aug 14, 2018 at 12:47 AM Emil Velikov wrote: > > On 13 August 2018 at 16:21, Tomasz Figa wrote: > > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov > > wrote: > >> > >> From: Emil Velikov > >> > >> The name string is guaranteed to b

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

On Tue, Aug 14, 2018 at 1:09 AM Emil Velikov wrote: > > On 13 August 2018 at 16:43, Tomasz Figa wrote: > > On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov > > wrote: > >> > >> On 13 August 2018 at 16:16, Tomasz Figa wrote: > >> > Hi Emil, >

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

On Tue, Aug 14, 2018 at 12:35 AM Emil Velikov wrote: > > On 13 August 2018 at 16:16, Tomasz Figa wrote: > > Hi Emil, > > > > On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov > > wrote: > >> > >> From: Emil Velikov > >> >

Re: [Mesa-dev] [PATCH 2/5] egl/android: use strcmp with drmVersion::name

On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov wrote: > > From: Emil Velikov > > The name string is guaranteed to be NULL terminated. Drop the explicit > length check that comes with strncmp(). Is there anything wrong with that length check? I feel like it's a good practice to keep it anyway.

Re: [Mesa-dev] [PATCH 3/5] egl/android: remove droid_probe_driver()

Hi Emil, On Mon, Aug 13, 2018 at 11:48 PM Emil Velikov wrote: > > From: Emil Velikov > > The function name is misleading - it effectively checks if > loader_get_driver_for_fd fails. Which can happen only only on strdup > error - a close to impossible scenario. How about a DRI node which

Re: [Mesa-dev] ANDROID: eglCreateImageKHR missing modifiers

On Tue, Jul 24, 2018 at 10:25 PM Martin Fuzzey wrote: > > Hi Thomasz, > > thanks for your reply > > On 21/07/18 04:27, Tomasz Figa wrote: > > > > As you noticed, this adds back the dependency on gralloc handle > > structure. Moreover, it actually adds a

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

On Fri, Jul 27, 2018 at 6:52 AM Chad Versace wrote: > > On Wed 25 Jul 2018, Tomasz Figa wrote: > > Hi Chad, > > > > On Wed, Jul 25, 2018 at 10:11 AM Chad Versace > > wrote: > > > > > > Problem 1: u_debug_stack_android.cpp transitively included &g

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

Hi Chad, On Wed, Jul 25, 2018 at 10:11 AM Chad Versace wrote: > > Problem 1: u_debug_stack_android.cpp transitively included > "pipe/p_compiler.h", but src/gallium/include was missing from the C++ > include path. > > Problem 2: Add -std=c++11 to AM_CXXFLAGS. Android's libbacktrace headers >

Re: [Mesa-dev] ANDROID: eglCreateImageKHR missing modifiers

Hi Martin, On Sat, Jul 21, 2018 at 1:01 AM Martin Fuzzey wrote: > > Hi, > > I am testing mesa / etnaviv / gbm_gralloc under Android 8.1 on i.MX6 > > I discovered the screen capture function was not working (it was > producing empty buffers). > > The reason for this seems to be that

Re: [Mesa-dev] [PATCH v2 0/4] Android kms_swrast support

On Thu, Jul 19, 2018 at 12:08 AM Robert Foss wrote: > > Hey Rob, > > On 2018-07-18 15:30, Rob Herring wrote: > > On Tue, Jul 17, 2018 at 4:33 AM Robert Foss > > wrote: > >> > >> This series implements kms_swrast support for the Android > >> platform. And since having to debug a null pointer

Re: [Mesa-dev] [RFC 3/5] platform/android: Enable kms_swrast fallback

Hi Rob, On Thu, Jul 5, 2018 at 7:07 PM Robert Foss wrote: > > Add support for the ForceSoftware option, which is togglable > on the Android platform through setting the "drm.gpu.force_software" > property to a non-zero value. > > kms_swrast is also enabled as a fallback for when a driver is not

Re: [Mesa-dev] [RFC 2/5] egl/android: Add Android property for forcing kms_swrast

On Thu, Jul 5, 2018 at 7:07 PM Robert Foss wrote: > > In order to simplify Android bringup on new devices, > provide the property "drm.gpu.force_software" which > forces kms_swrast to be used. > > Signed-off-by: Robert Foss > --- > src/egl/main/egldriver.c | 10 ++ > 1 file changed, 10

Re: [Mesa-dev] [RFC 1/5] st/dri: Allow kms_swrast to work without a device FD

Hi Emil, Robert, On Thu, Jul 5, 2018 at 9:57 PM Emil Velikov wrote: > > On 5 July 2018 at 12:32, Robert Foss wrote: > > Hey Eric! > > > > On 05/07/18 12:35, Eric Engestrom wrote: > >> > >> On Thursday, 2018-07-05 12:07:36 +0200, Robert Foss wrote: > >>> > >>> From: Tomeu Vizoso > >>> > >>> A

Re: [Mesa-dev] [PATCH] gallium: Fix automake for Android

_LIBS) to the hunk in > src/gallium/auxiliary/Makefile.am, but the build no longer worked. > libEGL failed to link. Fair enough. Thanks. Reviewed-by: Tomasz Figa Best regards, Tomasz ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 3/3] egl/android: Add DRM node probing and filtering

Hi Rob, On Wed, Jun 20, 2018 at 10:26 PM Robert Foss wrote: > > This patch both adds support for probing & filtering DRM nodes > and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD > gralloc call. > > Currently the filtering is based just on the driver name, > and the desired name

Re: [Mesa-dev] [PATCH] gallium: Fix automake for Android

Hi Chad, On Tue, Jun 19, 2018 at 3:46 PM Chad Versace wrote: > > Chromium OS uses Autotools and pkg-config when building Mesa for > Android. The gallium drivers were failing to find the headers and > libraries for zlib and Android's libbacktrace. > --- > configure.ac | 6

Re: [Mesa-dev] [PATCH v3 2/3] egl/android: #ifdef out flink name support

y setting > BOARD_USES_DRM_GRALLOC=true in BoardConfig.mk. > > Signed-off-by: Rob Herring > Signed-off-by: Robert Foss > --- > > Changes since RFC: > - Instead of removing code, #ifdef it out. FWIW, Reviewed-by: Tomasz Figa Best regards, Tomasz ___

Re: [Mesa-dev] [PATCH v3 1/3] gallium/util: Fix build error due to cast to different size

) (uintptr_t)tid, > backtrace); > } else { >backtrace = (Backtrace *) backtrace_entry->data; > } > -- > 2.17.1 > FWIW, Reviewed-by: Tomasz Figa Best regards, Tomasz ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

Hi Rob, Thanks for sending v3. Please see few more comments inline. On Sun, Jun 10, 2018 at 2:28 AM Robert Foss wrote: > > This patch both adds support for probing & filtering DRM nodes > and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD > gralloc call. > > Currently the

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

On Thu, Jun 14, 2018 at 4:14 AM Rob Herring wrote: > > On Wed, Jun 13, 2018 at 12:19 PM, Amit Pundir wrote: > > On 13 June 2018 at 20:45, Rob Herring wrote: > >> > >> +Amit and John > >> > >> On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss > >> wrote: > >> > This patch both adds support for

Re: [Mesa-dev] [PATCH 0/3] egl/android: Remove dependencies on specific grallocs

On Sat, May 26, 2018 at 12:38 AM Rob Herring <r...@kernel.org> wrote: > On Fri, May 25, 2018 at 9:25 AM, Tomasz Figa <tf...@chromium.org> wrote: > > On Fri, May 25, 2018 at 10:59 PM Rob Herring <r...@kernel.org> wrote: > > > >> On Fri, May

Re: [Mesa-dev] [PATCH 0/3] egl/android: Remove dependencies on specific grallocs

On Fri, May 25, 2018 at 10:59 PM Rob Herring <r...@kernel.org> wrote: > On Fri, May 25, 2018 at 4:15 AM, Robert Foss <robert.f...@collabora.com> wrote: > > > > > > On 2018-05-25 10:38, Tomasz Figa wrote: > >> > >> On Fri, May 25, 2018 at 5:33 PM

Re: [Mesa-dev] [PATCH 0/3] egl/android: Remove dependencies on specific grallocs

On Fri, May 25, 2018 at 5:33 PM Robert Foss wrote: > Hey, > On 2018-05-25 02:17, Rob Herring wrote: > > On Thu, May 24, 2018 at 6:23 AM, Robert Foss wrote: > >> Hey, > >> > >> I don't think I've received any feedback on this version yet. >

Re: [Mesa-dev] [PATCH 0/3] egl/android: Remove dependencies on specific grallocs

Hi Rob, On Thu, May 24, 2018 at 8:23 PM Robert Foss wrote: > Hey, > I don't think I've received any feedback on this version yet. > If anyone has some time to spare, it would be nice to get it merged. Really sorry for taking so long to review. Posted my comments

Re: [Mesa-dev] [PATCH 3/3] egl/android: Add DRM node probing and filtering

Hi Rob, Finally got to review this. Please see my comments inline. On Fri, May 11, 2018 at 10:48 PM Robert Foss wrote: [snip] > +EGLBoolean > +droid_load_driver(_EGLDisplay *disp) Since this is not EGL-facing, I'd personally use bool. > +{ > + struct

Re: [Mesa-dev] [PATCH 2/3] egl/android: #ifdef out flink name support

Hi Rob, Sorry for late review. Had some really busy time. On Fri, May 11, 2018 at 10:48 PM Robert Foss wrote: [snip] > @@ -1230,20 +1256,26 @@ dri2_initialize_android(_EGLDriver *drv, _EGLDisplay *disp) > dri2_dpy->is_render_node =

Re: [Mesa-dev] [PATCH v1 1/2] egl/android: #ifdef out flink name support

On Tue, May 1, 2018 at 11:20 AM Rob Herring wrote: > On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss wrote: > > From: Rob Herring [snip] > > @@ -1228,20 +1254,31 @@ dri2_initialize_android(_EGLDriver *drv, _EGLDisplay *disp) > > > >

Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

Hi Min, On Sat, Apr 28, 2018 at 11:56 AM He, Min <min...@intel.com> wrote: > Hi, Tomasz > On 4/27/2018 5:01 PM, Tomasz Figa wrote: > > Hi Min, > > > > On Fri, Apr 27, 2018 at 11:36 AM Min He <min...@intel.com> wrote: > > > >> To avoid blockin

Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

Hi Min, On Fri, Apr 27, 2018 at 11:36 AM Min He wrote: > To avoid blocking other EGL calls, release the display mutex before > calling update_buffers(), which will call droid_window_dequeue_buffer(). > The lock appears like below: > 1. Consumer thread: updateTexImage() ->

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

Hi Rob, On Fri, Apr 27, 2018 at 12:43 PM Chih-Wei Huang wrote: > 2018-04-27 2:19 GMT+08:00 Robert Foss : > > > > I've spent some time today preparing a #ifdef version of what robher > > submitted. > > > > It's fine, but there is no way

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

On Tue, Apr 24, 2018 at 4:26 PM Robert Foss wrote: > Hey Chih-Wei, > On 04/23/2018 04:17 AM, Chih-Wei Huang wrote: > > What's the impact to drm_gralloc? > I'm not terribly familiar with drm_gralloc, but as far as I understand it > depends on flink name support at the

Re: [Mesa-dev] [RFC] egl/android: Add DRM node probing and filtering

On Fri, Apr 20, 2018 at 4:17 PM Robert Foss <robert.f...@collabora.com> wrote: > On 04/20/2018 06:41 AM, Tomasz Figa wrote: > > Hi Rob, > > > > On Thu, Apr 19, 2018 at 1:03 AM Robert Foss <robert.f...@collabora.com> > > wrote: > > > >> Th

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

; --- > With this plus Robert's probing patch, we remove any gralloc > implementation dependency (other than it has to be a pre 1.0 > implementation...). Big Acked-by: Tomasz Figa <tf...@chromium.org> from me. +/- 1 nit inline This relic of the past should have disappeared long ag

Re: [Mesa-dev] [RFC] egl/android: Add DRM node probing and filtering

Hi Rob, On Thu, Apr 19, 2018 at 1:03 AM Robert Foss wrote: > This patch both adds support for probing & filtering DRM nodes > and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD > gralloc call. > Currently the filtering is based just on the driver

Re: [Mesa-dev] Removing GRALLOC_MODULE_PERFORM_GET_DRM_FD

On Mon, Mar 26, 2018 at 9:45 PM, Robert Foss <robert.f...@collabora.com> wrote: > Hey, > > On 03/23/2018 06:21 PM, Emil Velikov wrote: >> >> On 23 March 2018 at 16:20, Tomasz Figa <tf...@chromium.org> wrote: >>> >>> On Sat, Mar 24, 2018

Re: [Mesa-dev] Removing GRALLOC_MODULE_PERFORM_GET_DRM_FD

On Sat, Mar 24, 2018 at 12:55 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 23 March 2018 at 13:15, Tomasz Figa <tf...@chromium.org> wrote: > >> >> Perhaps we could try to use drmOpenWithType() [2]. We could have one >> property that would be p

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Fri, Mar 23, 2018 at 10:15 PM, Stefan Schake <stsch...@gmail.com> wrote: > On Fri, Mar 23, 2018 at 1:02 PM, Tomasz Figa <tf...@chromium.org> wrote: >> On Fri, Mar 23, 2018 at 8:52 PM, Robert Foss <robert.f...@collabora.com> >> wrote: >>> Hey Chih-Wei

Re: [Mesa-dev] Removing GRALLOC_MODULE_PERFORM_GET_DRM_FD

On Fri, Mar 23, 2018 at 3:03 AM, Robert Foss <robert.f...@collabora.com> wrote: > Hey Tomasz, > > > On 03/22/2018 09:27 AM, Tomasz Figa wrote: >> >> Hi Stefan, >> >> On Thu, Mar 22, 2018 at 8:42 AM, Stefan Schake <stsch...@gmail.com> wrote: >>

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Fri, Mar 23, 2018 at 8:52 PM, Robert Foss <robert.f...@collabora.com> wrote: > Hey Chih-Wei, > > > On 03/23/2018 03:43 AM, Chih-Wei Huang wrote: >> >> 2018-03-22 16:23 GMT+08:00 Tomasz Figa <tf...@chromium.org>: >>> >>> Hi Chih-Wei, >>

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Fri, Mar 23, 2018 at 11:43 AM, Chih-Wei Huang <cwhu...@linux.org.tw> wrote: > 2018-03-22 16:23 GMT+08:00 Tomasz Figa <tf...@chromium.org>: >> Hi Chih-Wei, >> >> On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang <cwhu...@linux.org.tw> wrote: >&

Re: [Mesa-dev] Removing GRALLOC_MODULE_PERFORM_GET_DRM_FD

Hi Stefan, On Thu, Mar 22, 2018 at 8:42 AM, Stefan Schake wrote: > Hey Robert, > > On Wed, Mar 21, 2018 at 4:16 PM, Robert Foss > wrote: >> Hey, >> >> I've started looking into removing the gralloc method >> GRALLOC_MODULE_PERFORM_GET_DRM_FD. >>

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

Hi Chih-Wei, On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: > 2018-02-21 3:03 GMT+08:00 Rob Herring : >> >> Perhaps worth revisiting. Given we've failed to progress at all since >> then may change opinions some. We already have to handle multiple >>

Re: [Mesa-dev] Removing GRALLOC_MODULE_PERFORM_GET_DRM_FD

Hi Rob, On Thu, Mar 22, 2018 at 12:16 AM, Robert Foss wrote: > Hey, > > I've started looking into removing the gralloc method > GRALLOC_MODULE_PERFORM_GET_DRM_FD. Thanks a lot for looking into this. > > The issues around this seems to be two parts: > 1) Finding the

Re: [Mesa-dev] [PATCH v6 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

On Wed, Mar 21, 2018 at 12:58 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 20 March 2018 at 14:24, Tomasz Figa <tf...@chromium.org> wrote: >> On Tue, Mar 20, 2018 at 10:44 PM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>>

Re: [Mesa-dev] [PATCH v6 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

On Tue, Mar 20, 2018 at 10:44 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 20 March 2018 at 04:40, Tomasz Figa <tf...@chromium.org> wrote: >> On Tue, Mar 20, 2018 at 2:55 AM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>> Hi Lepton, &g

Re: [Mesa-dev] [PATCH v6 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

we can unmap them at right time. >> >> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> >> Reviewed-by: Tomasz Figa <tf...@chromium.org> >> Signed-off-by: Lepton Wu <lep...@chromium.org> > > Nit: normally it's a good idea to have brief revision lo

Re: [Mesa-dev] [PATCH v5 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

e included in upstream patches. > Signed-off-by: Lepton Wu <lep...@chromium.org> > --- > .../winsys/sw/kms-dri/kms_dri_sw_winsys.c | 44 +++ > 1 file changed, 36 insertions(+), 8 deletions(-) Other than that: Reviewed-by: Tomasz Figa <tf...@chromium.org&

Re: [Mesa-dev] [PATCH v3 2/2] gallium/winsys/kms: Add support for multi-planes

On Wed, Mar 7, 2018 at 7:43 AM, Lepton Wu wrote: > Add a new struct kms_sw_plane which delegate a plane and use it > in place of sw_displaytarget. Multiple planes share same underlying > kms_sw_displaytarget. > > Change-Id: I0e9ca1d0ba0aa78c27dfdb50c30dc0c424fec172 >

Re: [Mesa-dev] [PATCH v4 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

te: >> On 13 March 2018 at 11:46, Tomasz Figa <tf...@chromium.org> wrote: >>> On Thu, Mar 8, 2018 at 7:39 AM, Lepton Wu <lep...@chromium.org> wrote: >>>> If user calls map twice for kms_sw_displaytarget, the first mapped >>>> buffer could get leaked.

Re: [Mesa-dev] [PATCH v2] egl/android: Implement the eglSwapinterval for Android.

is * the maximum value supported by Android according to the value of * ANativeWindow::maxSwapInterval. */ I guess whoever committing this patch could just fix this up without a resend. With the above: Reviewed-by: Tomasz Figa <tf...@chromium.org> Best regards, Tomasz ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

On Thu, Mar 8, 2018 at 7:39 AM, Lepton Wu wrote: > If user calls map twice for kms_sw_displaytarget, the first mapped > buffer could get leaked. Instead of calling mmap every time, just > reuse previous mapping. Since user could map same displaytarget with > different flags,

Re: [Mesa-dev] [PATCH v4 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

On Tue, Mar 13, 2018 at 3:10 AM, Emil Velikov wrote: > On 12 March 2018 at 17:45, Lepton Wu wrote: >> Ping. Any more comments or missing stuff to get this commited into master? >> > As things have changed a bit (the original map/unmap behaviour is

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

018 at 10:01 AM, Emil Velikov <emil.l.veli...@gmail.com> > >> wrote: > >>> Hi all, > >>> > >>> Pardon for dropping in late. I think you've got nearly everything > >>> settled down, just sharing a couple of ideas. > >>> > >&

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Wed, Feb 21, 2018 at 4:03 AM, Rob Herring <r...@kernel.org> wrote: > On Tue, Feb 20, 2018 at 4:26 AM, Tomasz Figa <tf...@chromium.org> wrote: >> On Tue, Feb 20, 2018 at 6:51 PM, Robert Foss <robert.f...@collabora.com> >> wrote: >>> Hey Tomasz, >>

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Tue, Feb 20, 2018 at 6:51 PM, Robert Foss <robert.f...@collabora.com> wrote: > Hey Tomasz, > > On 02/20/2018 09:55 AM, Tomasz Figa wrote: >> >> Hi Rob, >> >> On Fri, Feb 16, 2018 at 11:48 PM, Tomasz Figa <tf...@chromium.org> wrote: >>> >&

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

Hi Rob, On Fri, Feb 16, 2018 at 11:48 PM, Tomasz Figa <tf...@chromium.org> wrote: > On Fri, Feb 16, 2018 at 11:33 PM, Robert Foss <robert.f...@collabora.com> > wrote: >> Hey Tomasz, >> >> >> On 02/16/2018 05:10 AM, Tomasz Figa wrote: >>>

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Fri, Feb 16, 2018 at 11:33 PM, Robert Foss <robert.f...@collabora.com> wrote: > Hey Tomasz, > > > On 02/16/2018 05:10 AM, Tomasz Figa wrote: >> >> On Fri, Feb 9, 2018 at 11:06 PM, Rob Herring <r...@kernel.org> wrote: >>> >>> On Fri, Feb 9, 2

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Fri, Feb 9, 2018 at 11:06 PM, Rob Herring <r...@kernel.org> wrote: > On Fri, Feb 9, 2018 at 3:58 AM, Tomasz Figa <tf...@chromium.org> wrote: >> On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa <tf...@chromium.org> wrote: >>> On Fri, Feb 2, 2018 at 11:00 PM,

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa <tf...@chromium.org> wrote: > On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring <r...@kernel.org> wrote: >> On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa <tf...@chromium.org> wrote: >>> Hi Rob, >>> >>>

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring <r...@kernel.org> wrote: > On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa <tf...@chromium.org> wrote: >> Hi Rob, >> >> On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss <robert.f...@collabora.com> >> wrote: >

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

Hi Rob, On Tue, Jan 30, 2018 at 9:36 PM, Robert Foss wrote: >> uint32_t (*get_fd)(buffer_handle_t handle, uint32_t plane); >> uint64_t (*get_modifier)(buffer_handle_t handle, uint32_t >> plane); >> uint32_t

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: Add support for multi-planes (v2)

On Tue, Jan 9, 2018 at 6:15 PM, Tomasz Figa <tf...@chromium.org> wrote: > Adding some folks on CC for broader distribution. > > On Tue, Jan 9, 2018 at 3:52 PM, Lepton Wu <lep...@chromium.org> wrote: >> Gentle ping. Thanks. >> >> On Wed, Dec 27, 2017 at 1

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

Hi Rob, On Tue, Jan 30, 2018 at 1:17 AM, Robert Foss wrote: > Hey Tomasz, > > I'm tempted to split this work into two parts. > 1) Move gbm gralloc struct Alright, if we look at this only as an attempt to converge gbm_ and drm_gralloc, it's out of my scope and no

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

Hi Robert, On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss wrote: > This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, > since at least 4 implementations exist, and share a lot of contents. > The idea is to keep the common stuff defined in one place, and

Re: [Mesa-dev] [egl/android: Implement the eglSwapinterval for Android] egl/android: Implement the eglSwapinterval for Android.

rg > Cc: Kondapally, Kalyan <kalyan.kondapa...@intel.com>; Palli, Tapani > <tapani.pa...@intel.com>; Xu, Randy <randy...@intel.com>; Long, Zhifang > <zhifang.l...@intel.com>; Wu, Zhongmin <zhongmin...@intel.com>; Rob Herring > <r...@kernel.org>; Tomasz Fig

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

On Tue, Jan 16, 2018 at 12:00 AM, Rob Herring wrote: > On Mon, Jan 15, 2018 at 7:09 AM, Robert Foss > wrote: >> Hey, >> >> On 01/13/2018 12:49 AM, Gurchetan Singh wrote: >>> >>> We can define accessor functions too (not ptrs), then the struct is

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

Hi Rob, On Fri, Jan 12, 2018 at 5:26 AM, Robert Foss <robert.f...@collabora.com> wrote: > Heya, > > > On 12/22/17 1:09 PM, Tomasz Figa wrote: >> >> On Fri, Dec 22, 2017 at 10:09 AM, Gurchetan Singh >> <gurchetansi...@chromium.org> wrote: >>>

Re: [Mesa-dev] [PATCH] gallium/winsys/kms: Add support for multi-planes (v2)

Adding some folks on CC for broader distribution. On Tue, Jan 9, 2018 at 3:52 PM, Lepton Wu <lep...@chromium.org> wrote: > Gentle ping. Thanks. > > On Wed, Dec 27, 2017 at 11:35 PM, Lepton Wu <lep...@chromium.org> wrote: >> v2: address comments from Tomasz Figa >&g

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

On Fri, Dec 22, 2017 at 10:09 AM, Gurchetan Singh wrote: > So the plan is for alloc_handle_t to not be sub-classed by the > implementations, but have all necessary information that an implementation > would need? > > If so, how do we reconcile the implementation

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

On Sat, Dec 2, 2017 at 4:43 AM, Rob Herring <r...@kernel.org> wrote: > On Fri, Dec 1, 2017 at 8:44 AM, Tomasz Figa <tf...@chromium.org> wrote: >> On Fri, Dec 1, 2017 at 11:20 PM, Rob Herring <r...@kernel.org> wrote: >>> On Fri, Dec 1, 2017 at 7:30 AM, Ro

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

apani.pa...@intel.co >>> m> wrote: >>> > >>> > >>> > On 11/30/2017 06:13 AM, Tomasz Figa wrote: >>> > > >>> > > On Thu, Nov 30, 2017 at 3:43 AM, Robert Foss <robert.foss@collabo >>> &g

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

>> > >> > On 11/27/2017 04:14 PM, Robert Foss wrote: >> > > >> > > From: Tomasz Figa <tf...@chromium.org> >> > > >> > > There is no API available to properly query the >> > > IMPLEMENTATION_DEFINED >> > > form

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

On Tue, Nov 28, 2017 at 11:27 PM, Rob Herring wrote: > On Tue, Nov 28, 2017 at 5:49 AM, Emil Velikov > wrote: >> On 28 November 2017 at 10:45, Tapani Pälli wrote: >>> Hi; >>> >>> >>> On 11/27/2017 04:14 PM, Robert Foss wrote: >

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

oss <robert.foss@collabora.c >> > om> wrote: >> > > From: Tomasz Figa <tf...@chromium.org> >> > > >> > > There is no API available to properly query the >> > > IMPLEMENTATION_DEFINED >> > > format. As a wor

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

On Tue, Nov 28, 2017 at 8:49 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 28 November 2017 at 10:45, Tapani Pälli <tapani.pa...@intel.com> wrote: >> Hi; >> >> >> On 11/27/2017 04:14 PM, Robert Foss wrote: >>> >>> From: Tomasz Fi

Re: [Mesa-dev] [PATCH] egl: refactor color_buffers structure for deduplicating (v2)

cro of HAVE_WAYLAND_PLATFORM from color_buffers structure > for more generic and widespread helpers. > d) drop unneeded $native_type -> void * cast and viceversa. > e) create the local native_buffer of $native_type and cast on assignment. > > Signed-off-by: Mun Gwan-gyeon

Re: [Mesa-dev] [PATCH] glsl: Allow precision mismatch on dead uniform with GLSL ES 1.00 (v3)

Hi Kenneth, On Tue, Nov 7, 2017 at 8:18 AM, Kenneth Graunke <kenn...@whitecape.org> wrote: > On Thursday, October 19, 2017 9:02:20 PM PST Tomasz Figa wrote: >> Hi Ian, Kenneth, >> >> On Wed, Sep 27, 2017 at 2:57 AM, Tomasz Figa <tf...@ch

Re: [Mesa-dev] [PATCH mesa] meson: wire up egl/android

Hi everyone, On Sat, Oct 28, 2017 at 2:38 AM, Dylan Baker <dy...@pnwbakers.com> wrote: > Whooo! Thanks for doing this! > > Quoting Eric Engestrom (2017-10-27 07:40:17) >> Cc: Rob Herring <r...@kernel.org> >> Cc: Tomasz Figa <tf...@chromium.org> >&g

Re: [Mesa-dev] [PATCH] glsl: Allow precision mismatch on dead uniform with GLSL ES 1.00 (v3)

Hi Ian, Kenneth, On Wed, Sep 27, 2017 at 2:57 AM, Tomasz Figa <tf...@chromium.org> wrote: > Commit 259fc505454ea6a67aeacf6cdebf1398d9947759 added linker error for > mismatching uniform precision, as required by GLES 3.0 specification and > conformance test-suite. > > Several

Re: [Mesa-dev] [PATCH] egl/dri2: Implement swapInterval fallback in a conformant way (v2)

On Wed, Sep 27, 2017 at 11:06 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 25 September 2017 at 08:25, Tomasz Figa <tf...@chromium.org> wrote: > >> Gentle ping. :) >> > > I forgot that you don't have commit access. Can you please apply for on

[Mesa-dev] [PATCH] glsl: Allow precision mismatch on dead uniform with GLSL ES 1.00 (v3)

a comment explaining the behavior. - Fix bad copy/paste in commit message (s/varyings/uniforms). v2: - Change the behavior only for GLSL ES 1.00 shaders. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97532 Signed-off-by: Tomasz Figa <tf...@chromium.org> --- src/com

Re: [Mesa-dev] [PATCH] glsl: Allow precision mismatch on dead data with GLSL ES 1.00

;> Looking at existing applications, 2) or 3) seems to be widely adopted. >> To avoid compatibility issues, turn the error into a warning if GLSL ES >> version is lower than 3.0 and the data is dead in at least one of the >> shaders. >> >> Bugzilla: https://bugs.f

  1   2   3   >