Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

On Sun 04 Jun 2017, Jason Ekstrand wrote: > On June 4, 2017 5:36:57 PM Kenneth Graunke wrote: > > > On Sunday, June 4, 2017 3:27:04 PM PDT Jason Ekstrand wrote: > > > How does the texture even have a format of MESA_FORMAT_NONE? That seems > > > like the first question to

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

On 06/06/2017 02:58 AM, Kenneth Graunke wrote: On Monday, June 5, 2017 2:03:45 AM PDT Tapani Pälli wrote: FWIW this change fixes also regression on Android wallpaper since that commit. I'm planning on dropping this patch, as it seems that commit 708664159e18487b6676fd5b4c33f52003f81d9e

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

Hi, On 06.06.2017 02:58, Kenneth Graunke wrote: On Monday, June 5, 2017 2:03:45 AM PDT Tapani Pälli wrote: FWIW this change fixes also regression on Android wallpaper since that commit. I'm planning on dropping this patch, as it seems that commit 708664159e18487b6676fd5b4c33f52003f81d9e

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

On Monday, June 5, 2017 2:03:45 AM PDT Tapani Pälli wrote: > FWIW this change fixes also regression on Android wallpaper since that > commit. I'm planning on dropping this patch, as it seems that commit 708664159e18487b6676fd5b4c33f52003f81d9e Author: Jason Ekstrand

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

I just pushed this patch: https://patchwork.freedesktop.org/patch/158551/ Which is the "correct" fix. I'll send out an ISL patch shortly that adds a bunch more asserts and should make this sort of thing easier to catch in the future. On Mon, Jun 5, 2017 at 2:55 AM, Eero Tamminen

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

Hi, On 04.06.2017 22:26, Kenneth Graunke wrote: Since commit e9f5004d5ea38a21019e0affcd63d353b98d499a, KDE's Plasma Shell started crashing when intel_disable_rb_aux_buffer tried to dereference irb->mt, and there was no miptree. This happened during intel_texture_view_requires_resolve, coming

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

FWIW this change fixes also regression on Android wallpaper since that commit. On 06/04/2017 10:26 PM, Kenneth Graunke wrote: Since commit e9f5004d5ea38a21019e0affcd63d353b98d499a, KDE's Plasma Shell started crashing when intel_disable_rb_aux_buffer tried to dereference irb->mt, and there was

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

On June 4, 2017 5:36:57 PM Kenneth Graunke wrote: On Sunday, June 4, 2017 3:27:04 PM PDT Jason Ekstrand wrote: How does the texture even have a format of MESA_FORMAT_NONE? That seems like the first question to ask. It's the window system buffer, and it actually has a

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

On Sunday, June 4, 2017 3:27:04 PM PDT Jason Ekstrand wrote: > How does the texture even have a format of MESA_FORMAT_NONE? That seems > like the first question to ask. It's the window system buffer, and it actually has a format of B8G8R8A8_UNORM_SRGB...my guess is just that _Format isn't set

Re: [Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

How does the texture even have a format of MESA_FORMAT_NONE? That seems like the first question to ask. On Sun, Jun 4, 2017 at 12:26 PM, Kenneth Graunke wrote: > Since commit e9f5004d5ea38a21019e0affcd63d353b98d499a, KDE's Plasma > Shell started crashing when

[Mesa-dev] [PATCH] i965: Don't try to resolve CCS with MESA_FORMAT_NONE.

Since commit e9f5004d5ea38a21019e0affcd63d353b98d499a, KDE's Plasma Shell started crashing when intel_disable_rb_aux_buffer tried to dereference irb->mt, and there was no miptree. This happened during intel_texture_view_requires_resolve, coming from a glClear(). Apparently intel_tex->_Format is