Re: [Mesa-dev] [PATCH 7/7] virgl: use hw-atomics instead of in-ssbo ones

2018-09-03 Thread Erik Faye-Lund
On ma., sep. 3, 2018 at 11:50 AM, andrey simiklit wrote: Hi, One more small think here: > +int virgl_encode_set_hw_atomic_buffers(struct virgl_context *ctx, > + unsigned start_slot, unsigned count, > + const struct

Re: [Mesa-dev] [PATCH 7/7] virgl: use hw-atomics instead of in-ssbo ones

2018-09-03 Thread Erik Faye-Lund
On fr., aug. 31, 2018 at 7:35 PM, Gurchetan Singh wrote: On Thu, Aug 30, 2018 at 6:41 AM Erik Faye-Lund wrote: From: Tomeu Vizoso Emulating atomics on top of ssbos can lead to too small max SSBO count, so let's use the hw-atomics mechanism to expose atomic buffers instead.

Re: [Mesa-dev] [PATCH 7/7] virgl: use hw-atomics instead of in-ssbo ones

2018-09-03 Thread andrey simiklit
Hi, One more small think here: > +int virgl_encode_set_hw_atomic_buffers(struct virgl_context *ctx, > + unsigned start_slot, unsigned count, > + const struct pipe_shader_buffer *buffers) > +{ > + int i; I believe that

Re: [Mesa-dev] [PATCH 7/7] virgl: use hw-atomics instead of in-ssbo ones

2018-08-31 Thread Gurchetan Singh
On Thu, Aug 30, 2018 at 6:41 AM Erik Faye-Lund wrote: > > From: Tomeu Vizoso > > Emulating atomics on top of ssbos can lead to too small max SSBO count, > so let's use the hw-atomics mechanism to expose atomic buffers instead. > > Signed-off-by: Erik Faye-Lund > --- >

[Mesa-dev] [PATCH 7/7] virgl: use hw-atomics instead of in-ssbo ones

2018-08-30 Thread Erik Faye-Lund
From: Tomeu Vizoso Emulating atomics on top of ssbos can lead to too small max SSBO count, so let's use the hw-atomics mechanism to expose atomic buffers instead. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_context.c | 37 ++