Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-10-10 Thread Axel Davy
On 10/10/2015 17:49, Marek Olšák wrote: On Sat, Oct 10, 2015 at 4:15 PM, Bas Nieuwenhuizen wrote: Hi Marek, The revised series is mostly done. I wanted to do more testing and to try to make sure that the added cache flushes I am doing now (a CACHE_FLUSH event before

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-10-10 Thread Marek Olšák
On Sat, Oct 10, 2015 at 6:12 PM, Axel Davy wrote: > On 10/10/2015 17:49, Marek Olšák wrote: >> >> On Sat, Oct 10, 2015 at 4:15 PM, Bas Nieuwenhuizen >> wrote: >>> >>> Hi Marek, >>> >>> The revised series is mostly done. I wanted to do more testing and

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-10-10 Thread Marek Olšák
On Sat, Oct 10, 2015 at 5:49 PM, Marek Olšák wrote: > On Sat, Oct 10, 2015 at 4:15 PM, Bas Nieuwenhuizen > wrote: >> Hi Marek, >> >> The revised series is mostly done. I wanted to do more testing and to >> try to make sure that the added cache flushes

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-10-10 Thread Bas Nieuwenhuizen
Hi Marek, The revised series is mostly done. I wanted to do more testing and to try to make sure that the added cache flushes I am doing now (a CACHE_FLUSH event before a fast clear and on switching framebuffers) are the minimal needed. > Also, it looks like we don't need DCC decompression at

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-10-10 Thread Marek Olšák
On Sat, Oct 10, 2015 at 4:15 PM, Bas Nieuwenhuizen wrote: > Hi Marek, > > The revised series is mostly done. I wanted to do more testing and to > try to make sure that the added cache flushes I am doing now (a > CACHE_FLUSH event before a fast clear and on switching

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-10-08 Thread Marek Olšák
Hi Bas, How's it going? I've gotten a response from Catalyst devs and they're saying CMASK is unnecessary here. If it's always cleared to 0xff, it's better to disable it to save some bandwidth. Also, it looks like we don't need DCC decompression at all, right? It might be better to get rid of

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-09-24 Thread Bas Nieuwenhuizen
Hi Marek, Thanks for the review and my apologies, it seems I underestimated the potential for regressions in this series. See below for some comments in reaction to the review. For a v2 is it preferred that I rebase it to master, or keep basing it on the old version? There are some function

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-09-24 Thread Marek Olšák
On Thu, Sep 24, 2015 at 2:15 PM, Bas Nieuwenhuizen wrote: > Hi Marek, > > Thanks for the review and my apologies, it seems I underestimated the > potential for regressions in this series. > > See below for some comments in reaction to the review. > > For a v2 is it

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-09-24 Thread Bas Nieuwenhuizen
On Thursday, September 24, 2015 07:24:50 PM Marek Olšák wrote: > On Thu, Sep 24, 2015 at 2:15 PM, Bas Nieuwenhuizen > > wrote: > > Hi Marek, > > > > Thanks for the review and my apologies, it seems I underestimated the > > potential for regressions in this series. > >

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-09-24 Thread Marek Olšák
On Thu, Sep 24, 2015 at 9:47 PM, Bas Nieuwenhuizen wrote: > On Thursday, September 24, 2015 07:24:50 PM Marek Olšák wrote: >> On Thu, Sep 24, 2015 at 2:15 PM, Bas Nieuwenhuizen >> >> wrote: >> > Hi Marek, >> > >> > Thanks for the review and my

Re: [Mesa-dev] [PATCH 3/8] radeonsi: Enable DCC.

2015-09-23 Thread Marek Olšák
On Fri, Sep 4, 2015 at 9:47 PM, Bas Nieuwenhuizen wrote: > The flags to be enabled in the control registers have been taken from > Catalyst traces. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/gallium/drivers/radeon/r600_pipe_common.h | 1