[Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

And apply relatives change to: vlVaBufferSetNumElements vlVaCreateBuffer vlVaMapBuffer vlVaUnmapBuffer vlVaDestroyBuffer vlVaPutImage It is unfortunate that there is no proper va buffer type and struct for this. Only possible to use VAImageBufferType which is normally used for normal user data

[Mesa-dev] [PATCH 2/2] st/va: add support to export a surface as dmabuf

I.e. implements: VaAcquireBufferHandle VaReleaseBufferHandle for memory of type VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME And apply relatives change to: vlVaMapBuffer vlVaUnMapBuffer vlVaDestroyBuffer Implementation inspired from cgit.freedesktop.org/vaapi/intel-driver Tested with gstreamer-vaapi

[Mesa-dev] [PATCH 0/2] vaapi: add support for dmabuf export

This 2 patches allow to derive a va surface as a va image. Which one can be exported as dmabuf by calling VaAcquireBufferHandle. I have tested these patches with gstreamer-vaapi and nouveau driver. The pipeline looks like: gstvaapidecode:(vasurface, NV12) -> gstvaapipostproc:(dmabuf, RGBA) ->

Re: [Mesa-dev] [PATCH v2 07/13] st/va: add headless support, i.e. VA_DISPLAY_DRM

+ drm_info = (struct drm_state *) ctx->drm_state; + if (!drm_info) { + FREE(drv); + return VA_STATUS_ERROR_INVALID_PARAMETER; + } + +#if GALLIUM_STATIC_TARGETS + drm_fd = drm_info->fd; +#else + drm_fd = dup(drm_info->fd); +#endif + + if (drm_fd < 0)

Re: [Mesa-dev] [PATCH v2 6/8] st/va: handle Video Post Processing for configs

On 22.10.2015 18:37, Julien Isorce wrote: Add support for VA_PROFILE_NONE and VAEntrypointVideoProc in the 4 following functions: vlVaQueryConfigProfiles vlVaQueryConfigEntrypoints vlVaCreateConfig vlVaQueryConfigAttributes Signed-off-by: Julien Isorce Reviewed-by:

[Mesa-dev] [PATCH 02/15] virgl: rename virgl.h to virgl_screen.h

Provide a more meaningful name considering it's purpose. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/Makefile.sources | 2 +- src/gallium/drivers/virgl/virgl.h | 51 -- src/gallium/drivers/virgl/virgl_context.c | 2

[Mesa-dev] [PATCH 12/15] winsys/virgl: always memset prior to ioctl

Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c index

[Mesa-dev] [PATCH 15/15] winsys/virgl: rework line wrapping/indent

Wrap some of the 'omg it's getting out of hand' long lines, and re-indent where things feel off. Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c| 83 --- .../winsys/virgl/vtest/virgl_vtest_socket.c| 13 ++-

[Mesa-dev] [PATCH 11/15] winsys/virgl: use MALLOC to match FREE

The uppercase versions are wrappers which must be matched. Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c

[Mesa-dev] [PATCH 13/15] winsys/virgl: remove temporary ret variable

Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c index

[Mesa-dev] [PATCH 10/15] winsys/virgl: remove calloc/malloc casts

Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 5 ++--- src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c

[Mesa-dev] [PATCH 07/15] virgl: use virgl_screen/surface upcast wrappers

Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_context.c | 2 +- src/gallium/drivers/virgl/virgl_encode.c | 4 ++-- src/gallium/drivers/virgl/virgl_encode.h | 5 + src/gallium/drivers/virgl/virgl_resource.c | 4 ++--

[Mesa-dev] [PATCH 05/15] virgl: add virgl_context/sampler_view/so_target() upcast wrappers

Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_buffer.c| 6 +- src/gallium/drivers/virgl/virgl_context.c | 98 ++--- src/gallium/drivers/virgl/virgl_context.h | 17 + src/gallium/drivers/virgl/virgl_encode.c| 2

[Mesa-dev] [PATCH 08/15] virgl: introduce virgl_query() inline wrapper

Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_query.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/virgl/virgl_query.c b/src/gallium/drivers/virgl/virgl_query.c index ea50f2f..b06635b 100644

[Mesa-dev] [PATCH 03/15] virgl: remove sw_winsys pointer from virgl_screen

The screen already has a pointer to the (base) winsys object. With the latter of which implemented/sub-classed as either drm or sw based one, depending on the target. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_public.h | 1 -

[Mesa-dev] [PATCH 04/15] winsys/virgl/drm: drop unneeded forward declaration

Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.h b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.h index eac1d3e..a547654 100644 ---

[Mesa-dev] [PATCH 06/15] virgl: introduce and use virgl_transfer/texture/resource inline wrappers

The only two remaining cases of (struct virgl_resource *) require a closer look. Either the error checking is missing or the arguments provided feel wrong. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_buffer.c| 2 +-

[Mesa-dev] [PATCH 09/15] winsys/virgl: throw in some inline wrappers

Signed-off-by: Emil Velikov --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 10 +- src/gallium/winsys/virgl/drm/virgl_drm_winsys.h | 14 ++ src/gallium/winsys/virgl/vtest/virgl_vtest_winsys.c | 10 +-

Re: [Mesa-dev] [RFC] i965: Resolve color for all active shader images in intel_update_state().

Francisco Jerez writes: > Chris Wilson writes: > >> On Sat, Oct 03, 2015 at 05:57:05PM +0300, Francisco Jerez wrote: >>> Jordan Justen writes: >>> >>> > From: Francisco Jerez >>> > >>> > Fixes

[Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

Hi Roland, Jose I wanted to bring a problem I found to your attention, and discuss about it and ways to solve it. I'm working on regressions of piglit gpu.py between x86-64 and ppc64le, when running with llvmpipe. One of the regressions manifests itself in 2 tests, clip-distance-bulk-copy and

Re: [Mesa-dev] [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.

On 29 October 2015 at 09:24, Ivan Kalvachev wrote: > On 10/29/15, Ilia Mirkin wrote: >> On Wed, Oct 28, 2015 at 8:52 PM, Ivan Kalvachev >> wrote: >>> I'm attaching v3 of the patch. Same as v2, but without the extra empty >>>

Re: [Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

Patch #1: + if (buf->data) + FREE(buf->data); FREE() usually does a NULL check anyway. Apart from that minor nitpick the patch is Reviewed-by: Christian König Regards, Christian. On 29.10.2015 12:47, Julien Isorce wrote: And apply relatives change to:

[Mesa-dev] [PATCH 14/15] virgl: unwrap the includes

Include what you want, rather than relying on a header foo.h N levels down the include chain, to provide something that you need. Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/virgl_buffer.c| 2 ++ src/gallium/drivers/virgl/virgl_context.c

[Mesa-dev] [PATCH 01/15] virgl: move virgl_hw.h into the driver dir

Strictly speaking virgl_hw.h should reside in the driver folder, as it describes the hardware. Moving it allows us to nuke the following strange dependency winsys/vtest > driver > winsys/drm Signed-off-by: Emil Velikov --- src/gallium/drivers/virgl/Makefile.sources

Re: [Mesa-dev] [PATCH 0/7] st/va: VPP, dmabuf import and headless.

Hi Julien, if Emil or Ilia have no further comments please send out your full set of patches once more I would like to get this pusched upstream. Best regards, Christian. On 17.10.2015 01:14, Julien Isorce wrote: This patch serie adds initial support for Video Post Processing. It also

Re: [Mesa-dev] [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.

Am 29.10.2015 um 10:24 schrieb Ivan Kalvachev: > Configuring smtp server is too much hassle for a single patch and I > would like to avoid writing my email credentials if possible. > If I'm about to send more patches, then I guess I would have to do that. You might want to look into "git

Re: [Mesa-dev] [PATCH v2 7/8] st/va: add colospace conversion through Video Post Processing

+if(src_surface->fence) { + screen->fence_finish(screen, src_surface->fence, PIPE_TIMEOUT_INFINITE); + screen->fence_reference(screen, _surface->fence, NULL); +} That shouldn't be necessary cause all render operations to the same surface are pipelined anyway. Regards,

[Mesa-dev] [PATCH] mesa: DispatchComputeIndirect should return INVALID_VALUE on unaligned

From: Marta Lofstedt From the ARB_compute_shader specification: "An INVALID_OPERATION error is generated [...] if is less than zero or not a multiple of the size, in basic machine units, of uint." However, OpenGL ES 3.1 specification, section 17 and OpenGL 4.5

Re: [Mesa-dev] [PATCH 2/2] st/va: add support to export a surface as dmabuf

@@ -108,6 +109,9 @@ vlVaMapBuffer(VADriverContextP ctx, VABufferID buf_id, void **pbuff) if (!buf) return VA_STATUS_ERROR_INVALID_BUFFER; + if (buf->export_refcount > 0) + return VA_STATUS_ERROR_INVALID_BUFFER; Why it is illegal to CPU map a buffer which is exported? +

Re: [Mesa-dev] [PATCH v2] st/mesa: fix mipmap generation for immutable textures with incomplete pyramids

On Wed, Oct 28, 2015 at 1:00 PM, Nicolai Hähnle wrote: > Without the clamping by NumLevels, the state tracker would reallocate the > texture storage (incorrect) and even fail to copy the base level image > after reallocation, leading to the graphical glitch of >

Re: [Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

Am 29.10.2015 um 12:27 schrieb Oded Gabbay: > Hi Roland, Jose > > I wanted to bring a problem I found to your attention, and discuss > about it and ways to solve it. > > I'm working on regressions of piglit gpu.py between x86-64 and > ppc64le, when running with llvmpipe. > > One of the

[Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

This was causing compilation issues when one of its providers wasn’t already included before gbm.h. --- src/gbm/main/gbm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gbm/main/gbm.h b/src/gbm/main/gbm.h index 2708e50..8db2153 100644 --- a/src/gbm/main/gbm.h +++ b/src/gbm/main/gbm.h @@

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

Hi Emmanuel, On 29 October 2015 at 15:22, Emmanuel Gil Peyrot wrote: > This was causing compilation issues when one of its providers wasn’t > already included before gbm.h. Cc: "11.0" Reviewed-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] st/va: add support to export a surface as dmabuf

-Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 12:29 To: Julien Isorce; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 2/2] st/va: add support to export a surface as dmabuf > @@ -108,6 +109,9 @@

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Always try to enable GL_ARB_sample_shading

On Thu, Oct 22, 2015 at 2:34 AM, Neil Roberts wrote: > Previously this extension was only enabled when blitting between two > multisampled buffers. However I don't think it does any harm to just > enable it all the time. The ‘enable’ option is used instead of > ‘require’ so

Re: [Mesa-dev] [PATCH v2 7/8] st/va: add colospace conversion through Video Post Processing

Ack. I confirm it still works without it. So I'll remove it. Thx -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 14:02 To: Julien Isorce; mesa-dev@lists.freedesktop.org Cc: emil.l.veli...@gmail.com Subject: Re: [Mesa-dev] [PATCH v2 7/8]

[Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

This patch allows to use gallium vaapi without requiring a X server running for your second graphic card. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/Makefile.am | 9 src/gallium/state_trackers/va/context.c | 70 --- 2

[Mesa-dev] [PATCH v4 6/9] st/va: add colospace conversion through Video Post Processing

Add support for VPP in the following functions: vlVaCreateContext vlVaDestroyContext vlVaBeginPicture vlVaRenderPicture vlVaEndPicture Add support for VAProcFilterNone in: vlVaQueryVideoProcFilters vlVaQueryVideoProcFilterCaps vlVaQueryVideoProcPipelineCaps Add

[Mesa-dev] [PATCH v4 2/9] st/va: do not destroy old buffer when new one failed

If formats are not the same vlVaPutImage re-creates the video buffer with the right format. But if the creation of this new video buffer fails then the surface looses its current buffer. Let's just destroy the previous buffer on success. Signed-off-by: Julien Isorce ---

[Mesa-dev] [PATCH v4 5/9] st/va: handle Video Post Processing for configs

Add support for VA_PROFILE_NONE and VAEntrypointVideoProc in the 4 following functions: vlVaQueryConfigProfiles vlVaQueryConfigEntrypoints vlVaCreateConfig vlVaQueryConfigAttributes Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/config.c | 20

[Mesa-dev] [PATCH 1/2] gallium/radeon: always return the last SDMA fence on SDMA flush if needed

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 11 +++ src/gallium/drivers/radeon/r600_pipe_common.h | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c

[Mesa-dev] [PATCH 2/2] gallium/radeon: allow returning SDMA fences from pipe->flush

From: Marek Olšák pipe->flush never returned SDMA fences. This fixes it. This is only an issue on amdgpu where fences can signal out of order. --- src/gallium/drivers/radeon/r600_pipe_common.c | 64 +++ 1 file changed, 56 insertions(+), 8

Re: [Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

Ack. And I'll move this bit at the end just before the other FREE. Thx -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: 29 October 2015 12:22 To: Julien Isorce; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 1/2] st/va: implement

Re: [Mesa-dev] [PATCH 0/7] st/va: VPP, dmabuf import and headless.

Hi Christian, Ok I'll send all of it including last 2 patches about dmabuf export. I addressed all remarks already in my local branch and I did some round of testing, so it should be ok. Cheers Julien On 29 October 2015 at 12:10, Christian König wrote: > Hi Julien, >

[Mesa-dev] [PATCH v4 1/9] st/va: properly defines VAImageFormat formats and improve VaCreateImage

Also add RGBA, RGBX and BGRX. Also extend ChromaToPipe and implement PipeToYCbCr. Note that gstreamer-vaapi check all the VAImageFormat fields. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/image.c | 18 +++---

Re: [Mesa-dev] [PATCH v2 2/7] st/va: properly defines VAImageFormat formats and improve VaCreateImage

On 20 October 2015 at 17:34, Julien Isorce wrote: > static inline enum pipe_video_chroma_format > ChromaToPipe(int format) > { > switch (format) { > + case VA_RT_FORMAT_YUV400: > + return PIPE_VIDEO_CHROMA_FORMAT_400; Intentional ? We're barely handling it so

[Mesa-dev] [PATCH v4 9/9] st/va: add support to export a surface as dmabuf

I.e. implements: VaAcquireBufferHandle VaReleaseBufferHandle for memory of type VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME And apply relatives change to: vlVaMapBuffer vlVaUnMapBuffer vlVaDestroyBuffer Implementation inspired from cgit.freedesktop.org/vaapi/intel-driver Tested with gstreamer-vaapi

[Mesa-dev] [PATCH v4 4/9] st/va: implement dmabuf import for VaCreateSurfaces2

For now it is limited to RGBA, BGRA, RGBX, BGRX surfaces. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/surface.c | 97 - 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/surface.c

[Mesa-dev] [PATCH v4 3/9] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

Inspired from http://cgit.freedesktop.org/vaapi/intel-driver/ especially src/i965_drv_video.c::i965_CreateSurfaces2. This patch is mainly to support gstreamer-vaapi and tools that uses this newer libva API. The first advantage of using VaCreateSurfaces2 over existing VaCreateSurfaces, is that it

[Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

And apply relatives change to: vlVaBufferSetNumElements vlVaCreateBuffer vlVaMapBuffer vlVaUnmapBuffer vlVaDestroyBuffer vlVaPutImage It is unfortunate that there is no proper va buffer type and struct for this. Only possible to use VAImageBufferType which is normally used for normal user data

[Mesa-dev] [Bug 92645] kodi vdpau interop fails since mesa, meta: move gl_texture_object::TargetIndex initializations

https://bugs.freedesktop.org/show_bug.cgi?id=92645 Marek Olšák changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH] radeonsi: add ETC2 support for Stoney

From: Marek Olšák Untested. I don't have Stoney. --- src/gallium/drivers/radeonsi/si_state.c | 28 src/gallium/drivers/radeonsi/sid.h | 20 ++-- 2 files changed, 38 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] mesa/sso: Add compute shader support

On 2015-10-29 03:04:38, Iago Toral wrote: > On Thu, 2015-10-29 at 00:52 -0700, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/mesa/main/api_validate.c | 2 +- > > src/mesa/main/pipelineobj.c | 11 +++ > > 2 files changed, 12

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

Hi, On Thu, Oct 29, 2015 at 6:21 PM, Emil Velikov wrote: > On 29 October 2015 at 15:22, Emmanuel Gil Peyrot > wrote: >> This was causing compilation issues when one of its providers wasn’t >> already included before gbm.h. > Cc: "11.0"

Re: [Mesa-dev] [PATCH v4 1/9] st/va: properly defines VAImageFormat formats and improve VaCreateImage

@@ -80,12 +82,46 @@ YCbCrToPipe(unsigned format) ... +PipeToYCbCr(enum pipe_format p_format) You should probably rename those two functions as well, cause when we start to handle RGB formats as well the name doesn't match any more. BTW when do you use PipeToYCbCr? Regards, Christian. On

Re: [Mesa-dev] [PATCH v4 2/9] st/va: do not destroy old buffer when new one failed

On 29.10.2015 18:40, Julien Isorce wrote: If formats are not the same vlVaPutImage re-creates the video buffer with the right format. But if the creation of this new video buffer fails then the surface looses its current buffer. Let's just destroy the previous buffer on success. Signed-off-by:

Re: [Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

Am 29.10.2015 um 20:10 schrieb Oded Gabbay: > On Thu, Oct 29, 2015 at 9:02 PM, Ilia Mirkin wrote: >> On Thu, Oct 29, 2015 at 2:44 PM, Oded Gabbay wrote: >>> However, I would hate to keep the situation as is, meaning the test >>> passes on x86-64 and

Re: [Mesa-dev] i965: Invalid memory accesses after resizing brw_codegen's store table

On Thu, Oct 29, 2015 at 12:32 AM, Iago Toral wrote: > On Wed, 2015-10-28 at 10:58 -0700, Kristian Høgsberg wrote: >> On Wed, Oct 28, 2015 at 10:01:40AM +0100, Samuel Iglesias Gonsálvez wrote: >> > There is no opinions about this issue or reviews of the proposed patch >> > after

Re: [Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

Am 29.10.2015 um 19:44 schrieb Oded Gabbay: > On Thu, Oct 29, 2015 at 5:31 PM, Roland Scheidegger > wrote: >> Am 29.10.2015 um 12:27 schrieb Oded Gabbay: >>> Hi Roland, Jose >>> >>> I wanted to bring a problem I found to your attention, and discuss >>> about it and ways to

Re: [Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

Am 29.10.2015 um 20:33 schrieb Oded Gabbay: > On Thu, Oct 29, 2015 at 9:25 PM, Roland Scheidegger > wrote: >> Am 29.10.2015 um 20:10 schrieb Oded Gabbay: >>> On Thu, Oct 29, 2015 at 9:02 PM, Ilia Mirkin wrote: On Thu, Oct 29, 2015 at 2:44 PM, Oded

Re: [Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

On Thu, Oct 29, 2015 at 2:44 PM, Oded Gabbay wrote: > However, I would hate to keep the situation as is, meaning the test > passes on x86-64 and fails on ppc64le. Sounds like it'd actually be a difference between AVX and SSE4.2 as well -- what happens if you run on your

Re: [Mesa-dev] [PATCH v4 3/9] st/va: implement VaCreateSurfaces2 and VaQuerySurfaceAttributes

On 29 October 2015 at 17:40, Julien Isorce wrote: > + > +VAStatus > +vlVaCreateSurfaces2(VADriverContextP ctx, unsigned int format, > +unsigned int width, unsigned int height, > +VASurfaceID *surfaces, unsigned int num_surfaces, > +

Re: [Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

On Thu, Oct 29, 2015 at 9:02 PM, Ilia Mirkin wrote: > On Thu, Oct 29, 2015 at 2:44 PM, Oded Gabbay wrote: >> However, I would hate to keep the situation as is, meaning the test >> passes on x86-64 and fails on ppc64le. > > Sounds like it'd actually be

Re: [Mesa-dev] [PATCH v4 5/9] st/va: handle Video Post Processing for configs

On 29.10.2015 18:40, Julien Isorce wrote: Add support for VA_PROFILE_NONE and VAEntrypointVideoProc in the 4 following functions: vlVaQueryConfigProfiles vlVaQueryConfigEntrypoints vlVaCreateConfig vlVaQueryConfigAttributes Signed-off-by: Julien Isorce Reviewed-by:

Re: [Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

On Thu, Oct 29, 2015 at 5:31 PM, Roland Scheidegger wrote: > Am 29.10.2015 um 12:27 schrieb Oded Gabbay: >> Hi Roland, Jose >> >> I wanted to bring a problem I found to your attention, and discuss >> about it and ways to solve it. >> >> I'm working on regressions of piglit

Re: [Mesa-dev] [PATCH v4 4/9] st/va: implement dmabuf import for VaCreateSurfaces2

On 29.10.2015 18:40, Julien Isorce wrote: For now it is limited to RGBA, BGRA, RGBX, BGRX surfaces. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/surface.c | 97 - 1 file changed, 96 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] Problems with accuracy of coeffs_init + attribs_update

On Thu, Oct 29, 2015 at 9:25 PM, Roland Scheidegger wrote: > Am 29.10.2015 um 20:10 schrieb Oded Gabbay: >> On Thu, Oct 29, 2015 at 9:02 PM, Ilia Mirkin wrote: >>> On Thu, Oct 29, 2015 at 2:44 PM, Oded Gabbay wrote: However,

Re: [Mesa-dev] [PATCH v4 2/9] st/va: do not destroy old buffer when new one failed

Yes please. Thx Julien On 29 October 2015 at 19:12, Christian König wrote: > On 29.10.2015 18:40, Julien Isorce wrote: > >> If formats are not the same vlVaPutImage re-creates the video >> buffer with the right format. But if the creation of this new >> video buffer

Re: [Mesa-dev] [PATCH v2] st/mesa: fix mipmap generation for immutable textures with incomplete pyramids

On 29.10.2015 14:13, Marek Olšák wrote: On Wed, Oct 28, 2015 at 1:00 PM, Nicolai Hähnle wrote: Without the clamping by NumLevels, the state tracker would reallocate the texture storage (incorrect) and even fail to copy the base level image after reallocation, leading to the

Re: [Mesa-dev] [PATCH 00/15] virgl: misc cleanups and bikeshedding

On 29 October 2015 at 21:12, Emil Velikov wrote: > On 29 October 2015 at 11:12, Emil Velikov wrote: >> Hi all, >> >> A slightly longer series (that builds on top of the previous sent a >> minute ago), that moves/renames a couple of files, adds

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

On 10/27/2015 02:01 PM, samuel.pitoiset wrote: On 27/10/2015 12:52, Emil Velikov wrote: On 27 October 2015 at 10:50, samuel.pitoiset wrote: On 27/10/2015 11:37, Emil Velikov wrote: On 22 October 2015 at 00:16, Julien Isorce wrote: The

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

On Thu, Oct 29, 2015 at 11:28 PM, Emil Velikov wrote: > On 20 October 2015 at 17:40, Arnaud Vrac wrote: > > On Tue, Oct 20, 2015 at 6:35 PM, Emil Velikov > > wrote: > >> > >> On 20 October 2015 at 17:06, Julien Isorce

Re: [Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

Hi Julien, One can separate the errors checks and get those separately (+stable). I'll let others be the judge of that - I'm just going to point the sections I have in mind. On 29 October 2015 at 17:40, Julien Isorce wrote: > @@ -73,6 +76,10 @@

Re: [Mesa-dev] [PATCH v2 07/13] st/va: add headless support, i.e. VA_DISPLAY_DRM

On 29 October 2015 at 12:05, Christian König wrote: > >> + drm_info = (struct drm_state *) ctx->drm_state; >> + if (!drm_info) { >> + FREE(drv); >> + return VA_STATUS_ERROR_INVALID_PARAMETER; >> + } >> + >> +#if GALLIUM_STATIC_TARGETS >> +

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

On 20 October 2015 at 17:40, Arnaud Vrac wrote: > On Tue, Oct 20, 2015 at 6:35 PM, Emil Velikov > wrote: >> >> On 20 October 2015 at 17:06, Julien Isorce >> wrote: >> > >> > >> > On 19 October 2015 at 17:16, Emil Velikov

Re: [Mesa-dev] [PATCH] i965/nir: Mark const index UBO surfaces as used

On 2015-10-29 02:17:20, Iago Toral wrote: > On Thu, 2015-10-29 at 00:50 -0700, Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 6 -- > > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 6 -- > > 2

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

On Thu, Oct 29, 2015 at 10:15 AM, Grazvydas Ignotas wrote: > Hi, > > On Thu, Oct 29, 2015 at 6:21 PM, Emil Velikov > wrote: >> On 29 October 2015 at 15:22, Emmanuel Gil Peyrot >> wrote: >>> This was causing compilation

Re: [Mesa-dev] [PATCH] gbm.h: Add a missing stddef.h include for size_t.

On 29 October 2015 at 17:15, Grazvydas Ignotas wrote: > Hi, > > On Thu, Oct 29, 2015 at 6:21 PM, Emil Velikov > wrote: >> On 29 October 2015 at 15:22, Emmanuel Gil Peyrot >> wrote: >>> This was causing compilation

[Mesa-dev] [PATCH 1/2] [v3] i965/skl: Add GT4 PCI IDs

Like other gen8+ hardware, the hardware automatically scales up thread counts and URB sizes, so there is no need to do anything but add the PCI IDs. FINISHME: This patch still needs testing before merge. v2: Remove the PCI ID removal. That should be done as part of the next patch. v3: Update

[Mesa-dev] [PATCH] i965: Replace default case with list of enum values.

If we add a new file type, we'd like to get warnings if it's not handled. Unfortuately, gcc seems to have bugs (see the XXX). --- src/mesa/drivers/dri/i965/brw_fs.cpp | 16 +--- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 7 ---

[Mesa-dev] [PATCH] i965/vec4: Don't disable channels in any/all comparisons.

We've made a mistake in calling the Channel Enable bits "writemask", because they do more than control which channels of the destination are written -- they actually control which channels are enabled (surprise! surprise!) So, if we emit cmp.z.f0(8) null.xy<1>D g10<4,4,1>.xyzzD

[Mesa-dev] [PATCH] i965: Clean up FBH code.

It did a bunch of unnecessary stuff, emitting an extra MOV included. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 7 +++ src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 18 +- 2 files changed, 8 insertions(+), 17 deletions(-) diff --git

[Mesa-dev] Patchwork/mesa-stable question (was: Re: [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.)

On 29.10.2015 10:24, Ivan Kalvachev wrote: [snip] On 10/29/15, Nicolai Hähnle wrote: On 29.10.2015 01:52, Ivan Kalvachev wrote: On 10/26/15, Nicolai Hähnle wrote: On 25.10.2015 02:00, Ivan Kalvachev wrote: Some constants (like 1.0 and 0.5) could be

Re: [Mesa-dev] Patchwork/mesa-stable question (was: Re: [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.)

On Thu, Oct 29, 2015 at 7:11 PM, Nicolai Hähnle wrote: > On 29.10.2015 10:24, Ivan Kalvachev wrote: > [snip] >> >> On 10/29/15, Nicolai Hähnle wrote: >>> >>> On 29.10.2015 01:52, Ivan Kalvachev wrote: On 10/26/15, Nicolai Hähnle

Re: [Mesa-dev] Patchwork/mesa-stable question (was: Re: [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.)

On Thu, Oct 29, 2015 at 4:23 PM, Ilia Mirkin wrote: > On Thu, Oct 29, 2015 at 7:11 PM, Nicolai Hähnle wrote: >> perhaps because it >> wasn't inline. Is this something to worry about? Specifically, I believe the >> patch is a candidate for the stable

Re: [Mesa-dev] [PATCH 7/7] st/va: add headless support, i.e. VA_DISPLAY_DRM

On 29 October 2015 at 23:04, Arnaud Vrac wrote: > On Thu, Oct 29, 2015 at 11:28 PM, Emil Velikov > wrote: >> >> On 20 October 2015 at 17:40, Arnaud Vrac wrote: >> > On Tue, Oct 20, 2015 at 6:35 PM, Emil Velikov

Re: [Mesa-dev] [PATCH v2] st/mesa: fix mipmap generation for immutable textures with incomplete pyramids

On 29 October 2015 at 22:56, Nicolai Hähnle wrote: > On 29.10.2015 14:13, Marek Olšák wrote: >> >> On Wed, Oct 28, 2015 at 1:00 PM, Nicolai Hähnle >> wrote: >>> >>> Without the clamping by NumLevels, the state tracker would reallocate the >>> texture

Re: [Mesa-dev] [PATCH] texgetimage: fix regression with shadow 1d array

> > What exactly are the parameters to glGetTextureSubImage() that hits this? It's actually a call to glGetnTexImage #4 0x772ce215 in get_tex_depth (ctx=0x9d03d0, dimensions=2, xoffset=0, yoffset=0, zoffset=0, width=65, height=1, depth=40, format=6402, type=5125, pixels=0xe32a10,

[Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

The OpenGLES GLSL 3.1 specification uses the precision qualifier ordering rules from ARB_shading_language_420pack. Signed-off-by: Jordan Justen --- src/glsl/glsl_parser.yy | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH] glsl: Add compute shader builtin variables for OpenGLES 3.1

Signed-off-by: Jordan Justen --- src/glsl/builtin_variables.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index a6ad105..00113d5 100644 --- a/src/glsl/builtin_variables.cpp +++

Re: [Mesa-dev] [PATCH] glsl: OpenGLES GLSL 3.1 precision qualifiers ordering rules

Would it make sense to just modify the has_420pack function? Or do you not want all of it? On Thu, Oct 29, 2015 at 3:47 AM, Jordan Justen wrote: > The OpenGLES GLSL 3.1 specification uses the precision qualifier > ordering rules from ARB_shading_language_420pack. > >

[Mesa-dev] [PATCH 1/2] mesa/sso: Add MESA_VERBOSE=api trace support

Signed-off-by: Jordan Justen --- src/mesa/main/pipelineobj.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index 51ee10f..c8c50fa 100644 --- a/src/mesa/main/pipelineobj.c

[Mesa-dev] [PATCH 2/2] mesa/sso: Add compute shader support

Signed-off-by: Jordan Justen --- src/mesa/main/api_validate.c | 2 +- src/mesa/main/pipelineobj.c | 11 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c index c59b6f3..46f39e7

Re: [Mesa-dev] [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier.

On 29.10.2015 01:52, Ivan Kalvachev wrote: -- Forwarded message -- From: Ivan Kalvachev Date: Wed, 28 Oct 2015 23:46:44 +0200 Subject: [PATCH v3] r600g: Fix special negative immediate constants when using ABS modifier. To: Nicolai Hähnle

[Mesa-dev] [PATCH 2/3] nvc0/ir: add support for PK2H/UP2H

Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 1 + .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 5 - .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 24 ++ 3 files changed, 29 insertions(+), 1

[Mesa-dev] [PATCH 1/3] gallium: document PK2H/UP2H

Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/tgsi.rst | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index 01e18f3..1d19db3 100644 ---

[Mesa-dev] [PATCH 3/3] st/mesa: use PK2H/UP2H when gs5 is supported

ARB_gpu_shader5 should be a decent proxy for whether those instructions are supported. Signed-off-by: Ilia Mirkin --- Not actually ready to be committed, since r600/radeonsi need support for these ops as well. Should be easy to implement, but want to get the OK before I do

Re: [Mesa-dev] [PATCH 3/3] st/mesa: use PK2H/UP2H when gs5 is supported

On Thu, Oct 29, 2015 at 2:52 AM, Ilia Mirkin wrote: > ARB_gpu_shader5 should be a decent proxy for whether those instructions > are supported. > > Signed-off-by: Ilia Mirkin > --- > > Not actually ready to be committed, since r600/radeonsi need support

[Mesa-dev] [PATCH] i965: Setup pull constant state for compute programs

Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/brw_state.h| 1 + src/mesa/drivers/dri/i965/brw_state_upload.c | 2 ++ src/mesa/drivers/dri/i965/gen7_cs_state.c| 32

[Mesa-dev] [PATCH] main/get: Add MAX_COMBINED_COMPUTE_UNIFORM_COMPONENTS

Signed-off-by: Jordan Justen --- src/mesa/main/get_hash_params.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index c295615..fbc7b8f 100644 --- a/src/mesa/main/get_hash_params.py +++

  1   2   >