Elie Tournier writes:
> Hi there,
>
> Great topic. For the past few days, I was looking at a CI for Mesa:
> https://gitlab.freedesktop.org/hopetech/tracie
> OK, it's in a very very alpha stage. ;)
I did one of those things using apitrace diff-images in piglit:
Rob Clark writes:
> On Thu, Jun 20, 2019 at 12:26 PM Eric Anholt wrote:
>
> (tbh I've not really played w/ renderdoc yet.. I should probably do so..)
>
>> - Mozilla folks tell me that firefox's WebRender display lists can be
>> captured in browser and then replayed from the WR repo under
https://bugs.freedesktop.org/show_bug.cgi?id=110983
Bug ID: 110983
Summary: [AMD TAHITI XT] vulkan dota2 broken
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity:
On 6/22/19 5:10 AM, Connor Abbott wrote:
> I haven't thought about whether it's algebraically correct, but
> otherwise your pattern looks fine to me.
I'll have a proof when I send out the patch. :)
> If you haven't noticed already, I added some commented out code to
> nir_replace_instr() that
gbm_{bo,surface}_create_with_modifiers is missing the usage flags. Add a new
function which lets library users specify it.
Signed-off-by: Simon Ser
---
src/gbm/main/gbm.c | 38 ++
src/gbm/main/gbm.h | 17 +
2 files changed, 55 insertions(+)
https://bugs.freedesktop.org/show_bug.cgi?id=110983
Sylvain BERTRAND changed:
What|Removed |Added
Resolution|--- |NOTOURBUG
Status|NEW
This doesn't handle Y-flipping, but it's good enough to render the stars
in Neverball.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 28 +-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git
A pretty basic implementation of half of point sprites. No coordinate
flipping (either from the FB transform or from the sprite coord key).
Probably room for optimizations. Just enough to make the stars show up
in neverball, basically.
Alyssa Rosenzweig (2):
panfrost: Track point sprites in
In preparation for lowering point sprites, track them like we track
alpha testing state.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 39 --
src/gallium/drivers/panfrost/pan_context.h | 3 ++
2 files changed, 39 insertions(+), 3
Fix this build error on Ubuntu 18.04.
/usr/bin/ld: src/util/libmesa_util.a(u_cpu_detect.c.o): undefined reference to
symbol 'pthread_once@@GLIBC_2.2.5'
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110663
Suggested-by: Eric Engestrom
Signed-off-by: Vinson Lee
---
Hi List,
I'd like to announce the availability of mesa 19.0.7. This is the last release
of the mesa 19.0 series, and all users are encouraged to migrate 19.1.x instead.
I'd like to apologize for the lateness of this release, in my defence I was on
vacation most of the 19.0.7 cycle and there were
r-b
On Mon, Jun 24, 2019 at 6:37 PM Samuel Pitoiset
wrote:
>
> This reduces the size of fill operations needed to clear CMASK
> for layered color textures.
>
> GFX9 unsupported for now.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_surface.c | 3 ++-
>
r-b for this patch only.
On Mon, Jun 24, 2019 at 5:00 PM Samuel Pitoiset
wrote:
>
> This fixes a rendering issue with RoTR/DXVK.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 32 +++-
> 1 file changed, 15 insertions(+), 17
sorry, totally missed that it was set in src/amd/common as well.
r-b for this patch too.
On Tue, Jun 25, 2019 at 2:17 AM Marek Olšák wrote:
>
> If the shader is monolithic, the value of SPI_PS_INPUT_ENA that is generated
> by LLVM is used as-is.
>
> Marek
>
> On Fri, Jun 21, 2019 at 7:03 PM
https://bugs.freedesktop.org/show_bug.cgi?id=77449
Bug 77449 depends on bug 98996, which changed state.
Bug 98996 Summary: Counter Strike: Global Offensive performance on Radeon
Polaris
https://bugs.freedesktop.org/show_bug.cgi?id=98996
What|Removed |Added
t-b
Dieter
Am 25.06.2019 02:12, schrieb Marek Olšák:
From: Marek Olšák
---
src/mesa/state_tracker/st_cb_drawpixels.c | 58 +++
1 file changed, 38 insertions(+), 20 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c
r-b
On Mon, Jun 24, 2019 at 12:14 PM Samuel Pitoiset
wrote:
>
> This reduces the size of fill operations needed to clear FMASK
> for layered color textures.
>
> GFX9 unsupported for now.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_surface.c | 1 +
>
On Mon, Jun 24, 2019 at 11:48 AM Eric Anholt wrote:
>
> Rob Clark writes:
>
> > On Thu, Jun 20, 2019 at 12:26 PM Eric Anholt wrote:
> >
> > (tbh I've not really played w/ renderdoc yet.. I should probably do so..)
> >
> >> - Mozilla folks tell me that firefox's WebRender display lists can be
On Mon, Jun 24, 2019 at 11:41:55AM -0700, Eric Anholt wrote:
> Elie Tournier writes:
>
> > Hi there,
> >
> > Great topic. For the past few days, I was looking at a CI for Mesa:
> > https://gitlab.freedesktop.org/hopetech/tracie
> > OK, it's in a very very alpha stage. ;)
>
> I did one of those
If the shader is monolithic, the value of SPI_PS_INPUT_ENA that is
generated by LLVM is used as-is.
Marek
On Fri, Jun 21, 2019 at 7:03 PM Bas Nieuwenhuizen
wrote:
> Doesn't this cause assertions in si_shader_ps() for monolithic
> shaders? Some of these assertions check that at least one bit in
why?
We should be regulating enabling it with S_028C70_DCC_ENABLE.
On Mon, Jun 24, 2019 at 5:00 PM Samuel Pitoiset
wrote:
>
> CB_DCC_BASE should be 0 if no DCC.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_device.c | 15 ---
> 1 file changed, 8 insertions(+), 7
From: Marek Olšák
---
src/mesa/state_tracker/st_cb_drawpixels.c | 58 +++
1 file changed, 38 insertions(+), 20 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_drawpixels.c
b/src/mesa/state_tracker/st_cb_drawpixels.c
index 59868d3ff1d..26d3cc33e5c 100644
---
https://bugs.freedesktop.org/show_bug.cgi?id=105171
Michel Dänzer changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
Hi
I used to build radeonsi drivers, like radeonsi_dri.so and
radeonsi_drv_video.so by autogen in old version mesa, but when I switch to
meson which is the only way to build mesa driver now, I find radeonsi_dri.so
can not be generated, I used this to build drivers:
meson
Hi
I used to build radeonsi drivers, like radeonsi_dri.so and
radeonsi_drv_video.so by autogen in old version mesa, but when I switch to
meson which is the only way to build mesa driver now, I find radeonsi_dri.so
can not be generated, I used this to build drivers:
meson
Thanks for the head-up Marek, I will update once I have hardware access.
On 6/21/19 7:33 PM, Marek Olšák wrote:
Gfx10 remembers sample positions in compressed Z/S memory, so the hw
doesn't need the decompress pass for shader loads.
Marek
On Wed, May 22, 2019 at 4:20 PM Marek Olšák
R-b
On Fri, Jun 21, 2019, 4:14 PM Samuel Pitoiset
wrote:
> This simple extension might be useful for debugging purposes.
> GAPID has support for it.
>
> Signed-off-by: Samuel Pitoiset
> ---
>
> A simple crucible test:
> https://gitlab.freedesktop.org/mesa/crucible/merge_requests/47
>
>
Should be LOCAL_EXPORT_C_INCLUDE_DIRS.
Signed-off-by: Chih-Wei Huang
---
src/gallium/winsys/virgl/common/Android.mk | 2 +-
src/mapi/Android.mk| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/winsys/virgl/common/Android.mk
Mauro Rossi 於 2019年6月15日 週六 下午1:39寫道：
>
> Fixes the following building errors and resolves Bug 110922
> Fixes gallium_dri target missing symbols at linking.
>
> external/mesa/src/gallium/winsys/virgl/drm/Android.mk:
> error: libmesa_winsys_virgl (STATIC_LIBRARIES android-x86_64) missing
>
On 2019-06-24 at 08:21, cloudwin wrote:
> Hi
> I used to build radeonsi drivers, like radeonsi_dri.so and
> radeonsi_drv_video.so by autogen in old version mesa, but when I switch
> to meson which is the only way to build mesa driver now, I find
> radeonsi_dri.so can not be generated, I used
> I think assertions should be limited to the most basic of sanity checks,
> and the other asserts replaced by proper error handling.
So, should I leave it as is and let us hit assertions that we fix?
Cheers
Rohan Garg
signature.asc
Description: This is a digitally signed message part.
https://bugs.freedesktop.org/show_bug.cgi?id=110970
--- Comment #1 from Philip Rebohle ---
This only seems to happen with LLVM 8. The capture replays fine for me with
latest LLVM 9.0-git.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the
This reduces the size of fill operations needed to clear FMASK
for layered color textures.
GFX9 unsupported for now.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_surface.c | 1 +
src/amd/common/ac_surface.h | 1 +
src/amd/vulkan/radv_cmd_buffer.c| 7
Hi,
On 20.6.2019 22.26, Eric Anholt wrote:
Hey folks, I wanted to show you this follow-on to shader-db I've been
working on:
https://gitlab.freedesktop.org/anholt/renderdoc-traces
For x86 development I've got a collection of ad-hoc scripts to capture
FPS numbers from various moderately
https://bugs.freedesktop.org/show_bug.cgi?id=109757
Eric Engestrom changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Hi there,
Great topic. For the past few days, I was looking at a CI for Mesa:
https://gitlab.freedesktop.org/hopetech/tracie
OK, it's in a very very alpha stage. ;)
My idea was to use apitrace to dump and replay traces then compare images with
reference
images or images dump the previous week.
This reduces the size of fill operations needed to clear CMASK
for layered color textures.
GFX9 unsupported for now.
Signed-off-by: Samuel Pitoiset
---
src/amd/common/ac_surface.c | 3 ++-
src/amd/common/ac_surface.h | 1 +
src/amd/vulkan/radv_cmd_buffer.c | 8 ---
On Mon, 24 Jun 2019 at 12:00, Rohan Garg wrote:
>
> > I think assertions should be limited to the most basic of sanity checks,
> > and the other asserts replaced by proper error handling.
>
> So, should I leave it as is and let us hit assertions that we fix?
Sorry, can you rephrase?
Thanks,
Maintain a list of panfrost supported GPU's and exit early when
running on a unsupported GPU.
Signed-off-by: Rohan Garg
---
src/gallium/drivers/panfrost/pan_screen.c | 15 +++
src/gallium/drivers/panfrost/pan_screen.h | 6 ++
2 files changed, 21 insertions(+)
diff --git
This fixes a rendering issue with RoTR/DXVK.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index
CB_DCC_BASE should be 0 if no DCC.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_device.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 26b31cff9f1..dc5de683050 100644
---
> +if (!supported_gpu) {
> +fprintf(stderr, "Unsupported GPU\n");
> +free(screen);
> +return NULL;
> +}
End users may see this. Is it better to silently fail or to print a
message that Panfrost isn't loaded (either way, the swrast
https://bugs.freedesktop.org/show_bug.cgi?id=110970
--- Comment #2 from kd-11 ---
Confirmed. Switched to padoka drivers which are llvm9 and the issue is not
present.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the
https://bugs.freedesktop.org/show_bug.cgi?id=110970
kd-11 changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Now that all the prerequisites breaking u_blitter are fixed, we can
finally hook up panfrost_blit.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_blit.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_blit.c
txf instructions can result from blits, so handle them rather than
crash. Only works for 2D textures (not even 2D array texture) due to a
register allocation constraint that may not be sorted for a while.
Signed-off-by: Alyssa Rosenzweig
---
.../panfrost/midgard/midgard_compile.c| 41
Now the autogeneration of mipmaps is working (via u_blitter), we can
finally enable mipmaps!
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
We need the flush from u_blitter for a normal blit (e.g. for mipmaps);
it's only wallpaper-related blits that are special-cased.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
As far as we know, Utgard-style tiling only works for color render
targets, not depth/stencil, so ensure we don't try to tile it (rather
than compress or plain old linear) and drive ourselves into a corner.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_resource.c | 3 +++
To avoid interference with the wallpaper code, we need to do some state
tracking when generating mipmaps. In particular, we need to mark the
generated layers as invalid before generating the mipmap, so we don't
try to backblit them if they already had content.
Likewise, we need to flush both
We just implemented the routine; we may as well use it.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_blit.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_blit.c
b/src/gallium/drivers/panfrost/pan_blit.c
index
It doesn't make sense to try to render to multiple array elements at
once.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_mfbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/panfrost/pan_mfbd.c
b/src/gallium/drivers/panfrost/pan_mfbd.c
index
Allows for sharing some code as well as theoretically allowing cubemap
rendering.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 19 ---
src/gallium/drivers/panfrost/pan_mfbd.c | 11 +--
src/gallium/drivers/panfrost/pan_resource.c
Texturing is very broken, especially anywhere mipmapping is involved,
revolving around issues blitting and bugs with AFBC.
Let's fix this :)
Several hundred dEQP-GLES2 tests are now passing; see the updated
failures list at the end of the series.
Alyssa Rosenzweig (20):
panfrost: Disable
If a mipfilter is not set, it's legal to have an incomplete mipmap; we
should handle this accordingly. An "easy way out" is to rig the LOD
clamps.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 16
1 file changed, 16 insertions(+)
diff --git
Addresses the disparity between Mali and Gallium definitions of
array_size.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
Identify the seamless cubemap bit and passthrough the Gallium state
rather than setting unconditionally.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/include/panfrost-job.h | 5 +++--
src/gallium/drivers/panfrost/pan_context.c | 2 +-
A ton of tests were fixed by this series. A few were incorrectly passing
before (QualityError, for instance) and now are explicitly failing. A
few legitimate regressions but overwhelmingly positive.
Signed-off-by: Alyssa Rosenzweig
---
.../drivers/panfrost/ci/expected-failures.txt | 304
Let's match the blob. It's not clear what exactly this controls yet,
though.
Signed-off-by: Alyssa Rosenzweig
---
.../drivers/panfrost/midgard/midgard_compile.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
Fixes TILE_RANGE_FAULT raised on some tests in
dEQP-GLES3.functional.fbo.blit.*
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_fragment.c | 20
1 file changed, 20 insertions(+)
diff --git a/src/gallium/drivers/panfrost/pan_fragment.c
This is similar to the AFBC merge; now all (non-imported) buffers use a
common backing buffer. Reenables checksumming, eliminating a performance
regression.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 16 --
src/gallium/drivers/panfrost/pan_drm.c
The main ctx->blitter instance should be reserved for blits originated
from Gallium (like mipmap generation). Since wallpapering is
conceptually different -- wallpaper blits can be triggered by Gallium
blits -- the blitter pipes must be separate to avoid potential u_blitter
recursion.
I thought I already fixed this. Maybe that was a dream...? Then again, I
might be dreaming now.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pandecode/decode.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
Rather than tracking AFBC memory "specially", just use the same codepath
as linear and tiled. Less things to mess up, I figure. This allows us to
use the standard setup_slices() call with AFBC resources, allowing
mipmapped AFBC resources.
Unfortunately, we do have to disable AFBC (and
In a vertex shader, a tex op should map to txl, as there *must* be a LOD
given to the hardware (implicitly or explicitly).
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/midgard/midgard_compile.c | 8
1 file changed, 8 insertions(+)
diff --git
65 matches
Mail list logo
