Re: [Mesa-dev] [PATCH] st/mesa: Override blend factors involving alpha if it doesn't exist.

On Monday, August 27, 2018 6:18:21 PM PDT Marek Olšák wrote: > On Mon, Aug 27, 2018 at 5:55 PM, Kenneth Graunke > wrote: > > On Monday, August 27, 2018 11:05:19 AM PDT Marek Olšák wrote: > >> Yeah, this will be more complicated because it's per RT. > >> > >> I suggest adding a PIPE_CAP for the

[Mesa-dev] [PATCH] EGL/mesa: Initial writeup for MESA_query_renderer

--- docs/specs/EGL_MESA_query_renderer.txt | 58 ++ 1 file changed, 58 insertions(+) create mode 100644 docs/specs/EGL_MESA_query_renderer.txt diff --git a/docs/specs/EGL_MESA_query_renderer.txt b/docs/specs/EGL_MESA_query_renderer.txt new file mode 100644 index

Re: [Mesa-dev] [PATCH] st/mesa: Override blend factors involving alpha if it doesn't exist.

On Mon, Aug 27, 2018 at 5:55 PM, Kenneth Graunke wrote: > On Monday, August 27, 2018 11:05:19 AM PDT Marek Olšák wrote: >> Yeah, this will be more complicated because it's per RT. >> >> I suggest adding a PIPE_CAP for the hw capability to force DST_ALPHA >> to 0, and applying this workaround only

Re: [Mesa-dev] [PATCH] nir: Remove outdated comment

Reviewed-by: Jason Ekstrand On Mon, Aug 27, 2018 at 5:20 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > --- > > The move of comapre functions landed before the suggestion to remove > the comment, so removing it now. > > src/compiler/nir/nir_deref.c | 3 --- > 1 file

Re: [Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

On 27/08/18 22:20, Vadym Shovkoplias wrote: From: "vadym.shovkoplias" During intra stage linking some out variables can be dropped because it is not used in a shader with the main function. But these out vars can be referenced on later stages which can lead to further linking errors.

Re: [Mesa-dev] [PATCH 3/3] anv: Claim to support depthBounds for ID games

On Mon, Aug 27, 2018 at 12:50 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 23/08/2018 16:13, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_device.c | 9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/src/intel/vulkan/anv_device.c >

Re: [Mesa-dev] [PATCH] i965/gen7_urb: Re-emit PUSH_CONSTANT_ALLOC on GLK

On Mon, Aug 27, 2018 at 03:25:37PM -0700, Kenneth Graunke wrote: > On Monday, August 27, 2018 11:03:33 AM PDT Nanley Chery wrote: > > On Fri, Aug 24, 2018 at 05:46:44PM -0700, Nanley Chery wrote: > > > According to internal docs, some gen9 platforms have a pixel shader push > > > constant

Re: [Mesa-dev] [PATCH] i965/gen7_urb: Re-emit PUSH_CONSTANT_ALLOC on GLK

On Monday, August 27, 2018 11:03:33 AM PDT Nanley Chery wrote: > On Fri, Aug 24, 2018 at 05:46:44PM -0700, Nanley Chery wrote: > > According to internal docs, some gen9 platforms have a pixel shader push > > constant synchronization issue. Although not listed among said > > platforms, this issue

[Mesa-dev] [PATCH] nir: Remove outdated comment

--- The move of comapre functions landed before the suggestion to remove the comment, so removing it now. src/compiler/nir/nir_deref.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/compiler/nir/nir_deref.c b/src/compiler/nir/nir_deref.c index c8851688f9d..097ea8f1046 100644 ---

Re: [Mesa-dev] [PATCH v4 12/49] meson: don't build glx or dri by default on windows

Quoting Dylan Baker (2018-08-23 10:27:17) > Quoting Eric Engestrom (2018-08-23 10:13:17) > > On Wednesday, 2018-08-22 10:04:35 -0700, Dylan Baker wrote: > > > Signed-off-by: Dylan Baker > > > Reviewed-by: Eric Anholt > > > --- > > > meson.build | 8 ++-- > > > 1 file changed, 6

Re: [Mesa-dev] [PATCH 5/9] nir: Add a local dead write vars removal pass

(Disregard the incomplete mail, still adapting to notmuch-emacs). Jason Ekstrand writes: >> +static nir_deref_path * >> +get_path(struct state *state, nir_deref_instr *deref) >> +{ >> + struct hash_entry *entry = _mesa_hash_table_search(state->paths, >> deref); >> + if (!entry) { >> +

Re: [Mesa-dev] [PATCH] st/mesa: Override blend factors involving alpha if it doesn't exist.

On Monday, August 27, 2018 11:05:19 AM PDT Marek Olšák wrote: > Yeah, this will be more complicated because it's per RT. > > I suggest adding a PIPE_CAP for the hw capability to force DST_ALPHA > to 0, and applying this workaround only if the PIPE_CAP is 0. > > Marek I was thinking of applying

Re: [Mesa-dev] [PATCH 5/9] nir: Add a local dead write vars removal pass

Jason Ekstrand writes: > On Wed, Aug 15, 2018 at 4:57 PM Caio Marcelo de Oliveira Filho < > caio.olive...@intel.com> wrote: > >> Instead of doing this as part of the existing (local) copy prop vars >> pass. This is an intermediate step before changing both the dead >> write and the copy prop

Re: [Mesa-dev] [PATCH 6/9] nir: Make dead_write_vars pass global

Jason Ekstrand writes: > On Sat, Aug 25, 2018 at 9:40 AM Jason Ekstrand wrote: > >> Sorry I haven't given you any in-line review yet. I've been letting this >> pass simmer in my brain a bit and thinking about complexity and data >> structures. Here's a few questions for which I do not expect

Re: [Mesa-dev] [PATCH] intel: decoder: unify MI_BB_START field naming

Lionel, should we also include this in the stable queues ? On Tue, 2018-08-14 at 11:26 +0100, Lionel Landwerlin wrote: > The batch decoder looks for a field with a particular name to decide > whether an MI_BB_START leads into a second batch buffer level. Because > the names are different between

Re: [Mesa-dev] [PATCH] intel: decoder: handle 0 sized structs

Lionel, should we also include this in the stable queues ? On Sat, 2018-08-25 at 18:23 +0100, Lionel Landwerlin wrote: > Gen7.5 has a BLEND_STATE of size 0 which includes a variable length > group. We did not deal with that very well, leading to an endless > loop. > > Signed-off-by: Lionel

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

Vadym, should we also include this in the stable queues ? On Mon, 2018-08-20 at 16:31 +0300, vadym.shovkoplias wrote: > From Section 4.3.4 (Inputs) of the GLSL 1.50 spec: > > "Only the input variables that are actually read need to be written > by the previous stage; it is allowed to

[Mesa-dev] [PATCH] gallivm/radeonsi: allow to pass two swizzles into fetches.

From: Dave Airlie This hijacks the top 16-bits of swizzle, to pass in the swizzle for the second channel. This fixes handling .yx swizzles of 64-bit values. This should fixup radeonsi and llvmpipe. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107524 ---

[Mesa-dev] [PATCH 4/5 v2] i965/fs: Emit BRW_AOP_INC or BRW_AOP_DEC for imageAtomicAdd of +1 or -1

From: Ian Romanick v2: Refactor selection of atomic opcode to a separate function. Suggested by Jason. No changes on any other Intel platforms. Skylake total instructions in shared programs: 14304261 -> 14304241 (<.01%) instructions in affected programs: 1625 -> 1605 (-1.23%) helped: 4 HURT: 0

[Mesa-dev] [PATCH 2/5 v2] i965/fs: Emit BRW_AOP_INC or BRW_AOP_DEC for atomicAdd of +1 or -1

From: Ian Romanick Funny story... a single shader was hurt for instructions, spills, fills. That same shader was also the most helped for cycles. #GPUsAreWeird No changes on any other Intel platform. v2: Refactor selection of atomic opcode to a separate function. Suggested by Jason. Haswell,

Re: [Mesa-dev] [PATCH 2/5] i965/fs: Emit BRW_AOP_INC or BRW_AOP_DEC for atomicAdd of +1 or -1

On 08/26/2018 05:21 AM, Jason Ekstrand wrote: > On August 24, 2018 22:49:14 "Ian Romanick" wrote: > >> From: Ian Romanick >> >> Funny story... a single shader was hurt for instructions, spills, fills. >> That same shader was also the most helped for cycles.  #GPUsAreWeird >> >> No changes on

[Mesa-dev] [Bug 107698] Ubuntu 18.10 kernel 4.18rc1-4.18.6 or kernel 4.19rc1

https://bugs.freedesktop.org/show_bug.cgi?id=107698 --- Comment #3 from efeli...@yahoo.com --- When I boot ubuntu 18.10 with kernel 4.18rc1-4.18.6 or kernel 4.19rc1 , the result is black screen. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [Bug 107699] Account and Access request

https://bugs.freedesktop.org/show_bug.cgi?id=107699 --- Comment #1 from Sagar Ghuge --- Created attachment 141302 --> https://bugs.freedesktop.org/attachment.cgi?id=141302=edit SSH public Key -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

[Mesa-dev] [Bug 107699] Account and Access request

https://bugs.freedesktop.org/show_bug.cgi?id=107699 Bug ID: 107699 Summary: Account and Access request Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH v2] intel/tools: new i965_disasm tool

Hey Matt, Thanks for reviewing the patch. On 08/27/2018 11:06 AM, Matt Turner wrote: > On Mon, Aug 20, 2018 at 3:13 PM Sagar Ghuge wrote: >> >> Adds a new i965 instruction disassemble tool >> >> v2: 1) fix a few nits (Matt Turner) >> 2) Remove i965_disasm header (Matt Turner) >> >>

[Mesa-dev] [Bug 107655] X segfaults on startup in r300_dri.so, making system unusable

https://bugs.freedesktop.org/show_bug.cgi?id=107655 --- Comment #7 from mirh --- (In reply to Ilia Mirkin from comment #6) > The intention (and original function) was that this would be safe -- swr > would check for AVX support and load the relevant library (libAVX/libAVX2), > or bail on load. >

Re: [Mesa-dev] [PATCH 1/2] meson: Be a bit more helpful when arch or OS is unknown

Quoting Guido Günther (2018-08-27 09:32:54) > Hi, > On Mon, Aug 27, 2018 at 09:23:44AM -0700, Dylan Baker wrote: > > Quoting Guido Günther (2018-08-26 13:23:59) > > > V2: Add one missing @0@ > > > > > > Signed-off-by: Guido Günther > > > --- > > > meson.build | 21 ++--- > > > 1

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add radeonsi_zerovram driconfig option

On Fri, Aug 24, 2018 at 10:33 AM, Michel Dänzer wrote: > On 2018-08-24 1:06 p.m., Timothy Arceri wrote: >> More and more games seem to require this so lets make it a config >> option. >> --- >> src/gallium/drivers/radeonsi/driinfo_radeonsi.h | 1 + >>

Re: [Mesa-dev] [PATCH 4/4] radeonsi: enable radeonsi_zerovram for No Mans Sky

Reviewed-by: Marek Olšák Marek On Fri, Aug 24, 2018 at 7:06 AM, Timothy Arceri wrote: > --- > src/util/00-mesa-defaults.conf | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/util/00-mesa-defaults.conf b/src/util/00-mesa-defaults.conf > index ad59efba50b..5d15b3819fb 100644 >

Re: [Mesa-dev] [PATCH 2/4] radeonsi: enable GL 4.5 in compat profile

Reviewed-by: Marek Olšák BTW, this is conditional on ARB_direct_state_access being implemented properly. Marek On Fri, Aug 24, 2018 at 7:06 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_get.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/4] mesa: enable ARB_direct_state_access in compat for GL3.1+

_mesa_VertexArrayVertexBuffer_no_error crashes if vaobj == 0. _mesa_VertexArrayVertexBuffer doesn't have this issue. Marek On Fri, Aug 24, 2018 at 7:06 AM, Timothy Arceri wrote: > We could enable it for lower versions of GL but this allows us > to just use the existing version/extension checks

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: allow GL_UNSIGNED_BYTE type for SNORM reads

Reviewed-by: Marek Olšák Marek On Mon, Aug 27, 2018 at 7:46 AM, Tapani Pälli wrote: > OpenGL ES spec states: >"For normalized fixed-point rendering surfaces, the combination format > RGBA and type UNSIGNED_BYTE is accepted." > > This fixes following failing VK-GL-CTS tests: > >

Re: [Mesa-dev] [PATCH] st/mesa: Disable blending for integer formats.

Reviewed-by: Marek Olšák Marek On Sat, Aug 25, 2018 at 3:19 AM, Kenneth Graunke wrote: > Blending isn't valid for integer formats. Rather than having drivers > worry about this, just disable blending in this case. This hopefully > will increase hits in the CSO cache as well, by eliminating

Re: [Mesa-dev] [PATCH v2] intel/tools: new i965_disasm tool

On Mon, Aug 20, 2018 at 3:13 PM Sagar Ghuge wrote: > > Adds a new i965 instruction disassemble tool > > v2: 1) fix a few nits (Matt Turner) > 2) Remove i965_disasm header (Matt Turner) > > Signed-off-by: Sagar Ghuge > --- > src/intel/Makefile.tools.am | 14 +++ >

Re: [Mesa-dev] [PATCH] st/mesa: Override blend factors involving alpha if it doesn't exist.

Yeah, this will be more complicated because it's per RT. I suggest adding a PIPE_CAP for the hw capability to force DST_ALPHA to 0, and applying this workaround only if the PIPE_CAP is 0. Marek On Sat, Aug 25, 2018 at 10:46 AM, Ilia Mirkin wrote: > You have to make sure to flip

Re: [Mesa-dev] [PATCH] i965/gen7_urb: Re-emit PUSH_CONSTANT_ALLOC on GLK

On Fri, Aug 24, 2018 at 05:46:44PM -0700, Nanley Chery wrote: > According to internal docs, some gen9 platforms have a pixel shader push > constant synchronization issue. Although not listed among said > platforms, this issue seems to be present on the GeminiLake 2x6's we've > tested. > > We

Re: [Mesa-dev] [PATCH 3/3] anv: Claim to support depthBounds for ID games

On 23/08/2018 16:13, Jason Ekstrand wrote: --- src/intel/vulkan/anv_device.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 0357fc7c0ea..5a63592f7ca 100644 --- a/src/intel/vulkan/anv_device.c +++

Re: [Mesa-dev] [PATCH v3] intel/eu: print bytes instead of 32 bit hex value

Looks great! Reviewed-by: Matt Turner I'll push it shortly. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3] intel/eu: print bytes instead of 32 bit hex value

INTEL_DEBUG=hex prints 32 bit hex value and due to endianness of CPU byte order is reversed. In order to disassemble binary files, print each byte instead of 32 bit hex value. v2: Print blank spaces in order to vertically align output of compacted instructions hex value with uncompacted

[Mesa-dev] [Bug 107698] Ubuntu 18.10 kernel 4.18rc1-4.18.6 or kernel 4.19rc1

https://bugs.freedesktop.org/show_bug.cgi?id=107698 --- Comment #2 from Michel Dänzer --- This report is missing a description of the problem in prose. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 107698] Ubuntu 18.10 kernel 4.18rc1-4.18.6 or kernel 4.19rc1

https://bugs.freedesktop.org/show_bug.cgi?id=107698 efeli...@yahoo.com changed: What|Removed |Added CC||efeli...@yahoo.com --- Comment #1

[Mesa-dev] [Bug 107698] Ubuntu 18.10 kernel 4.18rc1-4.18.6 or kernel 4.19rc1

https://bugs.freedesktop.org/show_bug.cgi?id=107698 Bug ID: 107698 Summary: Ubuntu 18.10 kernel 4.18rc1-4.18.6 or kernel 4.19rc1 Product: Mesa Version: 18.2 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH 1/2] meson: Be a bit more helpful when arch or OS is unknown

Hi, On Mon, Aug 27, 2018 at 09:23:44AM -0700, Dylan Baker wrote: > Quoting Guido Günther (2018-08-26 13:23:59) > > V2: Add one missing @0@ > > > > Signed-off-by: Guido Günther > > --- > > meson.build | 21 ++--- > > 1 file changed, 14 insertions(+), 7 deletions(-) > > > > diff

Re: [Mesa-dev] [PATCH 1/2] meson: Be a bit more helpful when arch or OS is unknown

Quoting Guido Günther (2018-08-26 13:23:59) > V2: Add one missing @0@ > > Signed-off-by: Guido Günther > --- > meson.build | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/meson.build b/meson.build > index 1b3dfa221c9..c3a7e8cdd74 100644 > ---

Re: [Mesa-dev] Meson-windows v4: Potential path too long during zlib subproject build when using MsBuild backend

Quoting Liviu Prodea (2018-08-26 13:36:47) > See https://gitlab.freedesktop.org/dbaker/mesa/issues/1 for details. I think I saw something recently about this in the meson bug tracker, I'm following up with meson upstream and I'll get back to you. Dylan signature.asc Description: signature

[Mesa-dev] [Bug 107655] X segfaults on startup in r300_dri.so, making system unusable

https://bugs.freedesktop.org/show_bug.cgi?id=107655 --- Comment #6 from Ilia Mirkin --- The intention (and original function) was that this would be safe -- swr would check for AVX support and load the relevant library (libAVX/libAVX2), or bail on load. Something must have regressed in there

[Mesa-dev] [Bug 107655] X segfaults on startup in r300_dri.so, making system unusable

https://bugs.freedesktop.org/show_bug.cgi?id=107655 Michel Dänzer changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

From: "vadym.shovkoplias" During intra stage linking some out variables can be dropped because it is not used in a shader with the main function. But these out vars can be referenced on later stages which can lead to further linking errors. Bugzilla:

[Mesa-dev] [PATCH] mesa: allow GL_UNSIGNED_BYTE type for SNORM reads

OpenGL ES spec states: "For normalized fixed-point rendering surfaces, the combination format RGBA and type UNSIGNED_BYTE is accepted." This fixes following failing VK-GL-CTS tests: KHR-GLES3.packed_pixels.pbo_rectangle.rgba8_snorm KHR-GLES3.packed_pixels.rectangle.rgba8_snorm

Re: [Mesa-dev] [PATCH 4/4] virgl: add debug-switch to output TGSI

Am Montag, den 27.08.2018, 12:17 +0200 schrieb Erik Faye-Lund: > > On ma., aug. 27, 2018 at 9:49 AM, Gert Wollny com> wrote: > > Am Montag, den 20.08.2018, 14:10 +0200 schrieb Erik Faye-Lund: > > > This is quite useful for debugging shader-transpiling issues in > > > virglrenderer. > > Isn't

[Mesa-dev] [Bug 101247] Mesa fails to link GLSL programs with unused output blocks

https://bugs.freedesktop.org/show_bug.cgi?id=101247 --- Comment #3 from vadym --- Patch merged to master: commit 4a8444d5bc865119218eca8674e5614535f4829e (HEAD -> new_master, origin/master, origin/HEAD) Author: vadym.shovkoplias Date: Thu Aug 23 13:12:16 2018 +0300 glsl/linker: Allow

Re: [Mesa-dev] [PATCH 4/4] virgl: add debug-switch to output TGSI

On ma., aug. 27, 2018 at 9:49 AM, Gert Wollny wrote: Am Montag, den 20.08.2018, 14:10 +0200 schrieb Erik Faye-Lund: This is quite useful for debugging shader-transpiling issues in virglrenderer. Isn't this coverted by ST_DEBUG=tgsi? Ah, I wasn't even aware of this. There's one minor

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

On 27/08/18 12:08, Vadym Shovkoplias wrote: > I haven't got write permissions, so I'll appreciate if someone can > push it. > Thanks! Just done: https://gitlab.freedesktop.org/mesa/mesa/commit/4a8444d5bc865119218eca8674e5614535f4829e > > On Mon, Aug 27, 2018 at 12:52 PM, Alejandro Piñeiro >

Re: [Mesa-dev] [PATCH] egl/android: rework device probing

Hey, On 27/08/2018 11.47, Emil Velikov wrote: On 24 August 2018 at 18:55, Robert Foss wrote: Hey Emil, On 24/08/2018 14.21, Emil Velikov wrote: From: Emil Velikov Unlike the other platforms, here we aim do guess if the device that we somewhat arbitrarily picked, is supported or not. In

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

I haven't got write permissions, so I'll appreciate if someone can push it. Thanks! On Mon, Aug 27, 2018 at 12:52 PM, Alejandro Piñeiro wrote: > On 27/08/18 11:12, Vadym Shovkoplias wrote: > > Hi Timothy, Alejandro, Marek, > > Thanks for review! Can we merge the patch now ? > > > Yes, as soon

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

On 27/08/18 11:12, Vadym Shovkoplias wrote: > Hi Timothy, Alejandro, Marek, > > Thanks for review! Can we merge the patch now ? Yes, as soon as a patch gets a Rb, it can be pushed to master. Do you have write permissions to do it by yourself, or do you need someone of do that in your behalf? > >

Re: [Mesa-dev] [PATCH] egl/android: do not indent HAVE_DRM_GRALLOC preprocessor directive

On 24 August 2018 at 20:54, Mauro Rossi wrote: > Hi, > > Il giorno mer 15 ago 2018 alle ore 15:13 Mauro Rossi > ha scritto: >> >> Fixes: 3f7bca44d9 ("egl/android: #ifdef out flink name support") >> Fixes: c7bb82136b ("egl/android: Add DRM node probing and filtering") >> Signed-off-by: Mauro

Re: [Mesa-dev] [PATCH] egl/android: rework device probing

On 24 August 2018 at 18:55, Robert Foss wrote: > Hey Emil, > > > On 24/08/2018 14.21, Emil Velikov wrote: >> >> From: Emil Velikov >> >> Unlike the other platforms, here we aim do guess if the device that we >> somewhat arbitrarily picked, is supported or not. >> >> In particular: when a vendor

Re: [Mesa-dev] [PATCH] i965/batch: don't ignore the 'brw_new_batch' call for a 'new batch'

Hi all, It would be great if somebody look at this. I guess that this issue can affect every place where we use 'intel_batchbuffer_save_state/intel_batchbuffer_reset_to_saved' but only when the 'brw_batch_has_aperture_space' function returns false several times in a row. Pay attention that the

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

Hi Timothy, Alejandro, Marek, Thanks for review! Can we merge the patch now ? On Mon, Aug 27, 2018 at 6:08 AM, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > > > On 24/08/18 18:25, Alejandro Piñeiro wrote: > >> CCing Timothy just in case he still thinks that the original comment >>

[Mesa-dev] [PATCH v4 7/7] nir: add loop unroll support for complex wrapper loops

In GLSL IR we cheat with switch statements and simply convert them into loops with a single iteration. This allowed us to make use of the existing jump instruction handling provided by the loop handing code, it also allows dead code to be cleaned up once we have wrapped the code in a loop.

[Mesa-dev] [PATCH v4 3/7] nir: always attempt to find loop terminators

This will help later patches with unrolling loops that end with a break i.e. loops the always exit on their first interation. Reviewed-by: Jason Ekstrand --- src/compiler/nir/nir_loop_analyze.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH v4 5/7] nir/opt_loop_unroll: Remove unneeded phis if we make progress

Now that SSA values can be derefs and they have special rules, we have to be a bit more careful about our LCSSA phis. In particular, we need to clean up in case LCSSA ended up creating a phi node for a deref. This avoids validation issues with some CTS tests with the following patch, but its

[Mesa-dev] [PATCH v4 4/7] nir: add complex_loop bool to loop info

In order to be sure loop_terminator_list is an accurate representation of all the jumps in the loop we need to be sure we didn't encounter any other complex behaviour such as continues, nested breaks, etc during analysis. This will be used in the following patch. Reviewed-by: Jason Ekstrand ---

[Mesa-dev] [PATCH v4 2/7] nir: propagates if condition evaluation down some alu chains

v2: - only allow nir_op_inot or nir_op_b2i when alu input is 1. - use some helpers as suggested by Jason. shader-db IVB results: total instructions in shared programs: 9993483 -> 9993472 (-0.00%) instructions in affected programs: 1300 -> 1289 (-0.85%) helped: 11 HURT: 0 total cycles in

[Mesa-dev] [PATCH v4 6/7] nir: add loop unroll support for wrapper loops

This adds support for unrolling the classic do { // ... } while (false) that is used to wrap multi-line macros. GLSL IR also wraps switch statements in a loop like this. shader-db results IVB: total loops in shared programs: 2515 -> 2512 (-0.12%) loops in affected programs: 33

[Mesa-dev] [PATCH v4 1/7] nir: evaluate if condition uses inside the if branches

Since we know what side of the branch we ended up on we can just replace the use with a constant. All the spill changes in shader-db are from Dolphin uber shaders, despite some small regressions the change is clearly positive. V2: insert new constant after any phis in the

[Mesa-dev] [Bug 107524] Broken packDouble2x32 at llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=107524 --- Comment #8 from Matwey V. Kornilov --- (In reply to Dave Airlie from comment #6) > Created attachment 141293 [details] [review] > pass two swizzles into fetches. I've checked that the patch fixes the issue for llvm at my side. -- You are

Re: [Mesa-dev] [PATCH 3/4] virgl: introduce $VIRGL_DEBUG=verbose

Am Montag, den 20.08.2018, 14:10 +0200 schrieb Erik Faye-Lund: > This adds an environment-varaible that can be used for driver- variable With that patches 1-3 are Reviewed-By: Gert Wollny > specific flags, as well as a flag for it to enable verbose output. > > While we're at it, quiet some

Re: [Mesa-dev] [PATCH 4/4] virgl: add debug-switch to output TGSI

Am Montag, den 20.08.2018, 14:10 +0200 schrieb Erik Faye-Lund: > This is quite useful for debugging shader-transpiling issues in > virglrenderer. Isn't this coverted by ST_DEBUG=tgsi? Also, virglrenderer has a variable vrend_dump_shaders in vrend_renderer.c that enables dumping all the TGSI +

Re: [Mesa-dev] [PATCH 3/8] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

On Sun, Aug 26, 2018 at 11:54 PM Tapani Pälli wrote: > > > On 08/24/2018 05:04 PM, Jason Ekstrand wrote: > > On Fri, Aug 24, 2018 at 12:08 AM Tapani Pälli > > wrote: > > > > > > > > On 08/22/2018 05:18 PM, Jason Ekstrand wrote: > > > On Tue, Aug 21, 2018

[Mesa-dev] [PATCH 2/2] i965: Add INTEL_fragment_shader_ordering support.

From: Kevin Rogovin Adds suppport for INTEL_fragment_shader_ordering. We achieve the fragment ordering by using the same instruction as for beginInvocationInterlockARB() which is by issuing a memory fence via sendc. Signed-off-by: Kevin Rogovin --- docs/relnotes/18.3.0.html

[Mesa-dev] [PATCH 1/2] mesa: Add GL/GLSL plumbing for INTEL_fragment_shader_ordering.

From: Kevin Rogovin This extension provides new GLSL built-in function beginFragmentShaderOrderingIntel() that guarantees (taking wording of GL_INTEL_fragment_shader_ordering extension) that any memory transactions issued by shader invocations from previous primitives mapped to

[Mesa-dev] [PATCH 0/2] Implement INTEL_fragment_shader_ordering

From: Kevin Rogovin INTEL_fragment_shader_ordering provides the ability for shaders to issue a call to gaurnantee memory write operation ordering of overlapping pixels or samples. In contrast to ARB_fragment_shader_interlock, INTEL_fragment_shader_ordering instead of defining a critical region