[Mesa-dev] [PATCH] radv: don't expose linear depth surfaces on SI/CIK/VI either.

2018-08-30 Thread Dave Airlie
From: Dave Airlie ac_surface.c: gfx6_compute_surface says /* DB doesn't support linear layouts. */ Now if we expose linear depth and create a linear depth image and use CmdCopyImage to copy into it, we can't map the underlying memory and read it linearly which I think should work. ---

Re: [Mesa-dev] [PATCH] radeonsi: fix tess/gs fetchs for new swizzle.

2018-08-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Aug 30, 2018 at 7:29 PM, Dave Airlie wrote: > From: Dave Airlie > > I have piglit results from my machine, but I must have messed up, > and not built mesa in between properly. > > Fixes: bb17ae49ee2 (gallivm: allow to pass two swizzles into fetches.) >

Re: [Mesa-dev] [PATCH] radeonsi: fix regression in indirect input swizzles.

2018-08-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Aug 30, 2018 at 8:13 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes: > tests/spec/arb_enhanced_layouts/execution/component-layout/vs-fs-array-dvec3.shader_test > since I reworked the 64-bit swizzles. > > Fixes: bb17ae49ee2 (gallivm: allow to

Re: [Mesa-dev] [PATCH] mesa: ignore VAO IDs equal to 0 in glDeleteVertexArrays

2018-08-30 Thread Marek Olšák
Sadly, there are no tests for this. Marek On Thu, Aug 30, 2018 at 6:24 PM, Ian Romanick wrote: > This patch is > > Reviewed-by: Ian Romanick > > Is there a piglit test? I wonder how many other glDeleteFoo functions > mishandle the id=0 case. :( > > On 08/30/2018 12:16 PM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 7/7] radv: remove dead code in scan_shader_output_decl()

2018-08-30 Thread Dave Airlie
Assuming it all has no CTS regressions, and GTAV works. Reviewed-by: Dave Airlie for the series. On Thu, 30 Aug 2018 at 18:59, Samuel Pitoiset wrote: > > Never used. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_nir_to_llvm.c | 6 -- > 1 file changed, 6 deletions(-) > >

[Mesa-dev] [Bug 54805] gl_ClipVertex support horribly broken with software TNL

2018-08-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54805 Timothy Arceri changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] gallivm/radeonsi: allow to pass two swizzles into fetches.

2018-08-30 Thread Dave Airlie
On Fri., 31 Aug. 2018, 01:22 Michel Dänzer, wrote: > > On 2018-08-27 11:16 p.m., Dave Airlie wrote: > > From: Dave Airlie > > > > This hijacks the top 16-bits of swizzle, to pass in the swizzle > > for the second channel. > > > > This fixes handling .yx swizzles of 64-bit values. > > > > This

[Mesa-dev] [PATCH] radeonsi: fix regression in indirect input swizzles.

2018-08-30 Thread Dave Airlie
From: Dave Airlie This fixes: tests/spec/arb_enhanced_layouts/execution/component-layout/vs-fs-array-dvec3.shader_test since I reworked the 64-bit swizzles. Fixes: bb17ae49ee2 (gallivm: allow to pass two swizzles into fetches.) --- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 7

[Mesa-dev] [RFC] compiler: Move double_inputs to gl_program::DualSlotInputs

2018-08-30 Thread Jason Ekstrand
Previously, we had two field in shader_info: double_inputs_read and double_inputs. Presumably, the one was for all double inputs that are read and the other is all that exist. However, because nir_gather_info regenerates these two values, there is a possibility, if a variable gets deleted, that

[Mesa-dev] [Bug 107670] Massive slowdown under specific memcpy implementations (32bit, no-SIMD, backward copy).

2018-08-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107670 Timothy Arceri changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #8 from Timothy

[Mesa-dev] [Bug 107457] [Tracker] Mesa 18.2 release tracker

2018-08-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107457 Bug 107457 depends on bug 106865, which changed state. Bug 106865 Summary: [GLK] piglit.spec.ext_framebuffer_multisample.accuracy stencil tests fail https://bugs.freedesktop.org/show_bug.cgi?id=106865 What|Removed

[Mesa-dev] [Bug 106156] [TRACKER] Mesa 18.2 feature tracker

2018-08-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106156 Bug 106156 depends on bug 106865, which changed state. Bug 106865 Summary: [GLK] piglit.spec.ext_framebuffer_multisample.accuracy stencil tests fail https://bugs.freedesktop.org/show_bug.cgi?id=106865 What|Removed

Re: [Mesa-dev] [PATCH v2] i965/gen7_urb: Re-emit PUSH_CONSTANT_ALLOC on some gen9

2018-08-30 Thread Nanley Chery
On Thu, Aug 30, 2018 at 02:37:40PM -0700, Kenneth Graunke wrote: > On Wednesday, August 29, 2018 1:38:51 PM PDT Nanley Chery wrote: > > According to internal docs, some gen9 platforms have a pixel shader push > > constant synchronization issue. Although not listed among said > > platforms, this

[Mesa-dev] [PATCH] radeonsi: fix tess/gs fetchs for new swizzle.

2018-08-30 Thread Dave Airlie
From: Dave Airlie I have piglit results from my machine, but I must have messed up, and not built mesa in between properly. Fixes: bb17ae49ee2 (gallivm: allow to pass two swizzles into fetches.) --- src/gallium/drivers/radeonsi/si_shader.c | 13 - 1 file changed, 8 insertions(+), 5

Re: [Mesa-dev] [PATCH] mesa: ignore VAO IDs equal to 0 in glDeleteVertexArrays

2018-08-30 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick Is there a piglit test? I wonder how many other glDeleteFoo functions mishandle the id=0 case. :( On 08/30/2018 12:16 PM, Marek Olšák wrote: > From: Marek Olšák > > This fixes a firefox crash. > > Fixes: 781a78914c798dc64005b37c6ca1224ce06803fc > ---

[Mesa-dev] [PATCH 1/3] intel: aubinator: Adding missed platforms to the error message.

2018-08-30 Thread Rodrigo Vivi
Many new platforms got added to gen_device_name_to_pci_device_id() but the error message inside aubinator didn't reflected those changes. So syncing on the same order to be sure that we are not missing any now. Cc: Anuj Phogat Cc: Matt Turner Cc: Jordan Justen Signed-off-by: Rodrigo Vivi ---

[Mesa-dev] [PATCH 3/3] intel: Introducing Whiskey Lake platform

2018-08-30 Thread Rodrigo Vivi
Whiskey Lake uses the same gen graphics as Coffe Lake, including some ids that were previously marked as reserved on Coffe Lake, but that now are moved to WHL page. This follows the ids and approach used on kernel's commit b9be78531d27 ("drm/i915/whl: Introducing Whiskey Lake platform") Cc: José

[Mesa-dev] [PATCH 2/3] intel: Introducing Amber Lake platform

2018-08-30 Thread Rodrigo Vivi
Amber Lake uses the same gen graphics as Kaby Lake, including a id that were previously marked as reserved on Kaby Lake, but that now is moved to AML page. This follows the ids and approach used on kernel's commit e364672477a1 ("drm/i915/aml: Introducing Amber Lake platform") Reported-by: Timo

Re: [Mesa-dev] [PATCH v2] i965/gen7_urb: Re-emit PUSH_CONSTANT_ALLOC on some gen9

2018-08-30 Thread Kenneth Graunke
On Wednesday, August 29, 2018 1:38:51 PM PDT Nanley Chery wrote: > According to internal docs, some gen9 platforms have a pixel shader push > constant synchronization issue. Although not listed among said > platforms, this issue seems to be present on the GeminiLake 2x6's we've > tested. > > We

[Mesa-dev] [Bug 107765] [regression] Batman Arkham City crashes with DXVK under wine

2018-08-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107765 Bug ID: 107765 Summary: [regression] Batman Arkham City crashes with DXVK under wine Product: Mesa Version: 18.2 Hardware: Other OS: All

[Mesa-dev] [PATCH] mesa: ignore VAO IDs equal to 0 in glDeleteVertexArrays

2018-08-30 Thread Marek Olšák
From: Marek Olšák This fixes a firefox crash. Fixes: 781a78914c798dc64005b37c6ca1224ce06803fc --- src/mesa/main/arrayobj.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index a23031fe182..6e0665c0e5d 100644 ---

Re: [Mesa-dev] [PATCH] intel/nir: Lowering image loads and stores trashes all metadata

2018-08-30 Thread Jason Ekstrand
Thanks! On Thu, Aug 30, 2018 at 1:41 PM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Jason Ekstrand writes: > > > This fixes the GL_ARB_fragment_shader_interlock piglit test on gen8 > > platforms where the lack of metadata dirtying was causing another pass > > to

Re: [Mesa-dev] [PATCH] intel/nir: Lowering image loads and stores trashes all metadata

2018-08-30 Thread Caio Marcelo de Oliveira Filho
Jason Ekstrand writes: > This fixes the GL_ARB_fragment_shader_interlock piglit test on gen8 > platforms where the lack of metadata dirtying was causing another pass > to accidentally delete a much needed loop. > > Cc: Kenneth Graunke > https://bugs.freedesktop.org/show_bug.cgi?id=107745 >

[Mesa-dev] [PATCH] intel/nir: Lowering image loads and stores trashes all metadata

2018-08-30 Thread Jason Ekstrand
This fixes the GL_ARB_fragment_shader_interlock piglit test on gen8 platforms where the lack of metadata dirtying was causing another pass to accidentally delete a much needed loop. Cc: Kenneth Graunke https://bugs.freedesktop.org/show_bug.cgi?id=107745 Fixes: 37f7983bcca1 "intel/compiler: Do

Re: [Mesa-dev] [PATCH 5/7] gallium: add PIPE_CAP_MAX_COMBINED_HW_ATOMIC_COUNTER{S, _BUFFERS}

2018-08-30 Thread Wladimir J. van der Laan
On Thu, Aug 30, 2018 at 03:40:16PM +0200, Erik Faye-Lund wrote: > This moves the evergreen-specific max-sizes out as a driver-cap, so > other drivers with less strict requirements also can use hw-atomics. > > Remove ssbo_atomic as it's no longer needed. > > We should now be able to use

Re: [Mesa-dev] [PATCH 4/7] gallium: add PIPE_CAP_MAX_COMBINED_SHADER_BUFFERS

2018-08-30 Thread Wladimir J. van der Laan
On Thu, Aug 30, 2018 at 03:40:15PM +0200, Erik Faye-Lund wrote: > This gets rid of a r600 specific hack in the state-tracker, and prepares > for other drivers to be able to use hw-atomics. > > While we're at it, clean up some indentation in the various drivers. > > Signed-off-by: Erik Faye-Lund

[Mesa-dev] [Bug 107457] [Tracker] Mesa 18.2 release tracker

2018-08-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107457 Bug 107457 depends on bug 107223, which changed state. Bug 107223 Summary: [GEN9+] 50% perf drop in SynMark Fill* tests (E2E RBC gets disabled?) https://bugs.freedesktop.org/show_bug.cgi?id=107223 What|Removed

[Mesa-dev] [PATCH] pipe-loader: add a dup() in pipe_loader_sw_probe_kms

2018-08-30 Thread Emil Velikov
From: Emil Velikov The pipe_loader_release API closes the fd given, even if the pipe-loader should _not_ take ownership of it. With earlier commit we fixed pipe_loader_drm_probe_fd, and now with cover the final piece. Note that unlike the DRM case, here the caller _did_ forget to dup before

[Mesa-dev] [PATCH 2/4] u_vbuf: Fix leak

2018-08-30 Thread Ernestas Kulik
Reported by Coverity: data is heap-allocated, but only freed in the info->index_size != 0 branch. CID: 1438238 Signed-off-by: Ernestas Kulik --- src/gallium/auxiliary/util/u_vbuf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/util/u_vbuf.c

[Mesa-dev] [PATCH 4/4] vc4: Fix leak

2018-08-30 Thread Ernestas Kulik
Reported by Coverity: in the case where there exist hardware and non-hardware queries, the code does not jump to err_free_query and leaks the query. CID: 1430194 Signed-off-by: Ernestas Kulik --- src/gallium/drivers/vc4/vc4_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 3/4] v3d: Fix leak

2018-08-30 Thread Ernestas Kulik
Reported by Coverity: in the case of unsupported modifier request, the code does not jump to the “fail” label to destroy the acquired resource. CID: 1435704 Signed-off-by: Ernestas Kulik --- src/gallium/drivers/v3d/v3d_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 0/4] Coverity resource leak fixes

2018-08-30 Thread Ernestas Kulik
This patch series takes care of several reported resource leaks. Ernestas Kulik (4): glsl_to_tgsi: Fix potential leak u_vbuf: Fix leak v3d: Fix leak vc4: Fix leak src/gallium/auxiliary/util/u_vbuf.c| 1 + src/gallium/drivers/v3d/v3d_resource.c | 2 +-

[Mesa-dev] [PATCH 1/4] glsl_to_tgsi: Fix potential leak

2018-08-30 Thread Ernestas Kulik
Reported by Coverity: arr_live_ranges is freed in a different branch than the one in which it was allocated. CID: 1438391 Signed-off-by: Ernestas Kulik --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel: decoder: unify MI_BB_START field naming

2018-08-30 Thread Lionel Landwerlin
On 30/08/2018 16:23, Dylan Baker wrote: Quoting Lionel Landwerlin (2018-08-30 06:58:39) On 28/08/2018 17:01, Dylan Baker wrote: Quoting Lionel Landwerlin (2018-08-28 02:39:58) Yes, I think so. You asked on another commit too, both are related and this depends on other commits from Jason.

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: allow GL_UNSIGNED_BYTE type for SNORM reads

2018-08-30 Thread Dylan Baker
Quoting Tapani Pälli (2018-08-29 21:26:08) > > > On 08/29/2018 06:22 PM, Dylan Baker wrote: > > Quoting Tapani Pälli (2018-08-27 04:46:37) > >> OpenGL ES spec states: > >> "For normalized fixed-point rendering surfaces, the combination format > >> RGBA and type UNSIGNED_BYTE is

Re: [Mesa-dev] [PATCH] anv: blorp: support multiple aspect blits

2018-08-30 Thread Dylan Baker
Quoting Lionel Landwerlin (2018-08-30 06:42:06) > Newer blit tests are enabling depth blits. We currently don't > support it but can do by iterating over the aspects masks (copy some > logic from the CopyImage function). > > Signed-off-by: Lionel Landwerlin > Fixes: 9f44745eca0e41 ("anv: Use

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel: decoder: unify MI_BB_START field naming

2018-08-30 Thread Dylan Baker
Quoting Lionel Landwerlin (2018-08-30 06:58:39) > On 28/08/2018 17:01, Dylan Baker wrote: > > Quoting Lionel Landwerlin (2018-08-28 02:39:58) > >> Yes, I think so. You asked on another commit too, both are related and > >> this depends on other commits from Jason. > >> > >> Here is a list in order

[Mesa-dev] [PATCH] i965: Deny persistent mappings of incoherent GTT mmaps

2018-08-30 Thread Chris Wilson
On more recent HW, the indirect writes via the GGTT are internally buffered presenting a nuisance to trying to use them for persistent client maps. (We cannot guarantee that any write by the client will then be visible to either the GPU or third parties in a timely manner, leading to corruption.)

Re: [Mesa-dev] [PATCH] gallivm/radeonsi: allow to pass two swizzles into fetches.

2018-08-30 Thread Michel Dänzer
On 2018-08-27 11:16 p.m., Dave Airlie wrote: > From: Dave Airlie > > This hijacks the top 16-bits of swizzle, to pass in the swizzle > for the second channel. > > This fixes handling .yx swizzles of 64-bit values. > > This should fixup radeonsi and llvmpipe. > > Bugzilla:

[Mesa-dev] [PATCH] docs: update calendar to extended the 18.1 cycle by one more release

2018-08-30 Thread Andres Gomez
Due to having 2 additional RCs for 18.2. Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/release-calendar.html | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index

Re: [Mesa-dev] [PATCH V2] Check if the window is non-NULL before setting swap interval.

2018-08-30 Thread Emil Velikov
On 30 August 2018 at 11:41, Eric Engestrom wrote: > On Thursday, 2018-08-30 17:55:14 +0900, Tomasz Figa wrote: >> Hi Erik, Emil, Eric, >> >> On Tue, Jul 10, 2018 at 12:41 AM Erik Faye-Lund wrote: >> > >> > On Thu, Jul 5, 2018 at 7:02 PM Emil Velikov >> > wrote: >> > > >> > > On 5 July 2018 at

Re: [Mesa-dev] [RFC 00/10] Let us welcome EGLDevice

2018-08-30 Thread Mathias Fröhlich
Hi Emil, > Correct. We had a number of bugs (one of which breaking MT apps) that > makes me cautious. Working with environment variables basically is often asking for problems. The thread race condition ones being the most prominent. To overwrite something - especially for debugging - its ok to

Re: [Mesa-dev] [Mesa-stable] [PATCH] intel: decoder: unify MI_BB_START field naming

2018-08-30 Thread Lionel Landwerlin
On 28/08/2018 17:01, Dylan Baker wrote: Quoting Lionel Landwerlin (2018-08-28 02:39:58) Yes, I think so. You asked on another commit too, both are related and this depends on other commits from Jason. Here is a list in order of cherry picking : commit f430a37fa75f534c3a114b0ec546fa14f05f5da1

Re: [Mesa-dev] [PATCH] st/dri: use the FREE wrapper for the dri screen

2018-08-30 Thread Brian Paul
On 08/30/2018 07:32 AM, Eric Engestrom wrote: On Thursday, 2018-08-30 11:12:11 +0100, Emil Velikov wrote: From: Emil Velikov The memory is allocated with the uppercase wrapper. Tear down should match that. You're right, in dri2_init_screen() / dri_kms_init_screen(), but looking at the

[Mesa-dev] [PATCH] anv: blorp: support multiple aspect blits

2018-08-30 Thread Lionel Landwerlin
Newer blit tests are enabling depth blits. We currently don't support it but can do by iterating over the aspects masks (copy some logic from the CopyImage function). Signed-off-by: Lionel Landwerlin Fixes: 9f44745eca0e41 ("anv: Use blorp to implement VkBlitImage") Reviewed-by: Jason Ekstrand

[Mesa-dev] [PATCH 6/7] virgl: update minor differences to upstream header

2018-08-30 Thread Erik Faye-Lund
virgl_protocol.h is considered to have it's upstream in the virglrenderer repository, and somehow these minor differences has crept in. Let's sync with the upstream to avoid this. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_protocol.h | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 7/7] virgl: use hw-atomics instead of in-ssbo ones

2018-08-30 Thread Erik Faye-Lund
From: Tomeu Vizoso Emulating atomics on top of ssbos can lead to too small max SSBO count, so let's use the hw-atomics mechanism to expose atomic buffers instead. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_context.c | 37 ++

[Mesa-dev] [PATCH 5/7] gallium: add PIPE_CAP_MAX_COMBINED_HW_ATOMIC_COUNTER{S, _BUFFERS}

2018-08-30 Thread Erik Faye-Lund
This moves the evergreen-specific max-sizes out as a driver-cap, so other drivers with less strict requirements also can use hw-atomics. Remove ssbo_atomic as it's no longer needed. We should now be able to use hw-atomics for some stages and not for other, if needed. Signed-off-by: Erik

[Mesa-dev] [PATCH 1/7] st/mesa: use real bool for can_ubo

2018-08-30 Thread Erik Faye-Lund
We're doing full c99 now, so there's no point in using the old boolean type. Signed-off-by: Erik Faye-Lund --- This is not technically nessecary for the series, but IMO a nice cleanup nevertheless. src/mesa/state_tracker/st_extensions.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[Mesa-dev] [PATCH 4/7] gallium: add PIPE_CAP_MAX_COMBINED_SHADER_BUFFERS

2018-08-30 Thread Erik Faye-Lund
This gets rid of a r600 specific hack in the state-tracker, and prepares for other drivers to be able to use hw-atomics. While we're at it, clean up some indentation in the various drivers. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++

[Mesa-dev] [PATCH 2/7] st/mesa: clean up atomic vs ssbo code

2018-08-30 Thread Erik Faye-Lund
This makes the code a bit easier to follow; we first set up MaxShaderStorageBlocks, then we either set up a dedicated MaxAtomicBuffers, or we split MaxShaderStorageBlocks in two. While we're at it, also make the SSBO-splitting code tolerate the hypothetical case of having an odd number of SSBOs

[Mesa-dev] [PATCH 3/7] st/mesa: simplify MaxAtomicBufferSize-logic

2018-08-30 Thread Erik Faye-Lund
MaxAtomicCounters has already been assigned in the loop above in the ssbo_atomic = true case, so this will calculate the same value as the default. While we're at it, fixup indentation on the MaxAtomicBufferBindings assign. Signed-off-by: Erik Faye-Lund ---

[Mesa-dev] [PATCH 0/7] gallium/virgl: use hw-atomic buffers

2018-08-30 Thread Erik Faye-Lund
Here's a patch-series that cleans up some evergreen-specific gallium assumptions regarding hw-atomic buffers, as well as uses them on virgl to avoid reporting synthetically few SSBOs. The goal is really for gallium drivers to accrately report the exact amount of SSBOs and hw-atomic buffers they

Re: [Mesa-dev] [PATCH] st/dri: use the FREE wrapper for the dri screen

2018-08-30 Thread Eric Engestrom
On Thursday, 2018-08-30 11:12:11 +0100, Emil Velikov wrote: > From: Emil Velikov > > The memory is allocated with the uppercase wrapper. Tear down should > match that. You're right, in dri2_init_screen() / dri_kms_init_screen(), but looking at the history this used to be FREE() and Brian

Re: [Mesa-dev] [PATCH v2 4/5] gitlab-ci: update base + llvm images with scheduled pipelines

2018-08-30 Thread Emil Velikov
On 30 August 2018 at 11:41, Juan A. Suarez Romero wrote: > On Wed, 2018-08-29 at 14:16 +0100, Emil Velikov wrote: >> On 29 August 2018 at 11:12, Juan A. Suarez Romero >> wrote: >> > Use scheduled pipelines to update both the base and the LLVM images. >> > >> > This way allows to have an updated

Re: [Mesa-dev] [PATCH v2 1/5] gitlab-ci: build Mesa using GitLab CI

2018-08-30 Thread Emil Velikov
Hi Juan, Something I should have mentioned ealier: Pardon if my question are a bit rough - my rocker/docker experience is limited. On 30 August 2018 at 11:22, Juan A. Suarez Romero wrote: > On Wed, 2018-08-29 at 14:11 +0100, Emil Velikov wrote: >> Hi Juan, >> >> I've shared a number of

Re: [Mesa-dev] [RFC 00/10] Let us welcome EGLDevice

2018-08-30 Thread Emil Velikov
On 30 August 2018 at 10:54, Mathias Fröhlich wrote: > On Tuesday, 28 August 2018 16:22:33 CEST Emil Velikov wrote: >> > From a higher point of view the approach looks good. >> > >> > To sum up, you basically associate an _EGLDevice with each _EGLDisplay >> > where the _EGLDevice only contains the

[Mesa-dev] [PATCH v2] egl/wayland: do not leak wl_buffer when it is locked

2018-08-30 Thread Juan A. Suarez Romero
If color buffer is locked, do not set its wayland buffer to NULL; otherwise it can not be freed later. Rather, flag it in order to destroy it later on the release event. v2: instruct release event to unlock only or free wl_buffer too (Daniel) This also fixes

Re: [Mesa-dev] [PATCH v2] radv: fix passing clip/cull distances from VS to PS

2018-08-30 Thread Bas Nieuwenhuizen
okay, r-b with that. On Thu, Aug 30, 2018 at 1:39 PM Samuel Pitoiset wrote: > > > > On 8/30/18 12:30 PM, Bas Nieuwenhuizen wrote: > > On Wed, Aug 29, 2018 at 10:55 PM Samuel Pitoiset > > wrote: > >> > >> CTS doesn't test input clip/cull distances for the fragment > >> shader stage, which

Re: [Mesa-dev] [PATCH v2] radv: fix passing clip/cull distances from VS to PS

2018-08-30 Thread Samuel Pitoiset
On 8/30/18 12:30 PM, Bas Nieuwenhuizen wrote: On Wed, Aug 29, 2018 at 10:55 PM Samuel Pitoiset wrote: CTS doesn't test input clip/cull distances for the fragment shader stage, which explains why this was totally broken. I wrote a simple test locally that works now. This fixes a crash with

Re: [Mesa-dev] [PATCH v2 4/5] gitlab-ci: update base + llvm images with scheduled pipelines

2018-08-30 Thread Juan A. Suarez Romero
On Wed, 2018-08-29 at 14:16 +0100, Emil Velikov wrote: > On 29 August 2018 at 11:12, Juan A. Suarez Romero wrote: > > Use scheduled pipelines to update both the base and the LLVM images. > > > > This way allows to have an updated version of the base images even when > > the respect Rockerfiles

Re: [Mesa-dev] [PATCH V2] Check if the window is non-NULL before setting swap interval.

2018-08-30 Thread Eric Engestrom
On Thursday, 2018-08-30 17:55:14 +0900, Tomasz Figa wrote: > Hi Erik, Emil, Eric, > > On Tue, Jul 10, 2018 at 12:41 AM Erik Faye-Lund wrote: > > > > On Thu, Jul 5, 2018 at 7:02 PM Emil Velikov > > wrote: > > > > > > On 5 July 2018 at 17:17, Eric Engestrom wrote: > > > > On Thursday,

Re: [Mesa-dev] [PATCH v2] radv: fix passing clip/cull distances from VS to PS

2018-08-30 Thread Bas Nieuwenhuizen
On Wed, Aug 29, 2018 at 10:55 PM Samuel Pitoiset wrote: > > CTS doesn't test input clip/cull distances for the fragment > shader stage, which explains why this was totally broken. I > wrote a simple test locally that works now. > > This fixes a crash with GTA V and DXVK. > > Note that we are

Re: [Mesa-dev] [PATCH v2 1/5] gitlab-ci: build Mesa using GitLab CI

2018-08-30 Thread Juan A. Suarez Romero
On Wed, 2018-08-29 at 14:11 +0100, Emil Velikov wrote: > Hi Juan, > > I've shared a number of suggestions. I'll leave that to you if they > will be in v3 or patches on top. > > On 29 August 2018 at 11:12, Juan A. Suarez Romero wrote: > > > In order to build the images, Rocker is used. This is

[Mesa-dev] [PATCH] st/dri: use the FREE wrapper for the dri screen

2018-08-30 Thread Emil Velikov
From: Emil Velikov The memory is allocated with the uppercase wrapper. Tear down should match that. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/dri_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [RFC 00/10] Let us welcome EGLDevice

2018-08-30 Thread Mathias Fröhlich
On Tuesday, 28 August 2018 16:22:33 CEST Emil Velikov wrote: > > From a higher point of view the approach looks good. > > > > To sum up, you basically associate an _EGLDevice with each _EGLDisplay > > where the _EGLDevice only contains the meta information where to > > find the device and the

[Mesa-dev] [PATCH] radv: add missing support for protected memory properties

2018-08-30 Thread Samuel Pitoiset
Fixes Vulkan CTS CL#2849. Similar to the ANV driver. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 79dbbd886d..c300c88468 100644 ---

[Mesa-dev] [PATCH 2/7] radv: gather the output usage mask for clip/cull distances correctly

2018-08-30 Thread Samuel Pitoiset
It's a special case because both are combined into a single array. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader_info.c | 8 1 file changed, 8 insertions(+) diff --git a/src/amd/vulkan/radv_shader_info.c b/src/amd/vulkan/radv_shader_info.c index 5925fd924c..6262acb1a6

[Mesa-dev] [PATCH 5/7] radv: adjust the cull dist mask in scan_shader_output_decl()

2018-08-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index 0c7b238e10..069fb53b68 100644 --- a/src/amd/vulkan/radv_nir_to_llvm.c +++

[Mesa-dev] [PATCH 6/7] radv: remove radv_shader_context::num_output_{clips, culls}

2018-08-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index 069fb53b68..b2411fe38b 100644 --- a/src/amd/vulkan/radv_nir_to_llvm.c +++

[Mesa-dev] [PATCH 4/7] radv: get length of the clip/cull distances array from usage mask

2018-08-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 49 +-- 1 file changed, 40 insertions(+), 9 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index 17c76332e1..0c7b238e10 100644 ---

[Mesa-dev] [PATCH 3/7] radv: do not recompute the output usage mask for clipdist twice

2018-08-30 Thread Samuel Pitoiset
The shader info pass takes care of this now. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index d7cd8cc069..17c76332e1 100644

[Mesa-dev] [PATCH 7/7] radv: remove dead code in scan_shader_output_decl()

2018-08-30 Thread Samuel Pitoiset
Never used. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index b2411fe38b..af34c548c1 100644 --- a/src/amd/vulkan/radv_nir_to_llvm.c +++

[Mesa-dev] [PATCH 1/7] radv: add set_output_usage_mask() helper

2018-08-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader_info.c | 43 +++ 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/src/amd/vulkan/radv_shader_info.c b/src/amd/vulkan/radv_shader_info.c index a45c847c46..5925fd924c 100644 ---

Re: [Mesa-dev] [PATCH V2] Check if the window is non-NULL before setting swap interval.

2018-08-30 Thread Tomasz Figa
Hi Erik, Emil, Eric, On Tue, Jul 10, 2018 at 12:41 AM Erik Faye-Lund wrote: > > On Thu, Jul 5, 2018 at 7:02 PM Emil Velikov wrote: > > > > On 5 July 2018 at 17:17, Eric Engestrom wrote: > > > On Thursday, 2018-07-05 14:43:02 +0100, Emil Velikov wrote: > > >> On 5 July 2018 at 10:53, Eric

Re: [Mesa-dev] [PATCH] radv/meta: Set num_components on image_store intrinsics

2018-08-30 Thread Bas Nieuwenhuizen
On Thu, Aug 30, 2018 at 9:17 AM Samuel Pitoiset wrote: > > > > On 8/30/18 2:49 AM, Jason Ekstrand wrote: > > Now that image load/store intrinsics are variable-width, we need to set > > num_components accordingly. In 15d39f474b890, both glsl_to_nir and > > spirv_to_nir were updated to properly

Re: [Mesa-dev] [PATCH] radv/meta: Set num_components on image_store intrinsics

2018-08-30 Thread Samuel Pitoiset
On 8/30/18 2:49 AM, Jason Ekstrand wrote: Now that image load/store intrinsics are variable-width, we need to set num_components accordingly. In 15d39f474b890, both glsl_to_nir and spirv_to_nir were updated to properly set num_components but radv meta was left behind. Fixes: 15d39f474b890