[Mesa-dev] [PATCH 00/19] Substantially improve Midgard compiler

This series is dedicated to improving the Midgard compiler, specifically regarding the sections about indirect indexing and looping constructs. In the process, a number of orthogonal bugs/mysteries touched by these tests were fixed. The net result is that we are now passing all of:

[Mesa-dev] [PATCH 17/19] panfrost/midgard: Set integer mods

Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 38 ++- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index

[Mesa-dev] [PATCH 09/19] panfrost: Disable indirect outputs for now

The hardware needs this lowered anyway; for now, might as well use mesa's default lowering for pure conformance reasons. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 8 ++-- src/gallium/drivers/panfrost/pan_screen.c | 3 ++- 2

[Mesa-dev] [PATCH 02/19] panfrost/midgard: Pipe through varying arrays

Varying arrays sometimes are lowered to a series of directly accessed varyings (which we handled okay), but when indirectly accessed, they appear as a single array; we need to handle this as well. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 6

[Mesa-dev] [PATCH 08/19] panfrost/midgard: imul can only run on *mul

This restriction makes sense logically. Not sure why it wasn't obeyed before. In conjunction with previous commit's disclaimer, fixes dEQP-GLES2.functional.shaders.loop.for_dynamic_iterations.* Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/helpers.h | 2 +- 1 file

[Mesa-dev] [PATCH 04/19] panfrost/midgard: Respect component of bcsel condition

Fixes a bunch of non-vec4 indexing.varying_array tests. Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 29 ++- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c

[Mesa-dev] [PATCH 14/19] panfrost/midgard: Remove unused mir_next_block

Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index fcc17a5a092..539f8ca12bb

[Mesa-dev] [PATCH 05/19] panfrost/midgard: Remove useless MIR dump

Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index 1be96bc2eb9..f48e873a3f1 100644

[Mesa-dev] [PATCH 16/19] panfrost/midgard: Document sign-extension/zero-extension bits (vector)

For floating point ops, these bits determine the "negate?" and "abs?" modifiers. For integer ops, it turns out they control how sign/zero extension work, useful for mixing types. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/disassemble.c| 43 +++

[Mesa-dev] [PATCH 18/19] panfrost/midgard: Implement copy propagation

Most copy prop should occur at the NIR level, but we generate a fair number of moves implicitly ourselves, etc... long story short, it's a net win to also do simple copy prop + DCE on the MIR. As a bonus, this fixes the weird imov precision bug once and for good, I think. Signed-off-by: Alyssa

[Mesa-dev] [PATCH 07/19] panfrost/midgard: Don't try to inline constants on branches

Along with a corresponding fix to the move elimination pass (not included here yet -- I just have it disabled for now), this will fix dEQP-GLES2.functional.shaders.loops.for_uniform_iterations.* Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 3 +++

[Mesa-dev] [PATCH 11/19] panfrost/midgard: Dead code eliminate MIR

We reshuffle the existing "dead move elimination" pass into a generic dead code elimination layer, fixing bugs incurred with looping in the process. Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 25 --- 1 file changed, 10 insertions(+), 15

[Mesa-dev] [PATCH 12/19] panfrost/midgard: Track loop depth

This fixes nested loops. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/midgard_compile.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c

[Mesa-dev] [PATCH 19/19] panfrost/midgard: Optimize MIR in progress loop

Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/midgard_compile.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index

[Mesa-dev] [PATCH 03/19] panfrost/midgard: Implement indirect loads of varyings/UBOs

This adds preliminary support for indirect loads of varying arrays and uniform arrays, bringing a few new tests in shader.indexing.* to passing, although there remains a number of cases still missing. Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 90

[Mesa-dev] [PATCH 15/19] panfrost/midgard: Update integer op list

In the future, we might want to switch to a table-based approach, but for now, at least have it current. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/helpers.h| 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 01/19] panfrost/mdg/disasm: Print raw varying_parameters

The semantics of this field are not well understood; it is better to print it unconditionally along with the other unknown state, rather than silently eat the value. Without this change, some critical state was being lost in some shaders (notably, the offset for load/store scratchpad intructions

[Mesa-dev] [PATCH 10/19] panfrost: Use actual imov instruction

The bug this worked around is no longer applicable, it seems -- remove the hack that breaks more than it fixes. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 06/19] panfrost: Respect backwards branches in RA

Fixes a bunch of issues with looping. Honestly, I'm not sure why loops worked at all before. Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 83 +++ 1 file changed, 69 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH 13/19] panfrost/midgard: Fix off-by-one in successor analysis

This reduces register pressure substantially since we get smaller liveness ranges. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [Bug 110486] Power management

https://bugs.freedesktop.org/show_bug.cgi?id=110486 Bug ID: 110486 Summary: Power management Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority:

[Mesa-dev] [Bug 110486] Power management

https://bugs.freedesktop.org/show_bug.cgi?id=110486 --- Comment #1 from Mafia --- Created attachment 144065 --> https://bugs.freedesktop.org/attachment.cgi?id=144065=edit Power management -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 110485] Power management

https://bugs.freedesktop.org/show_bug.cgi?id=110485 Mafia changed: What|Removed |Added Attachment #144064|✿๓r.උrAƒ†✿.htm |â¿à¹r.à¶rAÆâ â¿.htm filename|

[Mesa-dev] [Bug 110485] Power management

https://bugs.freedesktop.org/show_bug.cgi?id=110485 --- Comment #2 from Mafia --- Created attachment 144064 --> https://bugs.freedesktop.org/attachment.cgi?id=144064=edit Power management -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 110485] Power management

https://bugs.freedesktop.org/show_bug.cgi?id=110485 --- Comment #1 from Mafia --- Created attachment 144063 --> https://bugs.freedesktop.org/attachment.cgi?id=144063=edit Power management -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 110485] Power management

https://bugs.freedesktop.org/show_bug.cgi?id=110485 Bug ID: 110485 Summary: Power management Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority:

[Mesa-dev] [Bug 110484] Power management

https://bugs.freedesktop.org/show_bug.cgi?id=110484 Bug ID: 110484 Summary: Power management Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority:

Re: [Mesa-dev] [PATCH v2] [Panfrost] Adds Bifrost shader disassembler utility

Hooray! Excited to see this in tree. Reviewed-by: Alyssa Rosenzweig I'll push this when I get a chance to sanity check (probably tomorrow) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 110480] vkcube renders too brightly on radv

https://bugs.freedesktop.org/show_bug.cgi?id=110480 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEW

[Mesa-dev] [PATCH v3 6/6] glsl/linker: check for xfb_offset aliasing

From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: " No aliasing in output buffers is allowed: It is a compile-time or link-time error to specify variables with overlapping transform feedback offsets." Currently, this is expected to fail, but it succeeds: " ...

[Mesa-dev] [Bug 110480] vkcube renders too brightly on radv

https://bugs.freedesktop.org/show_bug.cgi?id=110480 --- Comment #5 from Alexander Tsoy --- (In reply to Bas Nieuwenhuizen from comment #4) > 1) which vkcube did you use and where did you get it from? It's vkcube from vulkan-tools: https://github.com/KhronosGroup/Vulkan-Tools -- You are

[Mesa-dev] [Bug 110480] vkcube renders too brightly on radv

https://bugs.freedesktop.org/show_bug.cgi?id=110480 --- Comment #4 from Bas Nieuwenhuizen --- Created attachment 144058 --> https://bugs.freedesktop.org/attachment.cgi?id=144058=edit vkcube radv vs. amdvlk side by side See the attachment, for me the colors are equal. Can I ask 1) which

[Mesa-dev] [Bug 110480] vkcube renders too brightly on radv

https://bugs.freedesktop.org/show_bug.cgi?id=110480 --- Comment #3 from osch...@web.de --- Created attachment 144057 --> https://bugs.freedesktop.org/attachment.cgi?id=144057=edit nvidia -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 110480] vkcube renders too brightly on radv

https://bugs.freedesktop.org/show_bug.cgi?id=110480 --- Comment #2 from osch...@web.de --- Created attachment 144056 --> https://bugs.freedesktop.org/attachment.cgi?id=144056=edit amdvlk -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 110480] vkcube renders too brightly on radv

https://bugs.freedesktop.org/show_bug.cgi?id=110480 --- Comment #1 from osch...@web.de --- Created attachment 144055 --> https://bugs.freedesktop.org/attachment.cgi?id=144055=edit radv -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 110480] vkcube renders too brightly on radv

https://bugs.freedesktop.org/show_bug.cgi?id=110480 Bug ID: 110480 Summary: vkcube renders too brightly on radv Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 110476] Overwatch - some objects are rendered incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=110476 Danylo changed: What|Removed |Added CC||danylo.pilia...@gmail.com --- Comment #3 from

[Mesa-dev] [Bug 110476] Overwatch - some objects are rendered incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=110476 --- Comment #2 from Samuel Pitoiset --- LLVM r356956 introduced the regression. I reported the problem to the compiler team. I will let you know when it's fixed. -- You are receiving this mail because: You are the assignee for the bug. You

[Mesa-dev] [AppVeyor] mesa indexing #10830 failed

Build mesa 10830 failed Commit 662ec3e8c4 by Alyssa Rosenzweig on 4/21/2019 7:13 PM: panfrost/midgard: Remove unused mir_next_block\n\nSigned-off-by: Alyssa Rosenzweig Configure your notification preferences

[Mesa-dev] [Bug 110476] Overwatch - some objects are rendered incorrectly

https://bugs.freedesktop.org/show_bug.cgi?id=110476 --- Comment #1 from Samuel Pitoiset --- I can reproduce the issue, I will investigate. Thanks for the report! -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 110479] AddressSanitizer:DEADLYSIGNAL in src/egl/drivers/dri2/platform_surfaceless.c:139

https://bugs.freedesktop.org/show_bug.cgi?id=110479 Bug ID: 110479 Summary: AddressSanitizer:DEADLYSIGNAL in src/egl/drivers/dri2/platform_surfaceless.c:139 Product: Mesa Version: 19.0 Hardware: Other OS: