[Mesa-dev] [RFC PATCH] nir/algebraic: Remove problematic "optimization"
This line is no longer relevant now that booleans are 1-bit, and in fact
causes issues (infinite progress loop between algebraic optimizations
and copy prop) with constant vector masks.
Signed-off-by: Alyssa Rosenzweig
Cc: Jason Ekstrand
---
src/compiler/nir/nir_opt_algebraic.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/compiler/nir/nir_opt_algebraic.py
b/src/compiler/nir/nir_opt_algebraic.py
index 1c7b3597c1f..89d07aa1261 100644
--- a/src/compiler/nir/nir_opt_algebraic.py
+++ b/src/compiler/nir/nir_opt_algebraic.py
@@ -621,9 +621,6 @@ optimizations = [
(('bcsel', True, b, c), b),
(('bcsel', False, b, c), c),
(('bcsel', a, ('b2f(is_used_once)', 'b@32'), ('b2f', 'c@32')), ('b2f',
('bcsel', a, b, c))),
- # The result of this should be hit by constant propagation and, in the
- # next round of opt_algebraic, get picked up by one of the above two.
- (('bcsel', '#a', b, c), ('bcsel', ('ine', 'a', 0), b, c)),
(('bcsel', a, b, b), b),
(('fcsel', a, b, b), b),
--
2.20.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 1/3] panfrost/midgard: Set int outmod for ops writing integers
By default, the "normal" output modifier is set on ALU ops. This is the
correct default for float outputs -- for floats, it preserves the semantic
value. Unfortunately, when used with integers, it does not preserve the
bitstream encoding, causing misbehaviour. (It's an open question what
happens when `normal` is used with integers -- does it apply some other
transformation? or does it do floating point normalization/etc on the
ints as if they were floats?).
Instead, we default to the "clamp to integer" output modifier for
ops writing integers. Semantically, this makes sense (clamping an
integer to the nearest integer is the identity function). In the
hardware with an integer opcode, this is the actual "normal".
This fixes numerous sporadic and sometimes bizarre bugs relating to
integers, especially integer moves. With this in place, we no longer
care about the types involved; it's just bits on the wire again.
[Jason: Once this is merged, panfrost shouldn't have any blockers to
typeless mov]
Signed-off-by: Alyssa Rosenzweig
Cc: Connor Abbott
Cc: Jason Ekstrand
---
.../drivers/panfrost/midgard/helpers.h| 27 ++-
.../panfrost/midgard/midgard_compile.c| 3 ++-
2 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/src/gallium/drivers/panfrost/midgard/helpers.h
b/src/gallium/drivers/panfrost/midgard/helpers.h
index dc2de15931b..441c7285887 100644
--- a/src/gallium/drivers/panfrost/midgard/helpers.h
+++ b/src/gallium/drivers/panfrost/midgard/helpers.h
@@ -71,6 +71,9 @@
/* Is the op commutative? */
#define OP_COMMUTES (1 << 3)
+/* Does the op convert types between int- and float- space (i2f/f2u/etc) */
+#define OP_TYPE_CONVERT (1 << 4)
+
/* Vector-independant shorthands for the above; these numbers are arbitrary and
* not from the ISA. Convert to the above with unit_enum_to_midgard */
@@ -207,11 +210,11 @@ static struct {
[midgard_alu_op_fexp2] = {"fexp2", UNIT_VLUT},
[midgard_alu_op_flog2] = {"flog2", UNIT_VLUT},
-[midgard_alu_op_f2i]= {"f2i", UNITS_ADD},
-[midgard_alu_op_f2u]= {"f2u", UNITS_ADD},
-[midgard_alu_op_f2u8] = {"f2u8", UNITS_ADD},
-[midgard_alu_op_i2f]= {"i2f", UNITS_ADD},
-[midgard_alu_op_u2f]= {"u2f", UNITS_ADD},
+[midgard_alu_op_f2i]= {"f2i", UNITS_ADD | OP_TYPE_CONVERT},
+[midgard_alu_op_f2u]= {"f2u", UNITS_ADD | OP_TYPE_CONVERT},
+[midgard_alu_op_f2u8] = {"f2u8", UNITS_ADD |
OP_TYPE_CONVERT},
+[midgard_alu_op_i2f]= {"i2f", UNITS_ADD | OP_TYPE_CONVERT},
+[midgard_alu_op_u2f]= {"u2f", UNITS_ADD | OP_TYPE_CONVERT},
[midgard_alu_op_fsin] = {"fsin", UNIT_VLUT},
[midgard_alu_op_fcos] = {"fcos", UNIT_VLUT},
@@ -262,7 +265,7 @@ static struct {
/* Is this opcode that of an integer (regardless of signedness)? Instruction
* names authoritatively determine types */
-static bool
+static inline bool
midgard_is_integer_op(int op)
{
const char *name = alu_opcode_props[op].name;
@@ -272,3 +275,15 @@ midgard_is_integer_op(int op)
return (name[0] == 'i') || (name[0] == 'u');
}
+
+/* Does this opcode *write* an integer? Same as is_integer_op, unless it's a
+ * conversion between int<->float in which case we do the opposite */
+
+static inline bool
+midgard_is_integer_out_op(int op)
+{
+bool is_int = midgard_is_integer_op(op);
+bool is_conversion = alu_opcode_props[op].props & OP_TYPE_CONVERT;
+
+return is_int ^ is_conversion;
+}
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
index 4a26ba769b2..496ecb02e09 100644
--- a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
+++ b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
@@ -1336,8 +1336,9 @@ emit_alu(compiler_context *ctx, nir_alu_instr *instr)
return;
}
-/* Midgard can perform certain modifiers on output ofa n ALU op */
+/* Midgard can perform certain modifiers on output of an ALU op */
midgard_outmod outmod =
+midgard_is_integer_out_op(op) ? midgard_outmod_int :
instr->dest.saturate ? midgard_outmod_sat :
midgard_outmod_none;
/* fmax(a, 0.0) can turn into a .pos modifier as an optimization */
--
2.20.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 3/3] panfrost/midgard: Enable integer constant inlining
Midgard ALU features two types of constants: embedded constants (128-bit
chunk, zero/one per schedule bundle) and inline constants (16-bit
splattered into the op, second source if present). Inline constants are
much more efficient from a space and scheduling freedom standpoint, so
it's desirable to inline when possible. Now that integer ops are well
understood and in use, we enable inlining of integers constants in
addition to floats (which have been inlined since forever).
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/midgard/midgard_compile.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
index 5354c0667e2..421a3343a71 100644
--- a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
+++ b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
@@ -3134,11 +3134,7 @@ embedded_to_inline_constant(compiler_context *ctx)
/* Scale constant appropriately, if we can legally */
uint16_t scaled_constant = 0;
-/* XXX: Check legality */
if (midgard_is_integer_op(op)) {
-/* TODO: Inline integer */
-continue;
-
unsigned int *iconstants = (unsigned int *)
ins->constants;
scaled_constant = (uint16_t)
iconstants[component];
--
2.20.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 2/3] panfrost/midgard: Remove imov workaround
The previous commit fixes the issue this patched around.
Signed-off-by: Alyssa Rosenzweig
---
.../panfrost/midgard/midgard_compile.c| 26 ---
1 file changed, 26 deletions(-)
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
index 496ecb02e09..5354c0667e2 100644
--- a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
+++ b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
@@ -3362,31 +3362,6 @@ midgard_opt_copy_prop_tex(compiler_context *ctx,
midgard_block *block)
return progress;
}
-/* We don't really understand the imov/fmov split, so always use fmov (but let
- * it be imov in the IR so we don't do unsafe floating point "optimizations"
- * and break things */
-
-static void
-midgard_imov_workaround(compiler_context *ctx, midgard_block *block)
-{
-mir_foreach_instr_in_block_safe(block, ins) {
-if (ins->type != TAG_ALU_4) continue;
-if (ins->alu.op != midgard_alu_op_imov) continue;
-
-ins->alu.op = midgard_alu_op_fmov;
-ins->alu.outmod = midgard_outmod_none;
-
-/* Remove flags that don't make sense */
-
-midgard_vector_alu_src s =
-vector_alu_from_unsigned(ins->alu.src2);
-
-s.mod = 0;
-
-ins->alu.src2 = vector_alu_srco_unsigned(s);
-}
-}
-
/* The following passes reorder MIR instructions to enable better scheduling */
static void
@@ -3638,7 +3613,6 @@ emit_block(compiler_context *ctx, nir_block *block)
midgard_emit_store(ctx, this_block);
midgard_pair_load_store(ctx, this_block);
-midgard_imov_workaround(ctx, this_block);
/* Append fragment shader epilogue (value writeout) */
if (ctx->stage == MESA_SHADER_FRAGMENT) {
--
2.20.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/3] panfrost/midgard: Cleanup integers
Removes a bunch of hacks surrounding integers. There should be much less voodoo here now. Alyssa Rosenzweig (3): panfrost/midgard: Set int outmod for ops writing integers panfrost/midgard: Remove imov workaround panfrost/midgard: Enable integer constant inlining .../drivers/panfrost/midgard/helpers.h| 27 +++ .../panfrost/midgard/midgard_compile.c| 33 ++- 2 files changed, 23 insertions(+), 37 deletions(-) -- 2.20.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/2] ac: add comments to chip enums
Reviewed-by: Dave Airlie
On Wed, 15 May 2019 at 12:17, Marek Olšák wrote:
>
> From: Marek Olšák
>
> ---
> src/amd/common/amd_family.h | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/src/amd/common/amd_family.h b/src/amd/common/amd_family.h
> index 185ba029763..eed6553d44b 100644
> --- a/src/amd/common/amd_family.h
> +++ b/src/amd/common/amd_family.h
> @@ -50,5 +50,5 @@ enum radeon_family {
> CHIP_RV560,
> CHIP_RV570,
> -CHIP_R600,
> +CHIP_R600, /* R6xx */
> CHIP_RV610,
> CHIP_RV630,
> @@ -58,9 +58,9 @@ enum radeon_family {
> CHIP_RS780,
> CHIP_RS880,
> -CHIP_RV770,
> +CHIP_RV770,/* R7xx */
> CHIP_RV730,
> CHIP_RV710,
> CHIP_RV740,
> -CHIP_CEDAR,
> +CHIP_CEDAR,/* Evergreen */
> CHIP_REDWOOD,
> CHIP_JUNIPER,
> @@ -73,17 +73,17 @@ enum radeon_family {
> CHIP_TURKS,
> CHIP_CAICOS,
> -CHIP_CAYMAN,
> +CHIP_CAYMAN, /* Northern Islands */
> CHIP_ARUBA,
> -CHIP_TAHITI,
> +CHIP_TAHITI, /* GFX6 (Southern Islands) */
> CHIP_PITCAIRN,
> CHIP_VERDE,
> CHIP_OLAND,
> CHIP_HAINAN,
> -CHIP_BONAIRE,
> +CHIP_BONAIRE, /* GFX7 (Sea Islands) */
> CHIP_KAVERI,
> CHIP_KABINI,
> CHIP_HAWAII,
> CHIP_MULLINS,
> -CHIP_TONGA,
> +CHIP_TONGA,/* GFX8 (Volcanic Islands & Polaris) */
> CHIP_ICELAND,
> CHIP_CARRIZO,
> @@ -94,5 +94,5 @@ enum radeon_family {
> CHIP_POLARIS12,
> CHIP_VEGAM,
> -CHIP_VEGA10,
> +CHIP_VEGA10, /* GFX9 (Vega) */
> CHIP_VEGA12,
> CHIP_VEGA20,
> --
> 2.17.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 1/2] ac: add comments to chip enums
From: Marek Olšák
---
src/amd/common/amd_family.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/amd/common/amd_family.h b/src/amd/common/amd_family.h
index 185ba029763..eed6553d44b 100644
--- a/src/amd/common/amd_family.h
+++ b/src/amd/common/amd_family.h
@@ -50,5 +50,5 @@ enum radeon_family {
CHIP_RV560,
CHIP_RV570,
-CHIP_R600,
+CHIP_R600, /* R6xx */
CHIP_RV610,
CHIP_RV630,
@@ -58,9 +58,9 @@ enum radeon_family {
CHIP_RS780,
CHIP_RS880,
-CHIP_RV770,
+CHIP_RV770,/* R7xx */
CHIP_RV730,
CHIP_RV710,
CHIP_RV740,
-CHIP_CEDAR,
+CHIP_CEDAR,/* Evergreen */
CHIP_REDWOOD,
CHIP_JUNIPER,
@@ -73,17 +73,17 @@ enum radeon_family {
CHIP_TURKS,
CHIP_CAICOS,
-CHIP_CAYMAN,
+CHIP_CAYMAN, /* Northern Islands */
CHIP_ARUBA,
-CHIP_TAHITI,
+CHIP_TAHITI, /* GFX6 (Southern Islands) */
CHIP_PITCAIRN,
CHIP_VERDE,
CHIP_OLAND,
CHIP_HAINAN,
-CHIP_BONAIRE,
+CHIP_BONAIRE, /* GFX7 (Sea Islands) */
CHIP_KAVERI,
CHIP_KABINI,
CHIP_HAWAII,
CHIP_MULLINS,
-CHIP_TONGA,
+CHIP_TONGA,/* GFX8 (Volcanic Islands & Polaris) */
CHIP_ICELAND,
CHIP_CARRIZO,
@@ -94,5 +94,5 @@ enum radeon_family {
CHIP_POLARIS12,
CHIP_VEGAM,
-CHIP_VEGA10,
+CHIP_VEGA10, /* GFX9 (Vega) */
CHIP_VEGA12,
CHIP_VEGA20,
--
2.17.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 2/3] panfrost/decode: Stride decoding
With a special flag, texture descriptors can include custom stride(s).
We haven't seen a case of this used for mipmaps/cubemaps, so it's not
clear how that will be encoded, but this dumps correctly for single
one-level 2D textures.
Signed-off-by: Alyssa Rosenzweig
---
.../drivers/panfrost/include/panfrost-job.h | 3 ++
.../drivers/panfrost/pandecode/decode.c | 33 +--
2 files changed, 33 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/panfrost/include/panfrost-job.h
b/src/gallium/drivers/panfrost/include/panfrost-job.h
index 71ac054f7c3..96c2d07ef4d 100644
--- a/src/gallium/drivers/panfrost/include/panfrost-job.h
+++ b/src/gallium/drivers/panfrost/include/panfrost-job.h
@@ -1106,6 +1106,9 @@ enum mali_wrap_mode {
/* Corresponds to the type passed to glTexImage2D and so forth */
+/* Flags for usage2 */
+#define MALI_TEX_MANUAL_STRIDE (0x20)
+
struct mali_texture_format {
unsigned swizzle : 12;
enum mali_format format : 8;
diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c
b/src/gallium/drivers/panfrost/pandecode/decode.c
index 5a1fcf75ead..f8f49f69e42 100644
--- a/src/gallium/drivers/panfrost/pandecode/decode.c
+++ b/src/gallium/drivers/panfrost/pandecode/decode.c
@@ -1507,6 +1507,20 @@ pandecode_replay_vertex_tiler_postfix_pre(const struct
mali_vertex_tiler_postfix
bitmap_count *= 6;
}
+if (f.usage2 & MALI_TEX_MANUAL_STRIDE)
{
+/* Stride for each... what
exactly? TODO More traces */
+
+if (bitmap_count > 1) {
+pandecode_msg("Manual
stride with mip/cubemaps, decode uncertain");
+}
+
+/* This is a guess, we've only
+ * seen for 1-level non-mip 2D
+ * */
+
+bitmap_count += 1;
+}
+
int max_count =
sizeof(t->swizzled_bitmaps) / sizeof(t->swizzled_bitmaps[0]);
if (bitmap_count > max_count) {
@@ -1518,9 +1532,22 @@ pandecode_replay_vertex_tiler_postfix_pre(const struct
mali_vertex_tiler_postfix
int safe_count = MIN2(bitmap_count *
2, max_count);
for (int i = 0; i < safe_count; ++i) {
-char *a =
pointer_as_memory_reference(t->swizzled_bitmaps[i]);
-pandecode_log("%s%s, \n", (i
>= bitmap_count) ? "// " : "", a);
-free(a);
+char *prefix = (i >=
bitmap_count) ? "// " : "";
+
+/* How we dump depends if this
is a stride or a pointer */
+
+if ((f.usage2 &
MALI_TEX_MANUAL_STRIDE) && ((i + 1) == bitmap_count)) {
+/* signed 32-bit snuck
in as a 64-bit pointer */
+uint64_t stride_set =
t->swizzled_bitmaps[i];
+uint32_t
clamped_stride = stride_set;
+int32_t stride =
clamped_stride;
+assert(stride_set ==
clamped_stride);
+
pandecode_log("%s(mali_ptr) %d /* stride */, \n", prefix, stride);
+} else {
+char *a =
pointer_as_memory_reference(t->swizzled_bitmaps[i]);
+pandecode_log("%s%s,
\n", prefix, a);
+free(a);
+}
}
pandecode_indent--;
--
2.20.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 3/3] panfrost: Set custom stride for textures when necessary
From Gallium (and our) perspective, the stride of a BO is arbitrary. For
internal buffers, we can make it something nice, but for imported linear
buffers (e.g. EGL clients), we don't always have that luxury. To cope,
we calculate the expected stride of a texture, compare it to the BO's
actual reported stride, and if they differ, set the latter as a custom
stride.
Fixes rendering of windows not on tile boundaries (noticeable in Weston
with es2gears_wayland, for instance). Also, this should fix stride
issues with bufer reloading.
Signed-off-by: Alyssa Rosenzweig
Cc: Tomeu Vizoso
Cc: Boris Brezillon
---
src/gallium/drivers/panfrost/pan_context.c | 25 ++
1 file changed, 25 insertions(+)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost/pan_context.c
index cab7c89ac8b..c4bb57d782e 100644
--- a/src/gallium/drivers/panfrost/pan_context.c
+++ b/src/gallium/drivers/panfrost/pan_context.c
@@ -1115,6 +1115,17 @@ panfrost_emit_for_draw(struct panfrost_context *ctx,
bool with_vertex_data)
}
}
+/* Inject the strides */
+unsigned usage2 =
ctx->sampler_views[t][i]->hw.format.usage2;
+
+if (usage2 & MALI_TEX_MANUAL_STRIDE) {
+unsigned idx = tex_rsrc->last_level *
tex_rsrc->array_size;
+idx += tex_rsrc->array_size;
+
+
ctx->sampler_views[t][i]->hw.swizzled_bitmaps[idx] =
+rsrc->bo->slices[0].stride;
+}
+
trampolines[i] =
panfrost_upload_transient(ctx, >sampler_views[t][i]->hw, sizeof(struct
mali_texture_descriptor));
}
@@ -1951,6 +1962,7 @@ panfrost_create_sampler_view(
pipe_reference(NULL, >reference);
struct panfrost_resource *prsrc = (struct panfrost_resource *) texture;
+assert(prsrc->bo);
so->base = *template;
so->base.texture = texture;
@@ -1995,6 +2007,19 @@ panfrost_create_sampler_view(
break;
}
+/* Check if we need to set a custom stride by computing the "expected"
+ * stride and comparing it to what the BO actually wants. Only applies
+ * to linear textures TODO: Mipmap? */
+
+unsigned actual_stride = prsrc->bo->slices[0].stride;
+
+if (prsrc->bo->layout == PAN_LINEAR &&
+template->u.tex.last_level == 0 &&
+template->u.tex.first_level == 0 &&
+(texture->width0 * bytes_per_pixel) != actual_stride) {
+usage2_layout |= MALI_TEX_MANUAL_STRIDE;
+}
+
struct mali_texture_descriptor texture_descriptor = {
.width = MALI_POSITIVE(texture->width0),
.height = MALI_POSITIVE(texture->height0),
--
2.20.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/3] panfrost: Custom texture strides
This series implements custom textures stides. The first patch fixes some bugs in pandecode that hid the existence of the texture stride field in the first place. The second patch uses the knowledge gained from the first to identify and decode the stride field itself. Finally, the third patch uses this stride field in the driver itself, fixing winsys related bugs. Alyssa Rosenzweig (3): panfrost/decode: Futureproof texture dumping panfrost/decode: Stride decoding panfrost: Set custom stride for textures when necessary .../drivers/panfrost/include/panfrost-job.h | 3 ++ src/gallium/drivers/panfrost/pan_context.c| 25 ++ .../drivers/panfrost/pandecode/decode.c | 46 +-- 3 files changed, 70 insertions(+), 4 deletions(-) -- 2.20.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 1/3] panfrost/decode: Futureproof texture dumping
One field was not dumped for some reason. It's observed to be 0, but
it's still good to have it available.
Also, extra fields might be snuck in the bitmaps array (it's
variable-lengthed at the end), and we want to guard against that
possibility, so we dump a little more.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pandecode/decode.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c
b/src/gallium/drivers/panfrost/pandecode/decode.c
index 9d9b9b31bcd..5a1fcf75ead 100644
--- a/src/gallium/drivers/panfrost/pandecode/decode.c
+++ b/src/gallium/drivers/panfrost/pandecode/decode.c
@@ -29,6 +29,7 @@
#include
#include
#include "mmap.h"
+#include "util/u_math.h"
#include "../pan_pretty_print.h"
#include "../midgard/disassemble.h"
@@ -1456,6 +1457,7 @@ pandecode_replay_vertex_tiler_postfix_pre(const struct
mali_vertex_tiler_postfix
pandecode_prop("height =
MALI_POSITIVE(%" PRId16 ")", t->height + 1);
pandecode_prop("depth =
MALI_POSITIVE(%" PRId16 ")", t->depth + 1);
+pandecode_prop("unknown1 = %" PRId16,
t->unknown1);
pandecode_prop("unknown3 = %" PRId16,
t->unknown3);
pandecode_prop("unknown3A = %" PRId8,
t->unknown3A);
pandecode_prop("nr_mipmap_levels = %"
PRId8, t->nr_mipmap_levels);
@@ -1492,6 +1494,12 @@ pandecode_replay_vertex_tiler_postfix_pre(const struct
mali_vertex_tiler_postfix
pandecode_log(".swizzled_bitmaps =
{\n");
pandecode_indent++;
+/* A bunch of bitmap pointers follow.
+ * We work out the correct number,
+ * based on the mipmap/cubemap
+ * properties, but dump extra
+ * possibilities to futureproof */
+
int bitmap_count =
MALI_NEGATIVE(t->nr_mipmap_levels);
if (!f.is_not_cubemap) {
@@ -1506,9 +1514,12 @@ pandecode_replay_vertex_tiler_postfix_pre(const struct
mali_vertex_tiler_postfix
bitmap_count = max_count;
}
-for (int i = 0; i < bitmap_count; ++i)
{
+/* Dump more to be safe, but not
_that_ much more */
+int safe_count = MIN2(bitmap_count *
2, max_count);
+
+for (int i = 0; i < safe_count; ++i) {
char *a =
pointer_as_memory_reference(t->swizzled_bitmaps[i]);
-pandecode_log("%s, \n", a);
+pandecode_log("%s%s, \n", (i
>= bitmap_count) ? "// " : "", a);
free(a);
}
--
2.20.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 110663] threads_posix.h:96: undefined reference to `pthread_once'
https://bugs.freedesktop.org/show_bug.cgi?id=110663 --- Comment #2 from Vinson Lee --- This patch fixed my build issue. Tested-by: Vinson Lee (In reply to Eric Engestrom from comment #1) > This should fix your issue, but I haven't had time to dive in and see > exactly why quad-tex uses threads. > > 8< > diff --git a/src/gallium/tests/trivial/meson.build > b/src/gallium/tests/trivial/meson.build > index bbb25519e12ff466ce46..1f912d5aa46a16a06eda 100644 > --- a/src/gallium/tests/trivial/meson.build > +++ b/src/gallium/tests/trivial/meson.build > @@ -24,6 +24,7 @@ foreach t : ['compute', 'tri', 'quad-tex'] > '@0@.c'.format(t), > include_directories : inc_common, > link_with : [libmesa_util, libgallium, libpipe_loader_dynamic], > +dependencies : dep_thread, > install : false, >) > endforeach > >8 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] docs/features: don't list EXT extensions in a list for KHR/ARB/OES extensions
Reviewed-by: Ian Romanick On 5/14/19 1:07 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > docs/features.txt | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/docs/features.txt b/docs/features.txt > index 38d6186dbe1..b1799550a0c 100644 > --- a/docs/features.txt > +++ b/docs/features.txt > @@ -309,30 +309,20 @@ Khronos, ARB, and OES extensions that are not part of > any OpenGL or OpenGL ES ve >GL_ARB_seamless_cubemap_per_texture DONE (freedreno, > i965, nvc0, radeonsi, r600, softpipe, swr, virgl) >GL_ARB_shader_ballot DONE (i965/gen8+, > nvc0, radeonsi) >GL_ARB_shader_clock DONE (i965/gen7+, > nv50, nvc0, r600, radeonsi, virgl) >GL_ARB_shader_stencil_export DONE (i965/gen9+, > r600, radeonsi, softpipe, llvmpipe, swr, virgl) >GL_ARB_shader_viewport_layer_arrayDONE (i965/gen6+, > nvc0, radeonsi) >GL_ARB_sparse_buffer DONE (radeonsi/CIK+) >GL_ARB_sparse_texture not started >GL_ARB_sparse_texture2not started >GL_ARB_sparse_texture_clamp not started >GL_ARB_texture_filter_minmax not started > - GL_EXT_memory_object DONE (radeonsi) > - GL_EXT_memory_object_fd DONE (radeonsi) > - GL_EXT_memory_object_win32not started > - GL_EXT_render_snorm DONE (i965, radeonsi) > - GL_EXT_semaphore DONE (radeonsi) > - GL_EXT_semaphore_fd DONE (radeonsi) > - GL_EXT_semaphore_win32not started > - GL_EXT_sRGB_write_control DONE (all drivers > that support GLES 3.0+) > - GL_EXT_texture_norm16 DONE (freedreno, > i965, r600, radeonsi, nvc0) > - GL_EXT_texture_sRGB_R8DONE (all drivers > that support GLES 3.0+) >GL_KHR_blend_equation_advanced_coherent DONE (i965/gen9+) >GL_KHR_texture_compression_astc_hdr DONE (i965/bxt) >GL_KHR_texture_compression_astc_sliced_3d DONE (i965/gen9+, > radeonsi) >GL_OES_depth_texture_cube_map DONE (all drivers > that support GLSL 1.30+) >GL_OES_EGL_image DONE (all drivers) >GL_OES_EGL_image_external DONE (all drivers) >GL_OES_EGL_image_external_essl3 DONE (all drivers) >GL_OES_required_internalformatDONE (all drivers) >GL_OES_surfaceless_contextDONE (all drivers) >GL_OES_texture_compression_astc DONE (core only) > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] docs/features: don't list EXT extensions in a list for KHR/ARB/OES extensions
From: Marek Olšák --- docs/features.txt | 10 -- 1 file changed, 10 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 38d6186dbe1..b1799550a0c 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -309,30 +309,20 @@ Khronos, ARB, and OES extensions that are not part of any OpenGL or OpenGL ES ve GL_ARB_seamless_cubemap_per_texture DONE (freedreno, i965, nvc0, radeonsi, r600, softpipe, swr, virgl) GL_ARB_shader_ballot DONE (i965/gen8+, nvc0, radeonsi) GL_ARB_shader_clock DONE (i965/gen7+, nv50, nvc0, r600, radeonsi, virgl) GL_ARB_shader_stencil_export DONE (i965/gen9+, r600, radeonsi, softpipe, llvmpipe, swr, virgl) GL_ARB_shader_viewport_layer_arrayDONE (i965/gen6+, nvc0, radeonsi) GL_ARB_sparse_buffer DONE (radeonsi/CIK+) GL_ARB_sparse_texture not started GL_ARB_sparse_texture2not started GL_ARB_sparse_texture_clamp not started GL_ARB_texture_filter_minmax not started - GL_EXT_memory_object DONE (radeonsi) - GL_EXT_memory_object_fd DONE (radeonsi) - GL_EXT_memory_object_win32not started - GL_EXT_render_snorm DONE (i965, radeonsi) - GL_EXT_semaphore DONE (radeonsi) - GL_EXT_semaphore_fd DONE (radeonsi) - GL_EXT_semaphore_win32not started - GL_EXT_sRGB_write_control DONE (all drivers that support GLES 3.0+) - GL_EXT_texture_norm16 DONE (freedreno, i965, r600, radeonsi, nvc0) - GL_EXT_texture_sRGB_R8DONE (all drivers that support GLES 3.0+) GL_KHR_blend_equation_advanced_coherent DONE (i965/gen9+) GL_KHR_texture_compression_astc_hdr DONE (i965/bxt) GL_KHR_texture_compression_astc_sliced_3d DONE (i965/gen9+, radeonsi) GL_OES_depth_texture_cube_map DONE (all drivers that support GLSL 1.30+) GL_OES_EGL_image DONE (all drivers) GL_OES_EGL_image_external DONE (all drivers) GL_OES_EGL_image_external_essl3 DONE (all drivers) GL_OES_required_internalformatDONE (all drivers) GL_OES_surfaceless_contextDONE (all drivers) GL_OES_texture_compression_astc DONE (core only) -- 2.17.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] mesa: fix _mesa_max_texture_levels for GL_TEXTURE_EXTERNAL_OES
Marek Olšák writes: > From: Marek Olšák > > This helps fix: > piglit/bin/ext_image_dma_buf_import-sample_yuv -fmt=NV12 -auto > > Fixes: d88f3392fff7c6342f3840c4bd8195a1296c2372 Reviewed-by: Eric Anholt Apologies, I had only tested with the CTS. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] GLU and GLUT issues migrated to gitlab
On Mon, 2019-05-13 at 12:14 -0400, Adam Jackson wrote: > Not, I hope, that anyone is likely to notice, but I've moved the open > GLU and GLUT bugs from bugzilla to gitlab and closed the components in > bugzilla. I say "moved" but really glut only had one open bug and it > was fixed ages ago. Anyway, use gitlab now please. mesa/demos has been migrated now as well. - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 6/6] mesa: Set _NEW_VARYING_VP_INPUTS iff varying_vp_inputs are set.
Hi Marek,
> Reviewed-by: Marek Olšák
Thanks for the review!
Pushed!
best
Mathias
>
> Marek
>
> On Sun, May 12, 2019 at 9:05 AM wrote:
>
> > From: Mathias Fröhlich
> >
> > Signed-off-by: Mathias Fröhlich
> > ---
> > src/mesa/main/state.c | 13 ++---
> > 1 file changed, 6 insertions(+), 7 deletions(-)
> >
> > diff --git a/src/mesa/main/state.c b/src/mesa/main/state.c
> > index 9d8964952cd..3e2eb28dcc5 100644
> > --- a/src/mesa/main/state.c
> > +++ b/src/mesa/main/state.c
> > @@ -430,15 +430,14 @@ set_varying_vp_inputs(struct gl_context *ctx,
> > GLbitfield varying_inputs)
> > if (VP_MODE_FF != ctx->VertexProgram._VPMode)
> >return;
> >
> > + /* Only fixed-func generated programs ever uses varying_vp_inputs. */
> > + if (!ctx->VertexProgram._MaintainTnlProgram &&
> > + !ctx->FragmentProgram._MaintainTexEnvProgram)
> > + return;
> > +
> > if (ctx->varying_vp_inputs != varying_inputs) {
> >ctx->varying_vp_inputs = varying_inputs;
> > -
> > - /* Only fixed-func generated programs ever use varying_vp_inputs. */
> > - if (ctx->VertexProgram._MaintainTnlProgram ||
> > - ctx->FragmentProgram._MaintainTexEnvProgram) {
> > - ctx->NewState |= _NEW_VARYING_VP_INPUTS;
> > - }
> > - /*printf("%s %x\n", __func__, varying_inputs);*/
> > + ctx->NewState |= _NEW_VARYING_VP_INPUTS;
> > }
> > }
> >
> > --
> > 2.21.0
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/6] Update mesa state handling past VAO changes.
The series LGTM. Reviewed-by: Brian Paul On 05/12/2019 07:05 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi Brian, The series is a collection of comment updates and state handling cleanup past the VAO changes that went into mesa. There are two fixes for potential bugs in state handling included. There were no reports accoring that, and it does not change the outcome of intels CI. please review best Mathias Mathias Fröhlich (6): mesa/vbo: Update Comment to what is actually happening. mesa: Fix old outdated variable name in a comment. mesa: Make _mesa_set_varying_vp_inputs static in state.c. mesa: Fix test for setting the _NEW_VARYING_VP_INPUTS flag. mesa: Avoid setting _NEW_VARYING_VP_INPUTS in non fixed function mode. mesa: Set _NEW_VARYING_VP_INPUTS iff varying_vp_inputs are set. src/mesa/main/ff_fragment_shader.cpp | 2 ++ src/mesa/main/ffvertex_prog.c| 3 +++ src/mesa/main/state.c| 38 +++- src/mesa/main/state.h| 6 + src/mesa/vbo/vbo_exec_draw.c | 4 +-- 5 files changed, 27 insertions(+), 26 deletions(-) -- 2.21.0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 91793] the "bin" directory is not created
https://bugs.freedesktop.org/show_bug.cgi?id=91793 GitLab Migration User changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #5 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/10. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 107965] kmscube: video cube not working: i965_dri.so does not support the 0xffffffff PCI ID and segfaulting
https://bugs.freedesktop.org/show_bug.cgi?id=107965 GitLab Migration User changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #1 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/13. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 78496] Some data files not using DEMOS_DATA_DIR
https://bugs.freedesktop.org/show_bug.cgi?id=78496 GitLab Migration User changed: What|Removed |Added Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #1 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/9. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 97043] glxgears reported frame rate doesn't match actual with indirect rendering
https://bugs.freedesktop.org/show_bug.cgi?id=97043 GitLab Migration User changed: What|Removed |Added Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #2 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/11. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 105376] es2gears_wayland reports 120 fps while drawing at 60 fps
https://bugs.freedesktop.org/show_bug.cgi?id=105376 GitLab Migration User changed: What|Removed |Added Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #4 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/12. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 110673] amdgpu hevc encoding problems: segment fault and contents of garbage
https://bugs.freedesktop.org/show_bug.cgi?id=110673 Alex Deucher changed: What|Removed |Added CC||boyuan.zh...@amd.com -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 69135] Make EGLUT-Wayland code catch up with latest stable Wayland (1.2)
https://bugs.freedesktop.org/show_bug.cgi?id=69135 GitLab Migration User changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #1 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/8. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 15651] teapot display gets disturbed by moving a simultaneously running glxgears
https://bugs.freedesktop.org/show_bug.cgi?id=15651 GitLab Migration User changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #2 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/1. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 43332] corrupted output in mesa-demo/fp-tri using r600g
https://bugs.freedesktop.org/show_bug.cgi?id=43332 GitLab Migration User changed: What|Removed |Added Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #9 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/6. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 57013] Enable --without-glut
https://bugs.freedesktop.org/show_bug.cgi?id=57013 GitLab Migration User changed: What|Removed |Added Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #4 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/7. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 31630] [PATCH] egl: Add texture from pixmap example for GLES2.
https://bugs.freedesktop.org/show_bug.cgi?id=31630 GitLab Migration User changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #3 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/4. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 39116] [intel] manywin xdemo texture issue
https://bugs.freedesktop.org/show_bug.cgi?id=39116 GitLab Migration User changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #3 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/5. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 29094] Fail to build examples for OpenVG and ES for FreeBSD
https://bugs.freedesktop.org/show_bug.cgi?id=29094 GitLab Migration User changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #4 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/3. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 24318] Fix building of GLSL demos which use M_PI when M_PI is not defined by math.h
https://bugs.freedesktop.org/show_bug.cgi?id=24318 GitLab Migration User changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |MOVED --- Comment #16 from GitLab Migration User --- -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/demos/issues/2. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 46376] render error when run glsl demo or mesa demo without window manager
https://bugs.freedesktop.org/show_bug.cgi?id=46376 Bug 46376 depends on bug 61640, which changed state. Bug 61640 Summary: Mesa demos render black without a window manager present https://bugs.freedesktop.org/show_bug.cgi?id=61640 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 61640] Mesa demos render black without a window manager present
https://bugs.freedesktop.org/show_bug.cgi?id=61640 Kenneth Graunke changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Kenneth Graunke --- Works fine with the latest software and running in Xephyr, so don't care I guess. Closing as works for me. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 36070] Backtrace happens when runnig Mesa/tests/texleak
https://bugs.freedesktop.org/show_bug.cgi?id=36070 Kenneth Graunke changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 17820] copypixrate fails inside Xephyr
https://bugs.freedesktop.org/show_bug.cgi?id=17820 Kenneth Graunke changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [ANNOUNCE] mesa 19.1.0-rc2
Hello, list. The second release candidate for Mesa 19.1.0 is now available. Remind that right now there are two bugs blocking the final release: #110302 - [bisected][regression] piglit egl-create-pbuffer-surface and egl-gl-colorspace regressions #110357 - [REGRESSION] [BISECTED] [OpenGL CTS] cts-runner --type=gl46 fails in new attempted "41" configuration Bas Nieuwenhuizen (1): radv: Do not use extra descriptor space for the 3rd plane. Caio Marcelo de Oliveira Filho (1): anv: Fix limits when VK_EXT_descriptor_indexing is used Dave Airlie (1): kmsro: add _dri.so to two of the kmsro drivers. Dylan Baker (1): meson: Force the use of config-tool for llvm Eric Engestrom (1): travis: fix syntax, and drop unused stuff Gert Wollny (1): softpipe/buffer: load only as many components as the the buffer resource type provides Juan A. Suarez Romero (1): Update version to 19.1.0-rc2 Józef Kucia (1): radv: clear vertex bindings while resetting command buffer Kenneth Graunke (5): i965: Fix BRW_MEMZONE_LOW_4G heap size. i965: Force VMA alignment to be a multiple of the page size. i965: leave the top 4Gb of the high heap VMA unused i965: Fix memory leaks in brw_upload_cs_work_groups_surface(). iris: Use full ways for L3 cache setup on Icelake. Leo Liu (1): winsys/amdgpu: add VCN JPEG to no user fence group Lionel Landwerlin (4): anv: rework queries writes to ensure ordering memory writes anv: fix use after free anv: Use corresponding type from the vector allocation vulkan/overlay: keep allocating draw data until it can be reused Marek Olšák (1): st/mesa: fix 2 crashes in st_tgsi_lower_yuv Rob Clark (1): freedreno/ir3: fix rasterflat/glxgears Samuel Pitoiset (1): radv: fix setting the number of rectangles when it's dyanmic Timothy Arceri (1): Revert "glx: Fix synthetic error generation in __glXSendError" Tomeu Vizoso (2): panfrost: Fix two uninitialized accesses in compiler panfrost: Only take the fast paths on buffers aligned to block size git tag: mesa-19.1.0-rc2 https://mesa.freedesktop.org/archive/mesa-19.1.0-rc2.tar.xz MD5: 2607547a72c2b7a4dcc4fc09ebf0909a mesa-19.1.0-rc2.tar.xz SHA1: a38366408d6e10b323bc10c39cf217e486142be0 mesa-19.1.0-rc2.tar.xz SHA256: 33ad7dce6e2c96f95a905bb898a488ff71d206f5787693115997d88a87fbccae mesa-19.1.0-rc2.tar.xz SHA512: 4d04bec48cbfb17d6dbe7b7700083612e46cbaad3e3630d6219fd1988f5e793cdb5100b8c2531a94b6078f8bb239fef27ed440122d12a2473be5be8648b6a8b1 mesa-19.1.0-rc2.tar.xz PGP: https://mesa.freedesktop.org/archive/mesa-19.1.0-rc2.tar.xz.sig signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] vl/dri3: set back buffer from output to NULL with front buffer case
On 2019-05-14 5:29 a.m., Michel Dänzer wrote:
> [CAUTION: External Email]
>
> On 2019-05-09 8:10 p.m., Liu, Leo wrote:
>> Since the using output optimization is only for back buffer case
>>
>> Signed-off-by: Leo Liu
>> ---
>> src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
>> b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
>> index 1558d832555..77d1972af2c 100644
>> --- a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
>> +++ b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
>> @@ -438,6 +438,7 @@ dri3_set_drawable(struct vl_dri3_screen *scrn, Drawable
>> drawable)
>>ret = false;
>> else {
>>scrn->is_pixmap = true;
>> + scrn->base.set_back_texture_from_output = NULL;
>>if (scrn->front_buffer) {
>> dri3_free_front_buffer(scrn, scrn->front_buffer);
>> scrn->front_buffer = NULL;
>>
> Couldn't dri3_set_drawable be called for a pixmap first, then later for
> a window, for the same scrn?
I could not think of any of such case. AFAIK, the video is rendering
either to window drawable as back buffer case or to pixmap drawable as
front buffer case.
Thanks,
Leo
>
> --
> Earthling Michel Dänzer | https://www.amd.com
> Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] vl/dri3: set back buffer from output to NULL with front buffer case
On 2019-05-09 8:10 p.m., Liu, Leo wrote:
> Since the using output optimization is only for back buffer case
>
> Signed-off-by: Leo Liu
> ---
> src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> index 1558d832555..77d1972af2c 100644
> --- a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> +++ b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> @@ -438,6 +438,7 @@ dri3_set_drawable(struct vl_dri3_screen *scrn, Drawable
> drawable)
> ret = false;
>else {
> scrn->is_pixmap = true;
> + scrn->base.set_back_texture_from_output = NULL;
> if (scrn->front_buffer) {
> dri3_free_front_buffer(scrn, scrn->front_buffer);
> scrn->front_buffer = NULL;
>
Couldn't dri3_set_drawable be called for a pixmap first, then later for
a window, for the same scrn?
--
Earthling Michel Dänzer | https://www.amd.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 110345] Unrecoverable GPU crash with DiRT 4
https://bugs.freedesktop.org/show_bug.cgi?id=110345 --- Comment #34 from Samuel Pitoiset --- No hangs so far. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 0/2] Alternate default config mechanism
On 5/13/19 6:52 PM, Haehnle, Nicolai wrote: This approach seems entirely incompatible with si_debug_options.h, and will be an absolute maintenance nightmare going forward for adding / removing options, because you're introducing a second location where options are defined. Quite frankly, this seems like a terrible idea as-is. If you really can't use XML for whatever reason, then please find some way of deriving both the tables here and the XML from the same single source of truth. I was looking at this yesterday and came up with same conclusion. We should have the options in one place. Currently libexpat is statically linked with Android >=O, maybe for such restricted environments we could just inline the xml as is at compile time and parse that later or alternatively (maybe cleaner) parse and generate default option cache already during compilation? Cheers, Nicolai On 10.05.19 08:02, Sumit Semwal wrote: Mesa uses libexpat for many configuration parsing needs; however some userspaces like Android may not want to use libexpat for various reasons - eg some might restrict reading of any config xml files from filesystems. This patchset proposes a simple lookup mechanism for the default values as per current core mesa, keeping the same mesa-internal API as existing xmlconfig.c. Note: This RFC doesn't change mesa drivers that directly use libexpat API - vc4 and intel gen decoder. If these drivers need Android to be enabled for them, I request help from the experts there. For building and testing this on current AOSP/master, I have two hack patches - one provides empty dummy declarations for the XML* API in use in gen_decoder, while the other disables vc4 decoder functionality. These can be found at [1]. These have been built and boot-tested to UI on dragonboard. [1]: https://git.linaro.org/people/sumit.semwal/aosp/external/mesa3d.git/log/?h=expat_wip Sumit Semwal (2): mesa: utils: provide alternate default config mechanism mesa: Android: enable altxmlconfig for O+ src/gallium/targets/dri/Android.mk | 8 +- src/mesa/drivers/dri/Android.mk| 12 +- src/util/Android.mk| 12 +- src/util/Makefile.sources | 2 +- src/util/altxmlconfig.c| 261 + 5 files changed, 275 insertions(+), 20 deletions(-) create mode 100644 src/util/altxmlconfig.c ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
