[Mesa-dev] [PATCH] Require Visual Studio 2015.

We no longer need or use Visual Studio 2013. https://ci.appveyor.com/project/jrfonseca/mesa/build/52 --- docs/install.html | 2 +- include/c11/threads_win32.h | 12 +--- include/c99_compat.h| 4 ++-- src/util/macros.h | 4 +--- 4 files changed, 5

Re: [Mesa-dev] [PATCH] gallivm: don't use saturated unsigned add/sub intrinsics for llvm 8.0

N_BEHAVIOR_UNDEFINED); + /* + * This must match llvm pattern for saturated unsigned sub. + * (lp_build_max_simple actually does the job with its current + * definition but do it explicitly here.) + * NOTE: cmp/select does sext/trunc of the mask. Does not seem to + * interfere with llvm's ability to recognize the pattern but seems + * a bit brittle. + */ + LLVMValueRef no_ov = lp_build_cmp(bld, PIPE_FUNC_GREATER, a, b); + a = lp_build_select(bld, no_ov, a, b); } } Otherwise looks great AFAICT. Thanks Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 46/49] appveyor: use chocolatey (cinst) to install winflexbison

On 22/08/18 18:05, Dylan Baker wrote: v2: - fix typos in commit message --- appveyor.yml | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 15a31da9411..b26a3c624e8 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -34,7 +34,6 @@ branches:

[Mesa-dev] [PATCH] appveyor: Set git core.autocrlf setting to true.

The git core.autocrlf setting defaults to true (ie, all text files get checked out as CRLF on Windows), except on Appveyor where's set to "input" (ie, all text files get checked out with the upstream repository's line endings, which for us typically means LF.) And this was masking on Appveyor a

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 16:08, Jose Fonseca wrote: On 17/08/18 15:49, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:30 +0100, Jose Fonseca wrote: On 17/08/18 15:26, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote: On 17/08/18 15:06, Jose Fonseca wrote: On 17/08/18 14:52

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 15:49, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:30 +0100, Jose Fonseca wrote: On 17/08/18 15:26, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote: On 17/08/18 15:06, Jose Fonseca wrote: On 17/08/18 14:52, Jose Fonseca wrote: On 17/08/18 14:30

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 15:26, Mathieu Bridon wrote: On Fri, 2018-08-17 at 15:08 +0100, Jose Fonseca wrote: On 17/08/18 15:06, Jose Fonseca wrote: On 17/08/18 14:52, Jose Fonseca wrote: On 17/08/18 14:30, Jose Fonseca wrote: On 17/08/18 14:22, Mathieu Bridon wrote: --- Jose, can you test whether

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 15:06, Jose Fonseca wrote: On 17/08/18 14:52, Jose Fonseca wrote: On 17/08/18 14:30, Jose Fonseca wrote: On 17/08/18 14:22, Mathieu Bridon wrote: --- Jose, can you test whether this patch fixes your build issues? I don't have access to a Windows machine, and I can't reproduce

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 14:52, Jose Fonseca wrote: On 17/08/18 14:30, Jose Fonseca wrote: On 17/08/18 14:22, Mathieu Bridon wrote: --- Jose, can you test whether this patch fixes your build issues? I don't have access to a Windows machine, and I can't reproduce your problem on Linux.   src/util/xmlpool

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 14:30, Jose Fonseca wrote: On 17/08/18 14:22, Mathieu Bridon wrote: --- Jose, can you test whether this patch fixes your build issues? I don't have access to a Windows machine, and I can't reproduce your problem on Linux.   src/util/xmlpool/gen_xmlpool.py | 5 +   1 file

Re: [Mesa-dev] [PATCH] python: Help Python 2 print the line

On 17/08/18 14:22, Mathieu Bridon wrote: --- Jose, can you test whether this patch fixes your build issues? I don't have access to a Windows machine, and I can't reproduce your problem on Linux. src/util/xmlpool/gen_xmlpool.py | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v3] python: Rework bytes/unicode string handling

On 17/08/18 14:03, Mathieu Bridon wrote: On Fri, 2018-08-17 at 13:29 +0100, Jose Fonseca wrote: This change caused one of our MSVC build machines to fail with scons: Building targets ... Generating build\windows-x86-debug\util\xmlpool\options.h ... Traceback (most recent call last

Re: [Mesa-dev] [PATCH v3] python: Rework bytes/unicode string handling

This change caused one of our MSVC build machines to fail with scons: Building targets ... Generating build\windows-x86-debug\util\xmlpool\options.h ... Traceback (most recent call last): File "src\util\xmlpool\gen_xmlpool.py", line 221, in print(line, end='') UnicodeEncodeError:

Re: [Mesa-dev] [PATCH v2 5/5] scons: Check for mako 0.8.0

env.Append(CPPPATH = env['X11_CPPPATH']) Series looks good to me. Reviewed-by: Jose Fonseca Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/5] scons: Check for mako 0.8.0

On 14/08/18 18:34, Dylan Baker wrote: Bugzilla:

[Mesa-dev] [PATCH] gallium/tests: Don't ignore S3TC errors.

Now we do full S3TC decompression they should no longer fail. --- src/gallium/tests/unit/u_format_test.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/tests/unit/u_format_test.c b/src/gallium/tests/unit/u_format_test.c index 6de581fd049..437cc94b757 100644 ---

Re: [Mesa-dev] [PATCH] draw: force draw pipeline if there's more than 65535 vertices

_info)) { draw_prim_assembler_run(draw, prim_info, vert_info, Sounds good to me. Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] scons: Fix CC env quoting.

Handle the case where there are spaces in CC env var (ie, compiler + options.) This updates the CC check to match what newer SCons do internally. --- scons/gallium.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scons/gallium.py b/scons/gallium.py index

Re: [Mesa-dev] meson: Build with Python 3

AFAICS, we use python 2 in two places: (1) SCons* I suspect using Python 3 will be far from straightforward, as it will require newer SCons versions, and all that's implied. So I rather not embark on this yet. (2) C code generation scripts Python 3.5 seems to be included on our build

Re: [Mesa-dev] [PATCH] appveyor: Consume LLVM 5.0.1.

On 16/06/18 19:23, Matt Turner wrote: Is LLVM-5 now your oldest supported version? I know Igalia build tests with versions going all the way back to 3.3 before stable releases, so they might be able to cut down the required testing. We do plan to drop support for LLVM 3.x in the near future,

[Mesa-dev] [PATCH] appveyor: Consume LLVM 5.0.1.

https://ci.appveyor.com/project/jrfonseca/mesa/build/47 --- appveyor.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index bd33e2e9554..86440f0d76a 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -35,13 +35,13 @@ clone_depth: 100 cache:

Re: [Mesa-dev] [PATCH 44/48] meson: add windows specific linker flags

On 12/06/18 17:50, Dylan Baker wrote: Quoting Eric Engestrom (2018-06-12 04:38:04) On Monday, 2018-06-11 15:56:11 -0700, Dylan Baker wrote: --- meson.build | 21 + 1 file changed, 21 insertions(+) diff --git a/meson.build b/meson.build index a244694fd4a..e1b3afbe688

Re: [Mesa-dev] [PATCH] trace: Fix trace_context_transfer_unmap methods.

still a bit confused why this is necessary. Is that just so the dumped output looks like it's the same as if you called texture/buffer_subdata? Makes sense then, but in reality it still was a transfer. Reviewed-by: Roland Scheidegger Am 04.06.2018 um 15:01 schrieb Jose Fonseca: The emitted

[Mesa-dev] [PATCH] trace: Fix trace_context_transfer_unmap methods.

The emitted buffer_subdata/texture_subdata call didn't match the respective signatures. v2: Actually emit buffer_subdata call. --- .../auxiliary/driver_trace/tr_context.c | 60 +-- 1 file changed, 42 insertions(+), 18 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] trace: Fix trace_context_transfer_unmap methods.

did it match there? Also, I don't really understand why it doesn't work for buffers neither, even if some parameters don't make sense there, but if it's a transfer this should still be correct? Roland Am 01.06.2018 um 20:58 schrieb Jose Fonseca: The emitted buffer_subdata/texture_subdata call

[Mesa-dev] [PATCH 1/3] trace: Fix trace_context_transfer_unmap methods.

The emitted buffer_subdata/texture_subdata call didn't match the respective signatures. --- .../auxiliary/driver_trace/tr_context.c | 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/gallium/auxiliary/driver_trace/tr_context.c

[Mesa-dev] [PATCH 3/3] scons: Fix MinGW cross compilation with LLVM 5.0.

LLVM 5.0 requires additional Win32 libraries, and MinGW with pthreads. --- scons/llvm.py | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scons/llvm.py b/scons/llvm.py index 79118be371d..a34edfb4b67 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -123,6 +123,10 @@ def

[Mesa-dev] [PATCH 2/3] trace: Fix parsing of recent traces.

--- src/gallium/tools/trace/dump_state.py | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/src/gallium/tools/trace/dump_state.py b/src/gallium/tools/trace/dump_state.py index 4531843279e..2622d130bf8 100755 ---

Re: [Mesa-dev] [HOWTO] CI on appveyor with a linux image

I don't object merging Linux into appveyor.yml somehow, but I really don't have the time to figure out how to do it. I also fear that Linux infrastructure might be unstable in this initial initial period, and we end up receiving false failure notification emails. (Even appveyor windows builds

Re: [Mesa-dev] [PATCH] gallivm: Use alloca_undef with array type instead of alloca_array

_type, array_size, + unsigned array_size = bld_base->info->file_max[TGSI_FILE_IMMEDIATE] * 4 + 4; + bld->imms_array = lp_build_alloca_undef(gallivm, + LLVMArrayType(bld_base->base.vec_type, array_size), "imms_array"); } Looks good to me. I suppose there was no regressions with, e.g., piglit. Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] llvmpipe: Fix random number generation for unit tests

Hi Roland, It's indeed been long time since I wrote this and I'm no longer certain of what I intended to do, but the change looks overall. Reviewed-by: Jose Fonseca<jfons...@vmware.com> But is it really true rand returns 63 bits? I think it return RAND_MAX, which was actually often 3

Re: [Mesa-dev] [PATCH 2/2] draw: fix different sign logic when clipping

interp( clipper, new_vert, t, vert, vert_prev, viewport_index ); Series looks good to me. Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/4] gallivm: dump bitcode before optimization

M >= 0x0305) ? "[-mcpu=<-mcpu option>] " : "", - "[-mattr=<-mattr option(s)>]", - filename); - } - if (use_mcjit) { /* Setting the module's DataLayout to an empty string will cause the * ExecutionEngine

Re: [Mesa-dev] [PATCH] gallium: Do not add -Wframe-address option for gcc <= 4.4.

ress(1)); Thanks Vinson. Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] cmake: Warn that MSVC is unmaintained.

It has been broken for a while, and not much interest from our side in keeping it going, as most of us are using MinGW cross-compilers anyway. I'm not sure if there are other people interested on MSVC, so just warn for the time being. Also tone down the MSVC warnings, so they don't overwhelm the

Re: [Mesa-dev] [PATCH] gallium: silence __builtin_frame_address nonzero argument is unsafe warning

Makes sense. Thanks Reviewed-by: Jose Fonseca <jfons...@vmware.com> On 09/03/18 00:00, Timothy Arceri wrote: Calling __builtin_frame_address with a nonzero argument is unsafe but is sometimes done for debugging purposes. Since this code is part of some debug util code I'm as

Re: [Mesa-dev] [PATCH 1/2] draw: simplify (and correct) aaline fallback (v2)

On 06/03/18 20:52, Brian Paul wrote: Looks good.  That certainly does simplify things.  Two minor suggestions below. In any case, for both, Reviewed-by: Brian Paul <bri...@vmware.com> Looks great cleanup to me too.  Just minor issues inline. Both are Reviewed-by: Jose Fonseca

Re: [Mesa-dev] [PATCH] tgsi/scan: use wrap-around shift behavior explicitly for file_mask

Reviewed-by: Brian Paul <bri...@vmware.com> I also admit that somehow reg & 31 made me pause, but reg % 32 seems obviously right. Reviewed-by: Jose Fonseca <jfons...@vmware.com> Jose ___ mesa-dev mailing list mesa-dev@lists.freedeskt

Re: [Mesa-dev] [PATCH] RFC: gallium: increase PIPE_MAX_SHADER_SAMPLER_VIEWS to 128

On 27/02/18 02:38, srol...@vmware.com wrote: From: Roland Scheidegger Some state trackers require 128. (There are no plans to increase PIPE_MAX_SAMPLERS too, since with gl state tracker it's unlikely more than 32 will be needed, if you need more use bindless.) ---

Re: [Mesa-dev] [PATCH 2/2] softpipe: don't iterate through PIPE_MAX_SHADER_SAMPLER_VIEWS

if (view) { struct pipe_resource *tex = view->texture; Series LGTM. Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] draw: don't needlessly iterate through all sampler view slots

draw->sampler_views[shader_stage][i] = views[i]; - for (i = num; i < PIPE_MAX_SHADER_SAMPLER_VIEWS; ++i) + for (i = num; i < draw->num_sampler_views[shader_stage]; ++i) draw->sampler_views[shader_stage][i] = NULL; draw->num_sampler_views[shader_stage] =

[Mesa-dev] [PATCH] appveyor: Build with MSVC 2015.

The MSVC version we (at VMware) primarily care about from now on is 2015. We can drop support for building with 2013 in a future commit. I'm not aware of significant changes in C99/C11 support from MSVC 2013 to 2015, but there's no point in continuing supporting old MSVC versions when nobody

Re: [Mesa-dev] [PATCH] tgsi: Recognize RET in main for tgsi_transform

ader(const struct tgsi_token *tokens_in, assert( 0 ); } } + assert(call_stack == 0); tgsi_parse_free (); LGTM. Thanks. Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] tgsi: Recognize RET in main for tgsi_transform

surfaces. Reviewed-by: Jose Fonseca <jfons...@vmware.com> On 13/02/18 04:10, srol...@vmware.com wrote: From: Roland Scheidegger <srol...@vmware.com> Shaders coming from dx10 state trackers have a RET before the END. And the epilog needs to be placed before the RET (otherwise it will

Re: [Mesa-dev] [PATCH 2/2] gallium/util: silence clang warning in blitter code

YBE_UNUSED struct blitter_context_priv *ctx) { - assert(ctx->base.saved_fb_state.nr_cbufs != ~0u); + assert(ctx->base.saved_fb_state.nr_cbufs != (ubyte) ~0); } static void blitter_disable_render_cond(struct blitter_context_priv *ctx) Thanks. Reviewed-by: Jose Fonseca <

Re: [Mesa-dev] [PATCH 2/2] u_blit, u_simple_shaders: add shader to convert from xrbias format

ader_xrbias(struct pipe_context *pipe, + unsigned tex_target); + extern void * util_make_fragment_tex_shader_writemask(struct pipe_context *pipe, unsigned tex_target, LGTM. Reviwed-by: Jose Fonseca <jfons...@v

Re: [Mesa-dev] [PATCH] gallivm: fix crash with seamless cube filtering with different min/mag filter

Looks great. Reviewed-by: Jose Fonseca <jfons...@vmware.com> On 25/01/18 03:33, srol...@vmware.com wrote: From: Roland Scheidegger <srol...@vmware.com> We are not allowed to modify the incoming coords values, or things may crash (as we may be inside a llvm conditional and th

Re: [Mesa-dev] [PATCH] u_thread: Use pthread_setname_np on linux only

On 22/01/18 21:04, Samuel Thibault wrote: Hello, Jose Fonseca, on lun. 15 janv. 2018 12:29:39 +, wrote: On 13/01/18 11:33, Samuel Thibault wrote: pthread_setname_np was added in glibc 2.12 for the Linux port only, other ports do not necessarily have it. --- src/util/u_thread.h | 3

Re: [Mesa-dev] [PATCH] svga: Prevent use after free.

On 22/01/18 15:44, Emil Velikov wrote: On 22 January 2018 at 15:13, Jose Fonseca <jfons...@vmware.com> wrote: Courtesy of clang static analyzer. I was hunting for potential sources of memory corruption using Mesa with a GL trace, and happened to find this (unrelated) issue. --- src/g

Re: [Mesa-dev] [AppVeyor] mesa master #6655 failed

I suspect it's an infrastructure problem. I appeared frequently a while back, then went away, now's comming again. I think the consensus is to move this jobs out of fdo into https://github.com/mesa3d but I got no reply from Daniel Stone, so I'm not sure how to move that forward. Jose On

[Mesa-dev] [PATCH] svga: Prevent use after free.

Courtesy of clang static analyzer. I was hunting for potential sources of memory corruption using Mesa with a GL trace, and happened to find this (unrelated) issue. --- src/gallium/drivers/svga/svga_context.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH] draw: remove VSPLIT_CREATE_IDX macro

elt_idx = (unsigned)((int)(DRAW_GET_IDX(elts, elt_idx)) + elt_bias); /* Take care for DRAW_MAX_FETCH_IDX (since cache is initialized to -1). */ if (elt_idx == DRAW_MAX_FETCH_IDX && !vsplit->cache.has_max_fetch) { unsigned hash = elt_i

Re: [Mesa-dev] [PATCH] draw: fix vsplit code when the (post-bias) index value is -1

cept DRAW_MAX_FETCH_IDX */ vsplit->cache.fetches[hash] = 0; vsplit->cache.has_max_fetch = TRUE; Looks good to me. This code is indeed subtle. Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] u_thread: Use pthread_setname_np on linux only

\ - (__GLIBC__ >= 3 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 12)) + (__GLIBC__ >= 3 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 12)) && \ + defined(__linux__) pthread_setname_np(pthread_self(), name); # endif #endif Looks

Re: [Mesa-dev] [PATCH] util: fix NORETURN for msvc, add HAVE_FUNC_ATTRIBUTE_NORETURN to c99_compat.h

e NORETURN +# endif #endif #ifdef __cplusplus Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] gallivm: fix an issue with NaNs with seamless cube filtering

ord = lp_build_sub(coord_bld, coord, half); Series LGTM. Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallivm: fix texture wrapping for texture gather for mirror modes

ld, coord = lp_build_add(coord_bld, coord, offset); } /* compute mirror function */ - coord = lp_build_coord_mirror(bld, coord); + coord = lp_build_coord_mirror(bld, coord, TRUE); /* scale coord to length */ assert(bld->static_sampler_s

Re: [Mesa-dev] [PATCH 3/5] scons: add Wundef to the build flags

On 24/11/17 14:25, Emil Velikov wrote: From: Emil Velikov <emil.veli...@collabora.com> Analogous to the other build systems. Cc: Jose Fonseca <jfons...@vmware.com> Cc: Brian Paul <bri...@vmware.com> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> --- scons/g

Re: [Mesa-dev] [PATCH] llvmpipe: fix snorm blending

_termh, + is_inverse_factor(factor_dst) ? TRUE : FALSE); + resl = lp_build_blend_func(, func, src_terml, dst_terml); + resh = lp_build_blend_func(, func, src_termh, dst_termh); + + /* + * XXX pack2_native is not ok because the values have to be in ds

[Mesa-dev] Appveyor on github.com/mesa3d

On 16/11/17 15:56, Eric Engestrom wrote: On Thursday, 2017-11-16 14:20:03 +, Jose Fonseca wrote: On 16/11/17 14:08, Jose Fonseca wrote: On 15/11/17 12:20, Eric Engestrom wrote: On Wednesday, 2017-11-15 10:35:04 +, Jose Fonseca wrote: I could post a remark on AppVeyor's forums

Re: [Mesa-dev] [AppVeyor] mesa master #6163 failed

On 16/11/17 14:08, Jose Fonseca wrote: On 15/11/17 12:20, Eric Engestrom wrote: On Wednesday, 2017-11-15 10:35:04 +, Jose Fonseca wrote: I could post a remark on AppVeyor's forums, but it sounds from the logs the issue could be on our (freedesktop.org's) side. I've reconfigured AppVeyor

Re: [Mesa-dev] [AppVeyor] mesa master #6163 failed

On 15/11/17 12:20, Eric Engestrom wrote: On Wednesday, 2017-11-15 10:35:04 +, Jose Fonseca wrote: I could post a remark on AppVeyor's forums, but it sounds from the logs the issue could be on our (freedesktop.org's) side. I've reconfigured AppVeyor to use https://anongit.freedesktop.org

Re: [Mesa-dev] [AppVeyor] mesa master #6163 failed

I could post a remark on AppVeyor's forums, but it sounds from the logs the issue could be on our (freedesktop.org's) side. I've reconfigured AppVeyor to use https://anongit.freedesktop.org/git/mesa/mesa.git/ instead of git://anongit.freedesktop.org/mesa/mesa . Perhaps fewer things can go

Re: [Mesa-dev] [PATCH 16/17] util: Add Mesa ARB_get_program_binary helper functions

On 11/11/17 01:37, Jordan Justen wrote: On 2017-11-09 19:40:40, Jordan Justen wrote: On 2017-11-09 08:07:57, Jose Fonseca wrote: On 09/11/17 13:19, Emil Velikov wrote: On 9 November 2017 at 06:42, Jordan Justen <jordan.l.jus...@intel.com> wrote: Signed-off-by: Jordan Justen <jor

Re: [Mesa-dev] [PATCH 16/17] util: Add Mesa ARB_get_program_binary helper functions

On 10/11/17 03:40, Jordan Justen wrote: On 2017-11-09 08:07:57, Jose Fonseca wrote: On 09/11/17 13:19, Emil Velikov wrote: Hi Jordan, On 9 November 2017 at 06:42, Jordan Justen <jordan.l.jus...@intel.com> wrote: Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> ---

Re: [Mesa-dev] [PATCH 16/17] util: Add Mesa ARB_get_program_binary helper functions

On 09/11/17 13:19, Emil Velikov wrote: Hi Jordan, On 9 November 2017 at 06:42, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/util/Makefile.sources | 2 + src/util/meson.build | 2 + src/util/program_binary.c | 322

Re: [Mesa-dev] [PATCH 03/25] threads: update for late C11 changes

On 26/10/17 13:55, Jose Fonseca wrote: On 23/10/17 20:15, Emil Velikov wrote: Hi Nicolai, On 22 October 2017 at 20:07, Nicolai Hähnle <nhaeh...@gmail.com> wrote: From: Nicolai Hähnle <nicolai.haeh...@amd.com> C11 threads were changed to use struct timespec instead of xtime, an

Re: [Mesa-dev] [PATCH 03/25] threads: update for late C11 changes

. As xtime was replaced with timespec there's a couple of odd bits in the code. See http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1554.htm and http://en.cppreference.com/w/c/thread/{thrd_sleep,cnd_timedwait,mtx_timedlock} Note that cnd_timedwait is spec'd to be relative to TIME_UTC / CLOCK_REALTIM

Re: [Mesa-dev] [PATCH] blob: Use intptr_t instead of ssize_t

On 13/10/17 18:44, Jason Ekstrand wrote: ssize_t is a GNU extension and is not available on Windows or MacOS. Instead, we use intptr_t which should be effectively equivalent and is part of the C standard. This should fix the Windows and Mac OS builds. Cc: Jose Fonseca <jfons...@vmware.com&

Re: [Mesa-dev] [AppVeyor] mesa master #5788 failed

Per https://bugs.freedesktop.org/show_bug.cgi?id=103253 it's not just MSVC. So I'd really recommend sticking to one of the standard C types: intptr_t or int64_t. Jose On 13/10/17 10:41, Jose Fonseca wrote: SSIZE_T is included on the headers.  We include it in most places, but not necessary

Re: [Mesa-dev] [AppVeyor] mesa master #5788 failed

SSIZE_T is included on the headers. We include it in most places, but not necessary all. It brings a lot of baggage, so I don't recommend including it just for a ssize_t defitinion. Instead I'd recommend replacing ssize_t in our code with plain standard intptr_t. If you really rather use

Re: [Mesa-dev] [PATCH 1/2] gallium: allow 512-bit vectors

On 11/10/17 16:50, Tim Rowley wrote: Increase the max allowed vector size from 256 to 512. No piglit llvmpipe regressions running on avx2. Cc: Dave Airlie <airl...@redhat.com> Cc: Jose Fonseca <jfons...@vmware.com> --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 14 +++-

Re: [Mesa-dev] Piglit on windows

On 10/10/17 16:31, Kyriazis, George wrote: Hello… Piglit on windows prints out a message saying “Timeout are not implemented on Windows.”. These timeouts are the test timeouts in case a test hangs. What do people do when running piglit on windows and they hit a timeout? I would imagine

Re: [Mesa-dev] [PATCH] git_sha1_gen: accept MESA_GIT_SHA1_OVERRIDE env var

+git_sha1 = None +return git_sha1 + + +git_sha1 = get_git_envvar() +if not git_sha1: +git_sha1 = get_git_sha1() + +if git_sha1: sys.stdout.write('#define MESA_GIT_SHA1 "git-%s"\n' % git_sha1.rstrip()) Looks good to me. Reviewed-by: Jose Fonseca <jfon

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

On 29/09/17 12:17, Nicolai Hähnle wrote: On 28.09.2017 20:02, Roland Scheidegger wrote: Am 28.09.2017 um 18:19 schrieb Jose Fonseca: On 28/09/17 17:16, Roland Scheidegger wrote: Am 28.09.2017 um 17:53 schrieb Jose Fonseca: On 28/09/17 16:29, Roland Scheidegger wrote: Am 28.09.2017 um 16:12

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

On 28/09/17 17:16, Roland Scheidegger wrote: Am 28.09.2017 um 17:53 schrieb Jose Fonseca: On 28/09/17 16:29, Roland Scheidegger wrote: Am 28.09.2017 um 16:12 schrieb Jose Fonseca: On 27/09/17 15:07, Roland Scheidegger wrote: Am 27.09.2017 um 09:13 schrieb Olivier Lauffenburger: Software

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

On 28/09/17 16:29, Roland Scheidegger wrote: Am 28.09.2017 um 16:12 schrieb Jose Fonseca: On 27/09/17 15:07, Roland Scheidegger wrote: Am 27.09.2017 um 09:13 schrieb Olivier Lauffenburger: Software rasterizer and LLVM contain code to enable clipping as soon as a vertex shader writes

Re: [Mesa-dev] [PATCH] gallium: do not automatically enable clip planes when a vertex shader writes to gl_ClipDistance

On 27/09/17 15:07, Roland Scheidegger wrote: Am 27.09.2017 um 09:13 schrieb Olivier Lauffenburger: Software rasterizer and LLVM contain code to enable clipping as soon as a vertex shader writes to gl_ClipDistance, even if the corresponding clip planes are disabled. GLSL specification states

Re: [Mesa-dev] [PATCH] gallium: add new LOD opcode

data { #define TGSI_OPCODE_DDIV248 -#define TGSI_OPCODE_LAST249 +#define TGSI_OPCODE_LOD 249 + +#define TGSI_OPCODE_LAST250 /** * Opcode is the operation code to execute. A given operation defines the Looks good to m

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

On 26/09/17 12:20, Ilia Mirkin wrote: On Tue, Sep 26, 2017 at 7:07 AM, Jose Fonseca <jfons...@vmware.com> wrote: On 25/09/17 14:30, Eric Engestrom wrote: I pushed the rest of the series. See below for discussion on this patch. On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

On 25/09/17 14:30, Eric Engestrom wrote: I pushed the rest of the series. See below for discussion on this patch. On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca wrote: On 19/09/17 15:14, Eric Engestrom wrote: Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> ---

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

On 22/09/17 19:38, Dylan Baker wrote: Quoting Jose Fonseca (2017-09-22 11:10:34) On 22/09/17 18:47, Nirbheek Chauhan wrote: On Fri, Sep 22, 2017 at 10:19 PM, Jose Fonseca <jfons...@vmware.com> wrote: cmake provides a generic mechanism to set any variable, either from a command line -DF

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

On 22/09/17 18:47, Nirbheek Chauhan wrote: On Fri, Sep 22, 2017 at 10:19 PM, Jose Fonseca <jfons...@vmware.com> wrote: cmake provides a generic mechanism to set any variable, either from a command line -DFOO=boo, or via cache files. But meson didn't provide such standard mechanism

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

On 21/09/17 09:56, Nirbheek Chauhan wrote: On Thu, Sep 21, 2017 at 1:53 PM, Jose Fonseca <jfons...@vmware.com> wrote: On 12/04/17 18:57, Nirbheek Chauhan wrote: Hi Jose, On Wed, Apr 12, 2017 at 11:08 PM, Jose Fonseca <jfons...@vmware.com> wrote: One newbie question: what's y

Re: [Mesa-dev] initial meson port

On 21/09/17 01:20, Eric Anholt wrote: Dylan Baker writes: Results autotools : sh -c 535.34s user 30.33s system 310% cpu 3:02.05 total meson : sh -c 136.58s user 11.98s system 372% cpu 39.895 total I just want to point at these numbers again. meson is so

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

On 12/04/17 18:57, Nirbheek Chauhan wrote: Hi Jose, On Wed, Apr 12, 2017 at 11:08 PM, Jose Fonseca <jfons...@vmware.com> wrote: One newbie question: what's your workflow to update a wrap patch? Can we prototype changes locally without tarballing the patch? Any changes yo

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

names I'm not sure if this won't give the wrong results for unicode strings, but at any rate, I don't think that should ever happen in practice. So, Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.fre

Re: [Mesa-dev] [PATCH mesa 3/6] scons: use python3-compatible lists

ymbols = sym_table.keys() +symbols = list(sym_table.keys()) This one needs to stay. # convert the symbol table to source lists src_lists = {} Either way, this patch is Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev maili

Re: [Mesa-dev] [PATCH mesa 1/6] scons: use python3-compatible print()

*') env = drienv.Clone() if env['suncc']: -print 'warning: not building dri-vmwgfx' +print('warning: not building dri-vmwgfx') Return() env.Append(CPPPATH = [ Thanks for doing this. This patch is Reviewed-by: Jose Fonseca <jfons...@vmware.com> _

Re: [Mesa-dev] [PATCH] llvmpipe, gallivm: implement lod queries (LODQ opcode)

e/lp_screen.c @@ -252,7 +252,6 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param) case PIPE_CAP_MAX_TEXTURE_GATHER_COMPONENTS: return 4; case PIPE_CAP_TEXTURE_GATHER_SM5: - case PIPE_CAP_TEXTURE_QUERY_LOD: case PIPE_CAP_SAMPLE_SHADING: case PIPE_CAP_TEXTURE_GATHER_OFFSETS: return 0; @@ -265,6 +264,7 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param) return 1; case PIPE_CAP_FAKE_SW_MSAA: return 1; + case PIPE_CAP_TEXTURE_QUERY_LOD: case PIPE_CAP_CONDITIONAL_RENDER_INVERTED: case PIPE_CAP_TGSI_ARRAY_COMPONENTS: case PIPE_CAP_DOUBLES: LGTM. Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] llvmpipe, draw: improve shader cache debugging

if (variants_to_cull || lp->nr_fs_instrs >= LP_MAX_SHADER_INSTRUCTIONS) { struct pipe_context *pipe = >pipe; + if (gallivm_debug & GALLIVM_DEBUG_PERF) { + debug_printf("Evicting FS: %u fs variants,\t%u total variants," + "\t%u i

Re: [Mesa-dev] [PATCH] gallivm: fix gather implementation a bit

bld->static_texture_state->pot_depth, bld->static_sampler_state->wrap_r, Otherwise looks good. Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing lis

Re: [Mesa-dev] [PATCH] llvmpipe, tgsi: hook up dx10 gather4 opcode

LER_LOD_ZERO; @@ -5687,7 +5690,7 @@ exec_instruction( break; case TGSI_OPCODE_GATHER4: - assert(0); + exec_sample(mach, inst, TEX_MODIFIER_GATHER, FALSE); break; case TGSI_OPCODE_SVIEWINFO: LGTM. Reviewed-by: Jose Fonseca <jfons...@vmware

Re: [Mesa-dev] [PATCH] llvmpipe, draw: increase shader cache limits

which use a different - * number of max shader variants. */ -#define LP_MAX_SHADER_INSTRUCTIONS MAX2(256*1024, 512*LP_MAX_SHADER_VARIANTS) +#define LP_MAX_SHADER_INSTRUCTIONS (2048 * LP_MAX_SHADER_VARIANTS) /** * Max number of setup variants that will be kept around. Reviewed-by

Re: [Mesa-dev] [PATCH mesa] util: improve compiler guard

run every time, so can add some overhead, but looks ok for now. We can can try to improve if the itch is too great. Reviewed-by: Jose Fonseca <jfons...@vmware.com> Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] util: only use SCHED_IDLE in pthread_setschedparam() when it's defined

_param sched_param = {0}; /* The nice() function can only set a maximum of 19. Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 7/8] gallium: remove TGSI opcode SCS

On 22/08/17 12:28, Marek Olšák wrote: On Tue, Aug 22, 2017 at 1:10 PM, Jose Fonseca <jfons...@vmware.com> wrote: On 20/08/17 01:49, Marek Olšák wrote: From: Marek Olšák <marek.ol...@amd.com> use COS+SIN instead. I don't know if any existing gallium driver leverages that, but

Re: [Mesa-dev] [PATCH 7/8] gallium: remove TGSI opcode SCS

On 20/08/17 01:49, Marek Olšák wrote: From: Marek Olšák use COS+SIN instead. I don't know if any existing gallium driver leverages that, but it's a basic trigonometric principle that one can easily extract the sin from cos or vice-versa. It requires some extra care

Re: [Mesa-dev] [PATCH 2/2] gallium/os: fix os_time_get_nano() to roll over less

On 18/08/17 08:23, Frank Richter wrote: Hi, On 17.08.2017 02:34, Brian Paul wrote: BTW, I wonder if we would win by using lldiv(). Because this is often use for performance measurements, so these extra division might add some impact. Frank, do you want to look into that? In the mean time,

Re: [Mesa-dev] [PATCH 2/2] gallium/os: fix os_time_get_nano() to roll over less

eat. Thanks! Reviewed-by: Jose Fonseca <jfons...@vmware.com> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

<    1   2   3   4   5   6   7   8   9   10   >