Hi Andreas,
Similar patch for varyings linking was pushed 4 years ago, so I think this
patch should be also stable.
On Tue, Aug 28, 2018 at 12:20 AM, Andres Gomez wrote:
> Vadym, should we also include this in the stable queues ?
>
>
> On Mon, 2018-08-20 at 16:31 +0300, vadym.shovkoplias
Vadym, should we also include this in the stable queues ?
On Mon, 2018-08-20 at 16:31 +0300, vadym.shovkoplias wrote:
> From Section 4.3.4 (Inputs) of the GLSL 1.50 spec:
>
> "Only the input variables that are actually read need to be written
> by the previous stage; it is allowed to
On 23/08/18 01:51, Timothy Arceri wrote:
> On 21/08/18 19:42, Vadym Shovkoplias wrote:
>> Hi Timothy, Alejandro,
>>
>> Thanks for the review comments!
>> I'd just like to mention that the same approach is already used
>> in link_varyings.cpp file in
>> function cross_validate_outputs_to_inputs().
On 21/08/18 19:42, Vadym Shovkoplias wrote:
Hi Timothy, Alejandro,
Thanks for the review comments!
I'd just like to mention that the same approach is already used
in link_varyings.cpp file in
function cross_validate_outputs_to_inputs(). Here is a code snippet:
if (*input->data.used *&&
I agree that this comment is obsolete now. I'll update the patch, thanks!
On Wed, Aug 22, 2018 at 12:09 PM, Alejandro Piñeiro
wrote:
> On 21/08/18 11:42, Vadym Shovkoplias wrote:
>
> Hi Timothy, Alejandro,
>
> Thanks for the review comments!
> I'd just like to mention that the same approach is
On 21/08/18 11:42, Vadym Shovkoplias wrote:
> Hi Timothy, Alejandro,
>
> Thanks for the review comments!
> I'd just like to mention that the same approach is already used
> in link_varyings.cpp file in
> function cross_validate_outputs_to_inputs(). Here is a code snippet:
>
> if
Hi Timothy, Alejandro,
Thanks for the review comments!
I'd just like to mention that the same approach is already used
in link_varyings.cpp file in function cross_validate_outputs_to_inputs().
Here is a code snippet:
if (*input->data.used *&& !input->get_interface_type() &&
On 21/08/18 03:02, Timothy Arceri wrote:
> On 20/08/18 23:31, vadym.shovkoplias wrote:
>> From Section 4.3.4 (Inputs) of the GLSL 1.50 spec:
>>
>> "Only the input variables that are actually read need to be written
>> by the previous stage; it is allowed to have superfluous
>>
On 20/08/18 23:31, vadym.shovkoplias wrote:
From Section 4.3.4 (Inputs) of the GLSL 1.50 spec:
"Only the input variables that are actually read need to be written
by the previous stage; it is allowed to have superfluous
declarations of input variables."
Fixes:
*
Reviewed-by: Marek Olšák
Marek
On Mon, Aug 20, 2018 at 9:32 AM vadym.shovkoplias
wrote:
>
> From Section 4.3.4 (Inputs) of the GLSL 1.50 spec:
>
> "Only the input variables that are actually read need to be written
> by the previous stage; it is allowed to have superfluous
>
From Section 4.3.4 (Inputs) of the GLSL 1.50 spec:
"Only the input variables that are actually read need to be written
by the previous stage; it is allowed to have superfluous
declarations of input variables."
Fixes:
* interstage-multiple-shader-objects.shader_test
Bugzilla:
11 matches
Mail list logo
